- 01 Jun, 2020 40 commits
-
-
dpapad authored
Previously, when testing the focus() and blur() cases, the test was not waiting for both opacity and width transitions to finish, resulting in transitions from focus() finishing while the test was making assertions related to blur(). Properly waiting for all transitions to finish before moving on to the blur() case should fix the issue. Re-enabling the test on Mac, where it was disabled because of this reason. Bug: 997943 Change-Id: I6badb546fba4f093c2fa45490e2a52e5dae84982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223082Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#773729}
-
Chromium WPT Sync authored
Using wpt-import in Chromium cda0fb4d. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ifb5801e2cfc0570164319e9e46a87523b8533ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224644Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773728}
-
Haiyang Pan authored
This reverts commit 7a213fda. Reason for revert: The test RenderWidgetHostViewChildFrameBrowserTest.VisualPropertiesPropagation_RootWindowSegments failed quite often on "Android CFI" and android-pie-x86-rel builders, and flaky on android-asan. See http://shortn/_a3kmhb2wuI for more details of the flakiness Original change's description: > Add window segments concept to the content layer > > This change adds a the window segments concept to the > SynchronizeVisualProperties cascade. A display feature splits a view by, > e.g., a fold or a mask - an accessor is added to RenderWidgetHostViewBase > to provide this information during the calculation of visual properties. > When the root render widget is split by the display feature, there are > multiple 'window segments' that web authors will be able to use to split > their view and have a logical separation of content (either through > JavaScript or CSS). > > The root widget window segments are computed by the root > RenderWidgetHostImpl, based on the display feature on the > RenderWidgetHostView. The segments are then propagated to child local > frame roots via RenderFrameProxy and CrossProcessFrameConnector via the > new member on VisualProperties. > > Follow-up changes will finish hooking this information up to Blink in > order to expose it to the web, and also integrate with the platform > specific APIs in order to get the display feature information from the > underlying operating system. > > Explainers: > https://github.com/webscreens/window-segments/blob/master/EXPLAINER.md > https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/master/Foldables/explainer.md > > i2p: > https://groups.google.com/a/chromium.org/d/msg/blink-dev/_1_ljYsaqrU/qOoHJ7MhAgAJ > https://groups.google.com/a/chromium.org/d/msg/blink-dev/KsPRO3hkOGw/md4jgIAaAgAJ > > Bug: 1039050 1039051 > Change-Id: I6805cda5946bd5379ad6dcd68e092e5d7d9be42d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205123 > Commit-Queue: Daniel Libby <dlibby@microsoft.com> > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773545} TBR=danakj@chromium.org,kinuko@chromium.org,dlibby@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1039050 1039051 Change-Id: I74b881c8548cedfe1c694dbdee1ce617491bf75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225141Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#773727}
-
Sreeja Kamishetty authored
This CL disables BackForwardCache when SpeechRecognizer API is used, as we believe that currently we do not handle the speech recognition properly when the page is put into BackForwardCache. Supporting the SpeechRecognizer feature is to be compatible with BackForwardCache is the next step. BUG=1088445 Change-Id: I85334ac00251a1ead69f26c5de0e2f76e07066db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224981Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#773726}
-
Navid Zolghadr authored
Plumb through deep press gesture recognizer bit from Android Q+ to Chrome and send long press gesture earlier than the timeout as soon as the deep press bit is set. This change will cause long press gesture to be fired earlier if user presses finger harder on the screen and causes effects such as context menu or selection happens earlier to provide a better user experience inline with other apps on Android Q+. Bug: 1086263 Change-Id: I04b7d43fdfcaefeb6ca6ea6102f730283d972fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218551Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#773725}
-
Nina Satragno authored
Disable the ChromeVoxPanelTest.Gestures test, it has flaky crashes. Previously this had been disabled the wrong way. TBR=dtseng@chromium.org Bug: 1088438 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I76aa02d0dfbab80131a949d37c5258c0eded2de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224648Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#773724}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2f2595a89af3..b369376270f8 2020-06-01 m.maiya@samsung.com Vulkan: Enhance VulkanBarriersPerfBenchmark If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Test: Test: angle_perftest --gtest_filter=VulkanBarriersPerfBenchmark.Run/vulkan_buffer_copy Change-Id: Id5bd54da9c92f1a225db29f985243f92c7575aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224839Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773723}
-
Nina Satragno authored
Disable the ChromeVoxPanelTest.Gestures test, it has flaky crashes. TBR=dtseng@chromium.org Bug: 1088438 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I958a0a912df7338653af5dc3361571b18a581a62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225228Reviewed-by:
-
Christopher Cameron authored
A handful of odds-and-ends here. Add a mailbox argument to CALayerParams, as this is how we will reference the shared image in SkiaRenderer (texture ID won't do). Change the CALayerOverlaySharedStateto be thread-safe ref-counted, as it will now be passed across threads (previously it was just serialized). Populate the SkiaRenderer::ScheduleOverlays path for macOS. This will need further work to take into account the unique lifetime behaviors of IOSurfaces. Populate SkiaOutputDeviceBufferQueue::ScheduleOverlays for macOS and also Ozone. Bug: 894929 Change-Id: I0ab0ce7ed1aacd24a00b3854dc332bab58c134cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222129 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#773721}
-
Nate Chapin authored
LocalFrame::ForceSynchronousDocumentInstall and a few unit tests manually replace the Document of a LocalDOMWindow. They can be switched to go through the static-response navigation commit path relatively easily. This establishes the rule that only DocumentLoader is allowed to create a LocalDOMWindow or replace its Document. Bug: 1029822 Change-Id: I84b37f35be5387556999f9bc24f7ba5fa74b4ff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222776 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#773720}
-
Julie Jeongeun Kim authored
This CL skips creating AtkObject if the node is a child of leaf node using PlatformIsChildOfLeafIncludingIgnored() not to trigger a bunch of unused events on platform. In order to access to PlatformIsChildOfLeafIncludingIgnored() from AXPlatformNode, PlatformIsChildOfLeafIncludingIgnored() is moved to AXPlatformNodeDelegate. Bug: 1050718 Change-Id: If6d6cf3d1842f6f56222104fc7a184a55bd094c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164426Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#773719}
-
Robert Sesek authored
Older versions of the stapler did not support XPC services, but the ones that are part of Xcode 11 do support it. This reverts 4312c1f9. Bug: 979725 Change-Id: I0f9cd92e56119ca9ff33ce17896f20c9fe1e2f7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224821Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#773718}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8366f25277b5..378bd113c2c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nsatragno@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: nsatragno@google.com Change-Id: Ibb34aa92489d692168a03e7d281c4bf6719f46d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225069Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773717}
-
Martin Kreichgauer authored
A timer instantiated in the location where we want to measure request duration is simpler than using timer for the entire lifetime of the entire authenticator, and allows us to eliminate the additional type. It's probably also more precise, because we previously included GetInfo requests in the timer, which are irrelevant to the thing the timer is actually supposed to measure. Change-Id: I0669bcedc4dec517a6dc82922f836335cfc50855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204551 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/20cb5d07..a411e6d3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic53b45df4ddb94c8ac1c38688c0e6a08495173b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224643Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773715}
-
Elly Fong-Jones authored
This change: 1) Adds functionality to ui::Event to set the backing NativeEvent after the event has already been constructed 2) Has BridgedContentView attach the current NSEvent when redispatching a key event 3) Documents the fact that inter-window redispatch requires the "target window fixup" in CommandDispatcher Bug: 1085578 Change-Id: I6b8f7cddffaa1296c3ac9d390aaebdbfde6f88b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217854 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#773714}
-
Anupam Snigdha authored
As mentioned in the previous CL: crrev.com/c/2211440, converted VirtualKeyboardVisibilityRequest to mojo type and used that throughout the VK code. This patch is just renaming types and no functionality change is involved. Bug: 856269 Change-Id: Ia7f84db1dcc79bfa3c8220c05c827252cb65f772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223089Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
-
Nate Chapin authored
Use the LocalFrame or LocalDOMWindow variants instead. Bug: 1029822 Change-Id: I657acf46a9742cd226580194a4cc16b6884b1514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220479 Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Richard Townsend authored
Profiling indicated that a significant portion of the time spent constructing the HTMLDocumentParser was constructing the HTMLSourceTracker, which is unused. This especially affects blink_perf.parser tiny-innerHTML because it calls this constructor often. Bug: 901056, 1087199 Change-Id: I04bb50e4808dac10ce05639ed964c68838ea6125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220032Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#773711}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/252729d2fd72..6c5a213b20f9 2020-06-01 ahassani@chromium.org artifacts: upload dummy-dlc payloads if available 2020-05-31 kramasub@google.com dedede: Fix the firmware flash programming sequence 2020-05-30 dnschneid@chromium.org flash-ap: fix dedede invocation with CCD 2020-05-30 zentaro@google.com flash: Provide clear progress feedback 2020-05-30 mmortensen@google.com Add controller calls to fill out ModelMetadata using service calls. 2020-05-30 chrome-bot@chromium.org Update config settings by config-updater. 2020-05-29 bpastene@chromium.org cros_chrome_sdk: Fail fast in internal builds without src-internal. 2020-05-29 saklein@chromium.org autotest_quickmerge: Use chromite's argument parser. 2020-05-29 amusbach@chromium.org Reland "deploy_chrome: Warn before deploying to device with mismatched board" 2020-05-29 mmortensen@google.com Add service.get_models for ModelMetadata. 2020-05-29 navil@google.com Revert "chromeos_config: set debug to true for the release-basic builder." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ic4b741c5d24b7e9c8d85e505a8feeb0c0fc13000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225065Reviewed-by:
-
Lily Chen authored
This CL adds two histograms to CookieMonster. The first records the number of keys (eTLD+1's) which have undergone eviction due to reaching the per-registrable-domain cookie limit. The second records the number of keys (eTLD+1's) present in the store which have at least 1 cookie (which may or may not be expired). These are both logged periodically, once every 10 minutes of active browsing time. Bug: 1087156 Change-Id: I710e3bf6b16033fa1dea3401a7a43e0cf9ff2b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219157 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#773709}
-
Mythri A authored
Bug: chromium:1088419 Change-Id: I606947da17cd88cf27237032fe907b4ddf2e4704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225017 Auto-Submit: Mythri Alle <mythria@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#773708}
-
kylechar authored
Add a crash key to figure out what deserialization error is causing the main viz browser to GPU message pipe to be closed. The GPU process crashes on reinitialization so the crash key will appear in the crash dump. Bug: 1075495 Change-Id: I3661cc3b09330eca8f8418dabad968d13fadba09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225119Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#773707}
-
Domenic Denicola authored
Bug: 1066930 Change-Id: Ib1c79f8c9218821c7da3640e012cf042666e6d50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222692 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by:
-
Brian Geffon authored
This will be controlled via a finch experient, disabling by default. BUG=b:152605392 Change-Id: If05d35674d3048b7b7a3c58e8f9aab0300b4445e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223203Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#773705}
-
Abigail Klein authored
When user clicks close button in caption bubble, hide but do not close the bubble. This is important so that if a user moves to a different tab, the caption widget still exists and can be shown. Bug: 1055150 Change-Id: I2b988f3931d0874ed151e7425c69c7fe0c1c9120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222800Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#773704}
-
Scott Violet authored
This way it can be used by WebLayer. BUG=1085210 TEST=none Change-Id: Iff746831eba67fdfe2a03174e87523d91fec97b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222760Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#773703}
-
Jidong Qin authored
Change-Id: I16366d4b818bf1e0848e10c41873893ccbf6669d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223692Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#773702}
-
Mikhail Khokhlov authored
After this change the run_benchmark script will always use the pre-built trace processor from the cloud unless the --trace-processor-path flag is explicitly specified. Bug: b/151424541 Change-Id: I9d6958f1ba63326eadfc168095c17474dc2b8b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225018Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#773701}
-
Nina Satragno authored
Mark the following tests as flaky on linux: external/wpt/webvtt/rendering/cues-with-video/processing-model/embedded_style_media_queries.html external/wpt/webvtt/rendering/cues-with-video/processing-model/embedded_style_media_queries_resized.html TBR=evliu@google.com Bug: 1088475 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I2369b76b2e2b08dd39c097656b25bb4cdf3736c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225123Reviewed-by:
-
Antonio Gomes authored
... instead of WebMediaStreamTrack. Note that WebAudioMediaStreamSource ctor was also updated from taking a WebMediaStreamSource to take MediaStreamSource. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. BUG=704136 R=guidou@chromium.org Change-Id: I82f926bbb323121e61a20431dc59f62686891026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222528 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#773699}
-
Stephan Hartmann authored
Make operators 'inline' only. Bug: 819294 Change-Id: If07442258b4ebce26c013c4dff830c1d61dff9e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217415 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#773698}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia9d413f16ce0e450c85369c8be5fb17063b2a36a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224913Reviewed-by:
-
Rohit Rao authored
Both iOS and macOS WebKit were being built when setting checkout_ios_webkit=true, even though only one was ever used. This CL adds a variable to control whether WebKit is built for iOS or macOS, to prevent wasted compilation time. BUG=None Change-Id: I9610046919757515defcecb8a23f88fac141d031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223643Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#773696}
-
Devlin Cronin authored
Update the manifest.json for the search provider override test extension to use a localized message for the search domain. This provides just a bit of extra coverage to make sure the message is properly formatted and localized. Bug: 1079364 Change-Id: Ifb64bf2c7cf93401fec018246038f189b6e921a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219596Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#773695}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8a0284e2a83a..f1c5b95e516e 2020-06-01 marinaciocea@webrtc.org Rename worker_queue to send_transport_queue. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I0b60a9d74b80c5c585cbbd500eae1891715efac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225067Reviewed-by:
-
Henrique Nakashima authored
This usage of TabCreatorManager#getTabCreator() relies on it returning a non-ChromeTabCreator TabCreator to know it is not initialized. This CL changes it to expect an exception instead, which is what it really does. An alternative would be adding a method to the TabCreatorManager interface to check if it is initialized, but no other usages need this. Another option would be to pass in a Supplier<TabCreatorManager> that does not provide it until it's ready, but this is a larger change in ChromeActivity. Bug: 1085818 Change-Id: I6e9d4bee309825c111c93cb42eae2fc3a24ac752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222802 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#773693}
-
Mugdha Lakhani authored
This moves FinalStatus to components/prerender and updates references. Bug: 1057771 Change-Id: Iad9c04a90746a8dc95569d48bc909d2c6197a09d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220028 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#773692}
-
Julie Jeongeun Kim authored
This CL moves blink::WebPrintScalingOption to print.mojom to pass it to Mojo interfaces and removes web_print_scaling_option.h. This is a precursor CL to mojofy PrintHostMsg_GetDefaultPrintSettings. Bug: 1008939 Change-Id: Ia951aebcfb397275e9a0367e773924ba84ee256d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216131 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I4f5357f6a818dfaca7f042200565386a4588bb76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225066Reviewed-by:
-
