- 28 Apr, 2020 40 commits
-
-
Hongchan Choi authored
This is to catch up the spec change in AudioWorkletNode.onprocessorerror event handler. The current implementation uses a regular Event object to report an error, but the spec has changed to use a proper ErrorEvent. The CL also cleaned up redundant modification in the test file, which was caused by the previous revision. Bug: 1064240 Test: external/wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-onerror.https.html Change-Id: If7ac7eee96138ec0dbe02a3a046a5bdee27389db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168542Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#763506}
-
bttk authored
This will help identify crashes related to partner customization. Customization includes the default homepage url and default bookmarks. Bug: 1063948 Change-Id: I62ceb297f0fcfda7e322c97a6476454d147bc0a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150011Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#763505}
-
Chromium WPT Sync authored
Using wpt-import in Chromium df0eae72. With Chromium commits locally applied on WPT: 86131ac4 "Add a test for ReplaceTrack that verifies video track content." c317bae5 "[IntersectionObserver] Fix handling of remote parent frame intersection" 6e40df0d "[EventTiming] Attempt to fix some flaky tests" 9a26c536 "Effective Touch Action when <body> is the viewport defining element" 3f9ff2a8 "bluetooth: async/await for test helper methods" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools pwnall@chromium.org, jsbell@chromium.org: external/wpt/cookie-store pwnall@chromium.org, mkwst@chromium.org: external/wpt/native-io NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I341eee9d5f2a2214efcd3f467426f0eb55675162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171016Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#763504}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Id9abb7dd3555e36a19bd3c5d451d1b2209f13a78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170979Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#763503}
-
Esmael El-Moslimany authored
Split action menu button and remove button into two buttons. Bug: 1064850 Change-Id: Iee82ff988201cd5c9cdb44054b3d81addd03d4d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168832 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#763502}
-
siashah authored
The card issuer was added to CreditCard class in crrev.com/c/2145970. Please refer to the bug for the design doc. Bug: 1063426 Change-Id: Ifec43187879f3be9f0a5196bdbada0db5fd8f786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166133Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#763501}
-
Zach Trudo authored
The majority of the contents of messaging_layer should have been in chrome/browser/policy, with the public proto landing in components/policy. This change moves things to their appropriate location and updates the build rules. Bug=b:153361703 Change-Id: Ie57a14ff608682691e3c53cb6615be83e0d97fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166130 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Auto-Submit: Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#763500}
-
Chong Gu authored
Disable VideoCaptureDeviceTest on Fuchsia. Start running capture unittests on Fuchsia FYI bots, adds 2 minutes of bot time and run time. Bug: 1075762 Change-Id: I5e62bad602939c438a7f47e8c898304e63a5135e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168522 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#763499}
-
Mirko Bonadei authored
The directory //third_party/jsr-305 has recently been removed. Bug: 1070424 Change-Id: I2a3da25ee64ffcf28a6f59274af02656d6e71d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170346Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#763498}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1e6581c46ce7..9a90474af88f git log 1e6581c46ce7..9a90474af88f --date=short --first-parent --format='%ad %ae %s' 2020-04-28 fmayer@google.com Improve version detection. 2020-04-28 hjd@google.com Merge "traced: Allow statsd more concurrent sessions" 2020-04-28 fmayer@google.com Fix heap_profile script for Q. 2020-04-28 fmayer@google.com Fix heap_profile for Python 3. 2020-04-28 fmayer@google.com Roll trace_to_text in heap_profile. Created with: gclient setdep -r src/third_party/perfetto@9a90474af88f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I20178e806cca35fc591dcc10339c344055161be7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170794Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#763497}
-
Andrew Grieve authored
Bug: 1075998 Change-Id: I82d3f9da16faf7c344859dd8478af0f7a115dcc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170849 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#763496}
-
Mason Freed authored
To enable feature detection, this CL enables this: HTMLTemplateElement.prototype.hasOwnProperty("shadowRoot") This is as documented in the explainer, at [1]. [1] https://github.com/mfreed7/declarative-shadow-dom/blob/master/README.md#feature-detection-and-polyfilling Bug: 1042130 Change-Id: I529af9ce952b4d2e162e099c7ca703af8f3c4791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166466 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#763495}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d50c00bf..c301c370 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2e842b9b2c775d6dda8c68292b35148fb75cca7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170806Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#763494}
-
Maksim Ivanov authored
Remove the assertion on |googleResponseReceived| from the MergeSessionTest.XHRNotThrottled test, because checking this variable hits a race with the JS code that writes this variable (in the observer of XMLHttpRequest). It seems correct that the test shouldn't assert on this variable, because, unlike other MergeSessionTest tests, the merge session completion is already performed in the beginning of the test, and requests to Google addresses shouldn't be blocked. Bug: 990844 Test: Run the test ("browser_tests --gtest_filter=All/MergeSessionTest.XHRNotThrottled/1") several thousand times and with stress-ng Change-Id: I92d09409969fcc66623f2025abc3162af02cca04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170867Reviewed-by:Chris Mumford <cmumford@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#763493}
-
Scott Violet authored
BUG=1075662 TEST=FullscreenCallbackTest.testDestroyFragmentWhileFullscreen Change-Id: I46cc5865fe5b395304f860d715704bc909a818ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170976Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#763492}
-
zhaoyangli authored
Handles unknown system dialog by catching the exception. If it's a system update alert, choose later. If not, deny it. Bug: 1072000 Change-Id: Ifc12a37771c247d2f68c7f73ac0169aa337e5dda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159916 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#763491}
-
wutao authored
This is a preparation to create access token controller for ambient mode. This cl extracts common logic of ambient mode related unittests into an AmbientAshTestBase. Bug: b/148463064 Test: new AmbientAshTestBase Change-Id: I5b94820521653a3b519b4ed223322da919333a8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138505 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#763490}
-
Dan Harrington authored
Bug: 1044139 Change-Id: I8b6ce0db6e9cc9930f49080c5fbde533d199dbfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166343 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#763489}
-
Roman Sorokin authored
on branded builds Bug: 977743 Change-Id: Ie0a017323f26051601bde74c4d28e41ea85a95df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170866Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#763488}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I372cc59df1d4fa529f2e5e02d5320055e8130f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170802Reviewed-by:
-
Becca Hughes authored
Add a Media.Feed.Discover UKM event that is recorded when we discover a new Media Feed. This is to track usage of the feature. BUG=1065014 Change-Id: If0fb31dcf597cc51716c1397904412f199c09524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122368 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#763486}
-
Tommy Li authored
This test is flaky on Mac in general: https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/33739 Bug: 1076005 Change-Id: I9c338cc128d43e8d44977dc7328a73f7c23efd8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170554 Auto-Submit: Tommy Li <tommycli@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#763485}
-
Koji Ishii authored
The test itself is unchanged, so this probably starts to fail, or starts to flake (one win bot I checked passed this test.) TBR=mstensho@chromium.org Bug: 1076028 Change-Id: I7a69b5b4e4adad7c01815d62ece1a973db1ad907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170747Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#763484}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7d66c798bb49..d70aa16fd5af git log 7d66c798bb49..d70aa16fd5af --date=short --first-parent --format='%ad %ae %s' 2020-04-28 sokcevic@google.com Reland "Print ps in intervals while the process is running" Created with: gclient setdep -r src/third_party/depot_tools@d70aa16fd5af If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1074355 Tbr: agable@chromium.org Change-Id: I85571be61eb9b0259a93e697258441635c2306e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170791Reviewed-by:
-
wutao authored
There could be multiple URL requests at the same time. This patch creates URL loader for each request. Bug: b/153504737 Test: manual Change-Id: I990f60e09242fc1ce65e23b8068aa0edda59601c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141614Reviewed-by:
-
Haiyang Pan authored
- android-bfcache-rel - android-opus-arm-rel - android_blink_rel - android-cronet-arm-dbg - android-lollipop-arm-rel-swarming - ToTAndroid Also add cronet-gtests to the builder android-cronet-lollipop-arm-rel The following builders are not migrated for now since they are no working properly with Lollipop: - android-cronet-asan-arm-rel - android-asan Bug: 1032336, 1074410 Change-Id: I3186742244be821ca22f5481f0e652b0b3477410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168797 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#763481}
-
Amr Aboelkher authored
This CL is doing the following: - Rolling to the recent version - Update the README with the exact version Bug: chromium:1076079 Change-Id: Ie16aeaf8e2325762e6928a991c1aefe21dbfb24b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170868Reviewed-by:
-
Chris Lu authored
This creates the placeholder request config to be used to hold a place in the Overlay queue. This will be useful for when Translate waits to finish to show the show original banner. Bug: 1071914 Change-Id: I77801c572b8aa83c7bbaf43ae934ce75667732c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163850 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#763479}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c9bb56813821..06cce0bd8dab Created with: gclient setdep -r src-internal@06cce0bd8dab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yukishiino@google.com,hendrich@google.com,tommycli@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1065456,chromium:1074070 Tbr: yukishiino@google.com,hendrich@google.com,tommycli@google.com Change-Id: Ia07e2bd13b97653054b3344f66bc38b18ad1ce32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170788Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#763478}
-
David Black authored
This CL also creates: - chromeos::assistant::mojom::AssistantEntryPoint::kLauncherChip - chromeos::assistant::mojom::AssistantQuerySource::kLauncherChip Bug: b:154153233 Change-Id: Iea6255b794588ff98ff66f75ada8cc7316087901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160107 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Ben Joyce authored
Needs this CL to land first: https://chromium-review.googlesource.com/c/chromium/src/+/2166636 Bug: 1069613 Change-Id: I20d705ff00ed038f506315b8a22728fd4feec857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169847Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#763476}
-
Mason Freed authored
Per the explainer [1] and associated spec PRs, getInnerHTML() should use an options bag parameter, rather than just a boolean for the includeShadowRoots flag. This CL implements that change. [1] https://github.com/mfreed7/declarative-shadow-dom/blob/master/README.md#serialization Bug: 1042130 Change-Id: I678db433bc9555b6cf441d93f245cb1485c16e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166138 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 35 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2020-10-25. TBR=chromium-metrics-reviews@google.com Change-Id: I24021565e71a8416ac6b488bd0a40eedb0b46480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170303Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#763474}
-
haozhe authored
This patch uses owning_element of animations to sorting animations in getAnimations(), aligning the implementation with the spec: https://drafts.csswg.org/css-transitions-2/#animation-composite-order Bug: 1070460 Change-Id: I1bc627ffecc8450e1f2ad1cff0fefc12ac3971da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139359Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Hao Sheng <haozhes@chromium.org> Cr-Commit-Position: refs/heads/master@{#763473}
-
Rohit Rao authored
Compiles the SamplingHeapProfiler, with associated tests, and adds iOS to the list of platforms which use the allocator shim. BUG=1075702 Change-Id: I4e20027633f0e4ca9b49c37b110f6548ae8ace46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168810 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#763472}
-
Yves Arrouye authored
Use the term "Forced Re-Enrollment" for messages about FRE. Keep the term "Initial Enrollment Check" for initial enrollment. Add a log message when waiting for clock sync. Add a verbose log message when we have decided that an Initial Enrollment Check is needed. Add more verbose logging for conditions that make us skip that check. Bug: None Test: N/A Change-Id: I5e9b661e9a41da9e053afeed460d9c2b13ca77b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165863 Auto-Submit: Yves Arrouye <drcrash@chromium.org> Reviewed-by:
-
Alexander Timin authored
As child FrameTreeNodes are now owned by RenderFrameHost, make parent() return RenderFrameHostImpl* because the parent RenderFrameHost cannot change for the lifetime of the FrameTreeNode. This makes our handling of non-current (pending deletion, bfcache) frames more robust by making harder to refer to a frame which is not your parent. R=arthursonzogni@chromium.org,creis@chromium.org,alexmos@chromium.org CC=,bfcache-bugs@chromium.org BUG=1073269 Change-Id: Ic2661b69ddd09e1cc5d9095caf7f158fa31f4189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160970 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#763470}
-
Vaclav Brozek authored
DoCanonicalizeFileSystemURL transforms a filesystem URL and also checks that the path of the inner URL (i.e., the path of the URL following the filesystem: prefix) has length at least 2. At the same time, canonicalizing the inner path can decrease the URL length, e.g., "/." becomes "/". So if the path length is checked on the non-canonicalized URL, the sanity check passes, whereas on the canonicalized it does not. The former situation is what happens before this patch. As a result, canonicalizing the URL twice (e.g., once when constructing and the second time when applying even empty replacements) results in a valid URL the first time and an invalid one the second time. This is a bug, because canonicalizing a canonicalized URL should not change its properties. Therefore this CL ensures that the sanity check is done on the already canonicalized path. This fixes the above described bug. Some URLs which used to be considered as valid (only) on the first canonicalization, are now considered invalid every time. Example: "filesystem:http://e:/.". Also, this CL does a minor clean-up in DoCanonicalizeFileSystemURL: The function cached a const version of the parsed.inner_parsed() pointer, but then sometimes used the cached const version, and sometimes the original non-const. The CL turns all of the latter cases into the former one. Bug: 1075515 Change-Id: I48ae1efc6de9207ea29ae774180a9e2662def9f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169891Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#763469}
-
Mustafa Emre Acer authored
We have an allowlist for URLs that trigger lookalike heuristics, but we don't have the same for URLs that the lookalikes match to. This can be useful when many lookalikes match the same domain and we know that the lookalikes are not spoofs of the matched domain. In that case, allowlisting the matched domain is simpler than allowlisting multiple lookalikes. This new target allowlist contains regexes as opposed to SafeBrowsing style patterns. This is because it only makes sense to include hostnames as allowed targets and not full URLs. Bug: 1075739 Change-Id: I61b908123eca4df57f695f380e905715750a5e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166504 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#763468}
-
Andrew Grieve authored
Prevernts spamming bot logs when java_deobfuscate.py is broken Bug: 1075998 Change-Id: I0d56ffde20e58c065b6ff575673f656a4396f745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169764 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
