GitLab

In SuperSize console, clustering of symbols by name avoids collision by
checking object_path. But for symbols with missing object_path, such
collision is no longer guarded, and grouping can become too aggressive.

This CL softens the impact of missing object_path by using address to
resolve grouping for non-'**' symbols when object_path is missing.

Bug: 923936
Change-Id: I9856daa42ac93cd8b296324e8cfe5625e313bdac
Reviewed-on: https://chromium-review.googlesource.com/c/1431282Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626210}

Bug: 867008
Change-Id: I5d889fb6b023318e4d47dbc4818883d975c30960
Reviewed-on: https://chromium-review.googlesource.com/c/1422842Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626209}

Template URLs with nonzero prepopulate_id were implicitly
reordered by RemoveDuplicatePrepopulateIDs, though relative
order was preserved for elements with zero prepopulate_id.
This CL adjusts the algorithm to output the selected
representatives for each prepopulate_id in order of first
appearance in the original template_urls vector, stabilizing
the overall order (instead of partitioning as it did before).

Bug: 924268
Change-Id: Ic885065cbf20398dfff723a85aff35141e0cb9a5
Reviewed-on: https://chromium-review.googlesource.com/c/1428939
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626208}

This CL deduplicates verification code that was present in
- RenderFrameProxyHost::OnOpenURL
- RenderFrameHostImpl::OnOpenURL
- RenderFrameMessageFilter::OnDownloadUrl

The duplicated code is moved into new util functions.  The new functions
will be tweaked in the future to add more verification (e.g. to verify
|initiator_origin|).

Bug: 919144
Change-Id: I50515c42d7f5003dd1f782ba59349599dca0f88d
Reviewed-on: https://chromium-review.googlesource.com/c/1395886Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626207}

This is a reland of b21bf2bb

Original change's description:
> [Nav Experiment] Call LoadIfNecessary() in CWVWebView session restore.
> 
> The web view load scheduled by WKBasedNavigationManager::Restore() is
> deferred when used in CWVWebView's |resetWebStateWithSessionStorage|
> because the |_containerView| is not created until later. This CL calls
> LoadIfNecessary() explicitly after the view is created to trigger the
> session restoration.
> 
> This fixes WebViewRestorableStateTest when WKBasedNavigationManger is
> enabled. A better approach would be to turn this test into a
> programmatic test so both navigation managers implementations are
> tested, but web::features symbols are not exposed in ios/web_view.
> 
> Bug: 862714
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:ios-simulator-cronet
> Change-Id: I21e694e3fef6a833f1cce04ff9cebd3784349111
> Reviewed-on: https://chromium-review.googlesource.com/c/1135435
> Commit-Queue: Danyao Wang <danyao@chromium.org>
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
> Reviewed-by: Justin Cohen <justincohen@chromium.org>
> Auto-Submit: Danyao Wang <danyao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#626170}

Bug: 862714
Change-Id: I853a8e030bef9f812605eac24c65d8237027f107
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/c/1437574Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626206}

Bug: 925365
Change-Id: Ie97bc90690811a865652e533c5ea6d540b5523b3
Reviewed-on: https://chromium-review.googlesource.com/c/1437007Reviewed-by: Joe Mason <joenotcharles@google.com>
Commit-Queue: Oliver Li <olivierli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626205}

https://pdfium.googlesource.com/pdfium.git/+log/f0898a22bff3..148c14459dd2


git log f0898a22bff3..148c14459dd2 --date=short --no-merges --format='%ad %ae %s'
2019-01-25 tsepez@chromium.org Deprecate 7-Arg form of CFXA_Node constructor.
2019-01-25 thestig@chromium.org Make CFX_MemoryStream XFA-only.
2019-01-25 tsepez@chromium.org Remove last CJX_ classes that do not meaningfully extend superclasses
2019-01-25 thestig@chromium.org Cherrypick a PartitionAlloc fix.


Created with:
  gclient setdep -r src/third_party/pdfium@148c14459dd2

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:897585
TBR=dsinclair@chromium.org

Change-Id: I25faf505b1ccf7f9ec01c4aa2050d0acab677680
Reviewed-on: https://chromium-review.googlesource.com/c/1437495Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626204}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bc26fdabb612..bfb698e79191


Created with:
  gclient setdep -r src-internal@bfb698e79191

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I0a9498a0f1e869cab7201148dc1e373eb77f17fa
Reviewed-on: https://chromium-review.googlesource.com/c/1437494Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626203}

Using this API may be causing crashes, and it was only added for code
cleanliness. Remove it.

TBR=ellyjones

Bug: 924955
Change-Id: Id25bab33958381bd16ce4887c842943ccae99a34
Reviewed-on: https://chromium-review.googlesource.com/c/1437395
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626202}

Checking if Chrome version is compatible with ChromeDriver version.

Before ChromeDriver was set to support Chrome minimum supported version
and the next three consequent versions.
With this changes ChromeDriver will support from minimum supported
Chrome version up to Chrome current version + 1.

Bug: chromedriver:2685
Bug: chromium:925256
Change-Id: I179a75e7779dc4b4f22ac2f3f1f07c776396c233
Reviewed-on: https://chromium-review.googlesource.com/c/1436199Reviewed-by: John Chen <johnchen@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626201}

Added navigation plus waiting for frame to initialize. That'll ensure
that AutocompleteHistoryManager was instantitated properly.

Bug: 920620
Change-Id: I418753c1b793eaa5349db6c1dd229e39eefe4fa7
Reviewed-on: https://chromium-review.googlesource.com/c/1437056
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626200}

This changes the entry point into the WebXR APIs, as described
by the latest spec changes. It makes the concept of which physical
piece of hardware is being used implicit. The CL is unfortunately
large, but that's almost entirely due to the number of tests that the
change affects.

Bug: 916299
Change-Id: I32f2acec810761bbddd1f6df6e8ca91673dd381e
Reviewed-on: https://chromium-review.googlesource.com/c/1383393
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626199}

Change-Id: I9565476be970dd3593a1d874338d71ca5df9f6fa
Reviewed-on: https://chromium-review.googlesource.com/c/1436153Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626198}

Removes service catalog uses in these directories, replacing them
instead with inlined collections of Manifest objects.

Test-only manifests have also been converted from JSON to C++ and are
inlined within corresponding test code.

Bug: 895616
Change-Id: I9ea61bbc263307feed4eec6e4e66f3a88e785eed
Reviewed-on: https://chromium-review.googlesource.com/c/1436877Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#626197}

The system may purge the web view associated with the chrome://inspect page if
it is left with logging enabled and many other tabs are used.

Since the web view is gone, a page reload must occur when the user navigates
back to the tab. The reload will cause all logs to be cleared from the
chrome://inspect page and will reset the button back to "Start Logging". Turning
off logging in InspectDOMHandler ensures that the state matches what the user
will see when they navigate back to the chrome://inspect tab.

Bug: 920823
Change-Id: I852d5a264f2d11424e8183fe1aeffb0299572537
Reviewed-on: https://chromium-review.googlesource.com/c/1435035
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626196}

This change implements instructions sent by Epson to properly setup
their printers; mostly just boils down to falling back on a provided
generic Epson PPD.

Bug: chromium:895037
Test: All current and added test cases pass. Verified non-Epson matching unchanged
Change-Id: Ie336586bed844e1b9f6671d36312a89ed16849bc
Reviewed-on: https://chromium-review.googlesource.com/c/1407918Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Auto-Submit: Luum Habtemariam <luum@chromium.org>
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626195}

views wants to (more or less) own the DialogDelegate. This is currently
done via refcounting. To remove that dependency of the refcounts,
extract it into its own object, with lifetime contracts against
LoginHandler.

Now the threading and refcounting mess is largely confined to the
LoginHandler base class, rather than spread into the subclasses.

Bug: 908926
Change-Id: Ia7f88c23d051dff06492baee2b050f82265a59e3
Reviewed-on: https://chromium-review.googlesource.com/c/1388037Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626194}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I8b2793a95aa1a6642e0b87d98fe63747a55040b6
Reviewed-on: https://chromium-review.googlesource.com/c/1437398Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626193}

This is for consistency with Windows and allows minimized windows to be
activated.

BUG=924075
R=sky,fbeaufort

Change-Id: Ic86ffba47805b2ba4f5c8f049cdccd2e75be8d9b
Reviewed-on: https://chromium-review.googlesource.com/c/1437263
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626192}

This reverts commit ad149d1e.

Reason for revert: crbug/925079 — ubsan

Original change's description:
> Revise EventRewriter API.
>
> Since http://crrev.com/556458 there have been two (or three) completely
> different ways of ‘returning’ events from an EventRewriter:
>
> - The original output parameter on RewriteEvent(), with the clunky
>   NextDispatchEvent() to produce multiple events.
>
> - Calling SendEventToEventSource(source, event), when the replacement
>   event must pass through later event rewriters. (This had the problem
>   of not tracking the original source.)
>
> - Several EventRewriters do an end run around the rewriter system in
>   some cases, e.g. calling WindowEventDispatcher::OnEventFromSource()
>   after a timeout, since the original RewriteEvent() interface could
>   only produce events in response to incoming events.
>
> This CL replaces all the above cases with a consistent return mechanism,
> using Send…() functions. This is inspired by SendEventToEventSource(),
> but has the caller provide the output functions explicitly, so that
> multiple sources can correctly share an EventRewriter (as Ash does).
>
> This CL contains the EventRewriter/EventSource revision, under
> //ui/events, plus conversions of ‘trivial’ rewriters (essentially those
> that only used RewriteEvent()). Other rewriters will be converted in
> separate CLs for review by their respective OWNERS, because removing
> NextDispatchEvent() or asynchronous dispatch generally requires some
> logic change.
>
> This CL includes a compatibility shim for the old API, which will be
> removed once all rewriters have changed.
>
> How to convert an EventRewriter:
>
> How to convert an EventRewriter:
>
> - When the incoming event is accepted unchanged, replace old API uses of
>      return EVENT_REWRITE_CONTINUE;
>   with new API
>      return SendEvent(continuation, &incoming_event);
>
> - When the incoming event is to be discarded, replace old API uses of
>      return EVENT_REWRITE_DISCARD;
>   with new API
>      return DiscardEvent(continuation);
>
> - When the incoming event is to be replaced, replace old API uses of
>      *rewritten_event = std::move(new_event);
>      return EVENT_REWRITE_REWRITTEN;
>   with new API
>      return SendEventFinally(continuation, replacement_event);
>
> - When the incoming event is to be replaced, and the replacement event
>   should pass through later rewriters, replace old API uses of
>      return SendEventToEventSource(source, replacement_event);
>   with new API
>      return SendEvent(continuation, replacement_event);
>
> - When the incoming event is to be replaced by multiple events, replace
>   old API uses of
>      *rewritten_event = std::move(new_event_1);
>      // record new_event_2 … new_event_N
>      return EVENT_REWRITE_DISPATCH_ANOTHER;
>   with new API
>      details = SendEventFinally(continuation, new_event_1);
>      ⋮
>      return SendEventFinally(continuation, new_event_N);
>
> Bug: None
> Change-Id: I4d217cee5aa1a2f2dbf178ce642ef1b6e2338c25
> Reviewed-on: https://chromium-review.googlesource.com/c/1203882
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Reviewed-by: Michael Wasserman <msw@chromium.org>
> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
> Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
> Reviewed-by: Ken Buchanan <kenrb@chromium.org>
> Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#625701}

TBR=sadrul@chromium.org,msw@chromium.org,kenrb@chromium.org,kpschoedel@chromium.org,afakhry@chromium.org,pkotwicz@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 925079
Change-Id: I0489467f0ee4d6cfca4a71570280cfcb49678135
Reviewed-on: https://chromium-review.googlesource.com/c/1435688
Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org>
Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626191}

This CL changes the concept of choosing a primary display.

As discussed offline with rjkroege@, Chromium assumes that a primary
display must be chosen among displays located as near to origin
as possible (and Wayland does not have a concept of a primary display.
Thus, that assumption works best).

There are several cases, which have been addressed in WaylandScreen:
1) When an output is added, its type is NOT_PRIMARY as long as
geometry data is not known by that point.
2) Once Wayland sends all the geometry changes to a WaylandOutput,
the last one notifies WaylandScreen about the changes, and
OnOutputMetricsChanged is called. A decision on which display
is primary is taken based on several conditions:
 - If there was a single display added without bounds (it always
   happens on initialization, when no display was added before),
   it must have been the very same display, which received
   geometry changes, and it must become the primary display.
 - If an updated/newly added display is located closer to origin
   that a previous one, the former becomes a primary.
 - If an updated/newly added display is one of the nearest displays
   to origin and the previous display matches the same condition,
   choose the updated/newly added one, because Wayland is sending
   geometry changes for all the displays (a reaction to relocation
   actions performed by a user).

Bug: 924088
Change-Id: Icf13f7b7eee0a33a67ca4830168eff9b5332ee9b
Reviewed-on: https://chromium-review.googlesource.com/c/1426701
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626190}

Draw Occlusion has launched successfully last year, we now remove it from base::Feature list.

Bug: 924129

Change-Id: I4126303bdc87f34403789e9eccf74c98be89ca91
Reviewed-on: https://chromium-review.googlesource.com/c/1429381Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626189}

Currently, if a device starts a RemotePlayback session and an external
device plays/pauses the video (via the Android cast notification), the
WMPI that started the casting session never gets updated. This means
that the user will see the video element on their phone as "playing",
with no media time update, or they will see the local video as paused
when the cast video is clearly playing.

This CL addresses the issue by requesting Blink to play/pause the
HTMLMediaElement to match the state of the remotely playing video.
This is done by bubbling up play state changes from the
FlingingRenderer to WMPI via the OnRemotePlayStateChange interface.

To detect an external play state change, we save whether the last
command from WMPI was a play or a pause, and propagate a change whenever
we get a MediaStatus update that is of the opposite play state. The
cast device does not care if it receives a "PLAY" command while already
playing (or "PAUSE" when paused). Therefore, after calling
OnRemotePlayStateChange, FlingingRenderer does not need to treat the
commands it receives any differently than a user initiated command.

NOTE: This approach works reasonably well, but is not an ironclad
guarantee of consistency. We are fine with missing a few changes,
because all the user has to do is tap the video element once to return
to a consistent state. Being too aggressive in trying to detect play
state changes sometimes causes the phone to go in a feedback loop,
where it constantly issues commands while the UI wildly switches
between playing and pausing.

Bug: 790766
Change-Id: If230c412a6a020c88970e1c9475d8fdc97976c3b
Reviewed-on: https://chromium-review.googlesource.com/c/1413398
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626188}

Bug: 866062
Change-Id: Ib611fae1f944b2674531ba064f19810fc40dd381
Reviewed-on: https://chromium-review.googlesource.com/c/1417114Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626187}

This CL is adding a sanity dcheck to avoid tests crashing on MAC only when
a chrome developer forgot to call the base function
"ContentBrowserTest::PreRunTestOnMainThread".


  class MyBrowserTest : public ContentBrowserTest {

   public:

    void PreRunTestOnMainThread() override {

      [...]

      ContentBrowserTest::PreRunTestOnMainThread();
  // Required, otherwise crash on MAC.
    }

I recently did that silly mistake and needed time to set up a MAC build to
debug it. I believe this test is cheap enough and worth saving developers time.

R=sky@chromium.org

Change-Id: Iec0ed2e19b216a35c675016ad6ff88dc9e1c86ad
Reviewed-on: https://chromium-review.googlesource.com/c/1407110Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626186}

This change fixes a crash that occurs when trying to view the USB
preferences when a device has been granted permission to a site. The
crash is caused because addChosenObjects() does not check if |mSearch|
is null first before checking if the String is empty.

Bug: 923593
Change-Id: I772e4357361653e7b5e0ce41691e7832d525a68a
Reviewed-on: https://chromium-review.googlesource.com/c/1427740Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626185}

In Network Quality Estimator (NQE), start an experiment to
cap the value of the Effective Connection Type (ECT) when
the signal strength is low. Currently, NQE computes ECT based
on the observed RTT of the network traffic. This CL adds a mechanism
to modify ECT on connections expected to be slower without waiting
for the network traffic to take the full RTT.

Change-Id: I271aa0e461b4de96d8b33dd87c6a9e23298fadf9
Bug: 924160
Reviewed-on: https://chromium-review.googlesource.com/c/1420270Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626184}

Replace AccountTrackerService::GetAccountInfo() with
IdentityManager::GetPrimaryAccountInfo().

Bug: 922760
Change-Id: I39faccbf4fc622f808a1ec75e67656d55260c2bb
Reviewed-on: https://chromium-review.googlesource.com/c/1425611
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626183}

ImageChanged() is called immediately when a LayoutObject is added
as an ImageObserver of a StyleImage. Previously LayoutBlock::ImageChanged()
called FirstLineStyleRef() which would update the first line style cache
which might be too early. Particulary, that caused re-entrance of
AddClient() when we updated the pending image observer when the cache
was updated.

Now don't call FirstLineStyleRef() from LayoutBlock::ImageChanged().

Also added DCHECKs to ensure a LayoutObject calls StyleImage::AddClient()
and StyleImage::RemoveClient() for exactly the same count.

Bug: 924457
Change-Id: Ib3f33febfbc591707e70813c7cb4add90ced7671
Reviewed-on: https://chromium-review.googlesource.com/c/1436881
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626182}

This reverts commit b21bf2bb.

Reason for revert: broke the build: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8923328721517960816/+/steps/compile/0/stdout

Original change's description:
> [Nav Experiment] Call LoadIfNecessary() in CWVWebView session restore.
> 
> The web view load scheduled by WKBasedNavigationManager::Restore() is
> deferred when used in CWVWebView's |resetWebStateWithSessionStorage|
> because the |_containerView| is not created until later. This CL calls
> LoadIfNecessary() explicitly after the view is created to trigger the
> session restoration.
> 
> This fixes WebViewRestorableStateTest when WKBasedNavigationManger is
> enabled. A better approach would be to turn this test into a
> programmatic test so both navigation managers implementations are
> tested, but web::features symbols are not exposed in ios/web_view.
> 
> Bug: 862714
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:ios-simulator-cronet
> Change-Id: I21e694e3fef6a833f1cce04ff9cebd3784349111
> Reviewed-on: https://chromium-review.googlesource.com/c/1135435
> Commit-Queue: Danyao Wang <danyao@chromium.org>
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
> Reviewed-by: Justin Cohen <justincohen@chromium.org>
> Auto-Submit: Danyao Wang <danyao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#626170}

TBR=justincohen@chromium.org,eugenebut@chromium.org,jbudorick@chromium.org,danyao@chromium.org,ichikawa@chromium.org

Change-Id: Ie5346cd1e76b6e7510f589e2cb36602ed7cc0fbd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 862714
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/c/1436172Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626181}

This still leaves memory_instrumentation in the RC service, hosted
by content and the relevant dependencies. All dependencies to the
RC coordination unit graph are however scrubbed.

Bug: 910288
Change-Id: I6744d2f8d42ad8c88458b531057ada0c4c2ba01a
Reviewed-on: https://chromium-review.googlesource.com/c/1425042
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626180}

Previously introduced WebNavigationBodyLoader is now used for
loading the navigation request body, instead of faking the
WebURLRequest.

Brief list of changes in this patch:
- WebNavigationParams take a bunch of request- and response-related
  fields instead of WebURLRequest.
- RenderFrameImpl fills the params instead of constructing a fake
  WebURLRequest, and constructs NavigationBodyLoader.
- DocumentLoader synchronously processes params, and then starts
  body loader to receive the main resource data. Multiple places
  in Blink are interested in main resource loading process, so
  DocumentLoader notifies them by calling DispatchXXX methods
  on FrameFetchContext. We should be able to clean this up later
  if needed.
- webkit_unit_tests mimic production and create a body loader
  of their own.
- Some unrelevant test cases are removed (e.g. checking main
  resource request priority).

With this patch we are just two steps away from committing
navigation synchronously:
- Preload mhtml archives in advance to retrieve the mime type of
  the main document.
- Move commit from "received first byte" to "handle response" step.

Things which could be cleaned up:
- Elegantly notify interested parties about main resource load.
- Simplify the loading flow in DocumentLoader, making it linear.
  Currently, we keep the flow similar to original one, where we
  call StopLoading() from various places to minimize the CL and
  potential risk.

This patch corresponds to step 6.g of the doc linked in the bug.

TBR=mmenke@chromium.org

Bug: 855189
Change-Id: I379172a94d2d59f694d0cbb99f22b147339a5090
Reviewed-on: https://chromium-review.googlesource.com/c/1401238
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626179}

BUG=804637
R=thestig

Change-Id: Ia478f17bdc0ab07243a94fca6092b63d3cbaabfd
Reviewed-on: https://chromium-review.googlesource.com/c/1437479
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626178}

The cpu_profiler category is disabled by default.
This entry is not useful and is adding confusion
to users when reporting traces on bugs.

R=oysteine@chromium.org

Change-Id: I8d272dccf9307739d8cb5d95aa830357219ae31f
Reviewed-on: https://chromium-review.googlesource.com/c/1435747Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626177}

Bug: 924785
Change-Id: Ia077d4d43baf974df46baa64632254e95a9ec6b1
Reviewed-on: https://chromium-review.googlesource.com/c/1432883
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626176}

The //fuchsia:webrunner_pkg was moved to
//fuchsia/runners:web_runner_pkg but a reference to the old target was
still present in //fuchsia:action. This fixes the issue.

Bug: 922635
Change-Id: I29733695ef4dcbe1e84ae1b3be51754ed69b5297
Reviewed-on: https://chromium-review.googlesource.com/c/1435700
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626175}

The mojom category is needed to debug what is happening on the IO/Thread.
We are seeing janks related to communications between renderers, browser
and GPU. We believe the mojom categoy will help us doing investigation.

R=oysteine@chromium.org

Bug: 867931
Change-Id: Ic01d67ca82cf60e949793eaf5ac1a09486452519
Reviewed-on: https://chromium-review.googlesource.com/c/1437065Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626174}

According to the new RobolectricTestRunner(haven't updated yet): https://github.com/robolectric/robolectric/blob/robolectric-4.1/robolectric/src/main/java/org/robolectric/RobolectricTestRunner.java#L98
seems getJarResolver() called in the constructor which will check system property "robolectric.offline" for DependencyResolver.

Bug: 900746
Change-Id: Ia05f0028330b8633a9fe329824d1a97e18f37e50
Reviewed-on: https://chromium-review.googlesource.com/c/1436557Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Yun Liu <yliuyliu@google.com>
Cr-Commit-Position: refs/heads/master@{#626173}

JSON manifests are deprecated.

Bug: 895616
Change-Id: If5306731b0bae4cb12dba636e8a70aef87766514
TBR: halliwell@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1436734
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626172}

There are lots of unused includes. Also modernize the code slightly.

Change-Id: I55fea71019682e39a018f211c33f71db3543901a
Reviewed-on: https://chromium-review.googlesource.com/c/1435722Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626171}