GitLab

No intended behavior change.

BUG=none

Review URL: https://codereview.chromium.org/348493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278394 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/343613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278393 0039d316-1c4b-4281-b951-d872f2087c98

Previously, OpaqueBrowserFrameView was being used for popups and hosted apps. So popups and hosted apps would only use the native frame when the "Use system titlebars and borders" option was selected.

BUG=376137
TEST=Manual, see bug (Must use i3 window manager)

Review URL: https://codereview.chromium.org/327083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278392 0039d316-1c4b-4281-b951-d872f2087c98

Same owners as the one in enhanced_bookmarks/OWNERS.

BUG=None
R=blundell@chromium.org

Review URL: https://codereview.chromium.org/346843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278390 0039d316-1c4b-4281-b951-d872f2087c98

Show error when an http:// URL is passed as parameter
to chrome.app.window.create().

BUG=241487

Review URL: https://codereview.chromium.org/343433005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278389 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dnicoara
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/347803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278386 0039d316-1c4b-4281-b951-d872f2087c98

Listen to the full screen event, then if so, close the bubble.

BUG=326081

Review URL: https://codereview.chromium.org/320393005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278385 0039d316-1c4b-4281-b951-d872f2087c98

This is not necessary, and causes the entire ash mode to get WS_CAPTION
as ash mode shares a single HWND.

BUG=385557

Review URL: https://codereview.chromium.org/346713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278384 0039d316-1c4b-4281-b951-d872f2087c98

to ensure that we don't typically send out incomplete packets.

Review URL: https://codereview.chromium.org/343753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278382 0039d316-1c4b-4281-b951-d872f2087c98

This CL aims to fix the bug that when webview guest create a SharedWorker, the sctipt file of SharedWorker can not be loaded. 

The SharedWorker lives in a separate render process as the webview who creates it. Because  url_request_util::AllowCrossRendererResourceLoad（...） doesn't consider that the render process of the SharedWorker  is a guest, so it denies the load of SharedWorker's script.

So we introduce webview partition id map in ExtensitonRenderState. When loading a SharedWorker script, we will check whether the script file is in the accessible resource of given "Partition ID", and decide whether it can be loaded or not. 

BUG=

Review URL: https://codereview.chromium.org/333313004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278377 0039d316-1c4b-4281-b951-d872f2087c98

When settings in a window is enabled, add a back button to the devices
page. This helps because the window has no address bar. See bug for
screenshot.

Longer-term, the devices page should show as an overlay in Settings
rather than load as a new page.

RTL is not enabled for this page; see issue 386020.

BUG=384333
R=noamsml@chromium.org,oshima@chromium.org

+oshima@ for icon. Oshima, is theme_resources the right place for this?
+stevenjb@ for browser shenanigans in local_discovery_ui.cc.

Review URL: https://codereview.chromium.org/338423005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278376 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278370 0039d316-1c4b-4281-b951-d872f2087c98

This resulted in incorrect processing and things like entering not
working.

BUG=386256
TEST=none
R=ben@chromium.org, darin@chromium.org

Review URL: https://codereview.chromium.org/344763004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278369 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bruening@chromium.org
BUG=NONE

Review URL: https://codereview.chromium.org/341083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278367 0039d316-1c4b-4281-b951-d872f2087c98

BUG=364365

Review URL: https://codereview.chromium.org/344603004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278366 0039d316-1c4b-4281-b951-d872f2087c98

Mostly renumbered and restructured grammar productions.  Notable changes:

- add support for static attributes via StaticMember
- add support for built-in types ByteString and RegExp
- allow trailing comma in enum declarations

Depends on:
IDL parser: drop AttributeOrOperation and StaticAttribute overrides
https://codereview.chromium.org/336733002/
...or else breaks Blink compile.

Review URL: https://codereview.chromium.org/329853005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278365 0039d316-1c4b-4281-b951-d872f2087c98

 * If NSS version doesn't support AES-GCM
 * If NSS version doesn't support RSA-OAEP

BUG=384485

Review URL: https://codereview.chromium.org/343473004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278364 0039d316-1c4b-4281-b951-d872f2087c98

Skia's save() SaveFlags bits are deprecated. At this
point all callers have been updated to always pass kMatrixClip, but
SkCanvas subclasses also need to use the new willSave() API.

(depends on https://codereview.chromium.org/338833003/ rolling)

BUG=skia:2297
R=piman@chromium.org, reed@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/337163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278363 0039d316-1c4b-4281-b951-d872f2087c98

SyncTaskRunner's task invocation tend to grow call stack deeper.
This CL clears the call stack per task to avoid stack overflow.

BUG=344769

Review URL: https://codereview.chromium.org/334053008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278362 0039d316-1c4b-4281-b951-d872f2087c98

Should not affect behaviour of the normal app list. The experimental app
list now transitions pages in from the correct side of the screen,
instead of simply sliding pages out to the left.

BUG=377381

Review URL: https://codereview.chromium.org/316393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278361 0039d316-1c4b-4281-b951-d872f2087c98

BUG=347425
TEST=./unit_tests --gtest_filter="MetadataDatabaseTest.*:MetadataDatabaseIndexTest.*"

Review URL: https://codereview.chromium.org/340243004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278359 0039d316-1c4b-4281-b951-d872f2087c98

Honour the safe browsing opt out and report on incidents that arrive
before profile initialization is complete.

BUG=383039,383365
R=mattm@chromium.org, noms@chromium.org
TBR=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/341563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278358 0039d316-1c4b-4281-b951-d872f2087c98

mojo_common can not depends on embedder, as standalone application must
depends on it. channel_init is in fact a part of the embedder.

R=viettrungluu@chromium.org
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/346633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278357 0039d316-1c4b-4281-b951-d872f2087c98

Currently, we use wrong storage type for nested arrays. For example, the storage
type of the outer array of int8[][] is
StructPointer<Array_Data<int8_t>>. After this CL it will be
ArrayPointer<int8_t>.

The current code works because StructPointer happens to be of the same
size as ArrayPointer.

(The newly-added tests pass with/without this CL. But I think it is good
to have them.)

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/340223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278356 0039d316-1c4b-4281-b951-d872f2087c98

It's a goodness to sequester build configuration in the build/
directory. The gn secondary_source stuff was under tools/gn for
historical reasons, so move it to a more appropriate place.

BUG=None
TEST=do a gn build of base_unittests, run said unittests.

Review URL: https://codereview.chromium.org/340153004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278355 0039d316-1c4b-4281-b951-d872f2087c98

All benchmarks that uses the old format have been converted.

https://code.google.com/p/chromium/codesearch#search/&type=cs&sq=package:chromium&q=%22page_test%20=%20'%22%20

https://code.google.com/p/chromium/codesearch#search/&type=cs&sq=package:chromium&q=%22page_test%20=%20%5C%22%22

BUG=362293

Review URL: https://codereview.chromium.org/331213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278353 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/346663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278352 0039d316-1c4b-4281-b951-d872f2087c98

Since the "Create Shortcuts" button is disabled on ChromeOS, add a
pin/unpin button that allows pinning and unpinning the app from the
shelf. This is the functional equivalent of creating shortcuts on
ChromeOS.

Based off https://codereview.chromium.org/335523002/.

BUG=385526

Review URL: https://codereview.chromium.org/340453004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278351 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344769

Review URL: https://codereview.chromium.org/337803005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278350 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278349 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/b59161f0000eb4aca3dcef29f27ffd0fb5a568e5..30e6e2af14e84216b1c113fd7500d0822bc81daa

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=reed@google.com
BUG=

win_chromium_rel seems unrelated to this cl
NOTRY=True

Review URL: https://codereview.chromium.org/343593005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278348 0039d316-1c4b-4281-b951-d872f2087c98

A ui::Combobox (|denial_combobox_|) doesn't take an owner of a
ui::ComboboxModel, so we should have clarify who is the owner of
the combobox model.
This CL fixed the leak to make TranslateBubbleView owner of the
ui::ComboboxModel (|denial_combobox_model_|).

BUG=309468
R=sky@chromium.org

Review URL: https://codereview.chromium.org/330443004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278347 0039d316-1c4b-4281-b951-d872f2087c98

Add a regression test, confirming that sessions which race host
resolutions don't fail network transactions.

BUG=334413

Review URL: https://codereview.chromium.org/346713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278346 0039d316-1c4b-4281-b951-d872f2087c98

Modifies AudioInputCallback::OnData and use media::AudioBus instead of plain byte vector (Relanding).

Second attempt to land https://codereview.chromium.org/314713002/ which has been reverted.

TBR=dalecurtis
BUG=375155
TEST=WebRTC and WebSpeech demos

Review URL: https://codereview.chromium.org/344583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278345 0039d316-1c4b-4281-b951-d872f2087c98

Explicitly issue decode error if MP4 stream parser peek fails during
MDAT discarding.

BUG=380806
R=acolwell@chromium.org

Review URL: https://codereview.chromium.org/342083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278344 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344543

Review URL: https://codereview.chromium.org/340273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278343 0039d316-1c4b-4281-b951-d872f2087c98

BUG=354035
TEST=unit_tests,ash_unittests,manual
R=sadrul@chromium.org,derat@chromium.org

Review URL: https://codereview.chromium.org/255033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278342 0039d316-1c4b-4281-b951-d872f2087c98

BUG=386207

Review URL: https://codereview.chromium.org/343673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278341 0039d316-1c4b-4281-b951-d872f2087c98

This test was disabled because it was failing. A few changes have been made:
-The page zoom cannot be assumed to be 100% on load as it will depend on the screen size being tested on. So testPageSize now doesn't make that assumption.
-testAccessibilityWithPage was flaking because accessibility information was not always returned for the two text boxes. I spent a bit of time investigating, but couldn't work it out so I've left it partially disabled for now and filed crbug.com/378091.
-The files have all been moved to a more appropriate location (in particular the test was moved out of the data directory).

BUG=303491

Review URL: https://codereview.chromium.org/290803007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278340 0039d316-1c4b-4281-b951-d872f2087c98

Add histograms to record the response codes seen by all WebSocket
requests, and also the error codes. This will provide more insight into the
reasons for WebSocket connection failures.

BUG=384273
TEST=manually tested with chrome://histograms

Review URL: https://codereview.chromium.org/336753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278339 0039d316-1c4b-4281-b951-d872f2087c98