- 26 Apr, 2020 13 commits
-
-
chromium-autoroll authored
Roll silvermont AFDO profile from 84-4103.6-1587378376-benchmark-84.0.4118.0-r1 to 84-4103.6-1587378376-benchmark-84.0.4124.1-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I87c628a1801d1d584b7e60e960edd44b9455d297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167248Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762686}
-
Christoph Schwering authored
This CL moves kMaxParseableFields from form_autofill_util.h to autofill_constants.h. While used in few places, this constant is fundamental enough to be more prominently placed alongside other constants. Bug: 1007974 Change-Id: I9d88c9dcd61b6065bb74a35611e71f48ea3036e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166102 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#762685}
-
Xida Chen authored
This reverts commit d1c2a486. Reason for revert: caused compilation failure: https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/12506? Original change's description: > Add a json_perftest_decodebench program > > The existing //base/json/json_perftest.cc, run automatically as part of > continuous integration, benchmarks synthetic JSON data. This program, > run manually, benchmarks real data (e.g. from a web crawl, passed as > command line arguments). Both are useful. > > Bug: 1069271 > Change-Id: I61f519804d731895e804d86f893c857cc1ac5953 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154626 > Commit-Queue: Nigel Tao <nigeltao@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#762683} TBR=thakis@chromium.org,rsesek@chromium.org,nigeltao@chromium.org Change-Id: Id6b89d0a2aede5c454753b622ca05d69681225e0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1069271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167106Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#762684}
-
Nigel Tao authored
The existing //base/json/json_perftest.cc, run automatically as part of continuous integration, benchmarks synthetic JSON data. This program, run manually, benchmarks real data (e.g. from a web crawl, passed as command line arguments). Both are useful. Bug: 1069271 Change-Id: I61f519804d731895e804d86f893c857cc1ac5953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154626 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#762683}
-
Daniel Libby authored
This is a reland of 0de4d371 relanding (again) now that perf regressions are understood. There are cases where images are more frequently directly composited which leads to more memory usage. However there are Also some perf improvements, and no memory regressions on Android so we're going to reland this as-is. Original change's description: > Reland "Add support for drawImageRect-based directly composited images" > > Reland now that M83 has forked. Also adjust DCHECK in > picture_layer_impl.cc. crbug.com/1063358 points out that even if the > aspect ratio matches, we can still end up with a scaled tile that does not > exactly match the layer's bounds because of the raster scale adjustments > that kick in inside RecalculateRasterScales when the desired scale is > adjusted based on the ideal scale. > > > Original change's description: > > > Add support for drawImageRect-based directly composited images > > > > > > Directly composited images is a feature that rasterizes images at their > > > intrinsic size, when an image is the only thing drawn into a layer. > > > However, this determination is today made prior to painting the image > > > in blink, which can't be done with CompositeAfterPaint enabled. > > > > > > This CL adds support for detecting PictureLayers that qualify as directly > > > composited images, by analyzing the paint ops of the display item list. > > > If a single drawImageRect paint op is detected (with some facilities for > > > detecting images for which orientation is respected), then we'll > > > propagate the image's intrinsic size over to PictureLayerImpl on commit. > > > PictureLayerImpl then uses that information to calculate a raster scale > > > that results in the image being rasterized at its intrinsic size. > > > > > > There are a few additional changes needed outside that core calculation. > > > If the aspect ratio of the layer bounds does not match the image's > > > aspect ratio, we won't raster the image at the intrinsic size, but > > > instead will choose the scale from one dimension. In these cases, we will > > > choose to re-raster when the layer is resized until the layer bounds > > > aspect ratio matches that of the image. > > > If we do adjust the raster scale and add tilings to the active tree > > > (as is seen in the default configuration for web_tests), we should drop > > > the previous tilings (which are now non-ideal) since the max raster scale > > > tile will be chosen when the SharedQuadState is created during > > > AppendQuads. > > > We also need to tell the LayerImpl if nearest neighbor should be used > > > when the TileDrawQuad is scaled in the display compositor to preserve > > > the same output of the original drawImageRect. > > > > > > Bug: 875110 > > > > > > Change-Id: I2cda143f483c2aa30a6ae1fb850e1c7ef1227882 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036542 > > > Reviewed-by: vmpstr <vmpstr@chromium.org> > > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > > Commit-Queue: Daniel Libby <dlibby@microsoft.com> > > > Cr-Commit-Position: refs/heads/master@{#751891} > > TBR=vmpstr@chromium.org,pdr@chromium.org,dlibby@microsoft.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 875110 > Change-Id: I485e939ba08575a3e2af5a821558e54ce6132cc2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144398 > Reviewed-by: Daniel Libby <dlibby@microsoft.com> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Reviewed-by: vmpstr <vmpstr@chromium.org> > Commit-Queue: Daniel Libby <dlibby@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#758935} TBR=vmpstr@chromium.org,pdr@chromium.org Bug: 875110 Change-Id: Ide8ed7f61b045ad42862713597f2b59306e32d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167175 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#762682}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ide4ef2df019add1b44e11e6698febc27f60e8eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167133Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/423b86696dce..1fbaa59bb79e git log 423b86696dce..1fbaa59bb79e --date=short --first-parent --format='%ad %ae %s' 2020-04-26 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@1fbaa59bb79e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I877979f07b0c6c5c828733ce1fcece831f33176e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167132Reviewed-by:
-
Hua, Chunbo authored
Bug: 982799 Change-Id: I5ba868893940a65f387d4a22684a67dd922831fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161795Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Chunbo Hua <chunbo.hua@intel.com> Cr-Commit-Position: refs/heads/master@{#762679}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: I42036ead63263157dc9c534754f6ab551c4e2257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167151Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762678}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ib246207749f7b8e1c7dbdaf78156d1ad37e6f9b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167131Reviewed-by:
-
Chisoon Jeong authored
Change-Id: Ia2ac3bc3143eac207afc403f63568a9b5638bf73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166207 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Wanming Lin authored
This CL simplifies wpt/orientation-event tests by using testharness.js' `EventWatcher` to replace existing customized `waitForEvent` method and improving event comparison methods. Uses `setGetSensorShouldFail` to simulate UA can not provide sensor information for orientation/deviceorientationabsoluteevent.https.html, and merges which into orientation/basic-operation-absolute.https.html. Bug: 816462 Change-Id: Ia7bf83cb9401265722e472ccdd01adc114eff660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154389Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Wanming Lin <wanming.lin@intel.com> Cr-Commit-Position: refs/heads/master@{#762675}
-
Shakti Sahu authored
This CL adds automation tests for query tiles in NTP. Bug: 1068673 Change-Id: I2a8475fd600bab6f523950e7d452c80824943daf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152228 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#762674}
-
- 25 Apr, 2020 27 commits
-
-
Kyle Horimoto authored
This CL migrates About UI strings to a per-page provider and adds TODOs for adding relevant search tags. Bug: 1069849 Change-Id: I7f3655a13c795dbef70281c540a56642ae814e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166348 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#762673}
-
Kyle Horimoto authored
This CL migrates Reset UI strings to a per-page provider and adds TODOs for adding relevant search tags. Reset settings previously had a pattern in which loadTimeData was added within a Create() factory function for ResetSettingsHandler. I updated this such that loadTimeData is added within the strings provider for consistency with other pages, and also updated browser settings as well. Bug: 1069849 Change-Id: I85fc4a985a950e3e4ff9c826bf05961ffb750c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165664 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Kyle Horimoto authored
This CL migrates Accessibility UI strings to a per-page provider and adds TODOs for adding relevant search tags. Bug: 1069849 Change-Id: I43edcb765ae539d1d1a95ae687881e1dc644006a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165720 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Eugene Zemtsov authored
1. Generic interface for VideoEncoder in media. 2. Software VpxEncoder in media. (No fancy options are supported yet) 3. webcodecs/VideoEncoder can call media::VideoEncoder to encode frames. But there is no frame queue (only one frame can be encoded at once) and everything is happening on the main thread. Bug: 897297, 1045248 Change-Id: I0665c1c4f6cf8cfb47a15ece6511a3f03ff64ec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148643 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#762670}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0a8f039c4833..07d424c4e530 Created with: gclient setdep -r src-internal@07d424c4e530 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jianli@google.com,mmoskvitin@google.com,yoichio@google.com,nicolaso@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jianli@google.com,mmoskvitin@google.com,yoichio@google.com,nicolaso@google.com Change-Id: Ifa781a1c7e4fb6a74256314bb67f367dd52d889a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166318Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762669}
-
Rune Lillesveen authored
Always consider subtree-visibility: hidden as hidden for accessibility. This avoids making elements with out-of-date ComputedStyle objects visible for accessibility. all-expected-blink.txt is reverted back to the expectation before https://crrev.com/c09717ac13c9339bc54b086785fb0d0d0d410b0e Slightly more tests passing in css-subtree-visibility/subtree-visibility-032.html Let subtree-visibility-51.html use an expectation file instead of a TestExpectations line to be able to detect if its failures changes or if it starts passing. Bug: 1072447 Change-Id: I8988d5d580577c6e38f5d6b95c5c735fec54491a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164886 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#762668}
-
Roman Aleksandrov authored
This is a reland of 8cd221ee Original change's description: > SyncConsentScreen: Skip screen properly. > > Use new MaybeSkip method for skipping screen. Add tests for UMA stats. > > Bug: 1064561 > Change-Id: I9ddfa0fb5c994f1cb6d6c7abf5e61ca42fd065a3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146900 > Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#762370} Bug: 1064561 Change-Id: Ic9f6be0ea98423614d0ed2a524313679dd99baa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166163 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#762667}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c2f2cfca. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 6d36e845 "Migrate pointerevents/mouse-on-object.html to wpt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ie2aa0606520444f4e20ce87e5107e53334f1bb13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166425Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762666}
-
Kyle Horimoto authored
This CL migrates Printing UI strings to a per-page provider and adds TODOs for adding relevant search tags. Bug: 1069849 Change-Id: I69d261b65b3003305f608997e85a3d92d4f93b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165672 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Kent Tamura authored
This CL implements 'ruby-position' CSS property, which is a property independent from the existing '-webkit-ruby-position', but these properties share a single ComputedStyle field. We apply neither legacy name alias [1] nor legacy shorthands [2] because - Acceptable keyword sets are different in ruby-position and -webkit-ruby-position. - Avoid behavior changes with |element.style.webkitRubyPosition = 'after'|. * core/css/css_computed_style_declaration.cc Add 'ruby-position' to getComputedStyle() enumeration. * core/css/parser/css_parser_fast_paths.cc Add setting for fast-path parsing * core/css/properties/longhands/longhands_custom.cc Add CSSValueFromComputedStyleInternal() to translate a ComputedStyle:: GetRubyPosition() value to 'over' or 'under'. * core/css/resolver/style_builder_converter.{h,cc} Add a function to convert a parsed CSS keyword to a blink::RubyPosition value. * web_tests/external/wpt/css/css-ruby/ruby-position.html New test to check ruby annotation position. * web_tests/fast/ruby/ruby-position-om.html New test to check relationship between ruby-position and -webkit-ruby-position. Approved intent: https://t.co/nmCPv0Onhk [1] https://drafts.csswg.org/css-cascade/#legacy-name-alias [2] https://drafts.csswg.org/css-cascade/#legacy-shorthand Bug: 196690 Change-Id: I2f00099f90a2222b7ddba8b58c3a532f3b997744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152569Reviewed-by:Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#762664}
-
Kyle Horimoto authored
This CL migrates Files UI strings to a per-page provider and adds TODOs for adding relevant search tags. Bug: 1069849 Change-Id: I7a412af20335dc76d7a2303349e19a6937570574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165670 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Martin Kreichgauer authored
MakeCredentialRequestHandler::HandleResponse() was incorrectly rejecting responses with a googleAndroidClientData extension output whenever a corresponding input had been sent. This CL fixes that by inverting the check. Also add tests exercising solicited and unsolicited googleAndroidClientData extension responses. Further, add a test ensuring that we are not sending any unsolicited extensions in requests, since that has happened recently (see crrev.com/c/2165567). Bug: 1002262 Change-Id: Idc827dd3312f3fb914987615277f7f88575fd743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166583 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#762662}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/00d1f9a24d08..0a8f039c4833 Created with: gclient setdep -r src-internal@0a8f039c4833 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jianli@google.com,mmoskvitin@google.com,yoichio@google.com,nicolaso@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jianli@google.com,mmoskvitin@google.com,yoichio@google.com,nicolaso@google.com Change-Id: I0c0cf35431855ff43dc24616401c617103aa846a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166315Reviewed-by:
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/ac65d4531798..209319c1bf57 $ git log ac65d4531..209319c1b --date=short --no-merges --format='%ad %ae %s' 2020-04-23 junyer Compute first_byte_ eagerly. 2020-04-23 junyer Remove unused flags_ member from Prog class. 2020-04-23 junyer Replace some uses of "LL" and "ULL" suffixes. 2020-04-21 junyer Explain the need for double backslashes. 2020-04-20 junyer Remove memrchr() and the logic that calls it. 2020-04-19 junyer Use 64-bit integers for the BitState bitmap. Created with: roll-dep src/third_party/re2/src R=mmoroz@chromium.org Change-Id: I50a94c2d43f3e67b5d905395de864e4dadd05935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166639 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#762660}
-
Doug Arnett authored
This will be used to compare how much content is used with subframe language detection vs. just with main frame. Bug: 797328 Change-Id: I30ce39cd119e3b04941e1a6d89c467872e40ea55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163726Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#762659}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I6eb9eefe062daf345a8376919dfa86b7ed2a72a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166621Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762658}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6ba2c4fdcd1b..423b86696dce git log 6ba2c4fdcd1b..423b86696dce --date=short --first-parent --format='%ad %ae %s' 2020-04-25 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@423b86696dce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I02270c165e6379b4f208e04b3108e44cd92ecfa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166313Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium c34d237c. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 6d36e845 "Migrate pointerevents/mouse-on-object.html to wpt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I3550ad9bb1f3ef148ee578e198cf0ee15038942d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166424Reviewed-by:
-
Stephen McGruer authored
These files are auto-generated by reffy, and we have seen cases where Chromium developers edit them and then are surprised (or worse, never notice) when reffy reverts their changes upstream. The added PRESUBMIT is an upload error, but is not checked during commit time as on occasion it may be ok to change these files. We just want people to loop us in when they are doing so. Bug: 1016354 Change-Id: Ie2c0c36add56140a90dade56db5783c96cc8a5a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164569 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#762655}
-
Wez authored
Enabling ANGLE causes AEMU to flakily crash with an ASSERT() failure. TBR=sergeyu Bug: 1074600, 766360 Change-Id: I44393eef9a9971d4487fcc886f011b9ab6c40cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165786Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#762654}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6ccc4d96. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 6d36e845 "Migrate pointerevents/mouse-on-object.html to wpt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I6acca103f742c8743cfef0e884f2679b3946f438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165913Reviewed-by:
-
Istiaque Ahmed authored
With recent removal of all usages of ChromeAsyncExtensionFunction, it's time to say goodbye to ChromeAsyncExtensionFunction. This CL removes files for the class. Bug: 634140, 648275 Change-Id: I66a7b2eb1346ef4c7244eadada778bfad6474bcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164565 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#762652}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d011b980..0d2d6cca Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9a18b292be94520c35a0dc6476bdbbd97cd13f55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165912Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762651}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Icf772aa0f2d34f9c79243f4c8b5d61ba1ac6c017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166666Reviewed-by:
-
Istiaque Ahmed authored
This CL adds SERVICE_WORKER to BackgroundPageType enum that is used to record "Extensions.BackgroundPageType" histogram for installed extensions from installed_loader (on startup). This change also fixes typo in comment "Extension.BackgroundPageType" Bug: None Change-Id: I6f2364b7d3af4ae388750f44e6d3e76b7d707f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164250Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#762649}
-
Yuki Shiino authored
https://html.spec.whatwg.org/C/#the-formdataevent-interface defines the constructor as constructor(DOMString type, FormDataEventInit eventInitDict); and the 2nd argument is not "optional". Since FormDataEventInit has a required dictionary member, it doesn't make sense to make the argument "optional". Change-Id: Ib2caa6bf64d351c4da06123fa6142b62739fae3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164925 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#762648}
-
Yuki Shiino authored
The state argument has the default value of {}. https://w3c.github.io/mediasession/#mediasession Bug: 839389 Change-Id: Ia7e1e87d7ce39b52665453408a6a8bee04fd7e7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165165 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
