GitLab

Review URL: http://codereview.chromium.org/99292

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15086 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15085 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15082 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99290

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15080 0039d316-1c4b-4281-b951-d872f2087c98

Only unset the kWebPluginDelegateProperty property after calling the plugin's windowproc, otherwise if it ends up dispatching another message to itself we'll hit the NOTREACHED at the beginning of the function.

Review URL: http://codereview.chromium.org/99267

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15077 0039d316-1c4b-4281-b951-d872f2087c98

TBR=eseidel
BUG=8207
TEST=0


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15075 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/9049
Review URL: http://codereview.chromium.org/100267

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15073 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/9561 
http://crbug.com/11270 
http://crbug.com/11271 
http://crbug.com/11286 
and a couple of things that seem clearly to be
system issues rather than chromium issues.

Just trying to get the mac unit_test valgrind builder green.

Review URL: http://codereview.chromium.org/99259

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15071 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/57031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15070 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/100261

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15067 0039d316-1c4b-4281-b951-d872f2087c98

With this patch there's totally 5 measurements for audio IPC
1. Total round trip time
   browser request a packet until it gets a packet
2. Browser receive latency
   time for a packet to arrive browser from renderer
3. Browser process time
   time for browser to process the packet
4. Renderer receive latency
   time for a packet to arrive renderer from browser
5. Renderer process time
   process time on a packet in renderer

They are all using low resolution timer with accuracy of ~1-15ms.
Since we have a budget of ~200ms (for now) without clicks, I think
the accuracy shouldn't be a big problem, unless for case 1 where
we want to measure exact amount of clicks.

Review URL: http://codereview.chromium.org/99213

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15063 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/100260

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15061 0039d316-1c4b-4281-b951-d872f2087c98

To be merged with 2.0 (172) branch.

BUG=http://crbug.com/11208
TBR=mal


Review URL: http://codereview.chromium.org/99260

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15060 0039d316-1c4b-4281-b951-d872f2087c98

Specifically:
1) In webkit.gyp and test_shell.gyp, convert the rules to actions because of different grd outputs (localized grd files have locale in the .pak filename).
2) In chrome, make two targets each with a custom rule.  One target is for localized resources, the other for non-localized resources.  This is like the current windows build.

Review URL: http://codereview.chromium.org/100174


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15059 0039d316-1c4b-4281-b951-d872f2087c98

synchronous and robust.

Adding automation APIs with corresponding
IPC messages to count and find normal browser
windows.


Review URL: http://codereview.chromium.org/99268

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15058 0039d316-1c4b-4281-b951-d872f2087c98

a bug where you would cycle through a background tab's links even after
selecting a different tab.

TEST=Open Chromium.  Open a new tab.  Press tab and verify that we are correctly
cycling through the links in the new tab.

Review URL: http://codereview.chromium.org/100233

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15057 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/10957
TEST=Verify that the AddSearchProvider logic still works.  This dates back to an old bug http://b/1069781

Review URL: http://codereview.chromium.org/99168

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15056 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99262

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15055 0039d316-1c4b-4281-b951-d872f2087c98

BUG=11263
TEST=Go to any page and then click on a link to navigate to a new page.


Review URL: http://codereview.chromium.org/99263

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15052 0039d316-1c4b-4281-b951-d872f2087c98

Only send events to renderers that are listening to an event.Notify browser when a renderer is listening to an event.
Review URL: http://codereview.chromium.org/100214

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15050 0039d316-1c4b-4281-b951-d872f2087c98

* remove chrome\browser\views\find_bar_win_unittest.cc
* add Windows-only test targets:
  ** interactive_ui_tests
  ** plugin_tests
  ** selenium_tests
* Move from unit_tests to test_support_common:
  ** test/in_process_browser_test.{cc,h}
  ** test/ui_test_utils.{cc,h}


Review URL: http://codereview.chromium.org/100168

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15045 0039d316-1c4b-4281-b951-d872f2087c98

Calculate from the actual text width, not the allocated text width.

Review URL: http://codereview.chromium.org/99222


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15042 0039d316-1c4b-4281-b951-d872f2087c98

Glue part for the provisional WebKit merge (https://bugs.webkit.org/show_bug.cgi?id=25347).TBR=yurys
Review URL: http://codereview.chromium.org/99274

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15041 0039d316-1c4b-4281-b951-d872f2087c98

happening, so it seems unlikely that this is a reference counting
problem.

BUG=9746
Review URL: http://codereview.chromium.org/100247

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15038 0039d316-1c4b-4281-b951-d872f2087c98

issue by adding the style declaration wrappers to the object groups of
the elements they belong to.
Review URL: http://codereview.chromium.org/100204

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15037 0039d316-1c4b-4281-b951-d872f2087c98

R=thestig
BUG=10681
TEST=Start a long download.  Try to quit the browser.  Notice the spiffy title on the dialog box.


Review URL: http://codereview.chromium.org/100241

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15035 0039d316-1c4b-4281-b951-d872f2087c98

TBR=eseidel
BUG=10898
TEST=0

Review URL: http://codereview.chromium.org/100244

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15033 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99266

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15032 0039d316-1c4b-4281-b951-d872f2087c98

http://code.google.com/p/chromium/issues/detail?id=11264

Integer 0 and -1 have special meaning in HashMap<int, ...>, both cannot be used as key.
Specially filter out these two keys.

Review URL: http://codereview.chromium.org/100242

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15031 0039d316-1c4b-4281-b951-d872f2087c98

A NPObject can be called as a construct if it implements NPN_Construct, and NOT implements
NPN_InvokeDefault. Otherwise, NPN_InvokeDefault is called even when the object is called
as a constructor.

Review URL: http://codereview.chromium.org/56167

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15029 0039d316-1c4b-4281-b951-d872f2087c98

After discussing with various people, I think we're going to do this
in the short term at least. Currently we're calling into GTK from the
IO thread and Bad Things Happen when one does that.

We would like to write an Xlib, fully asynchronous system for dealing
with the clipboard (and to get the clipboard stuff out of base!). That
would let us avoid sending the selection over the IPC channel each
time it updates too.

However, that's going to be a lot of work and we have crashing
browsers happening /right now/. Also, Evan thinks that maybe we don't
have the deadlock situation on Linux that we do on Windows with
terminating sync requests from the renderer on the UI thread.

http://codereview.chromium.org/100238

BUG=9865


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15028 0039d316-1c4b-4281-b951-d872f2087c98

Undisable the temporarily disabled test, by fixing the URL expectation to have %22 instead of \" (to match change in GURL canonicalization).

BUG=11142
TBR=evan

Review URL: http://codereview.chromium.org/100148

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15027 0039d316-1c4b-4281-b951-d872f2087c98

I accidentally marked mac/linux as crash when I really wanted to mark win

BUG=11264

TBR=dglazkov

Review URL: http://codereview.chromium.org/100239

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15026 0039d316-1c4b-4281-b951-d872f2087c98

On POSIX one can install an unload handler which loops forever and
leave behind a renderer process which eats 100% CPU forever.

This is because the terminate signals (ViewMsg_ShouldClose and the
error from the IPC channel) are routed to the main message loop but
never processes (because that message loop is stuck in V8).

One could make the browser SIGKILL the renderers, but that leaves open
a large window where a browser failure (or a user, manually
terminating the browser because "it's stuck") will leave behind a
process eating all the CPU.

On Windows we don't have this issue because all the processes are in a
job so when the parent dies, all the children are killed too.

http://codereview.chromium.org/100222


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15025 0039d316-1c4b-4281-b951-d872f2087c98

to succeed. Disabling the MediaPlayerNew test as an ASSERT in Webkit is firing causing the
renderer to crash. Will debug this more and log a bug.

TBR=nsylvain

Review URL: http://codereview.chromium.org/100236

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15024 0039d316-1c4b-4281-b951-d872f2087c98

resource only changes to rebuild lots of stuff on Mac and Linux,
but since most of this is happening on Windows anyway, only
optimize for Windows.

This should make second builds faster since all the dependencies
are up to date.

Review URL: http://codereview.chromium.org/99265


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15023 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/102020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15022 0039d316-1c4b-4281-b951-d872f2087c98

BUG=11264

TBR=dglazkov

Review URL: http://codereview.chromium.org/100235

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15021 0039d316-1c4b-4281-b951-d872f2087c98

Stop the location bar from flashing white when navigating from one HTTPS site to another.  To do this, we have to make sure the SSLManager sees the DidCommitProvisionalLoad event before the location bar draws itself to the screen.

BUG=11157
TEST=Navigate from one HTTPS site to another and watch the location bar carefully.  It shouln't flash anymore.

Review URL: http://codereview.chromium.org/99247

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15020 0039d316-1c4b-4281-b951-d872f2087c98

R=jar

Review URL: http://codereview.chromium.org/99020


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15018 0039d316-1c4b-4281-b951-d872f2087c98