- 03 Mar, 2020 40 commits
-
-
Jonathan Backer authored
This reverts commit d32b3d49. Bug: 1037939 Change-Id: I150adeacc788d6e06e7c41b7ce00b4edd8cddc94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989034Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#746373}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e36af5c1ab9b..db533a37a8ca Created with: gclient setdep -r src-internal@db533a37a8ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Idecc3a5456dff651e768734dae29f4669929462b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083964Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746372}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/06b6db68ff7e..6e9087162a1c git log 06b6db68ff7e..6e9087162a1c --date=short --first-parent --format='%ad %ae %s' 2020-03-03 dneto@google.com Get spirv.hpp from SPIRV-Headers, not Glslang (#992) Created with: gclient setdep -r src/third_party/shaderc/src@6e9087162a1c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I3d264570307be0a48f0f533a645d85cb9f1c4816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083966Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746371}
-
Yoichi Osato authored
That's because we won't send body with the request. This CL also refactors CopyHeadFrom function to take reference than pointer because all arguments must not be null. Bug: 787704 Change-Id: I426c0251772cede8d130a24c298f99d005ac345c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082853Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#746370}
-
Tim van der Lippe authored
This test was replaced by an e2etest in https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2083316 TBR=aerotwist@chromium.org Bug: 1044632 Change-Id: Ie1fd5772d3139aa4b61a725cd271bd4bf6feec60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084853Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#746369}
-
shivanigithub authored
Change-Id: I0225bfb6a17f9a914eb317ee814d729778fc4e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079095Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#746368}
-
Ehimare Okoyomon authored
Changed edit_exception_dialog.js from site settings to follow the same exception pattern setting as add_site_dialog.js Bug: 1057091 Change-Id: I7d1337197df0fc7bc294df077eb433b90820c661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082379 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#746367}
-
Bret Sepulveda authored
To ensure permission bubbles are consistent with other bubbles in width, this patch tweaks CalculatePreferredSize so that it is always DISTANCE_BUBBLE_PREFERRED_WIDTH dips wide instead of sometimes snapping to a larger size. Change-Id: Ifed85665168ffccf2d8fda1e34f489a51c11f085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082570Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#746366}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/853789cdfe3c..96c2eb6258ae git log 853789cdfe3c..96c2eb6258ae --date=short --first-parent --format='%ad %ae %s' 2020-03-03 borenet@google.com [recipes] Move nanobench flags logic into gen_tasks_logic/nanobench_flags.go 2020-03-03 borenet@google.com [recipes] Compute nanobench flags in gen_tasks 2020-03-03 borenet@google.com [recipes] Move nanobench flags to a separate file Created with: gclient setdep -r src/third_party/skia@96c2eb6258ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: I888c5a94b2babf88cdcce4b0cdd27c9e3c2d6078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083963Reviewed-by:
-
Stepan Khapugin authored
Groups all per-window shutdown code together and moves it before the other shutdown code to match expected behaviour of shutdown in multiwindow world. Bug: none Change-Id: I7abf63beecd3d2d6c0479da9c9a6f31477f3ae53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084595Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746364}
-
Stepan Khapugin authored
Moves AppURLLoadingService to SceneController. Change-Id: Ifc8053cf455918fed6839646be65f22fd7d35a32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081427Reviewed-by:
-
Maksim Moskvitin authored
All usages already replaced with TopicInvalidationMap. Additionally, this CL adds tests for TopicInvalidationMap (based on the tests we had for ObjectIDInvalidationMap) and cleans up its interface from redundant ToString() and ResetFromValue(). There should be no behavioral changes. Bug: 1029698 Change-Id: I81c9e9aa5e00fd196fe8911b92f5c11b5d1f280a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078473 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#746362}
-
Andrew Solovey authored
Force log out unauthenticated enterprise users if |ForceLogoutUnauthenticatedUserEnabled| policy is set to true. |ChromeOSLimitedAccessAccountReconcilorDelegate| is being refactored to support two different types of accounts: child and enterprise with |ForceLogoutUnauthenticatedUserEnabled|. The ReconcilorDelegate logic connected with child accounts remains unchanged. Bug: b/146461662 Change-Id: Ic340ea3d59537f8c1092362ae0c8e32756bbb26f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058820 Commit-Queue: Andrei Salavei <solovey@google.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#746361}
-
Eugene Girard authored
Bug: 1057351 Change-Id: Id33f6092a76ea69ad92607fe0ebf7e397aca0654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083386 Commit-Queue: Eugene Girard <girard@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#746360}
-
Daniel Vogelheim authored
Remove unused functions and associated unit tests. This prepares for changes to rename & change the trusted_types_util.h interfaces. Bug: 739170 Change-Id: I45ddf92d5946cb72a33ae4fba2bfb8d04f8c4d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078611 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Yifan Luo <lyf@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#746359}
-
Ramin Halavati authored
Update AmbientAuthenticationInPrivateModesEnabled description and example value. Bug: 458508 Change-Id: Icc6e91ec5cfe15cc37886ebd52d4401b77b24e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081422 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#746358}
-
Bret Sepulveda authored
On Linux, the extensions menu bounds can appear off the screen in tests on the bots, which is causing the tests to be flaky. Since the menu doesn't have any control over where it appears, this patch just disables those checks to stop the failures. Bug: 1050012 Change-Id: I10bbf42cee6985eca82c60cf5c6e769cf7e81ab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080352 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#746357}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/29f04c8cdb9b..8ff2fc8fcdb1 git log 29f04c8cdb9b..8ff2fc8fcdb1 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 rsavitski@google.com Merge "traced_perf: pid/cmdline target white/black-listing" Created with: gclient setdep -r src/third_party/perfetto@8ff2fc8fcdb1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ied3d638fa7e898df6144853d5959651ff03a2567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083961Reviewed-by:
-
Mohamed Amir Yosef authored
Whether saving in the account store should be guarded by the current settings not the current state. This is relevant for when the user just opted in butter, it may take couple of seconds till the passwords get synced. We shouldn't however block storing in the account store in the meanwhile. Bug: 1012203 Change-Id: Ieac2799b88ab8d8d64dee84bbd51450af82790ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083453Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
Javier Ernesto Flores Robles authored
Adds the screen to be shown when there are no passwords to show. The current image is a placeholder while the final version is ready. Bug: 1045448 Change-Id: I7f5a6cdcd6f564d78d0ea25bc82312b23d8ddd14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082922 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746354}
-
Side Yilmaz authored
PassphraseDialogFragment. |Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates PassphraseDialogFragment class. Note: This change is only code clean-up, does not change any behavior. Bug: 1041781 Change-Id: I3153d152820781be684fc0fd0a7ff00d45c6981b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082912Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#746353}
-
Jonathan Backer authored
Bug: 1019787 Change-Id: I3f3121b7da6e46a9558ac0a2058b9ba8239fea84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078772 Auto-Submit: Jonathan Backer <backer@chromium.org> Reviewed-by:
-
Kenneth Russell authored
Due to flakiness seen, add RetryOnFailure expectation on GeForce GTX 1660 for deqp/functional/gles3/framebufferblit/depth_stencil.html . Bug: 1057635 Change-Id: I7140dc317fc229ddaf62c85ccfdc70049894ae6b Tbr: jmadill@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081619Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#746351}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7e2188de..189353b3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6e68b952753daefd30bbbfbecb4d6dcdac98a52c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084511Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746350}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: Ie729809d9a64635b28828461aaf84d01105b0719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083448Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746349}
-
Javier Ernesto Flores Robles authored
Adds the screen to be shown when the passwords are erased due a sign out. The current image is a placeholder while the final version is ready. Bug: 1045452 Change-Id: Ifccdbd64618e28d8c670aa80adf6b02b76e90b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084593 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9ee726959e1f..e36af5c1ab9b Created with: gclient setdep -r src-internal@e36af5c1ab9b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ic33623039df13345f92a406a8927d3b3dc21a65a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083960Reviewed-by:
-
Paul Lewis authored
Bug: 1032561, 1046784 Change-Id: I8de085643cd605e3f12b7640b703157f9bfbb176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082386Reviewed-by:
-
Nico Weber authored
MSVC_PUSH_DISABLE_WARNING (and MSVC_POP_WARNING) had a few (no-op) uses that needed cleaning up. MSVC_DISABLE_OPTIMIZE (and MSVC_ENABLE_OPTIMIZE) have no uses and can just be removed. Bug: 1053958 Change-Id: Ic4e3a4c7443988d4621d79e02b348f1a3628730f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082353 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#746345}
-
Rune Lillesveen authored
Sub-pixel size changes to the root element font-size did not update rem unit lengths if the px rounded root element font-size did not change. Bug: 928371 Change-Id: Id9fab5ac4ab5a126b39a0d2bd7373d01802d29fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083175Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#746344}
-
Nohemi Fernandez authored
Show an activity indicator animation when the sign-in operation is in progress and remove it if the user cancels the operation while it has not yet been completed. Bug: 971989 Change-Id: I0578f79318e7b0476c4d159ee163d00bbabb461d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079111Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#746343}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b19408040143..853789cdfe3c git log b19408040143..853789cdfe3c --date=short --first-parent --format='%ad %ae %s' 2020-03-03 borenet@google.com [recipes] Refactor nanobench flags Created with: gclient setdep -r src/third_party/skia@853789cdfe3c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: Iac597da19376331ea6a394c134c40c61579ff728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083957Reviewed-by:
-
Tobias Sargeant authored
SelectionPopupController uses ActionMode.getMenuInflater to instantiate a MenuInflater that uses an appropriately themed context. However this can never work for WebLayer, because it relies on the wrapped context as the only means of accessing its assets/resources. WebLayer cannot rely on the current implementation because reaching the fallback is dependent on the embedding application not having defined a resource with the same ID. WebView, on the other hand, must continue to use the current approach, because it injects its assets and resources into the activity context and can make use of activity themes, but in some cases may have to fall back to the WebContents context because on sokme Android versions and in some circumstances the ActionMode object has a context that has not had webview resources injected. Bug: 1057816 Change-Id: I417bea202ffb439fcc3960c3c5e28360b16fe9d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083476Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#746341}
-
Hans Wennborg authored
Bug: 993206 Change-Id: I2d010d65ae5b6007b7c065dc45ae8dd2a36d1dee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083183Reviewed-by:
-
Tim van der Lippe authored
Requires the same LLVM_ENABLE_PROJECTS arg specified. I also removed the duplication for the Ninja build instructions. R=hans@chromium.org Bug: 993206 Change-Id: I96d278120be62813a62b8c1f930b5ff55e2f34cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082924 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
Maksim Moskvitin authored
This CL is a part of ObjectID -> Topic API migration. It replaces ObjectID with Topic in InvalidationLogger and its dependencies. There should be only one behavioral change: chrome://invalidations page would expose 0 as an ObjectID::source for any subscription. It's not a real change, because |source| was already deprecated and the same value used. In the future chrome://invalidations should be updated to use Topic instead of ObjectID. chrome.invalidations.logInvalidations now receives TopicInvalidationMap::ToValue() instead of ObjectIDInalidationMap::ToValue(), but their ToValue() implementations are the same, so there should be no changes. Bug: 1029698 Change-Id: I17f36f7c43b664185bf87da4edb8d7d99a0afec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074877 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e8a277b7c74b..d5ae9bf042df git log e8a277b7c74b..d5ae9bf042df --date=short --first-parent --format='%ad %ae %s' 2020-03-03 szuend@chromium.org [utilities] Remove a use-site of Array#remove in RequestCookiesView 2020-03-03 szuend@chromium.org [utilties] Replace use-site of Array#remove with Array#filter 2020-03-03 tvanderlippe@chromium.org Add tsc.js to inputs of ts_library 2020-03-03 liviurau@chromium.org Retry rmtree on windows Created with: gclient setdep -r src/third_party/devtools-frontend/src@d5ae9bf042df If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1050549,chromium:1057642 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia4930b2a1edf63f4c1d366b30d5ad82bc82e0a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083958Reviewed-by:
-
Mihai Sardarescu authored
This CL extends the lifetime of histogram FirstRun.SignIn as it is a critical histogram used to log the way the user interacts with the sign-in screen shown during the first run. Bug: 1052986 Change-Id: I061d1257b006256af095ecb7ecc46f798da813ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083471Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#746336}
-
Himanshu Jaju authored
Bug: 1002436 Change-Id: Ia114dfb35767ac63a2ca3462d13c04cd7e64837c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082514Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
-
Tim van der Lippe authored
Clang-format is now part of the GitHub repository at https://github.com/llvm/llvm-project/tree/master/clang and requires the `clang` project to be enabled in the cmake command. R=hans@chromium.org Bug: 993206 Change-Id: I6527fd41050550f979836b76b5b86cda2dd36d95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081425 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
-
