- 19 Jun, 2020 40 commits
-
-
Andy Paicu authored
benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/browse:media:googleplaystore:2018 benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/load:social:vk:2018 benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/browse_accessibility:tech:codesearch:2018 TBR=sullivan@chromium.org Bug: 1097065 Change-Id: Ibc1da2f9e0628177182eb61c16401368cae35ba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253979Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#780340}
-
Evan Stade authored
CookieControlsController also moves. The only code change is to change the construction parameters of CookieControlsController so that it doesn't depend on PermissionsClient. Bug: 1071775 Change-Id: Ifffb29e83b9d75823920652ce73f5aa0c2b0b5d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240008Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#780339}
-
Will Cassella authored
If HTMLMediaElement::Play is called before HTMLMediaElement::LoadTimerFired is run, then LoadTimerFired will set the 'show-poster-flag' to 'true', and nothing will unset it even after playback begins. This was because the call to 'SetShowPosterFlag(true)' was in the wrong location, this CL moves it to the right location, and adds a test to prevent regression. Bug: 1094778, 1095320 Change-Id: Ia1c558a35f2816136994c0013061d2e00ae90ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249459 Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#780338}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/693e88ae8516..be637db5897d 2020-06-19 cwallez@chromium.org Vulkan: Correctly request 16bit shader features. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I439dc753de2b0ea0ffb8df3aba302684fea81e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254200Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780337}
-
Eric Seckler authored
The "TtsPlatformImpl:initialize" event is used around an async task that executes in the background, thus should be an async trace event outside the current thread's track. Change-Id: Icc89048a1c7e2a9659e12fbe74d5b0600b6becf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252166 Commit-Queue: Eric Seckler <eseckler@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#780336}
-
Peter Kotwicz authored
Disable DiskWrite Strict Mode checking in DecoderServiceHost#dispatchDecodeImageRequest() BUG=1095374 Change-Id: Id6a501aaba0fbfebd7833efcb48e22103d665a9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247381Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#780335}
-
Olya Kalitova authored
Replaces recommended free disk space message with required free disk space message when there is not enough free disk space for Plugin VM installation. Also updates confirmation message for setup flow before it is started. Bug: b/157584005 Change-Id: Ie95058e21d086cd34b8b31b115b602b9c27a71b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236354 Commit-Queue: Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#780334}
-
Anthony Vallee-Dubois authored
This also renames the kCBCMServiceAccounts feature to kCBCMPolicyInvalidations. Bug:1026261 Change-Id: Iae54bca447e3af263fc3fd1840639c04ed3652d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2175542Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#780333}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4c137c524b78..d43ba60f648c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC aaronhk@google.com,andypaicu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: aaronhk@google.com,andypaicu@google.com Change-Id: I8439c1a4743a6940c9db6cd5064ad9009ebe20ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254199Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780332}
-
Bartek Nowierski authored
This are needed when Chrome codebase is automatically rewritten to use CheckedPtr (see go/miracleptr for project description). Bug: 1080832 Change-Id: I1ca4ac87d37f57de8304fc22e0ba36cb60ca323a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243072 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#780331}
-
Rushan Suleymanov authored
This patch introduces two histograms for initial merge and remote update which counts number of remote specifics without full title: * Sync.BookmarkWithoutFullTitle.OnRemoteUpdate * Sync.BookmarkWithoutFullTitle.OnInitialMerge Bug: 1061411 Change-Id: Ife656adc183473a4860ee15a4941d9b25cb01061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252048Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#780330}
-
Stephen Roe authored
Build times for the arm64 CQ 10% bot experiment over the last 6 days are similar to the existing x64 CQ trybot: builder fuchsia_arm64 fuchsia_x64 builds 487 5109 build_minutes_p50 31.42 24.98 build_minutes_p70 46.82 40.13 build_minutes_p90 56.05 51.45 Stability is good at 10% https://ci.chromium.org/p/chromium/builders/try/fuchsia_arm64 Capacity is also good at 10%. The average number of arm64 bots running at one time at 10% CQ varies from 8 to 15 by day out of 240 bots. Typical spikes are 50 to 60 bots active when a CL build is in progress or 100 to 120 bots active when two CL builds overlap. Pending times at 10% CQ are low. p90 is 2 seconds, p95 is 8 seconds. There is more build time info at https://docs.google.com/spreadsheets/d/1Z_iOiX-9mTDxJrZJri97A-JY-goYkTHlKU4M9EDXLpA There is more pending time info at https://docs.google.com/spreadsheets/d/1YdszSQlLDi5X4Qnakess7YIfSLBu4hzZJ3aZ6cKPFX4 There is more capacity and bot usage info at https://docs.google.com/spreadsheets/d/1Zfn5w9yMB1oINtinS1KMblRbB209YfkqQsHRUKxdk7Q Bug: 1042511 Change-Id: I0b37c7602ddc8fa853dc6e18eeceb2ef396b8e86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252634Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#780329}
-
Yue Zhang authored
Since intents from YouTube don't have an app ID attached, this CL uses URL prefix as a proxy to support recording external intent related UMA for YouTube by checking if the url starts with "www.youtube.com/redirect?". Bug: 1095515 Change-Id: I610d5b62470fb8ef4273a3d82abf991205d035af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249045Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#780328}
-
Alexander Hendrich authored
The new API is only available to force-installed (see intro) extensions running on Chrome OS. Bug: 1081333 Change-Id: I5388e0d7e9af1150415226a11c4152d2196bb9f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250001 Auto-Submit: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#780327}
-
Ken MacKay authored
Bug: internal b/158335072 Change-Id: Ic3413ccd9722a8fadc05fb36a8a2e9c821cf65ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240275Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#780326}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/50097bb2..a2948f22 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I23463cf67914d0d8331d2c751f874097eae3230d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254158Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780325}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/23c845754ce8..42f585a5ad09 2020-06-19 mathias@chromium.org Fix `-theme-preserve` styles 2020-06-19 yangguo@chromium.org Allow COMMON_OWNERS to review BUILD.gn 2020-06-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083142 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I80b8f2fdf3aae38a0a7c20c1f2e27d1f97e5dab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253897Reviewed-by:
-
Olivier Robin authored
When resuming session, open a normal tab even if the previous active browser was incognito. Bug: 1095592 Change-Id: I77cf1939cc210b081deff8dd5cb8f987191200b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252804 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#780323}
-
Jonathan Mengedoht authored
Bug: 927473 Change-Id: I251f368f1b1db2c121105172827c69bf05cd6eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224870 Commit-Queue: Jonathan Mengedoht <mengedoht@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#780322}
-
Andrew Grieve authored
Bug: 1096987 Change-Id: I90c94ff848965c219054202c3dd3a319c8d14df3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254078 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#780321}
-
Victor Hugo Vianna Silva authored
This CL adds metrics to record whether the moving flow was explicitly triggered by the user on Settings, or after they used a profile store password in a form. Bug: 1063852 Change-Id: Ia4af24b09c636fb02c17d92c7a7f3c4ff25cfb7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249935 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#780320}
-
Ulan Degenbaev authored
The existing implementation measures memory usage of the main JS agent and reports URLs of the JS realms in the agent. The algorithm for mapping a JS realm to its reported URL walks the frame tree upwards to find the top-most cross-origin frame. The algorithm incorrectly assumed that all frames the path are local frames since the realms are local. This does not hold in the ABA case, where the main origin A embeds an iframe from origin B that in turn embeds an iframe from origin A. In such a case, the main JS realm and the grandchild realm are in the same JS agent and their frames are local. However, the child frame B is a remote frame. This CL fixes the algorithm to work both with local and remote frames. The URL of a remote frame can no longer be fetched from its document. Instead, it is fetched from the src attribute of the owner iframe element. This aligns with the upcoming spec and fixes the leak of post-server-redirect URLs. The CL also removes LocalFrame::FirstUrlCrossOriginToParent that is no longer needed. Bug: 1093880,1084999 Change-Id: I7a57a17701448d0fe210a66c7bdb8c0229fa5149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246175 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Shubham Aggarwal authored
As per issue 78507, we are looking to add support for SQLite databases to use Write-ahead logging (https://www.sqlite.org/wal.html) mode in Chromium. WAL mode should give us significant performance gains across almost all use-cases. This change is a first step towards achieving this. It adds opt-in support to enable WAL mode for a database connection and perform a checkpoint. It also adds a feature flag to enable WAL mode for all databases by default to investigate its feasibility and impact on performance. Bug: 78507 Change-Id: I7fc5edcc39b50d2a13755d587cf342bded1af60a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095927 Commit-Queue: Shubham Aggarwal <shuagga@microsoft.com> Reviewed-by:
Brandon Maslen <brandm@microsoft.com> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#780318}
-
Xianzhu Wang authored
When a frame is unthrottled, it may have pending visual update, and its descendant frames may skip throttling status update because their viewport intersection update may access dirty geometry of the ancestor frame. Previously in the case, the descendant frames might not have the flag of needing viewport intersection update set for the next document lifecycle update, and would fail to unthrottle. To ensure the descendant frames will be correctly unthrottled, now call SetIntersectionObservationState() when a frame is unthrottled. Bug: 1054644 Change-Id: Ifbb4db8cdcee58b9690937bb1f0ee311d1cb4bd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252030 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Shervin Oloumi authored
Updates the summary for Cryptohome's EvkkEncryptionType metric, making it more descriptive. Bug: 817430 Test: pretty_print.py and validate_format.py passes Change-Id: I5439f1b7acbf0d0dbfc7dd5d0c164bb888197418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253222 Auto-Submit: Shervin Oloumi <enlightened@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Reviewed-by:
-
Devlin Cronin authored
set_icon.js checked the `self` variable to determine whether the script was running in a ServiceWorker (such as a ServiceWorker-backed extension). However, this is unsafe because, unlike `window`, `self` can be overwritten by other script. If an extension specified a value for `self`, that would be used instead - and would subsequently crash if the value didn't support the `in` operator (i.e., wasn't an Object). When this happened, the custom bindings would fail to register any hooks. This, then, would result in API calls to browserAction.setIcon() in passing the arguments directly to the browser-side handling. When this happened, the browser would classify it as a bad message (because it didn't undergo the expected argument modifications), and would kill the renderer. Fix this by adding a native binding to return whether the script is running in a ServiceWorker context. Add a regression test. Bug: 1087948 Change-Id: I1bb593af735dec6d7a2a25050e62677f23c23dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253284Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#780315}
-
Andrew Grieve authored
This reverts commit 44a03014. Reason for reland: Wasn't the culprit (see bug) Original change's description: > Revert "Android: Define paths to expectation files in leaf targets" > > This reverts commit 4a914f21. > > Reason for revert: Build failure in https://ci.chromium.org/p/chrome/builders/ci/arm64-unpublished-builder and https://ci.chromium.org/p/chrome/builders/official/android-arm-official-next > > Possible reason might be renaming //chrome/android:monochrome_public_bundle__base_libs_and_assets_expectations and //chrome/android:trichrome_chrome_bundle__base_libs_and_assets_expectations > > Original change's description: > > Android: Define paths to expectation files in leaf targets > > > > This is easier to follow then deriving it in the templates. > > > > Also changes webview expectations apk->bundle > > > > Bug: 1095654 > > Change-Id: I5952ee9a660e4f32b22ef4100fea2f231d9eb96d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245880 > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Richard Coles <torne@chromium.org> > > Reviewed-by: Mohamed Heikal <mheikal@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#780157} > > TBR=torne@chromium.org,agrieve@chromium.org,mheikal@chromium.org > > Change-Id: I8ef314098ae3949d21fc885b885b467314f6d695 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1096987 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252344 > Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org> > Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780271} TBR=torne@chromium.org,agrieve@chromium.org,mheikal@chromium.org,triploblastic@chromium.org No-Presubmit: true Bug: 1096987 Change-Id: I67937a8b09d9ecca0be3356ae17fc517c8be5ce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254438Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#780314}
-
Sahel Sharify authored
This cl contains the following changes: 1-PaymentRequestUpdateDetails can have null shippingOptions/modifiers The cl modifies the TypeConverter to check for null arrays before passing them to Arrays.asList 2-changePaymentMethod/changeShipping[Address|Option] from PaymentDetailsUpdateService should get the binder's calling uid before posting the task to the browser's UI thread. Bug: 1026667 Change-Id: I94aaf4caa0d3b08db89993b0450cd3baf7b77a60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252199Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#780313}
-
Hans Wennborg authored
The ASan runtime started calling it after https://github.com/llvm/llvm-project/commit/6b4aeec94afc3626c19ed93dea5d158fbea29732 Bug: 1097067 Change-Id: Ifb37700e5385158cf957c987018f1a9561cc0cef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254318 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#780312}
-
Thomas Tellier authored
This CL reintroduces the submit button on the login / lock screen password textfield and disable the login display password button feature by default, by putting it under a feature flag. Bug: 1090319 Change-Id: I521a19262726f7c0566d824b0efe5aa1c9abb7a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247826 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#780311}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592560372-5e1e91918016f52d8aaeea816d2c59deb0aa5d08.profdata to chrome-win64-master-1592568001-645f451bc013d681af722dc2b85e4992534cb0fa.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I599d140a53e9aead7b21b3b47fdda93a958f88e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253891Reviewed-by:
-
Andy Paicu authored
TBR=garrick@chromium.org Bug: 1097021 Change-Id: I88623210e697f595ee03e1226abaac743d6b971e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254139Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#780309}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/62fea391fa99..6e722f2eaa58 2020-06-19 apodtele@gmail.com [base] Rework d1180b5f9598 until further notice. 2020-06-19 sebras@gmail.com [cff, cid] Fix segfaults in case of error (#58621). 2020-06-19 wl@gnu.org [base] Fix UBSAN error. 2020-06-19 wl@gnu.org [woff2] Fix segfault. 2020-06-19 svenevs.dev@gmail.com [sfnt] Support Intel compilers. 2020-06-19 sebras@gmail.com [base] Fix memory leak (#58611). 2020-06-19 sebras@gmail.com [cff] Fix memory leak (#58610). 2020-06-19 wl@gnu.org * src/cff/cffload.c (cff_index_get_pointers): Rename `t' to `tbl'. 2020-06-19 sebras@gmail.com [cff] Free table upon error allocating other data (#58609). 2020-06-17 wl@gnu.org woff2tags.h: Fix copyright year. 2020-06-13 wl@gnu.org Remove redundant inclusion of `ft2build.h'. 2020-06-08 david@freetype.org Make macros for header file names optional. 2020-06-02 wl@gnu.org * src/sfnt/ttcmap.c (tt_face_build_cmaps): Trace number of cmaps. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: Ida9cedae09810da765b1d8fd71c567c390bb57b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253887Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#780308}
-
Clemens Arbesser authored
Note that users may enable/disable a11y at any time, which is why the service has to update the state correspondingly. Bug: b/158989900 Change-Id: Ie4e58f3b8ece6df2c176c1b63820dd2a143789f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245702Reviewed-by:
Luca Hunkeler <hluca@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#780307}
-
Majid Valipour authored
Changes: - Fix regex to accept very short otp code: #(.[]+) -> #([]+) - Add tests to ensure we reject forbidden host characters - Add additional tests around number of spaces expected Followup patch will allow host to accept unicode. Change-Id: I7cbeabe31edd9c9ead7ae78425c8760f9c78ce9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248071 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Sam Goto <goto@chromium.org> Cr-Commit-Position: refs/heads/master@{#780306}
-
Oriol Brufau authored
::marker pseudo-elements are currently behind the CSSMarkerPseudoElement runtime flag. I plan to ship them soon, but without support for nested pseudo-elements (::before::marker and ::after::marker), since that would require more work in the style resolver. That's what Firefox did too. So this patch hides them behind CSSMarkerNestedPseudoElement, which implies CSSMarkerPseudoElement. In order to make it easier to check whether a pseudo-element should be exposed (e.g. in devtools or getComputedStyle), this patch adds a static PseudoElement::IsWebExposed method which takes care of doing the proper checks. Right now it's just for ::marker, but it can also be useful for future tree-abiding pseudo-elements like ::file-selector-button. Bug: 457718 Change-Id: Idf764855cca62e0776463346af04e4f2bcc53040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250103 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#780305}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d64d998b9f1f..b93c9d1a5342 2020-06-19 lalitm@google.com Merge "ui: revamp quantization for cpu and userspace slices" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1a514bab55739facd7e84142650f36e459a820ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253889Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592560372-e09cb0657078c6c75bd738f91c59baf5eafe0404.profdata to chrome-win32-master-1592568001-0b6b26a9a978d83410a95ed47a0a1a3dcdc59066.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ib70cf954f0c3ba7f90459af0e1a0e39a15a19790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253888Reviewed-by:
-
Xi Han authored
Bug: 1097069 Change-Id: I5becd0a8850c8eff6dcbb3bc5e55af656dac35fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254060Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#780302}
-
Sigurdur Asgeirsson authored
There's no need to represent this as a map on the wire and it creates complications in the mojo bindings for upcoming CLs. Bug: 1080672 Change-Id: I20cfe281d5dbb752bd5b376e45f6d1e1aff98852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250790Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#780301}
-
