GitLab

This patch makes the visual-viewport-managed scrollbars exclusive to
Android and improves normal scrollbars to be usable during pinch as follows:

1. Attach the scrollbar layers to the visual viewport, so they're always
   onscreen as you zoom in (as already shipped on Mac).
2. Set the container layer to the inner clip layer, so that the size and
   position of the thumb reflects the sum of the two viewports,
   instead of just the layout viewport.

Note that result of these changes is visually indistiguishable at
minimum page scale.  It only improves the behavior when zoomed in.

BUG=523056

Review URL: https://codereview.chromium.org/1308053003

git-svn-id: svn://svn.chromium.org/blink/trunk@201285 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a trivial patch, split off from https://codereview.chromium.org/1315993004.
This patch removes an incorrect "paintOffset" name and fixes the recorder
type in BlockFlowPainter.

Review URL: https://codereview.chromium.org/1316883003

git-svn-id: svn://svn.chromium.org/blink/trunk@201284 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch makes a few small clean-ups to getValueName:
- Type argument as CSSValueID instead of unsigned short
- Disallow trying to serialize invalid CSSValueIDs
- Don't add values for CSSValueInvalid in the offset tables

Review URL: https://codereview.chromium.org/1302273005

git-svn-id: svn://svn.chromium.org/blink/trunk@201283 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We no longer need paint-phase-based subtree display items because we'll
use paint layers as units of subtrees. This greatly simplifies subtree
caching.

Renamed subtree to subsequence.

BUG=410087

Review URL: https://codereview.chromium.org/1313223002

git-svn-id: svn://svn.chromium.org/blink/trunk@201282 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The method should be allowed to execute JS since it needs it to collect call stack.

BUG=525305

Review URL: https://codereview.chromium.org/1313693007

git-svn-id: svn://svn.chromium.org/blink/trunk@201280 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=525109

Review URL: https://codereview.chromium.org/1311363007

git-svn-id: svn://svn.chromium.org/blink/trunk@201279 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Specification at https://heycam.github.io/webidl/#idl-constants mentions the constants
should be defined as:

  const type identifier = value;

whereas the |type| is mentioned as:

  The type of a constant (matching ConstType) must not be any type other than a primitive
  type or a nullable primitive type

And string literals are not treated as primitive types. Hence we should remove the support
for having a constant like:

  const DOMString hello = "world";

BUG=469961

R=haraken@chromium.org

Review URL: https://codereview.chromium.org/1315663004

git-svn-id: svn://svn.chromium.org/blink/trunk@201278 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When user use styles formatting option with borders it can be important to not produce additional string tokens.

BUG=520724
R=lushnikov@chromium.org,pfeldman@chromium.org

Review URL: https://codereview.chromium.org/1310303004

git-svn-id: svn://svn.chromium.org/blink/trunk@201277 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=520259

Review URL: https://codereview.chromium.org/1309033003

git-svn-id: svn://svn.chromium.org/blink/trunk@201275 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL allows us to remove another shim, InlineBox::deprecatedBoxModelObject,
and clears the way for removing all direct LayoutObject access in core/line/.

BUG=499321

Review URL: https://codereview.chromium.org/1310473003

git-svn-id: svn://svn.chromium.org/blink/trunk@201274 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=461320

Review URL: https://codereview.chromium.org/1319823002

git-svn-id: svn://svn.chromium.org/blink/trunk@201273 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201226

BUG=524623
TBR=caryclark@google.com

Review URL: https://codereview.chromium.org/1318003002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201272 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201237

BUG=525050
TBR=caryclark@google.com

Review URL: https://codereview.chromium.org/1317993002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201271 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a subset of https://codereview.chromium.org/1313763002/.

The tests have to be removed in a separate patch to unblock the Chromium-side
patch: https://codereview.chromium.org/1314643002/.

BUG=524115

Review URL: https://codereview.chromium.org/1303233007

git-svn-id: svn://svn.chromium.org/blink/trunk@201270 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=525295,525296,525299,525300

git-svn-id: svn://svn.chromium.org/blink/trunk@201269 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This includes the following changes:
- Material design icons to match the current mocks better.
- Rename securityPanel.css into mainView.css, because it only contains main view CSS anyhow.
- Rewrite security panel main view DOM code to match the mocks.

BUG=484387

Review URL: https://codereview.chromium.org/1316853002

git-svn-id: svn://svn.chromium.org/blink/trunk@201267 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=522796

Review URL: https://codereview.chromium.org/1307843002

git-svn-id: svn://svn.chromium.org/blink/trunk@201266 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The friends of LayoutObject only need to access the layout tree mutation
methods, but get access to all LayoutObject private members.

Add LayoutObject::setDangerousOneWayParent() to avoid friends.

Expose several private/protected members to public which were accessed
using friend relationship.

Review URL: https://codereview.chromium.org/1306993002

git-svn-id: svn://svn.chromium.org/blink/trunk@201265 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It's an experimental "IDB v2" API implemented by both Firefox and
Chrome. Import the Moz test to ensure we're compatible.

R=cmumford@chromium.org

Review URL: https://codereview.chromium.org/1316203002

git-svn-id: svn://svn.chromium.org/blink/trunk@201264 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=css3/flexbox/repaint-rtl-column.html

Mark it as failing on Yosemite and pass everywhere else.

R=ojan@chromium.org
BUG=520167

Review URL: https://codereview.chromium.org/1294853002

git-svn-id: svn://svn.chromium.org/blink/trunk@201263 bbb929c8-8fbe-4397-9dbb-9b2b20218538

applyClippingToContext is equally "stateful", so the two entrypoints
does not seem warranted.
Fold applyClippingToContext into applyStatefulResource and then rename
it to prepareEffect (to match mask and filter). Similarly rename
postApplyStatefulResource to finishEffect.

Review URL: https://codereview.chromium.org/1308223003

git-svn-id: svn://svn.chromium.org/blink/trunk@201262 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch renames |isBlock(Node*)| to |isEnclosingBlock(Node*)| to make
meaning of function cleaner for improving readability.

This is follow up patch of http://crrev.com/1309903003, which introduces
|enclosingNodeOfType()|, which uses |isBlock()|.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; No behavior changes

Review URL: https://codereview.chromium.org/1320573003

git-svn-id: svn://svn.chromium.org/blink/trunk@201261 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=525286

git-svn-id: svn://svn.chromium.org/blink/trunk@201260 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to deprecate: https://groups.google.com/a/chromium.org/d/topic/blink-dev/R9JzO74jYvI/discussion

I plan to merge this to the M46 branch ASAP.

R=esprehn@chromium.org,yoav@yoav.ws
BUG=475104

Review URL: https://codereview.chromium.org/1314923005

git-svn-id: svn://svn.chromium.org/blink/trunk@201259 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Switch keypad and auto repeat booleans to use enum flags. Space was reserved
for them; this just brings PlatformKeyboardEvent more inline with
WebInputEvent.

BUG=524626

Review URL: https://codereview.chromium.org/1311233004

git-svn-id: svn://svn.chromium.org/blink/trunk@201258 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=524387

Review URL: https://codereview.chromium.org/1310863003

git-svn-id: svn://svn.chromium.org/blink/trunk@201257 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=521900

Review URL: https://codereview.chromium.org/1315703002

git-svn-id: svn://svn.chromium.org/blink/trunk@201256 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fix TestExpectations lint error after http://src.chromium.org/viewvc/blink?view=revision&revision=201246

BUG=524248
TBR=mnaganov@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1316863003 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201255 bbb929c8-8fbe-4397-9dbb-9b2b20218538

LayoutSVGResourceClipper::tryPathOnlyClipping contains the code to
emit the path - if one is successfully built. For the sake of layering,
push this out into the caller (SVGClipPainter) instead.

Also replace uses of clipperResource().isEmpty() with hasClipper(),
rename objectBoundingBox referenceBox (to better match the Masking spec
terminology) and rename the tryPathOnlyClipping to asPath.

Review URL: https://codereview.chromium.org/1308983007

git-svn-id: svn://svn.chromium.org/blink/trunk@201254 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Replace the runtime feature OverlayFullscreenVideo by
ForceOverlayFullscreenVideo. A previous change allows WebMediaPlayer
to decide whether to do overlay video, so this is no longer needed. The
replacement allows the feature to be forced on for layout tests.

BUG=511376
TEST=virtual/android/fullscreen layout tests, manual

Review URL: https://codereview.chromium.org/1311763004

git-svn-id: svn://svn.chromium.org/blink/trunk@201253 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The AbsoluteClipRects are now precomputed as part of
the compositing update step as this is the only
consumer of them (more precisely overlap testing).
Added some ASSERTs to ensure we compute them at
the right time and we don't hold onto stale values.

BUG=515970

Review URL: https://codereview.chromium.org/1316173002

git-svn-id: svn://svn.chromium.org/blink/trunk@201252 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=525031

Review URL: https://codereview.chromium.org/1315713003

git-svn-id: svn://svn.chromium.org/blink/trunk@201251 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=522865

Review URL: https://codereview.chromium.org/1312883002

git-svn-id: svn://svn.chromium.org/blink/trunk@201250 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reason for revert:
May be causing win failures, see http://crbug.com/524248#50

Original issue's description:
> Fix reftest crash logs
> 
> This patch fixes a long-standing bug where crashing reftests would not
> show some crash logs on the layout tests results page.
> 
> single_test_runner.py has an optimization to not run reftests when
> the base test crashes. This optimization accidentally failed to write
> crash logs (done through write_test_result(...)) as well. This patch
> fixes this bug and adds a small test.
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201147

TBR=dpranke@chromium.org,joelo@chromium.org,ojan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1318813005

git-svn-id: svn://svn.chromium.org/blink/trunk@201249 bbb929c8-8fbe-4397-9dbb-9b2b20218538

HTTP headers are byte strings, so anything outside of
ASCII needs to be explicitly encoded one way or another.

BUG=429569

Review URL: https://codereview.chromium.org/836823002

git-svn-id: svn://svn.chromium.org/blink/trunk@201248 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When testing all three mixed content types in one test, the test was
flaky because DevTools received requestWillBeSent events in different
orders. Instead of making sure that the requests are always sent in the
same order, this CL splits up the test into 3 separate tests, one for
each mixed content type, with common code in
resources/mixed-content-type-test.js.

BUG=523500

Review URL: https://codereview.chromium.org/1303033004

git-svn-id: svn://svn.chromium.org/blink/trunk@201247 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Let's see, whether would it help webkit_tests to complete.

BUG=524248

git-svn-id: svn://svn.chromium.org/blink/trunk@201246 bbb929c8-8fbe-4397-9dbb-9b2b20218538

And remove obsolete error messages.

3rd of 3 patches:
1. Add errors and prepare tests. (https://codereview.chromium.org/1293593003/)
2. Wire up the chooser on the Chrome side. (https://codereview.chromium.org/1286063002/)
3. This patch.

BUG=500989

Review URL: https://codereview.chromium.org/1284143006

git-svn-id: svn://svn.chromium.org/blink/trunk@201245 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Doing so results in assertion failure because the document lifecycle does not
allow rewinding from InPaintForSlimmingPaintV2 back to LayoutClean.

Skipping compositing update should be fine since SPv2 doesn't rely on old world
compositing anyway.

BUG=524879

Review URL: https://codereview.chromium.org/1312363003

git-svn-id: svn://svn.chromium.org/blink/trunk@201244 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1313633003

git-svn-id: svn://svn.chromium.org/blink/trunk@201243 bbb929c8-8fbe-4397-9dbb-9b2b20218538