GitLab

https://android.googlesource.com/platform/external/perfetto.git/+log/6f29c57c715c..6b0afc48ae3d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: Ibbb9977e68f2de024cd77dcbfa9a95218e632bd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398887Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#805006}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9218ba277ab5..72d35030231e

2020-09-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com
Change-Id: I028fb26d8c6e5f962475845d69f27d3df5a4bf67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398816Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#805005}

Bug: None
Change-Id: Icce93899dc2772432ee4df0671191998cf273ca5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390742Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805004}

Currently the multipaste menu item is notified of the selection update
by Button::StateChanged(). However, when the mouse moves from one delete
button to another one, the button state of the main button
where the mouse exists does not change: it keeps NORMAL since the
delete button is hovered. As a result, in this case the menu item
who loses the selection fails to hide its delete button.

This CL utilizes the property change callback to update the delete
button's visibility depending on the selection state.

Bug: 1112888
Change-Id: Idc711f95da53157cf37e8ccd5034be08e324a3c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388712Reviewed-by: David Black <dmblack@google.com>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805003}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7e3252b4439a..4b505928d537

2020-09-08 tvanderlippe@chromium.org Update CodeMirror to 5.57.0
2020-09-08 jacktfranklin@chromium.org Update lit-html to 1.3.0
2020-09-08 tvanderlippe@chromium.org Remove skip_rollup
2020-09-08 tvanderlippe@chromium.org [globals] self.UI.shortcutRegistry
2020-09-08 tvanderlippe@chromium.org [globals] self.Persistence.persistence
2020-09-08 tvanderlippe@chromium.org [globals] self.UI.shortcutsScreen
2020-09-08 andoli@chromium.org [ts] Typecheck css_overview/CSSOverviewController.js with TypeScript

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1058320,chromium:1101738
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I702da061a1b0097adc3a18c4b2017b9f1f8df050
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398807Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#805002}

Updates the expires_after attribute for 177 histograms that show
frequent access in the past 90 days.  These are the 90% most
frequently used histograms over that time that do not already
have a date later than or within 60 days of 2020-12-07.

TBR=chromium-metrics-reviews@google.com

Change-Id: I314b173a2f32f881cb12d3968823b60a5d50e276
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399040Reviewed-by: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Cr-Commit-Position: refs/heads/master@{#805001}

The
FullscreenControllerInteractiveTest.
TestTabDoesntExitMouseLockOnSubFrameNavigation
is flaky on win10_chromium_x64_rel_ng. Disable the test.

Bug: 1124492
TBR: thakis@chromium.org
Change-Id: I0cf69bbbcaf8305111ee2f4d25301677335e6582
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399005Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805000}

If the the date picker or time picker are dismissed without negative
button clicked. The dialog flow is leaked that any following downloads
will not show dialogs due to
DownloadLocationDialogResult.DUPLICATE_DIALOG.

Bug: 1125066
Change-Id: I1fc54941fdd8486e3346b0f3dca670bf5f5316ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394717Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804999}

Bug: 1124834
Change-Id: I659d866ed4e697bc189edd35789b2179c6d913ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392774Reviewed-by: Drew Wilson <atwilson@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Rakesh Soma <rakeshsoma@google.com>
Commit-Queue: Yusuf Sengul <yusufsn@google.com>
Cr-Commit-Position: refs/heads/master@{#804998}

Fix was landed in https://crrev.com/c/2159599.

Bug: 1069487
Change-Id: I88088ea07b76014e2cdb8c01ca0385f39470de10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388480
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804997}

Make the method friendlier to other callers.

Change-Id: Ied53accfacf02ac7d3f59d45b31cdc7fd2c34709
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393519Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804996}

Previously there were some cases where there was no parentVC on dealloc,
which caused the KVO observing from not being removed in some cases.

This CL adds a BOOL for tracking to make sure the KVO observing stops
on dealloc if needed.

Bug: 1108794, 1085419, 1122031
Change-Id: Ifdfe268658fe90386f3ceb6c202d208bd431ef62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398398Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804995}

Bug: 1044687
Change-Id: Iaa6e84f3d71382a0f783ddabcdb1383203f473e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391900Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Elaine Chien <elainec@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804994}

Bug: 852356
Change-Id: I360bb3e3e1c91c42f4e12d724508fc2614ae9624
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398679
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804993}

R=khorimoto@chromium.org

Bug: 1045266
Test: NetworkComponentsNetworkChooseMobileTest*
Change-Id: I4111a4cb0f13daf67ea51145b8f186a2b8b7ea02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392018Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804992}

Sine ScrollEvent is a subclass of MouseEvent we also need to check it
here.  I forgot to do this in the previous CL.

Bug: 957455
Change-Id: I40f2a65d51dde010c593712105e4d4d6ee2eb1a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397175
Auto-Submit: Nic Hollingum <hollingum@google.com>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804991}

Sometimes, while the icon was not loaded yet, we would end up in the
state where the crx file is corrupt and we would hide the app from the
list, causing some confusion in users. Now, in all cases when crx
file is corrupted, we will still display the app.

Also, adding more logs for STATUS_ERROR failures.

Bug: 1035860
Change-Id: I4adf66bdc5fca2a3139c2e02577ebd278d84913f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397576Reviewed-by: Anqing Zhao <anqing@chromium.org>
Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804990}

code.google.com redirects no longer work. This CL replaces links in /build/android
to source.chromium.org equivalent.
This CL was uploaded by git cl split.

R=tiborg@chromium.org

Change-Id: I0862b5c23da99ee793239f19baf0f4fffbfefe81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392760
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804989}

https://skia.googlesource.com/skia.git/+log/2b3b35f8381b..e659214bc6cf

2020-09-08 ethannicholas@google.com Revamped handling of SkSL node kinds
2020-09-08 bsalomon@google.com Re-enable use of sampler objects on ANGLE.
2020-09-08 johnstiles@google.com Change Inliner signature in preparation for analyzer pass.
2020-09-08 bsalomon@google.com SK_API on SkYUVAPixmaps::SupportedDataTypes.
2020-09-08 cwallez@chromium.org Fix Dawn's path to spirv-cross.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC reed@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: reed@google.com
Change-Id: Id6dd97fba2b67057e5aac37381978517105ddd6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398805Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#804988}

- Use make-gtest-filter.py to build a gtest filter automatically.
- Allow testing a full directory.
- --run-all: allow testing multiple targets in one run, instead of
  asking the user to pick.
- Speed it up if a file path is specified, by skipping the file
  search.
- Cache gn refs output, to make follow-up runs faster.
- Add --line option, to run a test at specific line number.
- Change call to ninja build so that output is streamed
- Switch to printing errors end then exiting for non-exceptional errors.
  This makes user errors more readable.

Change-Id: Ib3660123f5a7fe5c3ef3369d360c3ea3218d233a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391209
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804987}

This reverts commit 0c95e24c.

Reason for revert: The alternate strings turned out not to be needed.

Original change's description:
> Land alternate strings for APP deep scanning
> 
> This CL lands new strings that may be used for Advanced Protection
> Program users to send their downloads for deep scanning: "file.exe is
> unknown. Advanced Protection recommends sending this file to Google
> for scanning." as well as changing the button from "Send" to "Scan"
> 
> Screenshot: https://screenshot.googleplex.com/Mh8PfqxvHMy.png
> Bug: 1115142
> Change-Id: Ib43a25bd68c51bf86f3a86836c1afc6e31697d2c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350383
> Reviewed-by: Varun Khaneja <vakh@chromium.org>
> Commit-Queue: Daniel Rubery <drubery@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#797044}

TBR=vakh@chromium.org,drubery@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1115142
Change-Id: I10852def75769ac24aa273ccbbe3658fddbb2764
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399001Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804986}

As resolved by the CSSWG [1], we should respect system color rules
set by the author/user in Forced Colors Mode. This CL is the second
of several changes to make this happen.

Currently, in order to force colors in Forced Colors Mode, we revert
the related properties at the author origin. This logic is now removed
from the spec [2].

To accommodate the above changes, the plan is to simulate a revert at
the end of the cascade, but only if the computed value for a given
property is not already a system color and forced-color-adjust is set
to auto.

This CL moves the logic for reverting properties that are affected
by Forced Colors Mode to the end of the cascade using the
ForceColors() method (which was added here [3]).

[1] https://github.com/w3c/csswg-drafts/issues/4178
[2] https://github.com/w3c/csswg-drafts/commit/7c154ddc7f196df9b40a34a5f63bf6d157b1011b
[3] https://chromium-review.googlesource.com/c/chromium/src/+/2376666

Bug: 970285
Change-Id: I5039fdaf5ce6d5917a258e593fb2f527581c72e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388991
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804985}

This change allows LiteVideos to be shown on Forward-Back navigations.
Video sites have an increased rate of this navigations so the signal
is noisy to blocklist on. This adds Finch control to experiment with
turning on LiteVideos for Forward-Back navigations.

Bug: 1124949
Change-Id: I1f483d948545e5414ffbcc5791d99fcb5a5e56da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393241Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804984}

Cronet is now setting default_min_sdk_version via GN arg, so these
targets do not need special-casing.

Bug: 1119402
Change-Id: I1a402e770ff4588b0fe06d5f5847258f8193fa96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367738Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804983}

Currently AXPlatformNodeTextProviderWin::GetSelection() populates
selection SAFEARRAY as nullptr if the selection is a degenerate range on
a non editable node. Hence correct selection range is not returned on
deselecting the selected character.

This CL adds the change to return a valid selection for a degenerate
range. It also adds the conditions in
AXPlatformNodeTextRangeProviderWin::Select() to prevent selections
inside of a list marker. Relevant unit tests are added to validate the
change.

AX-Relnotes: Fixed an issue with character selection for Narrator users.

Bug: 1114779
Change-Id: I882ca2c6ade013678b948548918b02417d85aee6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346095
Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#804982}

Previous to CL:2376666, pseudo element background-colors were not
getting overridden in Forced Colors Mode. CL:2376666 fixes this issue.
This CL adds a new web test to ensure that this behavior doesn't
regress in future changes.

Bug: 970285,1124362
Change-Id: Iebb16a3233bf4257d0acced9f6c00dcce4cfe983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393779
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804981}

If audio stream is not in float format we can process audio buffers by
taking the same route as an audio data processing. This can happen if
audio buffers are supplied within the same process and we are using
external buffer pool.

Bug: internal b/159173611
Test: cast_audio_backend_unittests; run GVA config on the reference device
Signed-off-by: Volodymyr Riazantsev <riazantsevv@google.com>
Change-Id: I0548fc81960313f95f1c609f9e3676da0af3774e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391284Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804980}

With all current targets setting create_srcjar=false, we can remove all
code that creates srcjars in prepare resources so that no new usages are
created.

TBR= #cced OWNERS, just a mechanical deprecation change (for the files outside of build).

Bug: 1073476
Change-Id: I102744c75f9be1ee8e78203a524a12a474f55390
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392740
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804979}

The show() invocation got lost in the shuffle of
crrev.com/6d9b12cf

Bug: 1125450
Change-Id: Ia0203fc3586b4b0b787e5f9b162b25e45fbef29e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398885Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804978}

For reuse in computing intrinsic sizes.

R=ikilpatrick@chromium.org

Bug: 1083010
Change-Id: I335a51c5fa5e4e578010b40602fc93d7b9b07ffb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380736
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804977}

We only support 21+, so we should build for it.

Bug: 1116198
Change-Id: I552a946b245de0f54485ea985e08b53b92186bb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367984Reviewed-by: Ben Mason <benmason@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804976}

This patch adds a test for JSON serialization of a very long fallbackUrl
string being passed into PaymentRequest API.

Bug: 1110324, 1115091
Change-Id: Iac3f0197038199451ebe5276e11c10e53cb62a2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346973
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Nick Burris <nburris@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804975}

This CL removes some of the AdsPageLoadMetricsObserver unit test
functions that could be replaced by calling accessors and then
functionality directly on those.

Change-Id: I483baa317258b76ecc4a438774660799c791c4ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390875Reviewed-by: John Delaney <johnidel@chromium.org>
Commit-Queue: Eric Robinson <ericrobinson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804974}

private.

The IncognitoInterstitialDelegate methods should be used in conjunction
with the IncognitoInterstitial MVC. Currently, it's possible to create
instance of the IncognitoInterstitialDelegate and invoke its methods
from outside of package scope.

This CL changes the scope of these methods to package private and moves
the IncognitoInterstitialDelegateTest to the same package.

Bug: 1103262
Change-Id: Id0a87b386e4f0c3414c744e5bd51da6f61bc9922
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398480Reviewed-by: Alice Wang <aliceywang@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Rohit Agarwal <roagarwal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804973}

GetPDFDocInfo() and GetPDFPageSizeByIndex() call PDFium APIs underneath
that use single precision, not double precision. Change their
signatures to reflect that fact.

Meanwhile, change the output of GetPDFPageSizeByIndex() from two
pointer parameters to a base::Optional<gfx::SizeF> return value.

Change-Id: I91e3645027f2345f930c6ee8ca886f84deed6897
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393013Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804972}

This is necessary for mocking calls to `onGoogleAccountsRequest` in
tests.

Change-Id: Ia7a99ce052071b8728f30710491194d8da6a8b96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396158
Auto-Submit: Tim Sergeant <tsergeant@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804971}

The PaymentHandler UI used to have a workaround to get the bottomsheet
padding for content height computation. Now that CL[1] has fixed the
bottom-sheet height computation issue, the workaround caused "overfix"
and so need to be dropped.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2372811

Bug: 1125515, 1059269
Change-Id: I9fd7701c5cd658ebb9ea87fe0825e0ce050a49a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398959Reviewed-by: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804970}

SA should handle reload (pref didn't change, but the profile changed). Similar to STS and ChromeVox.

R=anastasi@google.com, dmazzoni@chromium.org

AX-Relnotes: n/a
Fixed: 1125211
Test: manual; on-device
Change-Id: I0ab62e970d2cf948512bf49947a48bd1d7aacda9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398939Reviewed-by: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804969}

This target is used by the CQ to typecheck javascript

Bug: none
Change-Id: I7655a135ac9816dbbf7b84b9d5c0331fda5d0ef0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379441
Auto-Submit: Fergus Dall <sidereal@google.com>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804968}

Fixed: 1124785
Change-Id: I88e275c933ec12ee1d8630797f2c1dd3462bcb19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397535
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804967}