GitLab

https://skia.googlesource.com/skia.git/+log/fb3beb0591ae..f2030783094e


git log fb3beb0591ae..f2030783094e --date=short --no-merges --format='%ad %ae %s'
2018-06-19 kjlubick@google.com Revert "added GrSkSLFP and converted DitherEffect to use it"


Created with:
  gclient setdep -r src/third_party/skia@f2030783094e

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=kjlubick@chromium.org

Change-Id: If5cf0f7062d25ea9fe01633524495716273c8c13
Reviewed-on: https://chromium-review.googlesource.com/1106018Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#568442}

https://chromium.googlesource.com/catapult.git/+log/5ecb02850aa4..c5ef6d834a15


git log 5ecb02850aa4..c5ef6d834a15 --date=short --no-merges --format='%ad %ae %s'
2018-06-19 treib@chromium.org Disable flaky ActionRunnerTest.testWait on Mac


Created with:
  gclient setdep -r src/third_party/catapult@c5ef6d834a15

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:853865
TBR=sullivan@chromium.org

Change-Id: I57b9ff27d91409e0c79cf2dde0ee583fa5662693
Reviewed-on: https://chromium-review.googlesource.com/1106019Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#568441}

This CL is part of a serie of CLs to remove usage of the deprecated
method NavigationController::GetActiveEntry.

Bug: 273710
Change-Id: I6f1cc34384968ee158eea430a3a8f00d2c378546
Reviewed-on: https://chromium-review.googlesource.com/1102507Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568440}

Bug: 805015
Change-Id: Ic066f3f7d939b5175ed19b6d710f343475fba7a8
Reviewed-on: https://chromium-review.googlesource.com/1100944Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568439}

* Uses AIDL interfaces to work across class loaders
* Adds a bottom bar in CCT if the module is loaded

Bug: 843161
Change-Id: I8eaaaebf78cfb875f61deebca8df3e98a4f8c0dc
Reviewed-on: https://chromium-review.googlesource.com/1085060
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568438}

The main scrolling coordinator update, ScrollingCoordinator::
UpdateAfterPrePaint, does not affect paint and can be moved after paint.
This change will make it easier to compare the new PaintTouchActionRects
update to the current scrolling coordinator update.

This patch also moves the PaintTouchActionRects update into
ScrollingCoordinator::UpdateTouchEventTargetRectsIfNeeded so the two
codepaths can be directly compared. With this change, the
PaintTouchActionRects codepath now uses the existing dirty bits and only
runs when touch event rects might have changed.

This patch has a bugfix for the following layout test where
PaintTouchActionRects would not invalidate the touch action dirty bit:
fast/events/touch/compositor-touch-hit-rects-transform-changed-nolayout.html

This is a followup to https://crrev.com/566542 which moved the scrolling
coordinator update to after PrePaint.

Bug: 851513
Change-Id: I8ca1373832b49edd5518b43c524b6dcd57e3b36b
Reviewed-on: https://chromium-review.googlesource.com/1103777
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568437}

This CL is part of a serie of CLs to remove usage of the deprecated
method NavigationController::GetActiveEntry.

Bug: 273710
Change-Id: Ibb8542a3110e6a4842c7744a879fbeb8d577dace
Reviewed-on: https://chromium-review.googlesource.com/1102506Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568436}

Following bot results are included.
6908 6923 6925 6928 6932 6935 6936 6938 6943 6946

1 lines were removed and 1 lines were deflaked by consecutive
results since 6904.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I08741cf902301a6dafc20561c5ed391da450eedc
Reviewed-on: https://chromium-review.googlesource.com/1103431
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568435}

This CL is part of a serie of CLs to remove usage of the deprecated
method NavigationController::GetActiveEntry.

Bug: 273710
Change-Id: I2d11ff1898c785ba912e361390e414720800d5cc
Reviewed-on: https://chromium-review.googlesource.com/1102472Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568434}

Bug: 755840
Change-Id: I4f693945cb65b7be8360636307dc165a7c317f4f
Reviewed-on: https://chromium-review.googlesource.com/1104868
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568433}

Change-Id: I70184c0164e9064d9f6d86bd3892ae0100cb4178
Reviewed-on: https://chromium-review.googlesource.com/1105064Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568432}

The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I0f556f544ee09975dcee90e93abc1eda4fcb542e
Reviewed-on: https://chromium-review.googlesource.com/1106037
Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#568431}

Need for eureka-internal/178533

Bug: internal b/110284450
Test: on device
Change-Id: I17482cbfa0d3812047714e648a1562a8cfe55be8
Reviewed-on: https://chromium-review.googlesource.com/1103671Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Gaofeng Huang <gfhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568430}

TBR=timvolodine@chromium.org

Change-Id: I36020efa88606fa42a29c451f3e66164290ba8a7
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1106139
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#568429}

Change-Id: Ie0f12a43cc9321b24820e9a23fe676abf4d2f244
Reviewed-on: https://chromium-review.googlesource.com/1105382Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568428}

Bug: 853992
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Id441f479a233d0aa1cd6c2761da40819e0be2bc2
Reviewed-on: https://chromium-review.googlesource.com/1105998
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568427}

EnsureComputedStyle is used to compute style for display:none nodes in
an already up-to-date tree. These instances of EnsureComputedStyle in
tests broke when trying out changes for issue 831569.

Change-Id: I02cc6babcfe1f2193c47673a6a124385c558594a
Reviewed-on: https://chromium-review.googlesource.com/1105992Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568426}

This gives the fade in/out effect on the loading progress bar that 2D UI
now has.

BUG=853821
R=tiborg

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I3d07e2ea005c0fbaafb9042a257b3eac4979a4e9
Reviewed-on: https://chromium-review.googlesource.com/1104984
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568425}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/72566aa8..7edcaa70

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Icbe83637d4e3f122e133c842fb147bf4f07cc4a7
Reviewed-on: https://chromium-review.googlesource.com/1105716Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#568424}

Change-Id: Ib0644da4b7b06b3b7fcb7e43e8706cb071667f99
Reviewed-on: https://chromium-review.googlesource.com/1105391Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568423}

When generating the .reg template, policies that are strings are
properly escaped. And for policies that are dicts - the strings inside
those dicts are properly escaped eg:
{"quote_of_the_day": "\"I'll be back\" - Arnold"}

But then the dict as a whole is wrapped in quotes but not escaped.
Eg:
"{"quote_of_the_day": "\"I'll be back\" - Arnold"}"
Note that this string ends immediately due to improper escaping: "{"

This affects three policies (that are included in the REG file):
ManagedBookmarks, ExtensionSettings and RegisteredProtocolHandlers.

The diff in the generated REG file is available internally here:
go/chromeregdiff

Bug: 834893
Change-Id: Ied752f1f4fea4fdf3a31706080f0e3e9484060e8
Reviewed-on: https://chromium-review.googlesource.com/1104465Reviewed-by: Lutz Justen <ljusten@chromium.org>
Commit-Queue: A Olsen <olsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568422}

BUG=809444
R=blundell@chromium.org

Change-Id: Iea99e6e7809faa2f03702bab7a575c8a6c4e17b8
Reviewed-on: https://chromium-review.googlesource.com/1104421
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568421}

It looks like support was added to mojo to allow for platform specific
IPCs. Update mojom::DisplayClient so that platform specific IPCs are
only compiled on that platform.

Bug: none
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ie495671ef90225fecffe07606bbdad3a35c67f78
Reviewed-on: https://chromium-review.googlesource.com/1102558
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568420}

Now the Quick View browser test suite has been optimized for speed, we
can finish off by documenting the Quick View test JS. Two test helpers
only lack documentation: document what they do.

Comment only change: no change in behavior, no new tests.

Bug: 851888
Change-Id: If87c49919cdd3bd51fa35f714130fc74fb84b543
Reviewed-on: https://chromium-review.googlesource.com/1105530Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568419}

USS requires atomic writes of sync metadata and native model data
to guarantee consistency between both.

This patch adds the required functionality to persist the bookmarks
sync metadata together with the bookmark model.

Two methods are added to the bookmark client that allows
encoding/decoding metadata. Bookmark model invokes those methods when
writing/reading the stored data respectively.

A new keyed service is introduced that owns the
BookmarkModelTypeProcessor such that there is a run-time dependency
from the bookmark model on the new service.

This ensures that the metadata stored in the processor outlives
bookmark model and hence would be available whenever the bookmark
model needs to be persisted.

Bug: 516866
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0e24ebf712d3b83130b0338ed72ffb833a78830f
Reviewed-on: https://chromium-review.googlesource.com/1094876
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568418}

This reverts commit 0d53513f.

Reason for revert: Flaky tests, see bug

Bug: 854143

Original change's description:
> Headless: don't run unload hooks upon web contents close.
> 
> Change-Id: I6e391fadbbf47aa6427a16495bdca3c88d456b05
> Reviewed-on: https://chromium-review.googlesource.com/1105041
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568213}

TBR=dgozman@chromium.org,pfeldman@chromium.org,eseckler@chromium.org

Change-Id: I252909f78e6d33b98819f6510f780997327a6901
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1106077Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568417}

Leave portless devices alone.

Bug: 853693, b/79580580
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I0e505b0f87fdb2b416ca080ad104ea6710e2ec6a
Reviewed-on: https://chromium-review.googlesource.com/1104433Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Oskar Sundbom <ossu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568416}

It's already in a block with if (pseudo_id == kPseudoIdFirstLetter).

Just a nit I noticed while seeing the patch for issue 853551.

Bug: 853551
Change-Id: Ib4fadc46497c2ed4142f88f9d57938273acf622d
Reviewed-on: https://chromium-review.googlesource.com/1105831Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Emilio Cobos Álvarez <emilio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568415}

Using wpt-import in Chromium b8d38118.
With Chromium commits locally applied on WPT:
03ef65db "Update existing WebUSB WPT to be multi-global"
89102421 "Reland "Multi-global WebUSB WPT for window and worker""
08784a11 "[Mojo Blob URLs] Make clicking an <a target="blank_"> with a blob URL work correctly."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19925

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
bugsnash@chromium.org, ericwilligers@chromium.org, meade@chromium.org, nainar@chromium.org, rjwright@chromium.org, shend@chromium.org:
  external/wpt/css/css-conditional
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

TBR=robertma

No-Export: true
Change-Id: Icae359d0cf4f6c466463821019e4b41647aff942
Reviewed-on: https://chromium-review.googlesource.com/1105837
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568414}

Commit b47442dc ("viz: Determine fallback strategy in SurfaceAggregator")
simplified the code in SurfaceLayerImpl::CreateSurfaceDrawQuad(), but ended
up with a construct like this:

    viz::SharedQuadState* foo = foo = bar();

Simplify the assignment and make it more readable.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I88560e1acd1766d4f1676c2aa90b18be32971a60
Reviewed-on: https://chromium-review.googlesource.com/1105829
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568413}

https://chromium.googlesource.com/catapult.git/+log/f13bae2df0b8..5ecb02850aa4


git log f13bae2df0b8..5ecb02850aa4 --date=short --no-merges --format='%ad %ae %s'
2018-06-19 treib@chromium.org Disable flaky ActionRunnerTest.testWaitForElement on Mac


Created with:
  gclient setdep -r src/third_party/catapult@5ecb02850aa4

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:852931
TBR=sullivan@chromium.org

Change-Id: I02d4be752592d1569f0d182fae6dd200df309b71
Reviewed-on: https://chromium-review.googlesource.com/1105102Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#568412}

Differences between ComputedStyle for background-image and
-webkit-mask-image properties may be due to the StyleImages having
different CSSValue instances rather than being different by semantic
value.
This CL disables the base ComputedStyle equivalency check if
either of these properties detect a difference as they can produce
false positive assertions.

As part of this the FontFaceCache bypass of the base ComputedStyle
optimisation was reworked into a bypass of the ComputedStyle
check instead for consistency and to allow the optimisation to
proceed where it is technically valid to do so.


Bug: 781461
Change-Id: I4c28c500819fb75da27130c147f2fbfde2ac93da
Reviewed-on: https://chromium-review.googlesource.com/1080366Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568411}

TransportListView displays a list of transports over which the user can
access security keys.

Bug: 849323
Change-Id: Id445b7fea711f8b3e482588cc3d6213e3221d3be
Reviewed-on: https://chromium-review.googlesource.com/1097775
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568410}

The header should be set for all requests originating from
nostate-prefetch, main resource, all redirects and all subresources.

Using base::BindRepeating in new tests because of presubmit
warning, also switched similar tests to it for consistency.

Bug: 796855
Change-Id: I90614fac595f2dbc087a6ac99f54e2fc7d37f89a
Reviewed-on: https://chromium-review.googlesource.com/1104692
Commit-Queue: Egor Pasko <pasko@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568409}

The only changes in this reland are to add additional Slow expectations, since
two of the layout tests are very slow on MSAN bots. See crbug.com/853977.

Originally reviewed at
https://chromium-review.googlesource.com/c/chromium/src/+/1097047.

Original description:

CallExtraOrCrash is a function to call into V8 Extras and crash if it
fails. Unfortunately, calling into V8 Extras can fail under normal
conditions such as stack overflow and Worker destruction, causing a lot
of unnecessary crashes. Remove CallExtraOrCrash.

This is a stopgap change designed to be mergable to version 68. It
avoids major code restructuring but as a result lacks robust
encapsulation.

The general strategy is to pass a boolean pointer to functions in
ReadableStreamOperations that call into V8 Extras. If the internal call
fails, the boolean is set to true, and the call returns a default value.

BodyStreamBuffer keeps the boolean as member variable. Once a call to a
V8 extra function fails, the boolean is set and no more calls will be
made. This is to avoid us taking action based on information that is
incorrect.

For Tee() and the from-stream version of the BodyStreamBuffer
constructor, we use an ExceptionState object instead. In these cases, it
is straightforward to pass through ExceptionState object from the Blink
bindings. This allows the failure to be propagated safely back to
Javascript.

Conversely, DefaultReaderRead() has been switched from using
ExceptionState to using an error-signalling bool. This is because its
callers do not have access to a real ExceptionState object. Previously
callers used a NonThrowableExceptionState, but this was not suitable as
DefaultReaderRead() can throw.

BodyStreamBuffer mostly wraps access to ReadableStreamOperations, so
some degree of encapsulation has been retained.

7 new layout tests exercise each of the deterministically reachable
crashes, using stack overflows. Because they depend on stack layout and
whether DCHECKs are enabled, they only hit the crashes in particular
environments.

TBR=yhirano@chromium.org,yukishiino@chromium.org

Bug: 829790, 849312, 853977
Change-Id: I308ee14ba063f25742eae3cb4c889c3bd50b38d3
Reviewed-on: https://chromium-review.googlesource.com/1105678Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568408}

removes assertions that (unneccesarily) assume getUserMedia returns something else than what was requested

BUG=836871

Change-Id: If8f52f259ea924bdc9ac68a854c34188f3f56cda
Reviewed-on: https://chromium-review.googlesource.com/1105528Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568407}

This reverts commit 18a428ba.

Reason for revert: We realized that EventQueueImpl (after merged with MediaElementEventQueue) : target is not 1:1. Instead of EventQueueImpl with a target, each event should have its target.

Original change's description:
> Add EventQueueImpl::target_
> 
> This CL is a continuation of
> https://chromium-review.googlesource.com/c/chromium/src/+/1088356.
> 
> This CL gives an event target to EventQueueImpl and use it instead of
> event->target() so that we can have EventQueueImpl and
> MediaElementEventQueue with the same structure.
> 
> Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit#
> 
> Bug: 846618
> Change-Id: I394e3b1c01df3a2af671bb6d72fe9d32ac9ea94e
> Reviewed-on: https://chromium-review.googlesource.com/1098736
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567220}

TBR=hajimehoshi@chromium.org,haraken@chromium.org,altimin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 846618
Change-Id: Ic2f63364ec2d76d3aef51432d9e4c1258034c867
Reviewed-on: https://chromium-review.googlesource.com/1105653Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568406}

The recently-added virtual/user-activation-v2/ needs the same expectations
as other suites. While we're here, also update the bug numbers.

TBR=mustaq@chromium.org
NOTRY=true

Bug: 828506
Change-Id: Ic1e7b0e394f1eb93fc265bc17b53eed40aa1b605
Reviewed-on: https://chromium-review.googlesource.com/1105980Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568405}

https://webrtc.googlesource.com/src.git/+log/024eeff4215d..790da37b72f9


git log 024eeff4215d..790da37b72f9 --date=short --no-merges --format='%ad %ae %s'
2018-06-19 saza@webrtc.org Fuzz AEC field trial killswitches
2018-06-19 saza@webrtc.org Remove non-API beamformer references


Created with:
  gclient setdep -r src/third_party/webrtc@790da37b72f9

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I6481f93beab31e8ef1e437ac25f7dc7114df6662
Reviewed-on: https://chromium-review.googlesource.com/1105103
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#568404}

We realized that MediaElementEventQueue : target is not 1 : 1. Then,
Having MediaElementEventQueue own a target doesn't make sense. This CL
enforces to set a target of an event before enqueuing and use it when
dispatching.

Bug: 846618
Change-Id: Iacc19e6c55040fe05e4883fa33f570b3424650e0
Reviewed-on: https://chromium-review.googlesource.com/1105803Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568403}