- 28 May, 2019 40 commits
-
-
Morten Stenshorne authored
The constraint space has several resolution sizes, depending on what we're to resolve. There's "available size", "percentage resolution size" (and "replaced percentage resolution size"), and even "percentage resolution inline-size for parent writing mode". The latter is used when resolving percentage based margins and padding. This works when staying within LayoutNG, but when we need to enter legacy layout for some child, we convert all those values into something that legacy layout understands, and dumb down the number of values to basically 3 (plus two optional values); see BoxLayoutExtraInput. Avoid setting an indefinite containing block inline-size, since we use this value to resolve percentage padding and margins. The test included only *crashed* without this fix (it rendered correctly if DCHECKs were bypassed), but I figured it would be useful to have a test for correct rendering in this case as well. Bug: 966795 Change-Id: Ia2a2ede55a257b41dc38236a8bb0ff689e75a310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631370 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#663800}
-
Emily Stark authored
For converting HTTP auth to committed interstitials, we'll need to be able to access the AuthChallengeInfo in the navigation stack, to pass from there into the interstitial itself. The interstitial needs this information to insert credentials into the auth cache when the user enters them. In contrast, today the auth challenge info is stored with the request itself, and the request hangs around waiting for the user to enter credentials which are then put into the cache. With committed interstitials, the request completes while the auth prompt is shown, so the interstitial code will keep track of the AuthChallengeInfo for inserting into the cache, instead of the request itself. This CL plumbs the AuthChallengeInfo from HttpResponseInfo out of URLRequest to ResourceResponse. Subsequent CLs will plumb it through the navigation code into the committed interstitial code. (Specifically: NavigationHandle will have an auth_challenge_info() getter similar to its ssl_info() getter, and a NavigationThrottle will create a LoginHandler to show the login prompt and hang on to the AuthChallengeInfo from the NavigationHandle.) Bug: 963310 Change-Id: I2c79e50b29c9a598efa074d4554424408286886c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625831 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#663799}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I4cfaba445e9492b99fb1fb2cbcb4d0980447c109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630814Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#663798}
-
Yi Su authored
This CL moves RequiresContentFilterBlockingWorkaround function into wk_web_view_util so that it can be shared by CRWWKNavigationHandler and CRWWebController. Bug: 956511 Change-Id: I011413d885233d02daaf6ce7c0ea3c9ff197afe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631416Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#663797}
-
Georges Winkenbach authored
1. Search + Fn + F3 should trigger zoom window. 2. With keyboard setting treat-top-row-keys-as-function-keys, Search + <function key> should trigger corresponding action. Updated event-rewriter unit tests. Bug: 966894 Test: Build and deploy chrome on device, manually check top-row keys. Change-Id: Ied7b2267cf0fbdfbf46484585a32b488a4406a8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626490 Commit-Queue: Georges Winkenbach <gwink@chromium.org> Reviewed-by:James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#663796}
-
Jarryd authored
This change alters how per host quota is calculated. Specifically, there is a case where users have low disk space availability where the quota is based off available disk space. This change ignores that branch of logic for users that have the StaticHostQuota Finch study enabled. The study is disabled by default, but will be enabled for 100% of users, starting with Dev/Canary and moving up the channels to Stable. Keeping this behind a Finch study allows us to disable this change with a single line change to Finch. Bug: 965710 Change-Id: Icd5ed59c1c592ccd9554395427f6707210376271 Signed-off-by:
Jarryd Goodman <jarrydg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625744Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#663795}
-
kylechar authored
Merge CompositorOverlayCandidateValidator class into OverlayCandidateValidator. The inheritance hierarchy was a relic of historical code structure and not really necessary anymore. Also rename CompositorOverlayCandidateValidator<Platform> classes to shorten names. Bug: 963597 Change-Id: I0f242f069e3bfc540f57b0add3b2be9a00f495bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629290Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#663794}
-
Caleb Raitto authored
This library is supposed to be excluded from LSAN, but somehow we're still seeing leaks from this library [1]. Fix this by excluding the path to the library in third_party. Leave the existing entry in case it's somehow catching other libfontconfig leaks. [1] https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8914727183139935872/+/steps/browser_tests__with_patch_/0/logs/Deterministic_failure:_PDFExtensionInternalLinkClickTest.CtrlLeft__status_CRASH_/0 Bug:961017 Change-Id: I8869755987ff595e9df634dc3d997f0eb136cf66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614437 Commit-Queue: Alexander Potapenko <glider@chromium.org> Reviewed-by:
Alexander Potapenko <glider@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#663793}
-
Sylvain Defresne authored
Uses of base::Callback<...> is deprecated in favor of either base::OnceCallback<...> or base::RepeatingCallback<...> (the former is preferred if possible). This is part 2 of a multi-CL refactoring and does: - use PostTaskAndReplyWithResult in HistoryService::QueryURL thus removing a naked "new" and the use of base::Unretained and base::Owned to pass the value to both callbacks - change QueryURLCallback to be invoked with a QueryURLResult instead of three values thus allowing to remove an helper function - change HistoryBackend::QueryURL to return the result by value instead of via an out parameter - add move and copy assignment operator to QueryURLResult Bug: 812523, 714018 Change-Id: I7907802824c7c51b6d1457b522e519bae6a9ad2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631377 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#663792}
-
Tatiana Buldina authored
Bug: chromedriver:1231 Change-Id: I4be96e0105cc6e854a7ef01ad9d0dc4dd965ec6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627552Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#663791}
-
Mohamed Amir Yosef authored
Bug: 967713 Change-Id: I0fb0800c6d4fc3b114556f0ec70450a46eb18157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632230 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#663790}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/51e9e5659a55..7e01e4e0d6b7 git log 51e9e5659a55..7e01e4e0d6b7 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 capn@google.com Support images with linear tiling for transfers Created with: gclient setdep -r src/third_party/swiftshader@7e01e4e0d6b7 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/119620767,chromium:b/132437008 TBR=swiftshader-team+autoroll@google.com Change-Id: Ia42166a4e193c1f3bf87d37e7713c3fe111a54c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631133Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663789}
-
Carlos Caballero authored
BEST_EFFORT tasks will not run until after startup and only if there is no critical work pending. This patch should not change the current behaviour. Please double check whether the task being posted via BrowserThread::PostAfterStartupTask really cares about being run after startup or just wants to run after any critical work was completed. If you are fine with it just running after critical work has completed LGTM and keep on with your life. If that is not the case let me know and please explain your reasoning in a comment. More details: https://docs.google.com/document/d/1P8PV1qX2cOR2WRFD6v9CjygJkE_mftCtJ7BoqQHCKZI This CL was uploaded by git cl split. R=georgesak@chromium.org Bug: 887407 Change-Id: I12017f988c1ec4c04ce0ce3a52725bc6b9b62240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632258 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Georges Khalil <georgesak@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#663788}
-
Sylvain Defresne authored
Uses of base::Callback<...> is deprecated in favor of either base::OnceCallback<...> or base::RepeatingCallback<...> (the former is preferred if possible). This is part 1 of a multi-CL refactoring and does: - convert GetCountsAndLastVisitForOriginsCallback to be a base::OnceCallback<...> - pass the callback parameter by value instead of as a const reference Bug: 812523, 714018 Change-Id: I932b424b026611c8b1adfdb3fb244d0afd0ec1cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630484 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: -
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/15902f4c7d5d..33d3be2b8bdb Created with: gclient setdep -r src-internal@33d3be2b8bdb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: Id6d8fb4affdfd3c74843c7c38bbe254925fe3442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631737Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663786}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6c7db9c63098..78b2b18661fc git log 6c7db9c63098..78b2b18661fc --date=short --no-merges --format='%ad %ae %s' 2019-05-28 zoddicus@users.noreply.github.com Add fuzzer for WebGPU->Vulkan spirv-opt passes (#2625) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@78b2b18661fc The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: Ibc9ae5ccb6efb16d8f39fdb466ba6b5d1fcc0bd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631358Reviewed-by:
-
John Abd-El-Malek authored
These tests reach into the net::URLRequestContext from StoragePartition, which isn't possible when network service feature flag is enabled. Bug: 967698 Change-Id: Ie0bd2ae1b8ba96c3ff7227df62702aab4546fc43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631892 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#663784}
-
Ioana Pandele authored
The origin passed into PasswordAccessoryController::RefreshSuggestionsForField is never used. This CL removes it. TBR=tmartino@chromium.org (for trivial mock change) Bug:none Change-Id: Ibe6d487143137220bf4692ea3c919a2a39d86e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632149 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#663783}
-
Carlos Caballero authored
BEST_EFFORT tasks will not run until after startup and only if there is no critical work pending. This patch should not change the current behaviour. Please double check whether the task being posted via BrowserThread::PostAfterStartupTask really cares about being run after startup or just wants to run after any critical work was completed. If you are fine with it just running after critical work has completed LGTM and keep on with your life. If that is not the case let me know and please explain your reasoning in a comment. More details: https://docs.google.com/document/d/1P8PV1qX2cOR2WRFD6v9CjygJkE_mftCtJ7BoqQHCKZI This CL was uploaded by git cl split. R=finnur@chromium.org Bug: 887407 Change-Id: I539b49ee3a87ffa73c43add69c4a6006de490918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632161 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#663782}
-
danakj authored
See discussion thread: https://groups.google.com/a/chromium.org/d/topic/blink-dev/338WKwWPbPI/discussion Removes OS_ANDROID support for running web tests since we are no longer running them on Android bots. Depends on https://chromium-review.googlesource.com/c/chromium/src/+/1629049 which disabled the test suite on bots. R=avi@chromium.org, dpranke@chromium.org Bug: 567947 Change-Id: Ia0420056e3a7982b24c29f94945fb1034523d7af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628956Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#663781}
-
Avery Musbach authored
This reverts commit 40165b9a. Reason for revert: This CL is suspected of causing Issue 967196, according to Comment 2 on that issue: https://bugs.chromium.org/p/chromium/issues/detail?id=967196#c2 Original change's description: > overview: Show drop target even if split view is disabled > > The purpose of the present CL is to add a drop target in a certain > workflow. As of [1], the "drag to snap" mode has become a "normal drag" > mode which is available even when split view mode is not available. For > testing, you can note that in clamshell mode, with the functionality of > [2] disabled (the current default), split view mode is not available, > but you can still do a "normal drag" from overview. There is presently > no drop target in that workflow. There is no drop target depicted in [3] > either, but I am pretty sure a drop target is actually appropriate, > because of [4] (which is assigned to me) if for no other reason. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/1612121 > [2] https://crbug.com/890029 > [3] https://bugs.chromium.org/p/chromium/issues/detail?id=866622#c33 > [4] https://crbug.com/961170 > > Test: manual > Bug: 866622, 961170 > Change-Id: I079d01c3e449b10f23a19a9993fbdd44d0c1482e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627562 > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: Sammie Quon <sammiequon@chromium.org> > Commit-Queue: Avery Musbach <amusbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#663305} TBR=afakhry@chromium.org,sammiequon@chromium.org,amusbach@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 866622, 961170 Change-Id: Ie2317389231366bdbc86667140cbd87c5d7259eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632550Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#663780}
-
John Abd-El-Malek authored
Bug: 966633 Change-Id: I840509fcf2e0cf27ed1bdf8a384023a95d424b6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629690 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#663779}
-
Ilia Samsonov authored
This CL removes unused code, and does not change the TestLauncher behavior. This code was introduced here https://codereview.chromium.org/1806353003 to allow launching unit tests in Mash. The Mash tests launcher no longer exist, and no other implementation of PreRunTest exist. Bug: 936248 Change-Id: Ie7e968d52904b249d57f23dc7c404d477265ed47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626023 Commit-Queue: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#663778}
-
Tommy C. Li authored
BLOCK is now the default setting for Flash. Update the strings in Content Settings Page to make BLOCK "(recommended)" instead of ASK. Bug: 967046 Change-Id: I515e70e2ba2bbd9a716b46af1567522ebab3a2b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628422Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#663777}
-
Cliff Smolinsky authored
Address sanitizer runs were flaky for the chrome and chrome_child dll load sanity tests. While it's not 100% clearly exactly what is causing the issues because they can't be repro'd, it does appear that the failures relate to unloading the dlls (with FreeLibrary). These dlls have never been intended to be freed like this, however. During normal execution they are never unloaded but instead just go away when the process is terminated. This change updates the tests to match that behavior and simply let the process exit. Bug: 964861 Change-Id: I46384f42b87e99d9615fa754097d0d589bd4a62d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627755Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
-
danakj authored
Use OnceCallback where possible, and BindRepeating where it is meant to be called more than once. R=guidou@chromium.org, liberato@chromium.org Bug: 953861, 751838 Change-Id: Iadb80d5367adc68d9fcc7e98e992a1b65ff7a890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629070Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#663775}
-
Benoît Lizé authored
This is required to pin ordered code in memory on platforms that support it. This forwards the file and locations within it of the ordered code to Java, from native, as this is not discoverable purely from Java. This is controlled by a feature which is disabled by default, and the logging code will be replaced by the actual pinning one on supported platforms. Bug: 929926 Change-Id: I8c79c0609dd2709e3e4eefc5d8c971d84df6f4dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631659 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#663774}
-
Peng Huang authored
VkSubmitInfo::pWaitDstStageMask must be must be a valid pointer to an array of waitSemaphoreCount valid combinations of VkPipelineStageFlagBits values. Bug: None Change-Id: I23fe8210f724cbb11c48e6dcab7e6452fe0cab3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630540Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#663773}
-
Fergus Simpson authored
Remove aura::Env from WMHelperCastShell: Upstream has removed aura::Env from the WMHelper interface, this CL removes it from the CastShell specialization as well. NoGnCheck views_delegate: The header include and dep in the BUILD.gn file are both guarded correctly, but gncheck still thinks the include is illegal. Don't gncheck the include. Bug: b/133174544 Test: Chromecast build Change-Id: Id5de601311c8285416172cb1e97b74957f341fd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628999Reviewed-by:
Sergey Volk <servolk@chromium.org> Auto-Submit: Fergus Simpson <afergs@chromium.org> Commit-Queue: Fergus Simpson <afergs@chromium.org> Cr-Commit-Position: refs/heads/master@{#663772}
-
Joanmarie Diggs authored
* Emit ATK focus and object:state-changed:focused events in response to ax::mojom::Event::kActiveDescendantChanged * Add ATK_STATE_FOCUSED to the state set of the active descendant * Update tests to reflect new events and states Bug: 959857 Change-Id: Idb97671e1c4f65aa293e1e4e7dbd5a9ecf47fb2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631404Reviewed-by:
Martin Robinson <mrobinson@igalia.com> Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Auto-Submit: Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/master@{#663771}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I49ef7868dfc7aedf4ad44ecf26dd9ef5884fdb91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632552Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#663770}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6925d000325a..5ca8b4622a59 git log 6925d000325a..5ca8b4622a59 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 eseckler@google.com Merge "public: Only build on platforms with IPC support for now" 2019-05-28 ilkos@google.com Merge "Allow final metrics result to be empty" 2019-05-28 lalitm@google.com Merge "metrics: fix crash when metric name not found" 2019-05-28 lalitm@google.com Merge "metrics: add tests for protobuilder functions" 2019-05-28 lalitm@google.com Merge "trace_processor: add support for text proto out and interactive metrics" 2019-05-28 treehugger-gerrit@google.com Merge "Fix chrome build" 2019-05-28 lalitm@google.com Merge "trace_processor: add support for proto and sql metric from shell" 2019-05-28 lalitm@google.com bazel: remove support for generate descriptors 2019-05-28 lalitm@google.com Merge "metrics: add support for extension fields in descriptors" 2019-05-28 lalitm@google.com Merge "metrics: add support for non-message repeated fields" 2019-05-28 khokhlov@google.com Merge changes Ie6400c7f,Ia8ac1a7f 2019-05-28 lalitm@google.com Merge "traceconv: bump shas" 2019-05-28 lalitm@google.com Merge "protos: add descriptor set build import" 2019-05-28 hjd@google.com Merge "Add zlib to buildtools" 2019-05-28 lalitm@google.com perfetto: ensure that ftrace descriptor is only built in standalone 2019-05-24 lalitm@google.com trace_processor: expose metric registration and proto extension fns 2019-05-24 lalitm@google.com metrics: introduce properly namespace metric file paths 2019-05-24 lalitm@google.com trace_processor: metrics: register built-in metrics upfront 2019-05-23 primiano@google.com Merge "Perfetto Client API (4): Add initial integration test" 2019-05-23 treehugger-gerrit@google.com Merge "TracingMutexImpl: Fix DestroyTracingSession()" 2019-05-23 treehugger-gerrit@google.com Merge "Add gen_amalgamated to gen_all" 2019-05-23 ilkos@google.com Merge "Simplify error and data loss stats" 2019-05-23 treehugger-gerrit@google.com Merge "Trace processor: add trace_metadata table" 2019-05-23 lalitm@google.com metrics: add proper support for repeated fields 2019-05-23 lalitm@google.com trace_processor: improve helper proto design 2019-05-23 ilkos@google.com Add statistics as a proto 2019-05-23 lalitm@google.com metrics: refactor metrics code into proper builder class 2019-05-23 ilkos@google.com Merge "Add count of spawned processes and other minor improvements" 2019-05-23 lalitm@google.com Merge "loadtool: fix loadtool sleeping longer than intended" 2019-05-23 primiano@google.com Merge "Remove gen_amalgamated from gen_all" 2019-05-23 eseckler@google.com service: Let producers choose whether to enable SMB scraping 2019-05-22 lalitm@google.com Merge "perfetto: refine proto descriptor support" 2019-05-22 lalitm@google.com Merge "metrics: add typechecking to metric result protos" 2019-05-22 treehugger-gerrit@google.com Merge "Extract common code from our various build generators into a library" 2019-05-22 lalitm@google.com Merge "trace_processor: fix overflow of window size" 2019-05-22 skyostil@google.com Unify include statements for protobuf 2019-05-22 ilkos@google.com Merge "Filter out failed launches" 2019-05-22 primiano@google.com Fix autoroller, remove extra ../ in GN file 2019-05-22 skyostil@google.com Merge "Add retired instruction count field for legacy events" 2019-05-22 lalitm@google.com Merge "traceconv: add comment about catapult" 2019-05-22 lalitm@google.com trace_processor: fix debug dcheck 2019-05-22 lalitm@google.com Merge "trace_processor: fix typo" 2019-05-21 primiano@google.com Perfetto Client API (3): Tracing muxer implementation 2019-05-21 primiano@google.com Perfetto Client API (2): public interfaces and backend implementation 2019-05-21 primiano@google.com Perfetto Client API (1): initial refactorings Created with: gclient setdep -r src/third_party/perfetto@5ca8b4622a59 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:129747127,chromium:129747127,chromium:129747127,chromium:129747127,chromium:129747127,chromium:b/133324726,chromium:133268735,chromium:132678367,chromium:132678367,chromium:132678367 TBR=perfetto-bugs@google.com Change-Id: I411cb3737e9f4b32f7f933ca9bbb05a4c29bc5f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631735Reviewed-by:
-
John Abd-El-Malek authored
Disable some unit tests in NavigationURLLoaderTest and ResourceDispatcherHostTest and fix one test in the former when network service is enabled. Fix NavigationURLLoaderTest.RequestFailedCertErrorFatal to work with network service. The other tests that are disabled in NavigationURLLoaderTest depend on net:: test objects that are an implementation detail of the old path, to ensure that the request is cancelled correctly when the navigation or context goes away. It's not clear how much value these tests actually provide, and this is a bit hard to test in a unit test with network service, so I'm disabling them for now. ResourceDispatcherHostTest.ForbiddenDownload is disabled because it's a regression test for a ResourceDispatcherHost bug. Bug: 966633 Change-Id: If979805546875ca616a1c54ff559d9f40498038a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631768 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
Martijn Croonen authored
This updates from revision 0e2a405f597a3c1be456d704b42bdd5e0d4954bb (2019-02-21) to revision c3a44bfc61dcf0feb1cc0e37a95fb281799d43c6 (2019-05-24) Bug: 951494 Change-Id: Iaa722617a8c48a4b22daa1d872508871608debc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615741 Auto-Submit: Martijn Croonen <martijnc@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
The accessibility of the TableView isn't great. This CL improves it by increase the contrast of the sublabels. It also use a shared constant for the font of the sub labels in case we need to modify it in the future. Bug: 960264 Change-Id: I962f66082c459ccf9999848e510670d9e12dca11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627364Reviewed-by:
Huanzhong Huang <huanzhong@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#663766}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1b6aded661de..46fe0e4be950 git log 1b6aded661de..46fe0e4be950 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 jonahr@google.com Cleanup Features headers. 2019-05-28 aleino@nvidia.com Use D3D11 GetDimensions driver workaround for 2D array textures Created with: gclient setdep -r src/third_party/angle@46fe0e4be950 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Change-Id: Ie2e264678d91f7f859c1bffb9d4c5f2225892523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631575Reviewed-by:
-
Avi Drissman authored
This allows it to show dialogs and work as required. BUG=948882 TEST=as in bug Change-Id: Ifc339187093e571f8f6062cfa4a9d3130a357e02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631873 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#663764}
-
Ivan Sandrk authored
There's a P0 escape from the locked mode currently in M75 which is just days away from stable. This is a very quick and simple fix that addresses the problem for now and it will be backmerged immediately to M75. Bug: 957950 Change-Id: I2c39c04d4bc0219c000977928b538c60619a6bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632251 Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#663763}
-
Devlin Cronin authored
Opaque origins (such as about:blank and data: URLs) inherit the security and privileges of their creator origins, which are tracked in precursor tuples. ScriptContext::GetEffectiveDocumentURL() attempts to determine the precursor origin of an opaque URL today by traversing the creation chain and looking for the first non-about:blank opener or parent. However, this is not always strictly correct for all opaque origins; for instance, the precursor tuple of a data: frame may not be that of its immediate parent in the case of nested iframes. Update ScriptContext::GetEffectiveDocumentURL() to use Origin::GetTupleOrPrecursorTupleIfOpaque(), which correctly tracks this. Note that we still have to do the opener/parent traversal case because content script matching needs to have the full URL (including path), and not just the scheme, host, and port tuple. To balance these, we simply return the document URL (which is potentially opaque) in the case of a mismatch between opener/parent traversal and the precursor tuple. This should be an exceptionally rare case in practice. Updating this method to use the precursor tuple is a prerequisite for adding support for data:-URL content script injection. ----- Reland Notes ----- The original patch didn't account for a parent being null in the iteration of the frame tree, which could cause issues in edge cases (that are not terribly uncommon). The reland adds a graceful return in those cases, and adds a regression test. Bug: 55084 Change-Id: Ib46d67dddc3fe0b769e30abe383534e5c490c912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621196 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#663762}
-
Saman Sami authored
This CL enables all viz_unittests that pass with Vulkan. Bug: 961373 Change-Id: Ie0d0c590d58a930bf5e005dc233240203d76e773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625015 Commit-Queue: Saman Sami <samans@chromium.org> Auto-Submit: Saman Sami <samans@chromium.org> Reviewed-by:
-
