Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 16 Nov, 2020 1 commit
    • Johann Koenig's avatar
      Revert "Invalidate SelectionShouldFollowFocus elements during container focus" · 521b10cc
      Johann Koenig authored 
      This reverts commit c7a07b61.

Reason for revert: May be causing Win7 errors. Speculatively reverting based on change log:
https://chromium.googlesource.com/chromium/src/+log/88b177aef..742f164dd0
https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/110238

content_browsertests failed because of:
All/DumpAccessibilityEventsTest.AccessibilityEventsAriaComboBoxFocus/uia
All/DumpAccessibilityTreeTest.AccessibilityAriaTreeDiscontinuous/uia

Original change's description:
> Invalidate SelectionShouldFollowFocus elements during  container focus
>
> Items in single selection containers that have accessibility focus
> should get the selected state. Code to mirror focus to selection
> exists, but the selected state must be refreshed.
>
> Replacing AXLayoutObject::SelectionShouldFollowFocus with a helper
> method in ax_role_properties, ui::IsSelectRequiredOrImplicit and
> including Role::kTreeItem [1] since the ARIA spec lists aria-selected
> as a required state.
>
> Adding AXObject::IsSelectedFromFocusSupported (see AXLayoutObject impl)
> which provides a mostly conclusive answer for whether an element can
> support this behavior.
>
> During this investigation, I found there was a portion of the spec that
> was not implemented, so I created a crbug [2] for that. "If any DOM
> element in the widget is explicitly marked as selected, the user
> agent MUST NOT convey implicit selection for the widget."
>
> Also created a crbug [3] for followup to consider including more
> selectable roles for this behavior. Currently only roles that require
> or have an implicit value for aria-selected allow this behavior.
> It may be desirable to include roles columnheader, rowheader, gridcell
> and row, but felt that would be out of scope for this CL.
>
> [1]: https://www.w3.org/TR/wai-aria-1.1/#treeitem
> [2]: https://crbug.com/1143451  (Not allowed with explicit selection)
> [3]: https://crbug.com/1143483  (Consider allowing more roles)
>
> AX-Relnotes:Notify the aria-selected state changed for items that
> have their selected state follow focus, and enable this behavior for
> role=treeitem elements inside single-selection containers.
>
> Bug: 1141579
> Change-Id: Idce80a91f41df859775eed59a922ac7c923d9f4f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493000
> Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
> Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#827487}

TBR=dmazzoni@chromium.org,haraken@chromium.org,aleventhal@chromium.org,kschmi@microsoft.com,Adam.Ettenberger@microsoft.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1141579
Change-Id: Ibd959d5d6066bbe93aea4dffa3d4bc7cc6b35dd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537820Reviewed-by: default avatarJohann Koenig <johannkoenig@google.com>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#827653}
      521b10cc
  3. 15 Nov, 2020 39 commits