- 31 Oct, 2019 40 commits
-
-
Alice Boxhall authored
TBR=dtapuska@chromium.org Bug: 1020036 Change-Id: I5add7fa7b57e7ace63e84599ca3b120a71a933a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890463Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#711147}
-
Tsuyoshi Horo authored
This class will be used to read partial body data of a web bundle response from server. Bug: 1018640 Change-Id: Ib945b9152527be2dfd2fc43dc1e6ef8fcc09b12f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886271Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#711146}
-
Gauthier Ambard authored
This CL create the EG2 target for Showcase and also convert the Content Suggestions TestCase. Change-Id: Iee84c298746b1a8da8d455b5214ea61eb5e0ea6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873750 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#711145}
-
Alice Boxhall authored
TBR=sky@chromium.org Bug: 928924 Change-Id: I71b6615a8855bbb76b0807ecd5abb6153441b9a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892233Reviewed-by:
-
Alexey Baskakov authored
We generate an icon placeholder using a letter with some solid background color. Let the test check if letter_color is actually presented in the icon. This is a follow up test enhancement for the previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/1888234 Bug: 1019102 Change-Id: I10e196926dff78032dcd8f00e93e24715d1be913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891816 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#711143}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/672707f76e2d..64a3bb93dcea git log 672707f76e2d..64a3bb93dcea --date=short --no-merges --format='%ad %ae %s' 2019-10-31 enga@chromium.org Add DrawCallPerf tests Created with: gclient setdep -r src/third_party/dawn@64a3bb93dcea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I583c7b103c871bd9be5f2a82cbacdc3e5f6d8ce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892063Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711142}
-
Eric Willigers authored
If the web app manifest specifies 'standalone' or 'fullscreen', we do not show minimal-ui Back and Reload buttons. We only show the buttons when a web app is being opened in a standalone window, and the manifest requested 'browser' or 'minimal-ui', or failed to specify a display mode. https://w3c.github.io/manifest/#display-modes Not yet implemented: support for the extensions-based implementation of bookmark apps - crbug.com/1014346 Bug: 1007151 Change-Id: I68be5280d2d5cfb1ad1565c9408635a694aad2c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883271 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#711141}
-
Austin Tankiang authored
Also remove WriteOnCacheFile as it is no longer being used. Bug: 1003238 Change-Id: I8cf85264b08b7ed969c2bf88f40b36702810404c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890396 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#711140}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/69a6c2e64544..7677c2ab05a0 git log 69a6c2e64544..7677c2ab05a0 --date=short --no-merges --format='%ad %ae %s' 2019-10-31 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@7677c2ab05a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I39f57619e6134148b2242ec405d70d4f295cf4c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892431Reviewed-by:
-
Michael Spang authored
Updating displays in TestScreen loses the pixel size, which causes later calls to SetDisplayRotation to revert updates of the display size made by TestScreen::OnWindowBoundsChanged. Bug: 1019015 Change-Id: I47d77665102c9500609cfd203740e320ef841af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889295 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#711138}
-
nancy authored
kAppServiceInstanceRegistry is used to checked whether AppService Instance Registry feature is used. The default value is set as disable. When AppService Instance Registry feature is done,the flag will be marked as enable. BUG=1011235 Change-Id: If1fadd8cf1079c59141980c282b8506919252a6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890511 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#711137}
-
Manas Verma authored
Changing "fido_eligible_credit_card_id" to "fido_eligible_card_id" to match server field names. Bug: 949269 Change-Id: I932fd907cd18dd5377e1e0b278cec0b936a6c25b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891769Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#711136}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/54eda5713da0..6524ae660745 git log 54eda5713da0..6524ae660745 --date=short --no-merges --format='%ad %ae %s' 2019-10-30 tsepez@chromium.org Prevent duplicate string creation in CFWL_ComboBox::AddString() 2019-10-30 tsepez@chromium.org Remove c_str() calls from CXFA_Node::InsertItem() Created with: gclient setdep -r src/third_party/pdfium@6524ae660745 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: Idc4e822f8c6b0a99586859d2b84dcbc786dd7275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892391Reviewed-by:
-
Austin Tankiang authored
This code is unreachable now that the legacy drive client is disabled. Bug: 1003238 Change-Id: I08bf70752e98df90a3c78eb8d506337a460fc86a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885859Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
-
Hitoshi Yoshida authored
ActivilyLoggerTest creates some GC objects like DOMWrapperWorld which may be related to the global environment. Without running a GC after the test, these objects are kept alive and thus some statistics can show wrong values in the next test. e.g. DOMWrapperWorld::NonMainWorldsExistInMainThread() Bug: 1018970 Change-Id: Ib692c6593b121f187b6d70fa05a109135701b864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890373Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#711133}
-
Adam Rice authored
This reverts commit 3bce0223. Reason for revert: This is no longer needed in ToT because it has already been merged and released for M77. Original change's description: > Disable WebSocket connection throttling in the network service > > Permit any number of connect requests to be pending in the network > service. > > Note that per-server WebSocket connection serialisation is still > applied, so this doesn't permit denial-of-service attacks against > servers. > > BUG=1006243 > > Change-Id: I31a10ec3384f32aa34ff0380f22738271bee0160 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829629 > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Commit-Queue: Adam Rice <ricea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701043} TBR=ricea@chromium.org,yhirano@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1006243 Change-Id: I195e463ab05461c8246be372378671c9b53a1c65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880999Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#711132}
-
Tim Song authored
This CL also adds unit tests for the collapse/expand behaviour for the message center. TEST=manual + new unit tests BUG=1019405 Change-Id: I1189549e41e6f11f2d513c4d041de6e5ac108caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888187 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#711131}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6d4996c3785c..f6276f9ca394 Created with: gclient setdep -r src-internal@f6276f9ca394 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Idac35285153659e16b45c6ed9058cb19c9287a01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892352Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711130}
-
Doug Turner authored
Bug: None Change-Id: Ibd6eee35a6d06083464ff9e76af779bf1871499c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874720Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Commit-Queue: Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#711129}
-
John Abd-El-Malek authored
This is more aligned with Android style guide. Change-Id: I503748a796e2e5934e92d6ec9c6963907debabbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890824 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#711128}
-
Xianzhu Wang authored
After https://chromium-review.googlesource.com/c/chromium/src/+/1873504, we can put tests directly under a virtual directory, no longer needing the extra level of directory. TBR=wangxianzhu@chromium.org Bug: 1014162 Change-Id: I6aad51c4c508a50d274d35acdf9112cc9d809330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892094Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#711127}
-
Alice Boxhall authored
TBR=ftang@chromium.org Bug: 1020034 Change-Id: If72015dc9ed501aebc92689d63b52856cbfdc8fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890397Reviewed-by:
-
Henrique Nakashima authored
Leaving the public API of SharedPreferencesManager intact for now, changes are broad and I don't want to mix them with this CL. Bug: 1017800 Change-Id: I658afd16cf56a5436193d5d307cc38c0964b79a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888388Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#711125}
-
David Tseng authored
Change-Id: I46b9842698c02d40f48919514ab84b7f719cb994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881815 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#711124}
-
Yuchen Liu authored
Bug: 825041 Test: CQ Change-Id: I64bedf18614a6a2c17e004a372123156290065b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887739 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#711123}
-
Alice Boxhall authored
This reverts commit 1a90cb5c. Reason for revert: This seems to have caused a failure on MSan: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8898122667520416480/+/steps/unit_tests/0/logs/Deterministic_failure:_DownloadProtectionServiceTest.LargeFileBlockedByPreference__status_CRASH_/0 Original change's description: > Preserve original Safe Browsing verdict for download deep scanning. > > In cases where deep scanning fails, we currently supply a SAFE verdict. > If the original verdict from Safe Browsing was UNCOMMON, we will > therefore downgrade the warning. This CL preserves the original verdict > and returns it in cases where deep scanning fails. It also adds a test > implementation of the BinaryUploadService, for easier testing of code > using uploads. > > Fixed: 1017921 > Change-Id: I444b301c3fe75ebbe0561bc6b201945242f09dc2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887736 > Commit-Queue: Daniel Rubery <drubery@chromium.org> > Reviewed-by: Bettina Dea <bdea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711049} TBR=bdea@chromium.org,drubery@chromium.org Change-Id: I2464508513e6728a8519a141e22d2ff226233733 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890399Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 19c668ff. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" f701be68 "[css-pseudo] Restrict the properties allowed in ::marker" 96a711f0 "CSS: Update min-width and min-height parsing WPTs" c47a6f0b "Use a transformed bounding box when hit testing transformed elements" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Ifffb45b1403daec1c269eea8dd6bacc44782d33d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892271Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711121}
-
David Tseng authored
Bug: 1005524 Change-Id: I690a7881c79c02ed44bdd370f661a72e752fe735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887590Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#711120}
-
Tommy Steimel authored
This CL changes updates the ChromeOS Media Notification to hide the grey rectangle that surrounds the dismiss button. It is replaced by a circular background colored the same as the notification background. Bug: 1012740 Change-Id: Id8d0fefb63dbf75d5b8efd95e96cbd1a41fa3a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888273Reviewed-by:
-
rbpotter authored
Change the way style module JS files are autogenerated so that Polymer CSS build will correctly replace mixins. This is necessary for mixins to be correctly handled in optimized Web UI pages. Bug: 965770 Change-Id: I1de91006c4b0828a6371ef525c066293691e0e16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892093 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#711118}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: I3a0f911c35ef6838f63a83f20410048d1cae6c54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892451Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711117}
-
Peter Kasting authored
Bug: 1003612 Change-Id: I1ad31927926264069d8196de2c87ea23364da952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887666 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#711116}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5bd8cb74a659..32913c128aec git log 5bd8cb74a659..32913c128aec --date=short --no-merges --format='%ad %ae %s' 2019-10-31 qingsi@webrtc.org Removes the flakiness in PeerConnectionUsageHistogramTest. Created with: gclient setdep -r src/third_party/webrtc@32913c128aec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I22135ea3a7acfdcc8c5b3aa89253c29786262bd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892133Reviewed-by:
-
Will Harris authored
Filter crashes due to code integrity failure into their own histogram BrowserRenderProcessHost.ChildCodeIntegrityFailures. This histogram can be monitored independently of the usual crash metrics, meaning any non-CIG regressions are not missed. BUG=750886 Change-Id: I6913ca894d21e5f798e82fe8e6f216b2c46c8ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888738Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#711114}
-
Robin Lewis authored
Also adds minimum supported version of Chrome for GCPW. Bug: 907493 Change-Id: Ie4d0e050050c0f807ec1725bf223df2a11a1e164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881474 Commit-Queue: Robin Lewis <wrlewis@google.com> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#711113}
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for media::Renderer using PendingReceiver and SelfOwnedReceiverRef. Bug: 955171 Change-Id: Ibbd108219a3f3eac175e4122376f1a78ed976aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886070Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#711112}
-
Jon Mann authored
Previously the configRequiresPassphrase_ value wasn't always updating when the security type changed, this resulted in the password field getting shown/hidden at incorrect times. Bug: 1019495 Change-Id: I127ad6bf57595afc1a244455a14386c00585eab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889470 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#711111}
-
Sven Zheng authored
When tests run in parrallel, the dialog get randomly closed with reason lost focus. For bubble dialog, when they get deactivate they will close themselves: https://cs.chromium.org/chromium/src/ui/views/bubble/bubble_dialog_delegate_view.cc?l=237&rcl=c32f919eb9638bd8b1030a460c016c6b75a1c286 There's also test trying to tackle the problem: https://cs.chromium.org/chromium/src/chrome/browser/ui/views/tabs/tab_hover_card_bubble_view_browsertest.cc?l=345&rcl=2e48cb8072cdcf0a4da0c3e04e196a100838ebcc This cl will fix it by block close the dialog temporarily. Why it wasn't an issue when pixel test not enabled? It's because there's no wait/async in ShowAndVerifyUi(). But with pixeltest, there are several async calls and wait for callback, which give the browser chance to close the dialog. Eg the async in snapshot: https://cs.chromium.org/chromium/src/ui/snapshot/snapshot_aura.cc?l=51&rcl=07fe9cc024d6c20514423412c9c3aead11d9767c When running in 36 launcher jobs, this issue contributes ~2% flakiness. I've also observed that in very rare cases, dialog can get closed with ESC pressed. But I didn't figure out which test mis-sending the ESC key press to the system. So the block close will block all reasons instead of lost focus only. Bug: 958242 Change-Id: I51037dd7070fc4c35195d0e07c408763906dcdd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889949 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#711110}
-
John Lee authored
- Track thumbnails only if they are currently in view or are just a standard finger swipe away. - Do not track thumbnails for pinned tabs. - Do not track thumbnails when the tab strip is closed. Note that this CL does not implement actually untracking thumbnails. It merely calls the method in the C++ side that will eventually do it. Bug: 1015132 Change-Id: I86f7a8ea284395fc97dfed60fbb0452a0dfaa8ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885504 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a25f3386ca1a..69a6c2e64544 git log a25f3386ca1a..69a6c2e64544 --date=short --no-merges --format='%ad %ae %s' 2019-10-30 pprabhu@chromium.org Stop running irrelevant pre-cq on LCQ Created with: gclient setdep -r src/third_party/chromite@69a6c2e64544 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I2832dbc1c24a1639a10f55e6156793b40ad86a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892099Reviewed-by:
-
