GitLab

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4b91fed..9237715

TBR=enne@chromium.org,yurys@chromium.org

Review URL: https://codereview.chromium.org/1166383003

Cr-Commit-Position: refs/heads/master@{#333655}

This patch fixes more size_t to int truncations that I missed on
the initial runs.

R=danakj
BUG=167187
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1170403002

Cr-Commit-Position: refs/heads/master@{#333654}

This scale is currently 0, but if a PaintedScrollbarLayerImpl ends up
in the RenderSurfaceLayerList, we'll try to get the layer's rect in
target space. Since the scale is 0 we end up dividing by 0 and get a
NaN which is bad times.

If we init this to 1 things work until the PaintedScrollbarLayer has
a chance to Update().

R=enne
BUG=497947
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1172873002

Cr-Commit-Position: refs/heads/master@{#333653}

BUG=chromium:489795
TEST=None
R=sergiyb@chromium.org

Review URL: https://codereview.chromium.org/1168813003

Cr-Commit-Position: refs/heads/master@{#333652}

the same data more than once.

BUG=451256
R=rch@chromium.org

Review URL: https://codereview.chromium.org/1160823007

Cr-Commit-Position: refs/heads/master@{#333651}

DecryptingDemuxerStream should report proper video_rotation
of the underlying DemuxerStream.

BUG=none

Review URL: https://codereview.chromium.org/1175563005

Cr-Commit-Position: refs/heads/master@{#333650}

When creating a bookmark file by draging and droping the URL to the desktop
chromium uses the page title for the filename. In cases where the title starts
with a dot the webloc file will also start with a dot. Since files starting
with a dot are considered hidden and not shown by e.g. the Finder users won't
see the expected resulting file. To circumvent this a dot as the first
character is handled like any other character not allowed in a filename and
gets replaced by a hyphen.

BUG=138917
TEST=Paste "data:text/html,<title>. . . hey!</title>" into the Omnibox and drag
  and drop the URL to the desktop.

Review URL: https://codereview.chromium.org/1118813005

Cr-Commit-Position: refs/heads/master@{#333649}

This was made stable in https://codereview.chromium.org/866893003 but
that CL missed this is-dev-channel check.

BUG=495039,384644

Review URL: https://codereview.chromium.org/1170843005

Cr-Commit-Position: refs/heads/master@{#333648}

BUG=439512, 472215

TEST=./tools/perf/run_benchmark --browser=system smoothness.maps

Review URL: https://codereview.chromium.org/1171113002

Cr-Commit-Position: refs/heads/master@{#333647}

BUG=480025

Review URL: https://codereview.chromium.org/1172183003

Cr-Commit-Position: refs/heads/master@{#333646}

This CL defines the LicenseManager interface and implements a dummy
GaiaLicenseManager that returns the user's Gaia token.

BUG=b/19799333

Review URL: https://codereview.chromium.org/1163023002

Cr-Commit-Position: refs/heads/master@{#333645}

Encryption errors can arise due to OS issues in some cases or simply directory
corruption. Rather than crashing trigger an unrecoverable error.

BUG=123223

Review URL: https://codereview.chromium.org/1161463005

Cr-Commit-Position: refs/heads/master@{#333644}

This was only used in one place and it was unnecessary.

Review URL: https://codereview.chromium.org/1172163002

Cr-Commit-Position: refs/heads/master@{#333643}

We have traditionally tested all of the GPUTiming functionalities within
GPUTracer since GPUTracer utilizes GPUTiming extensively. With the
introduction of gl_unittests as well as GPUTiming getting more
complicated it makes sense to have GPUTiming specific unit tests. This
CL is the first step in moving towards that direction, simply moving
all of the GPUTiming GL queries into a fake query class which can
handle the query expectations.

R=sievers@chromium.org, vmiura@chromium.org
BUG=453965, 345227

Review URL: https://codereview.chromium.org/1162203006

Cr-Commit-Position: refs/heads/master@{#333642}

1/4 MB per copy operation on Mali pre-Lollipop.

BUG=460288,498443
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1159833002

Cr-Commit-Position: refs/heads/master@{#333641}

BUG=471928

Review URL: https://codereview.chromium.org/1123163002

Cr-Commit-Position: refs/heads/master@{#333640}

Fix a bug where exiting the SSL certificate export from the page info
bubble (connection \ certificate information \ details \ save to file)
could cause chrome to hang on Windows 8.1.

BUG=344012

Review URL: https://codereview.chromium.org/1158043004

Cr-Commit-Position: refs/heads/master@{#333639}

DamageTrackerTest does a lot of impl side operations that could not
happen in practice, e.g. LayerImpl::SetPosition(),
LayerImpl::Add/RemoveChild(). These operations won't trigger property
trees rebuild/update so the verification on draw_transform would fail.

The simple fix in this case seems to be forcing a property trees
rebuild.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1170383003

Cr-Commit-Position: refs/heads/master@{#333638}

Linking against the 10.6 SDK tickles an AppKit bug that causes a parent
NSWindow to disappear from screen when it has a child window that
closes.

NativeWidgetMac tries to ensure windows are only closed when they have
no parent window. However, for child Widgets with non-Widget parents, if
the "anchor" NSView used to create the dialog was removed from its own
view hierarchy while the child dialog is still alive, this step was
being skipped.

Specifically, this happens for tab-modal dialogs that have a fade out
animation that can outlast the NSView it was initially anchored off.

Fix by retaining the NSWindow parent when the parent-child relationship
is initially created.

BUG=485854

Review URL: https://codereview.chromium.org/1169063002

Cr-Commit-Position: refs/heads/master@{#333637}

The MacViews native app window implementation was only available behind
a gyp flag (mac_views_browser). This includes it into a regular Mac
build and allows it to be enabled from chrome:flags.

BUG=459877

Review URL: https://codereview.chromium.org/1167883002

Cr-Commit-Position: refs/heads/master@{#333636}

This field trial will allow the config service client to be enabled as well
as providing a means to set the config service URL. Values on the command
line will override values coming from the field trials.

BUG=466753

Review URL: https://codereview.chromium.org/1162903008

Cr-Commit-Position: refs/heads/master@{#333635}

In case that no response has been received within 3 seconds,
cancel the current request and start a new one.

BUG=internal b/21298386

Review URL: https://codereview.chromium.org/1169163002

Cr-Commit-Position: refs/heads/master@{#333634}

adb over wifi is broken for power measurements. This should fix it.

BUG=497238

Review URL: https://codereview.chromium.org/1153143007

Cr-Commit-Position: refs/heads/master@{#333633}

BUG=498478
TEST=unit tested
R=rsleevi@chromium.org, tengs@chromium.org

Review URL: https://codereview.chromium.org/1170363002

Cr-Commit-Position: refs/heads/master@{#333632}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/c15d957..b23e6aa

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/1174683006

Cr-Commit-Position: refs/heads/master@{#333631}

Add WebContents getters to PresentationServiceDelegateImpl
    and Media Router Dialog Controller.

BUG=464216
R=imcheng@chromium.org,mfoltz@chromium.org

Review URL: https://codereview.chromium.org/1156373014

Cr-Commit-Position: refs/heads/master@{#333630}

They are empty so they aren't visible. Trying to paint a view with
empty bounds actually leads to DCHECK fails when they try to use the
empty size incorrectly. With slimming paint this could happen for the
first frame when we paint /everything/ to try cache it all until
invalidation. Instead, defer painting empty things until they actually
have something to paint. This also means less wasted time painting
subtrees that aren't visible.

R=sky@chromium.org, weiliangc@chromium.org, sky, weiliangc
BUG=498066

Review URL: https://codereview.chromium.org/1166373008.

Cr-Commit-Position: refs/heads/master@{#333629}

BUG=433140

Review URL: https://codereview.chromium.org/1173753002

Cr-Commit-Position: refs/heads/master@{#333628}

This is the first step in a refactoring of the declarativeContent API
implementation. The goal is to facilitate profile state matching by
providing abstractions for conditions and condition state tracking
and evaluation.

This CL consists of step 2 described in the associated bug: encapsulation of CSS
selector condition tracking logic. No functional change is intended.

Originally committed at https://crrev.com/fe76220cf0a1cdcfe74ca7daeae9f1da2b91cc6b
and reverted at https://crrev.com/4fcf9f62d9099af2e55186d9c423e2ded4fdca0d due to crashes.

BUG=492946, 497586

Review URL: https://codereview.chromium.org/1166393002

Cr-Commit-Position: refs/heads/master@{#333627}

There are two ways to generate flings in Android WebView: through user
finger gesture or through calling WebView API flingScroll(int vx, int
vy).  This CL unifies Android WebView's fling code with Chrome. This
means Android WebView will use the same fling curve in InputHandlerProxy
as Chrome now does.

Also note "smooth scrolling" (which is used by WebView#pageUp(),
WebView#pageDown() and WebView#requestChildRectangleOnScreen(child,
rect, false)) logic stays unchanged in this CL and does not use the same
fling curve as mentioned above.  Instead, it uses the underlying curve
in android.widget.OverScroller.startScroll().

Corner cases:
1. What happens when a smooth scroll immediately follows a fling before the
fling finishes?
The fling will be stopped and smooth scroll takes control of WebView's
scroll offset.

2. What happens when a fling immediately follows a smooth scroll before it
finishes?
The smooth scroll will be stopped and fling takes control of WebView's
scroll offset.

Next steps:
1. crbug.com/493765: make the API WebView#flingScroll() always target
root layer.
2. Smooth scroll is still handled by WebView. Expose
ui::Scroller::StartScroll to support smooth scroll in chromium
compositor.

BUG=378984
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1063853005

Cr-Commit-Position: refs/heads/master@{#333626}

This adds single process support for IOSurface and
SurfaceTexture backed GpuMemoryBuffers.

Also makes the SurfaceTexture code more consistent
with IOSurface code by using a singleton instead of
leaking a raw pointer.

BUG=497559
TEST=content_browsertests --gtest_filter=ChildThreadImplGpuMemoryBufferBrowserTests/*

Review URL: https://codereview.chromium.org/1120873002

Cr-Commit-Position: refs/heads/master@{#333625}

Previously, only URLRequests created by URLFetcher had stack traces.

This is intended to be temporary.

BUG=498289

Review URL: https://codereview.chromium.org/1174593002

Cr-Commit-Position: refs/heads/master@{#333624}

Developed based on watk@'s CL with modifications.

With this CL, opening chrome://media-internals after HTML5 media playback has
happened is working.

Technical details:
- In the browser process, always save up to 128 latest media log events per
  render process. If we hit the limit, old logs will be discarded.
- When chrome://media-internals UI is opened, all saved logs will be sent to the
  UI.
- When a tab is closed, all saved logs associated with that tab is discarded.

Test shows that 128 log entries should be sufficient for 4 youtube video
playbacks (with minor seeking activities).

BUG=497286
TEST=Manually tested.

Review URL: https://codereview.chromium.org/1169983003

Cr-Commit-Position: refs/heads/master@{#333623}

Using a weak ptr for compositor_impl_ is unnecessary if we are not
checking for null. Using a callback with an unretained ptr is better.

Review URL: https://codereview.chromium.org/1176643002

Cr-Commit-Position: refs/heads/master@{#333622}

Though repro of bug 418324 was unsuccessful locally, inspection of Blink
HTMLMediaElement's usage of WebMediaPlayer::currentTime() revealed
race between Pipeline time management and WMPI/Blink seek time
knowledge was at least partly responsible for the flakiness.

This change updates WMPI::seek() and WMPI::currentTime() implementations
with logic similar to WebMediaPlayerAndroid to:
1) eliminate some redundant seeks, and
2) reflect the best knowledge of seek target time when responding
   to currentTime() requests. This latter piece is expected to
   fix the race and layout test flakiness.

BUG=418324
TEST=no media_unittest nor blink http/tests/media/ or media/ regression locally on Linux, layout test bots show no flakiness for mediasource-redundant-seek.html

Review URL: https://codereview.chromium.org/1164343003

Cr-Commit-Position: refs/heads/master@{#333621}

Revert of Add simple presubmit check to remoting. (patchset #2 id:60001 of https://codereview.chromium.org/1166123004/)

Reason for revert:
Abandoning in favour of implementing a better longer-term solution.

Original issue's description:
> Print out a note, during change upload, on running Remoting browser-tests before commiting changes under $src/remoting.
>
> BUG=
>
> Committed: https://crrev.com/44de127d69cd00dfc636e2f8f2cdf42f0e85b7d4
> Cr-Commit-Position: refs/heads/master@{#333390}

TBR=jamiewalch@chromium.org,kelvinp@chromium.org,sergeyu@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1177633002

Cr-Commit-Position: refs/heads/master@{#333620}

Chrome now uses the Lollipop MR1 SDK, so make that version code
available from native code.

Review URL: https://codereview.chromium.org/1172843002

Cr-Commit-Position: refs/heads/master@{#333619}

BUG=chromedriver:922

Review URL: https://codereview.chromium.org/1165263008

Cr-Commit-Position: refs/heads/master@{#333618}

Fails flakily for Linux and ChromeOS ASan LSan bots.

BUG=498407
TBR=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/1172193002

Cr-Commit-Position: refs/heads/master@{#333617}

See bug for context. This patch adds code to
keep track of extensions using the automation API
that want to subscribe to accessibility events and
implements an IPC to forward the accessibility events.

The next CL will complete the implementation
based on this new IPC and delete the code that
forwards accessibility events using the extension
event router.

BUG=495323

Review URL: https://codereview.chromium.org/1151523009

Cr-Commit-Position: refs/heads/master@{#333616}