GitLab

It turns out that a few bots have psutils 0.4.1 and the set_cpu_affinity API was
introduced in 0.5. I'm investigating why bots have differing versions, but for
now this patch makes us robust to any psutil version.

BUG=395228

Review URL: https://codereview.chromium.org/407303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285372 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395655
R=oshima@chromium.org
TEST=athena_unittests

Review URL: https://codereview.chromium.org/414903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285371 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396388

Review URL: https://codereview.chromium.org/419463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285370 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285368 0039d316-1c4b-4281-b951-d872f2087c98

Previously an identifier used as the list in a feoreach statement would not count as "using" the identifier, which would give unused variable errors. Added a unit test.

Checks for unused identifiers in component(). Previously these were not checked. This checking turned up a misspelling in the cc build. Added a unit test.

Fixes for the ozone media build (turned up when testing).

R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/420443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285367 0039d316-1c4b-4281-b951-d872f2087c98

BUG=242216

Review URL: https://codereview.chromium.org/414023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285366 0039d316-1c4b-4281-b951-d872f2087c98

Instead of just the small white-bar, allow dragging the entire width of the
minimized home-card to get into the overview mode.

BUG=396867
R=mukai@chromium.org

Review URL: https://codereview.chromium.org/416963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285365 0039d316-1c4b-4281-b951-d872f2087c98

BUG=364612

Review URL: https://codereview.chromium.org/416833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285364 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the GN build for the ui/ozone component (and tests). The
following build should work going forward:

 gn gen out_gn_ozone --args="use_ozone=true"
 ninja -C out_gn_ozone -j1000 -k50 ozone_egl_demo ozone_unittests

BUG=396316
TEST=compile & run ozone_egl_demo, ozone_unittests
TBR=darin

Review URL: https://codereview.chromium.org/409163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285362 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/418983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285361 0039d316-1c4b-4281-b951-d872f2087c98

chrome/app/generated_resources.grd: added messages for
DOWNLOAD_INTERRUPT_REASON_SERVER_UNAUTHORIZED
content/browser/download: handling of
DOWNLOAD_INTERRUPT_REASON_SERVER_UNAUTHORIZED

BUG=386146

Review URL: https://codereview.chromium.org/351863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285359 0039d316-1c4b-4281-b951-d872f2087c98

Additional compile time checks are being added to Skia and since
MSVS compilers don't support querying the compiler for support we
must manually set the values. This mirrors what has already been
done in the main Skia repo.

Review URL: https://codereview.chromium.org/416833005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285358 0039d316-1c4b-4281-b951-d872f2087c98

bootstrap.py:
+ Fixed build (missing/wrong compile flags)
+ Added -s option to stop before trying to rebuild GN with GN
+ -v option passes -v to ninja
+ Use env vars CC, CXX, CXXFLAGS
+ Added mac support

R=brettw@chromium.org
BUG=

Review URL: https://codereview.chromium.org/403463005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285356 0039d316-1c4b-4281-b951-d872f2087c98

This patch just renames some variables to be more consistent with
each other.

The new pattern is:
current_<type of rect>_rect_

R=reveman

Review URL: https://codereview.chromium.org/413863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285355 0039d316-1c4b-4281-b951-d872f2087c98

This is failing on our new 64-bit devices:
https://uberchromegw.corp.google.com/i/clank/builders/volantis-official-perf-clankium-lmp/builds/15/steps/dromaeo.jslibeventjquery/logs/stdio

BUG=392153

Review URL: https://codereview.chromium.org/400493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285354 0039d316-1c4b-4281-b951-d872f2087c98

To avoid false-positive reports from UBsan's vptr instrumented Chrome,
sources/functions/types are blacklisted. The reasons for each blacklisting is
accordingly commented.

BUG=174801
R=aarya@google.com

Review URL: https://codereview.chromium.org/405643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285353 0039d316-1c4b-4281-b951-d872f2087c98

R=wfh@chromium.org
BUG=51909
TEST=Verify that chrome still runs on Windows Server 2008

Review URL: https://codereview.chromium.org/417923006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285352 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/415143004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285351 0039d316-1c4b-4281-b951-d872f2087c98

This changes the semantics of the public system API: instead of
(attempting) to returning "invalid argument" (e.g., when you pass a null
pointer for a required argument), we'll crash/trap/kill you.

The reason for this is that it's not really sensible to check pointers
up front in the face of threads doing different things (e.g., memory
that is valid to read to/write from at the beginning of a call may not
be valid later).

As such, we wrap "user" pointers in a (new) |UserPointer<>| class, and
provide ways of accessing the memory that they refer to. We should never
pass around user pointers as plain pointers. (This careful treatment
will probably already be needed to properly support NaCl, for example.)

Still to do (but this change is already too big):
* Update comments (in mojo/public/c/system).
* Properly convert the remaining user pointers being passed around as
  plain pointers. This includes:
  * Getting rid of |GetPointerUnsafe()| and also the existing
    |VerifyUserPointer...()| functions.
  * Changing how we handle the various options structs.
  * Changing some of the |Dispatcher| interface.
* Write tests for |UserPointer<>|, etc.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/418033005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285350 0039d316-1c4b-4281-b951-d872f2087c98

The data referenced by c_str() is only valid as long as the
std::string is still live, so hold std::string values
on the stack.

This was causing tests to fail on my Trusty laptop.

BUG=
R=binji@chromium.org

Review URL: https://codereview.chromium.org/414843004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285346 0039d316-1c4b-4281-b951-d872f2087c98

First off, create a new window manager app (wm_flow_wm) which uses the core_window_manager_lib static lib to implement a basic WM.

Second, create a new demo launcher (wm_flow_init) that starts the view manager, embeds wm_flow_wm, and starts an additional app (wm_flow_app).

Thirdly, creates an additional app (wm_flow_app) that also connects to the view manager init service and asks it to embed it somewhere, thus giving it a connection to the view manager (and a top-level window).

I had to change ViewManagerInitService to have some shared state so that it was possible to connect to it > 1 time.

R=sky@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/400113005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285345 0039d316-1c4b-4281-b951-d872f2087c98

It was assuming that modifying selectionStart/selectionEnd on an input
element focused the element, but Blink just changed to remove that
behavior.

Fixed by explicitly focusing the element.

BUG=397212,393504
R=asvitkine@chromium.org
TBR=dtseng

Review URL: https://codereview.chromium.org/418053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285344 0039d316-1c4b-4281-b951-d872f2087c98

This sample app is useful for testing but doesn't have software support.
Add it and use it when we can't initalize GL.

Also, fix the app to not block the message loop indefinitely. We can
render on a task and let other work (event processing) continue.

BUG=none
TEST=ozone_demo on egltest, caca
NOTRY=true

Review URL: https://codereview.chromium.org/416893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285342 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285341 0039d316-1c4b-4281-b951-d872f2087c98

Try Chromium build with SkFontMgr_android.

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=robertphillips@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/413743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285340 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
NOTRY=true
TBR=alexst

Review URL: https://codereview.chromium.org/418113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285336 0039d316-1c4b-4281-b951-d872f2087c98

Support snapshot-sync on demoted URL.
Previous implementation drops changes in demoted changes, and doesn't mirror new changes on demoted URLs.

BUG=344769
TEST=unit_tests --gtest_filter="LocalFileChangeTrackerTest.*"

Review URL: https://codereview.chromium.org/394033005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285335 0039d316-1c4b-4281-b951-d872f2087c98

Fix the devtools resources target to use the grit template.

Fix the grit template to use the correct output directory for the expected files if one is specified

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/414973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285334 0039d316-1c4b-4281-b951-d872f2087c98

Apparently this target isn't built there and running fails with a weird error.

TBR=phajdan.jr@chromium.org,,

Review URL: https://codereview.chromium.org/416153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285332 0039d316-1c4b-4281-b951-d872f2087c98

BUG=397185
TBR=jdduke@chromium.org
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/410423005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285331 0039d316-1c4b-4281-b951-d872f2087c98

Looks like the revert didn't help.

> Revert 285259 "Avoid processing mutations when ChromeVox active ..."
> 
> Suspected to have caused CvoxBrailleUtilUnitTest.TextFieldSelection to
> start being flaky. Sample failure output:
> 
> CvoxBrailleUtilUnitTest.TextFieldSelection (run #1):
> [ RUN      ] CvoxBrailleUtilUnitTest.TextFieldSelection
> [5693:5693:0724/085516:WARNING:chrome_browser_main_chromeos.cc(275)] Running as stub user with profile dir: test-user
> Xlib:  extension "RANDR" missing on display ":9".
> [5693:5822:0724/085517:WARNING:local_extension_cache.cc(199)] Extensions will not be installed from update URLs until /var/cache/external_cache/.initialized exists.
> [5693:5771:0724/085518:WARNING:raw_channel_posix.cc(214)] recvmsg: Connection reset by peer
> [5693:5693:0724/085518:INFO:CONSOLE(1283)] "Running TestCase CvoxBrailleUtilUnitTest.TextFieldSelection", source: test_api.js (1283)
> [5693:5693:0724/085518:ERROR:web_ui_test_handler.cc(74)] undefinedFailed: RUN_TEST_F("CvoxBrailleUtilUnitTest","TextFieldSelection")
> Expected 'NavBraille(text=": strawberry edtxt"  startIndex="4"  endIndex="7")' to be eqJSON({"text":{"string_":": strawberry edtxt","spans_":[]},"startIndex":0,"endIndex":1})
> obj/chrome/browser/resources/chromeos/chromevox/chromevox_tests.gen/common/braille_util_test-gen.cc:407: Failure
> Value of: RunJavascriptTestF(false, "CvoxBrailleUtilUnitTest", "TextFieldSelection")
>   Actual: false
> Expected: true
> [5693:5771:0724/085518:WARNING:raw_channel_posix.cc(214)] recvmsg: Connection reset by peer
> [  FAILED  ] CvoxBrailleUtilUnitTest.TextFieldSelection, where TypeParam =  and GetParam() =  (1472 ms)
> 
> 
> > Avoid processing mutations when ChromeVox active indicator moves.
> > 
> > This makes touch exploration a bit more responsive; a lot of the processing
> > time was spent responding to the mutations generated from the active
> > indicator.
> > 
> > BUG=377040
> > 
> > Review URL: https://codereview.chromium.org/405433010
> 
> TBR=dmazzoni@chromium.org
> 
> Review URL: https://codereview.chromium.org/418893002

TBR=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/416943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285330 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=jochen@chromium.org, oshima@chromium.org

Review URL: https://codereview.chromium.org/413843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285329 0039d316-1c4b-4281-b951-d872f2087c98

BUG=377725
TEST=manual

Review URL: https://codereview.chromium.org/419463004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285328 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116119

Review URL: https://codereview.chromium.org/417993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285325 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285324 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178831:178841&mode=html
TBR=pkasting@chromium.org,haraken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/417923005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285323 0039d316-1c4b-4281-b951-d872f2087c98

BUG=397108
TEST=none

Review URL: https://codereview.chromium.org/416833004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285322 0039d316-1c4b-4281-b951-d872f2087c98

In a follow-up CL, I will clean up the histogram definitions, remove
stale ones, and add the new ones

BUG=223859
R=isherman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/413143004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285316 0039d316-1c4b-4281-b951-d872f2087c98

This change adds a toggle to turn webspeech off when tab goes background.
And further request to turn media capture devices on will be denied.
So Both WebRTC and webSpeech won't be able to initiate new requests when tab is in background.

This CL also fixed a bug in the original CL that was reverted: some times recognition will not be aborted immediately after screen lock.
The issue is caused by that calling abort() will not delete the session in SpeechRecognitionManagerImpl.
So if a SpeechRecognition objects calls multiple start(), several sessions with the same request_id will be created.
And when passing the request_id to abort the sessions, only 1 session will be aborted
This change requests the all sessions in the same render view to be aborted.
Thus solving the above issue.

BUG=396054
R=jochen@chromium.org, tsepez@chromium.org, xians@chromium.org

Review URL: https://codereview.chromium.org/415933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285314 0039d316-1c4b-4281-b951-d872f2087c98

objdump was failing when running beta or dev branch of Chrome, because the
filename is now google-chrome-beta or google-chrome-dev.

The code in getos.py was only checking for google-chrome.

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/417763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285312 0039d316-1c4b-4281-b951-d872f2087c98