- 14 Jan, 2020 40 commits
-
-
Ian Kilpatrick authored
This is primarily a refactor. This removes usages of FlexItem::box (if possible), and provides an alterate implementation of: - MarginBoxAscent - ComputeStretchedSize ...when not present. Bug: 845235 Change-Id: Ife8c54fb779de5d2afdcb904ab92acd6c724cf1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998618 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#731565}
-
Jeroen Dhollander authored
When pressing on the keyboard icon to switch from voice input to text mode, the on-screen keyboard was not displayed. This forced the user to tap explicitly on the query input field to show the keyboard. Fixing this exposed a few other problems, including the issue reported in b/134766206, which now became a lot more visible because you could actually see the on-screen keyboard appear and immediately dismiss when the Assistant UI was launched in tablet mode. So this CL also fixes that bug. Note that this only addresses the onscreen keyboard in tablet mode. I opened b/146679393 to fix the related issue in normal mode but with on-screen keyboard enabled through the accessibility settings. Bug: b/146210314, b/134766206 Tests: added many unittests to |ash_unittests --gtest_filter="AssistantPageViewTabletMode.*"| Change-Id: I49da3ca647aa4bde0026f6fa84e582874836be63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972619 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#731564}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/9f1e03b61de8..146e16f68fdc git log 9f1e03b61de8..146e16f68fdc --date=short --first-parent --format='%ad %ae %s' 2020-01-14 bclayton@google.com C++14: Use enum class builtin hashing 2020-01-14 bclayton@google.com C++14: Use std::enable_if_t instead of our own Created with: gclient setdep -r src/third_party/swiftshader@146e16f68fdc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I8a993f667404cefb8dc2b462106e88da87e62eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001105Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#731563}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=jbroman@chromium.org Bug: 1041419 Change-Id: I7fc98a8361856747ff71216263d88157da304ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997827 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#731562}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=rohitrao@chromium.org Bug: 1041419 Change-Id: I56d2b632cd9e44db7c184e96bf119392e421405b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998571 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#731561}
-
evliu authored
This CL adds a toggle switch to the caption settings page to enable the Live Caption feature. The toggle is hidden behind the 'LiveCaption' media switch and will be used for experimental purposes while the feature is being developed. Screenshot: https://drive.google.com/a/google.com/file/d/1ykGmZ4q7l7OR_V9jedAyEwk0fcxXa3da/view?usp=sharing Bug: 1033227 Change-Id: I5913167ad230ecd62e96e7229f4c2e95b41b582a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979100Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#731560}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=rohitrao@chromium.org Bug: 1041419 Change-Id: I238eb712b932b7e2d408fd8e9b43ebef8af8cd99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998570 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Theresa Wellington authored
BUG=1041870 TBR=aluo@chromium.org,arbesser@chromium.org Change-Id: I5c0670220cd35f0915cf2be7d55d2248739626dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999248 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#731558}
-
Aga Wronska authored
Blocked and paused app icons are greyed out and have relevant badges applied. Only one badge can be applied at the time. The order is following: 1. Blocked badge 2. Paused badge 3. Chrome badge Bug: 1019833 Test: ChromeAppIconTest Change-Id: Ia6f947e01bd97cd3ced6a858988d2226e448391f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990086 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#731557}
-
kylechar authored
The display compositor no longer runs as part of the browser UI thread. This CL removes the dep from //content/browser to //components/viz/service as it's no longer necessary. This required cleaning up a number of unnecessary #includes in src/content/browser/. Also cleanup a few other viz deps from content that have become unnecessary. At this point only tests and some WebView code have dependencies on //components/viz/service from content. Bug: 1033325 Change-Id: Ie1793cc265847246257b49effc67736e119eaa2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994601Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#731556}
-
Anton Bikineev authored
This implements card table visitation in the atomic pause. Card table keeps track of which cards (consecutive regions of 512 bytes in a page) may store references from old objects to young. Therefore it has to be visited while collection objects in the young generation. Design doc: https://bit.ly/2ZXGU20 Bug: 1029379 Change-Id: I3f4bb335399f799a95bd3be0495f44523142774b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990286 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#731555}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=kerrnel@chromium.org Bug: 1041419 Change-Id: I4cfe3ec688654eb150109796731db62797ab7519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998379 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#731554}
-
Theresa Wellington authored
BUG=1041904 TBR=bsheedy@chromium.org Change-Id: Ie214e9bb83d743201cadc535b103cc6f1397119c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001290Reviewed-by:
-
Guillaume Jenkins authored
Makes spell check use the latest en-* and fa-IR dictionaries from the hunspell_dictionaries repo. Dictionaries have already been uploaded to the download servers and LoadingDock payloads have been set, so the .bdic files are ready to be downloaded. Dictionaries updated here: https://chromium-review.googlesource.com/c/chromium/deps/hunspell_dictionaries/+/1992612 DEPS rolled here: https://chromium-review.googlesource.com/c/chromium/src/+/1994089 Bug: 1041438 Change-Id: I279dc91e82eacbba339e351c01e2fb0ba7a1aa73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999772 Auto-Submit: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#731552}
-
Dana Fried authored
Precursor to solving a bug where popping out an extension icon wouldn't always cause the correct animation in a space-constrained toolbar. Bug: 1040618, 1040676 Change-Id: I990800755b90a8c0ade4370df5c4fca32f923b63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996139Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#731551}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=achuith@chromium.org Bug: 1041419 Change-Id: I580ce7a66aa6e232395f3a45d0df9658b9b6156f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998356 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#731550}
-
Adam Langley authored
JSON \u escapes may only be followed by four hex digits[1]. (The spec doesn't actually define HEXDIG, but the text above says “followed by four hexadecimal digits that encode the character's code point. The hexadecimal letters A though F can be upper or lowercase.”) Due to the use of |HexStringToInt|, sequences like "\u0x12" were accepted, i.e. an 0x or 0X prefix was permitted. This change causes them to be correctly rejected. [1] https://tools.ietf.org/html/rfc4627#section-2.5 Change-Id: Ib8731cb917183588d5a0fc9f7edf7e2757b3dfb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999329Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#731549}
-
Arthur Wang authored
This reverts commit 5f865cce. Reason for revert: caused issue on https://ci.chromium.org/p/chrome/builders/official/linux64. bug is crbug/1041360 Original change's description: > Ignore weak undefined symbols when calculating dpkg dependencies > > This is needed after [1] used weak undefined symbols to test feature > support in libgbm. The dependencies for the Chrome debian package are > unchanged before/after this change. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/1988382 > > BUG=1031269 > R=thestig,thakis > CC=spang > > Change-Id: I760033d5883bf65a5a39316ea382766ae3754088 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992340 > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#730271} TBR=sky@chromium.org,thakis@chromium.org,thestig@chromium.org,thomasanderson@chromium.org,crschmidt@google.com,tlelong@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1031269 Change-Id: I9e812e1cb7642be212f74d4d182222bda0a4f1c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993918Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Arthur Wang <wuwang@google.com> Cr-Commit-Position: refs/heads/master@{#731548}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=eugenebut@chromium.org Bug: 1041419 Change-Id: I103e9513ecf879d73f756ddad08b0ef34bcf6d7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998427 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#731547}
-
Toni Barzic authored
The feature will control whether shelf navigation widget buttons and overview button are shown in tablet mode. BUG=1012814 Change-Id: Icbb67f1056c5e1a5556fc9a76f9a89abcaf7464e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999747 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#731546}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f12daef7970e..52e9146a65fd git log f12daef7970e..52e9146a65fd --date=short --first-parent --format='%ad %ae %s' 2020-01-14 nigi@chromium.org Add an embeddertest for text extraction of Type 3 fonts. Created with: gclient setdep -r src/third_party/pdfium@52e9146a65fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ib1ec213d8940428dfb12fada218d8b0dd969f4b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999956Reviewed-by:
-
Allen Bauer authored
Bug: 648382 Change-Id: Idab058df0c7ebdc9624bd05331922b08830a1b71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999222Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#731544}
-
Dan Beam authored
R=mahmadi@chromium.org BUG=none Change-Id: Ic963abc0078359a0c781660ddc308ef82a2876cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999437 Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#731543}
-
Scott Violet authored
SessionBackend is used exclusively on a background task runner (it's created on the main thread). SessionBackend's destructor does IO. No provisions were made to ensure SessionBackend was deleted on the background task runner, which would result in running IO on the main thread. This patch ensures SessionBackend is deleted on the background task runner. BUG=112512 TEST=none Change-Id: I47f9c95195dfffdede5e87196c320253de2acef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000959Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#731542}
-
Eric Stevenson authored
This reverts commit 24f7b916. Reason for revert: Tests are broken. Original change's description: > Android: Better error messaging for some UnsatisfiedLinkErrors. > > A common cause of UnsatisfiedLinkErrors is that the native library > hasn't been loaded yet. It's difficult to tell the difference between > this and other UnsatisfiedLinkErrors. > > This CL adds generated code that queries LibraryLoader to determine > library loading status and throws an explicit error when a native > method is called before the library has been loaded. > > Bug: 1022938 > Change-Id: I63980990abaef16da3847a05eda01cb116779560 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976905 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729461} TBR=agrieve@chromium.org,estevenson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1022938, 1041154 Change-Id: Ie2ccc65024262325f0e394a35dea39e51a61b802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999002 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#731541}
-
Adrienne Walker authored
I am not longer working on these parts of the code, so I shouldn't be a frontline OWNER that folks send code reviews too. I'm always happy to answer questions. :) Change-Id: I9b2d1a6b9aa55e108b6fe6375040d1aad7c37174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995473 Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#731540}
-
Sigurdur Asgeirsson authored
This allows the use of Activity tracking without persistent storage. This will ultimately allow enabling Activity tracking for all Canary and Dev users, as well as across all process types, and for all platforms that use Crashpad for crash reporting. Change-Id: Ie000a00a027348ab877a5fcefc0f019333475e94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974671Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#731539}
-
Lan Wei authored
When I tried to run mouse event wpt tests manually with mouse wheel, uievents/order-of-events/mouse-events/wheel-basic-manual.html uievents/order-of-events/mouse-events/wheel-scrolling-manual.html I got the error "Harness status: Error done() was called without first defining any tests". I create a test object inside these two tests and call done() with these test objects. Bug: 1040611 Change-Id: I1f11f1587540fb335f4361b2cbbd88c8794a5d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993117Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#731538}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=alemate@chromium.org Bug: 1041419 Change-Id: Idb09397d39d80887de5a4f6ded65b8919b9a9655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998065 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=msw@chromium.org Bug: 1041419 Change-Id: I507908a5e214b18e9431e2686980c353e6e92178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998281 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#731536}
-
Kurt Horimoto authored
This util file contains CreateAggregateMediatorSupport() which is used to aggregate OverlayRequestSupport from an array of supported mediator classes. Bug: 1030357 Change-Id: I46369a084b716b9c059901be4a1e76b5ab9858e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996264 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#731535}
-
Klaus Weidner authored
This appeared to be the preferred name based on discussions in the community group. This is a separate CL since it's a somewhat noisy mechanical change. Bug: 991747 Change-Id: Ic3bce2459703168f014526dc5e20a7f0f3af1567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974684 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#731534}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I8852f390bf39402c8e8374d72b17b0bddcaeea34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001098Reviewed-by:
-
Piotr Bialecki authored
This reverts commit 3e21b750. Reason for revert: Prevents Chrome Canary rollout to Play Store (http://b/147660531). Original change's description: > Reland "Move away from using DFM to distribute AR-related code" > > This is a reland of cd842897 > > Original CL caused Chrome Canary to be rejected from Play Store. > Play Store validates whether ARCore SDK's manifest entries are present > only for applications that contain entry about ARCore being either > required or optional. > > Additional changes needed for reland: > - ArCoreShimImpl.java should not be included in java_sources - it will > be brought in by ar_java target on supported configurations since > it depends on ARCore SDK which is included only for specific targets > - relaxed the change in arcore_consent_prompt.cc - the original change > would cause builds that are not supporting ARCore (by design) to > crash > > Original change's description: > > Move away from using DFM to distribute AR-related code > > > > This change will make Chrome for Android stop using DFM to ship the > > ARCore SDK. This is done to enable us to provide AR experiences for > > apps using WebView. The changes are introduced in a way to enable us to > > switch back to using AR DFM if need be. > > > > Changes summary: > > - chrome_java target (defined in chrome/android/BUILD.gn) now also > > compiles ArCoreShimImpl.java (see java_sources.gni) - this means that > > java parts from ARCore SDK have to be added to its deps > > - libarcore_sdk_c.so needs to be listed in loadable modules - this is > > done in monochrome_public_common_apk_or_module_tmpl (only if target > > is a base module when ARCore is enabled) > > - AndroidManifest.xml no longer needs to contain the min_apk_version > > and InstallActivity entries explicitly - they will be brought in > > auto-magically by the build system and were needed only because > > manifest merging did not work for DFMs > > - ArCoreInstallUtils (java) should never report that we can request > > installation of AR DFM > > - ArCoreConsentPrompt (native) should never think it needs to request > > installation of AR DFM > > - Added a DCHECK and graceful handling of null jstring for java_path > > (path to ARCore SDK .so) - it can be null if loadable_modules do not > > contain correct entry - with the DCHECK, debug builds will still > > crash but the release builds should just report that the WebXR > > specified session configuration (session mode == "immersive-ar") is > > not supported > > > > Binary-Size: Tracked in crbug/1040289 > > Bug: 1031623, 1040289 > > Change-Id: Ia2f305d1685f1c7207cc187d253f59a6331c36fc > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988834 > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Alexander Cooper <alcooper@chromium.org> > > Auto-Submit: Piotr Bialecki <bialpio@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#729818} > > Binary-Size: Tracked in crbug/1040289 > Bug: 1031623, 1040289 > Change-Id: I87eac0bc3748973e22190c6dba1187e822f83082 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995769 > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Alexander Cooper <alcooper@chromium.org> > Commit-Queue: Piotr Bialecki <bialpio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#731011} TBR=tedchoc@chromium.org,bialpio@chromium.org,alcooper@chromium.org Change-Id: I7a17c13377ed1eb93a2e7586ae8269bc103d8035 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1031623, 1040289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001066Reviewed-by:
-
Dan Beam authored
This reverts commit 60dfcf2f. Reason for revert: FAILED: ../../third_party/perfetto/src/protozero/message_unittest.cc:298:40: error: expected '(' for function-style cast or type construction MessageHandle<FakeRootMessage> handle(msg); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ../../third_party/perfetto/src/base/test/utils.h:34:30: note: expanded from macro 'EXPECT_DCHECK_DEATH' GTEST_EXECUTE_STATEMENT_(statement, "PERFETTO_CHECK") ^~~~~~~~~ 1 error generated. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8891267197314487504/+/steps/compile/0/stdout Original change's description: > Add fake typed TRACE_EVENT macros for IOS and NACL builds. > > This allows users to not care if tracing is supported on their system. > > Bug: 916074 > Change-Id: I69aa8178bb19f1a65186a2aba4f08699b6ba6ee3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953210 > Reviewed-by: Stephen Nusko <nuskos@chromium.org> > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Commit-Queue: Stephen Nusko <nuskos@chromium.org> > Auto-Submit: Stephen Nusko <nuskos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#731514} TBR=eseckler@chromium.org,nuskos@chromium.org Change-Id: Ia0cc5d2a330a408898c6248378726e43ddd8a732 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 916074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000964Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#731531}
-
Krishna Govind authored
TBR=kariah@chromium.org Change-Id: Ibfdf0eed9b30ae1fdac375a50454f55ba45df235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999446Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#731530}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=takumif@chromium.org Bug: 1041419 Change-Id: Ife4a250bf109ae1137c17113f633be6ae0680ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997813 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#731529}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=dougt@chromium.org Bug: 1041419 Change-Id: I5e14d61cfcd41ca650b14bda2c9ddf9cc356ea61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998558 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#731528}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/488d35ac0b1c..9f1e03b61de8 git log 488d35ac0b1c..9f1e03b61de8 --date=short --first-parent --format='%ad %ae %s' 2020-01-14 chrisforbes@google.com Add initial stub implementation of AHB Created with: gclient setdep -r src/third_party/swiftshader@9f1e03b61de8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I62da0a74953e17b3be1dc80eef0585312ecb145a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999954Reviewed-by:
-
Daniel Cheng authored
Most of the time, the only changes required are in the .cc. On some occasions though, the header also needs to be updated. It doesn't really make sense to get two reviewers for the case where the header needs to be updated too, so just consolidate ownership. Bug: 1012033 Change-Id: If8179bda928782f182ac086f73ca75415a2641a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993878 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
