- 21 Nov, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605895128-ea3f86e674d4361d5284b25de8910e19181b674b.profdata to chrome-linux-master-1605916713-42186a780bbf4a6606356f169d60384bd3619cf2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8c71f1248ea776c8ffc1057af767f9e8d944f7bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552725Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829935}
-
Julie Jeongeun Kim authored
This CL converts ExtensionMsg_SetSessionInfo to mojo and introduces channel_mojom_traits.h to convert version_info::Channel to extensions.mojom.Channel. Bug: 1146103 Change-Id: Iacc3d116bf08a7f32eadb5066cd9690b3aec89ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548943 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#829934}
-
David Tseng authored
This change builds on top of the logic to enqueue utterances for tts platforms (which are interfaces to native tts api for that platform) while initializing/loading. It adds the same treatment for TtsEngineDelegate, which is responsible for built-in tts engines shipped as extensions for each platform. This starts off for built in engines on Chrome OS, but can encompass the network tts engine we ship for other platforms. The new behavior will be to enqueue until the built-in engine(s) are ready; readiness is signaled by detecting at least one voice for the built-in engines (Googletts/Espeak). Note it can be uninitialized in this scheme. R=dmazzoni@chromium.org Change-Id: Ie681e5830909245b566969b491043225c0640be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552369 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#829933}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I822c4c6f4db2012091eea993c28681a9f8c0a7d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550612Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1605895128-00d55e6bb356ebbc13be21f27095ad3409f51b0e.profdata to chrome-mac-master-1605916713-5c2651f0c6431583f545a63fcbde858a51a7c7b1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If268008d1a40a45939a4ab6cd9060bd60b6847c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552932Reviewed-by:
-
Eugene Zemtsov authored
This is an improved version of crrev.com/827150. The original CL caused test flakiness and was rolled back. Bug: 1119892, 1146168, 1148686 Change-Id: I37a39c679b62eddd22bc1be88d9a939da20fc434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549830 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#829930}
-
Scott Violet authored
When 'overflow: clip' is set along a particular axis, scrollWidth/Height should return the overflow size. BUG=1087667 TEST=external/wpt/css/css-overflow/overflow-clip-scroll-size.html Change-Id: I447d6249ca0234c491521d42b1139e415b78bcbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531117 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#829929}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605884021-38c8ae5c2e6706d9e606dfe2bcddc4d1100361a4.profdata to chrome-win64-master-1605895128-0d0cfee41041bede7470dc9636efcf6ef0284e30.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6a4b8849c5c6eb1cb95a894a6d11ee30601c7efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552449Reviewed-by:
-
Ahmed Fakhry authored
This is a reland of https://crrev.com/c/2548880 which was reverted due to a flaky test. The flakiness root cause was resolved in https://crrev.com/c/2552921. Therefore, there're no changes in this CL from the original. TBR=jamescook@chromium.org, poromov@chromium.org, isandrk@chromium.org, bmalcolm@chromium.org Original CL description: Capture Mode should be disabled when the `kDisableScreenshots` policy is disabled. It also should be disabled when a tab requests to be in a locked fullscreen mode, and any on going recording should be interrupted. BUG=1150585 TEST=Existing, and added a new test. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548880Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Brian Malcolm <bmalcolm@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#829390} Change-Id: If427589bcaf9837d0def703dbeff6fc03b8167cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552215Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#829927}
-
James Cook authored
Attempting to open a downloaded file from the download shelf would trigger a DCHECK because I was using the file manager mojo remote on the wrong thread. The code is asynchronous already, so post a task to the UI thread to do the work. Bug: none Change-Id: Ib43969c51b479ab4bbfecc7198eea7d1a193a1cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553082 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#829926}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8a682e08..67965b97 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3e7538b632b0eb6b89e20d5bfc61c99ad091e8d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552885Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829925}
-
Michael Hansen authored
This updates the layout of the contact visibility page to show the "no contacts" state on its own without the description text above it, and switches out the iron-list for a dom-repeat so that we can let the entire content area scroll so that you can see more contacts at once. Screenshots: https://screenshot.googleplex.com/7V92cx9RbcrXUXx.png https://screenshot.googleplex.com/C2cmhbM2GEAAhY4.png Bug: b:168841167 Change-Id: Iaddbd317a9a167ee6193ca9afc0d1ac08397b132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548454 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#829924}
-
Xing Liu authored
The code that uses this enum is deleted in: https://chromium-review.googlesource.com/c/chromium/src/+/2486031 This CL marks the enum deprecated in enums.xml. TBR=bcwhite@chromium.org Bug: 1130635 Change-Id: Ib148fc0e6632aa5fc70db2c8c5d82e88a59178c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551297Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#829923}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c4ca12e32e6a..040de9214830 2020-11-20 courtneygo@google.com Vulkan: Move FenceRecyler to CommandQueue. 2020-11-20 cnorthrop@google.com Capture/Replay: Limit GL_MAX_IMAGE_UNITS further 2020-11-20 jmadill@chromium.org Trace Tests: Screenshot within the render loop. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Test: Test: LEGO MEC Change-Id: Ia09078d0510390fec7d30f143cdd17f8a494c124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552177Reviewed-by:
-
Sam Maier authored
Bug: 1151350 Change-Id: I913b01265232168fcf3833bc59f4d343501a75b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553001 Auto-Submit: Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#829921}
-
Peter Wen authored
As recommended in the lint README, lint-suppressions.xml should only be used for temporary and permanent ignores, not for old code that should be fixed at some point: https://chromium.googlesource.com/chromium/src/+/master/build/android/docs/lint.md Thus, bulk-moving ignores for old code into lint-baseline.xml. The one exception is for UnusedResources, since having these checks in lint-baseline.xml causes a lot of bloat in terms of lines since each language's xml file is listed on a separate line for every resource. Bug: 1069186, 1077861, 1116130, 1085410, 1039415 Fixed: 1069186, 1085410 Change-Id: Iac10f4dc087e12b43595aae154dc7ffb821f2325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552853 Auto-Submit: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/16973d613fed..8f8e2dc7d50f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I528774ac7c0b843af830e1ae05b848a745ccf4fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551517Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ce4be1e64050..4d62438ecdeb 2020-11-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 7ffc87db..81ed1058 (829478:829759) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I812fc276305fcb5eaa811972fec50ef74ad0130a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552900Reviewed-by:
-
David Van Cleve authored
This CL updates blink::SecurityOrigin and url::Origin to include port-0 origins' ports in their serializations. Right now, url::SchemeHostPort has the following control flow: serialize the scheme and host if port == 0, return if there's a default port for the scheme, and the port is not the default, serialize the port The port == 0 branch was previously necessary because blink::SecurityOrigin didn't support port-0 origins and some tests compared blink::SecurityOrigins' serializations to those of url::Origins. With crbug.com/1136678 fixed, blink::SecurityOrigins now support port 0 and we can update the serialization behavior in blink::SecurityOrigin and url::Origin simultaneously to be the above pseudocode with the "port == 0" branch removed. Test: Adds unit tests covering port 0 serialization Change-Id: Ide11b75302a1abda7a602b24678e2985bfe39e3b Fixed: 1136966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472446 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#829917}
-
Arthur Eubanks authored
Some configurations are hitting the current 12 hour timeout limit, like the ToT Clang Mac ASan bot. Bug: 1151435 Change-Id: I3527d18ddfb0d135ea8afc5e66e35d42d758e416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553186Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#829916}
-
Hirokazu Honda authored
V4L2VEA DCHECKs both bitrate and framerate are more than zero. It depends on clients and can be false due to an issue. We would rather checks it by if-clauses and skips if they are invalid. Bug: b:173420909 Test: meet.google.com on trogdor Change-Id: I0f3776368b782c8bb2691dbc5e49ebc22cf16d1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548583 Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#829915}
-
Christopher Cameron authored
Several callsites only use ImageData::GetSkImageInfo in the process of retrieving all of the relevant information to construct a SkPixmap. TBR=yiyx,fserb Bug: 1150969 Change-Id: I3a44bcb8ab357559f4f16d749b5abf8b69136f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552999Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#829914}
-
Jesse Schettler authored
Ensure the scrollbar is always visible when scanned images extend beyond the app window. Bug: 1059779 Change-Id: I6aca5b1ffa478e1cfff4d5f081e92f79a86eb535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552214 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#829913}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b69a9d48bf17..c5a37b1d7286 2020-11-20 egdaniel@google.com Revert "Move vulkan memory uma stats to report on submit." 2020-11-20 johnstiles@google.com Enable SPIR-V disassembly output from skslc. 2020-11-20 johnstiles@google.com Revert "SkSL: Test/implement "geometric" intrinsics" 2020-11-20 robertphillips@google.com Revert "Hook up ShaderErrorHandler in the Metal backend." 2020-11-20 robertphillips@google.com Revert "Remove legacy SkImage::MakeFromYUVATextures." 2020-11-20 robertphillips@google.com Remove uses of SkCanvas::flush 2020-11-20 mtklein@google.com tweak SkVMBlitter for paints with no shader 2020-11-20 johnstiles@google.com Factor out redundant code for compiling GLSL/Metal/SPIR-V/CPP/H files. 2020-11-20 michaelludwig@google.com Don't allow replaceClip to exceed bitmap device size 2020-11-20 adlai@google.com Spruce up iOS viewer and cut CPU drain 2020-11-20 jvanverth@google.com Hook up ShaderErrorHandler in the Metal backend. 2020-11-20 brianosman@google.com SkSL: Test/implement "geometric" intrinsics 2020-11-20 reed@google.com resolve filterquality up front in imageshader 2020-11-20 brianosman@google.com SkSL: Reduce default heap usage, improve heap benchmarks 2020-11-20 johnstiles@google.com Reland "Remove inliner from IR generation stage." 2020-11-20 robertphillips@google.com Update GrProgramInfo's constructor 2020-11-20 michaelludwig@google.com Revert "Simplify layer bounds syncing and no-device error handling in SkCanvas::internalSaveLayer" 2020-11-20 egdaniel@google.com Move vulkan memory uma stats to report on submit. 2020-11-20 bsalomon@google.com Remove legacy SkImage::MakeFromYUVATextures. 2020-11-20 johnstiles@google.com Allow swizzle optimizations to apply to any 'trivial' ctor fields. 2020-11-20 johnstiles@google.com Enable Mac to build with SK_VULKAN enabled. 2020-11-20 egdaniel@google.com Pass in the color load op to GrProgramInfo. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1151195,chromium:1151270,chromium:1151294,chromium:1151320,chromium:1151322 Tbr: lovisolo@google.com Change-Id: Id87f7f9fb5200a36243fb06793b85a298d0f0224 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553121Reviewed-by:
-
Khushal authored
This is dead code since we use OOPR by default now. R=boliu@chromium.org Bug: 1151490 Change-Id: I860a440064e67c4561f016292d37d45d0dfeeb90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552889 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#829911}
-
Olivier Yiptong authored
This CL implements a Chrome UI that allows users to pick one or more fonts, resulting from a request originating from a Blink API call. This change implements a multi-select chooser that offers the option to "import" fonts to sites as well as the ability to cancel. It is implemented as a permission bubble initially. Fixed: 1138621 Change-Id: I9f4a0bd7a990823d2de0c19372cbedc4e811d7d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543603 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a08962107ef6..cd00d19b5ae3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tbansal@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1127088,chromium:1138953 Tbr: tbansal@google.com Change-Id: I3825cbb3b9e41e84a9426ae7e4867116b50cba37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552178Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829909}
-
Tom Anderson authored
* Removes the concept of "overridden dispatchers" and converts the few usages to event observers instead. * Removes Linux.X11.ServerRTT histogram as it has expired. R=sky NOPRESUBMIT=true Bug: None Change-Id: I14837f7dddc5876f1c72cda23a702e6a8e0a5966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552714 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#829908}
-
Hiroshige Hayashizaki authored
To unify how V8CacheOptions is set across classic script evaluation code paths. Bug: 1111134 Change-Id: Ie84d896775951a2eb31bfaa23251c99fe3372ea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541362Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#829907}
-
Curt Clemens authored
The illustration is part of an iron-iconset. For whatever reason, <use> tags don't work inside iron-iconset, so strip those out and replace them with the actual path definitions. Bug: 1151511 Change-Id: Ic4a8d21e7f079f61c3cfb91bafba0daff141bdf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552965Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#829906}
-
Chris Thompson authored
Manually tested that the crash is fixed and no negative effects. Bug: 1150751 Change-Id: Id46097e62f3e826fb42abb4d65f0e7f0c2691570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553004Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Chris Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#829905}
-
Olivier Yiptong authored
This implements the blink portion of the API to trigger a font chooser. This extends the previous stub to communicate with the Browser process. The content/embedder side will be extended in a future CL to complete the implementation end-to-end. Bug: 1138621 Change-Id: I0d5206b10566eed6a40227f994523cabaf3e0913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538143 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
-
James Cook authored
After discussion with security team and the files team, we want to avoid using hard-coded /home/chronos/user/MyFiles paths in lacros. Instead, have ash-chrome pass the paths to lacros-chrome at startup over mojo. This also avoids making the exact path an implicit API contract between ash and lacros. If a future Chrome OS release moves the directories to new locations, lacros will follow along. Ash currently uses /home/chronos/u-<hash> for paths. The security folks would like to switch to /home/user/<hash>, but ash doesn't use those yet. Once ash switches, lacros will automatically follow. We have to leave a few references to /home/chronos/user in lacros for now, until we drop support for Chrome OS M89 and can be sure that ash always sends the default paths. crbug.com/1150702 tracks clean up. Because unit tests are not launched by ash, we override the default paths for documents and downloads in the test harness, to simulate how ash launches lacros in production. Bug: 1150575 Test: added to unit_tests Change-Id: Ifcf637dcbdcb91fa5bb7f3b81c161e3ce87c7e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495961 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
-
Max Moroz authored
R=inferno@chromium.org TBR=dpranke@chromium.org Change-Id: I56d6684addf8e7f9c16dca2d963e01c0c8020b99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553147Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#829902}
-
Tom Anderson authored
The old code used dlsym(RTLD_DEFAULT), which will attempt to obtain the symbol from libraries already loaded. This works most of the time because Xlib gets loaded by eg. GTK, but in cases where Xlib is not already loaded (eg. certain ChromeOS setups), XFree will not be found, leading to a crash. The fix is to switch to the existing xlib_support which internally does dlopen("libX11.so.6") so it shouldn't have this issue. R=sky Bug: 1150918 Change-Id: I82d28cf86e187cc1213b607482f7bd1f4a8e2287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552209 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: -
Dominic Mazzoni authored
This is a quick fix for a performance issue that we've seen in several cases but is particularly bad for one Android app on Android TV. Whenever a node in the accessibility tree changes, we fire a TYPE_WINDOW_CONTENT_CHANGED accessibility event, which is needed for Android to clear its accessibility cache. However, when a major change to a web page happens and a lot of events are fired on different nodes, the overhead of firing an event on every single node is much too high and just ends up slowing the device to a crawl or causing an ANR. The alternative is to just fire TYPE_WINDOW_CONTENT_CHANGED on the root, invalidating the whole WebView. This is inefficient compared to invalidating just one node, but much more efficient than individually updating hundreds of nodes. What this patch does is add some really simple and quick logic to count how many WINDOW_CONTENT_CHANGED events we're firing within a single accessibility tree atomic update, and when we reach some maximum it fires an event on the root and then suppresses further events of this type until the next update. It might be cleaner to move this logic to AccessibilityEventDispatcher instead in the future, but for now this is the most straightforward fix and it results in a big performance improvement in practice. is changing Bug: b/159131746 Change-Id: Ic04f5e87a205e80f460715de14f99de70a0cf90e AX-Relnotes: improves performance on some Android pages when lots of content Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552897 Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#829900}
-
Alison Maher authored
Forced colors should now happen at used value time. This change adds an internal property to store the forced colors value of border-color. This internal value is then applied to the visited /unvisited border-bottom-color, border-top-color, border-right-color and border-left-color at used value time when appropriate. The other forced color properties will be moved in follow up changes. Bug: 970285 Change-Id: If2da52205595edf38b5009adaedcb0008c87d0e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511858 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#829899}
-
Sinan Sahin authored
This CL also includes a bug fix for the show/hide animations so that the "message dismissed" callback isn't called for animations that don't actually hide the message. Bug: 1137941 Change-Id: I8286feacf03196879642870ce5d582910d8df01e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538338Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#829898}
-
Yue Li authored
Bug: 1149455 Test: None Change-Id: Ibf022a85132defcbbda53326da21d13287cb3210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546171 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#829897}
-
Kyle Horimoto authored
WireMessage protocol v3 used an unsigned 16-bit integer to represent the message length. Unfortunately, when big messages are sent (e.g., images sent through Phone Hub), the size can exceed the maximum value of a 16-bit int, so the protocol breaks down. This CL introduces v4, which uses an unsigned 32-bit integer to represent the message size. For backward compatibility, we still use v3 to send messages used for authentication, Smart Lock, and Instant Tethering. If a message is sent for any other feature type, we use v4. Bug: 1150565, 1106937 Change-Id: I2e074505f8efa8a6a7ba355229e8cd0adf7e7c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552250 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
