GitLab

The problem is that calling hide/cancel on a popup is async.

With two popups, you would get

Previously:
SHOW A
HIDE A
SHOW B
NOTIFY SELECTION A
HIDE B
NOTIFY SELECTION B

When notifying the selection of A in the above scenario, it was
clearing the frame pointer (and actually updating the wrong popup).
Then when hiding the second popup, it's reference was actually gone
already.

Fix this by making the call to hide sync instead of async.

BUG=416354

Review URL: https://codereview.chromium.org/603303002

Cr-Commit-Position: refs/heads/master@{#296826}

We won't launch this feature for M39, so disable public opt-in flag.

BUG=416664

Review URL: https://codereview.chromium.org/610443002

Cr-Commit-Position: refs/heads/master@{#296825}

I missed this one when I was reformatting the controlled settings.

BUG=417624

Review URL: https://codereview.chromium.org/601283004

Cr-Commit-Position: refs/heads/master@{#296824}

It is impossible to whitelist an extension which is note a component, when the
api is restricted to components. Since we need to whitelist such regular
extension, this patch removes the location restriction and whitelists all
clients of this API.

Along the way, id testing extensions using this api has been changed to a new
one, since it was reused with other tests not related to the api.

TEST=browser_tests: *FileBrowser*, *FileManager*
BUG=None

Review URL: https://codereview.chromium.org/601103002

Cr-Commit-Position: refs/heads/master@{#296823}

Move initializeChildFrame from RenderFrameImpl to RenderFrameProxy.  Replace RenderFrameImpl::OnSwapOut's call to setIsRemote with WebRemoteFrame::initializeFromFrame that was introduced in part 1 of this change (https://codereview.chromium.org/591413004/)

This will be followed by another CL that will remove setIsRemote on the blink side.

BUG=416102

Review URL: https://codereview.chromium.org/592263002

Cr-Commit-Position: refs/heads/master@{#296822}

The "snionly" tag only applies to preloaded values and only affects
people who are forcing SSLv3 on the command line. (We no longer have the
option in the preferences to disable TLS and the preference has been
renamed so even those who might have set it in the past shouldn't have
it now).

It also complicates pending work to reduce the size of the preload data.

BUG=102779
R=eroman@chromium.org, rsleevi@chromium.org

Review URL: https://codereview.chromium.org/578553004

Cr-Commit-Position: refs/heads/master@{#296821}

It doesn't work, and it is no longer used.

BUG=416208
R=cpu@chromium.org, jam@chromium.org

Review URL: https://codereview.chromium.org/601563002

Cr-Commit-Position: refs/heads/master@{#296820}

BUG=416722
R=gab@chromium.org, robertshield@chromium.org

Review URL: https://codereview.chromium.org/603803002

Cr-Commit-Position: refs/heads/master@{#296819}

It's possible to get a copy of an answer from previous matches and get the
same answer attached to a similar server-provided answer.  In the future,
we may decide that we want to have different answers attached to multiple
suggestions, but the current assumption is that there should only ever be
one suggestion with an answer.

BUG=

Review URL: https://codereview.chromium.org/603683004

Cr-Commit-Position: refs/heads/master@{#296818}

BUG=

Review URL: https://codereview.chromium.org/598223003

Cr-Commit-Position: refs/heads/master@{#296817}

BUG=325045

Review URL: https://codereview.chromium.org/604903005

Cr-Commit-Position: refs/heads/master@{#296816}

Exclude more targets from openssl build.

BUG=none
TEST=none
R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/602433002

Cr-Commit-Position: refs/heads/master@{#296815}

Brings in the following changes:

commit 87b96db4268293187d7cf741907a6d5d1d8080e0
Author: agl@chromium.org <agl@chromium.org>
Date:   Thu Sep 25 20:28:09 2014 +0000

    Update to NSS 3.16.7.

    This contains a fix for the RSA signature forgery bug (CVE-2014-1568):
    https://www.mozilla.org/security/announce/2014/mfsa2014-73.html

    Chrome and ChromeOS have already released updates containing this fix:
      http://googlechromereleases.blogspot.com/2014/09/stable-channel-update_24.html
      http://googlechromereleases.blogspot.com/2014/09/stable-channel-update-for-chrome-os_24.html

    https://codereview.appspot.com/142600043/

    (This the SVN version of the git change, referenced above. It seems that the
    NSS git is still a mirror from this SVN repo and thus one cannot commit to it
    directly.)

    git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/nss@292145 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

BUG=414124

Review URL: https://codereview.chromium.org/603153004

Cr-Commit-Position: refs/heads/master@{#296814}

This brings in the following changes to the addin:
r1578 Add default compiler include paths to visual studio
r1577 Cleanup create_package.py
r1576 Fix several issues with debugging PPAPI plugins
r1575 Update versions used for testing the addin
r1574 Only skip uploading of addin if the file already exists on google storage.

BUG= https://code.google.com/p/chromium/issues/detail?id=179121
R=binji@chromium.org

Review URL: https://codereview.chromium.org/604083003

Cr-Commit-Position: refs/heads/master@{#296813}

BUG=417892
TBR=fsamuel@chromium.org

Review URL: https://codereview.chromium.org/604103004

Cr-Commit-Position: refs/heads/master@{#296812}

Without this, Chromecast apps will not have time to handle
window.unload events when user switches to a new app.

R=lcwu@chromium.org,byungchul@chromium.org
BUG=400876

Review URL: https://codereview.chromium.org/601293002

Cr-Commit-Position: refs/heads/master@{#296811}

This reverts commit 3d148e7d.

BUG=417597
TBR=bauerb@chromium.org,dhnishi@chromium.org,cpu@chromium.org

Review URL: https://codereview.chromium.org/595213006

Cr-Commit-Position: refs/heads/master@{#296810}

Use it at appropriate places.
Also add corresponding UMA histogram value.

BUG=416233

Review URL: https://codereview.chromium.org/586223002

Cr-Commit-Position: refs/heads/master@{#296809}

Review URL: https://codereview.chromium.org/599633005

Cr-Commit-Position: refs/heads/master@{#296808}

Blocking renderer->plugin messages can be interrupted by any message
from the plugin->renderer (even async ones). So while handline a blocking
message, such as HandleInputEvent or HandleBlockingMessage, it's currently
possible to re-enter JavaScript. This patch makes that impossible by
queueing up Plugin->Renderer messages sent via PPB_Messaging::PostMessage
while any renderer->plugin sync message is on the stack.

BUG=384528

Committed: https://crrev.com/f73075c99b5ba30e8d62dc5f13fdfb210d0fc506
Cr-Commit-Position: refs/heads/master@{#296311}

Review URL: https://codereview.chromium.org/589213003

Cr-Commit-Position: refs/heads/master@{#296807}

Bunch of includes are actually unnecessary, simply removed them.

For the fullscreen state, I believe FullscreenNotificationBlocker
can handle it correctly. MessageCenterNotificationManager doesn't
have to handle it anymore.

BUG=None
R=dewittj@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/604453002

Cr-Commit-Position: refs/heads/master@{#296806}

Previously 4096 bytes write buffer was used for XMPP socket. Problem is
that ChromeAsyncSocket stops writing when the buffer is full and
talk::XmppClient ignores this error, as result random chunks of data may
be lost. This CL increses buffer size to 64k - same value that's used in
notifier::XmppConnection.
This is essentially a temporary workaround until the problem is fixed
in jingle::ChromeAsyncSocket or talk::XmppClient

BUG=417336

Review URL: https://codereview.chromium.org/608613002

Cr-Commit-Position: refs/heads/master@{#296805}

Adding tracking to verify the theory that jankiness of ExtensionMessageFilter::OnExtensionAddListener is because of the observer invocation.

BUG=401560, 417106

Review URL: https://codereview.chromium.org/600213002

Cr-Commit-Position: refs/heads/master@{#296804}

We still need to finish updating the extensions to use these translations.

BUG=416983
TBR=plundblad

Review URL: https://codereview.chromium.org/610453002

Cr-Commit-Position: refs/heads/master@{#296803}

The common string descriptors: iManufacturer, iProduct and iSerialNumber
should be accessible without opening the device. On Linux these can be
read out of sysfs without having access to the usbfs device node. This
is critical on Chrome OS because otherwise the permission broker needs
to be asked for permission to access the device. On other platforms we
fall back to opening the device temporarily. This will stop being the
case on OS X when libusb is no longer used and on Windows this will be
part of the initial enumeration process.

BUG=
TBR=dgozman@chromium.org

Review URL: https://codereview.chromium.org/601073002

Cr-Commit-Position: refs/heads/master@{#296802}

+ Correct the layout and size of the offline icon when getting a DNS_PROBE_FINISHED_NO_INTERNET error
+ Delay AudioContext initialising until required to reduce CPU usage.

BUG=417614

Review URL: https://codereview.chromium.org/601523003

Cr-Commit-Position: refs/heads/master@{#296801}

BUG=414808
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/601283005

Cr-Commit-Position: refs/heads/master@{#296800}

Normally extensions must specify a concrete list of url patterns. But with this
patch, extensions on the whitelist can do:

 "permissions": ["externally_connectable.all_urls"],
 "externally_connectable": {
    "matches": ["<all_urls>"]
  }

and they will be able to be connected to from any url.

Also add an entry to the whitelist for the CryptoToken extension.

BUG=417062,417494

Review URL: https://codereview.chromium.org/599163003

Cr-Commit-Position: refs/heads/master@{#296799}

Make DisplayConfigurator save the requested display power
state even when it fails to configure CRTCs. This lets the
previously-requested state be used for future mode changes.

BUG=chrome-os-partner:31571

Review URL: https://codereview.chromium.org/597683004

Cr-Commit-Position: refs/heads/master@{#296798}

BUG=416209
TEST=None

Review URL: https://codereview.chromium.org/591803002

Cr-Commit-Position: refs/heads/master@{#296797}

This removes the last files regarding guava since
http://crbug.com/380688 has now been addressed.

TBR=darin@chromium.org
BUG=412673

Review URL: https://codereview.chromium.org/602203003

Cr-Commit-Position: refs/heads/master@{#296796}

There are 3 different sets of callbacks generated by AppKit in response to
swipe events. The previous code relied on assumptions about the timing of the
callbacks. It expected to receive the beginGestureWithEvent: callback before
receiving any touchesMovedWithEvent: callbacks. Yosemite AppKit broke this
assumption.

The new code stops using beginGestureWithEvent: except to determine edge cases
associated with the Magic Mouse, thus removing this implicit assumption.

Because history swiping direction is determined very early on in the life cycle
of the gesture, this CL adds some logic to ensure that the direction isn't
determined prematurely.

BUG=414103
TEST=History swiping should work as expected with both magic mouse and
trackpad.

Review URL: https://codereview.chromium.org/600743003

Cr-Commit-Position: refs/heads/master@{#296795}

Revert of Revert of Revert of Revert of Set the javac target and source to 1.7 (patchset #1 id:1 of https://codereview.chromium.org/603833002/)

Reason for revert:
*Fingers crossed* all the Android builders are on Java 7 now.
Please comment on
https://code.google.com/p/chromium/issues/detail?id=411503#c31 if you see any Android builders failing to compile due to unknown target version 1.7.

Original issue's description:
> Revert of Revert of Revert of Set the javac target and source to 1.7 (patchset #1 id:1 of https://codereview.chromium.org/601983002/)
>
> Reason for revert:
> Broke Android bots:
> http://build.chromium.org/p/chromium.linux/builders/Android%20Arm64%20Builder%20%28dbg%29/builds/2225
> http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/66337
>
> Original issue's description:
> > Revert of Revert of Set the javac target and source to 1.7 (patchset #1 id:1 of https://chromiumcodereview.appspot.com/579543003/)
> >
> > Reason for revert:
> > All the bots have been switched to Java 7 according to https://code.google.com/p/chromium/issues/detail?id=411503#c19
> >
> > Original issue's description:
> > > Revert of Set the javac target and source to 1.7 (patchset #2 id:20001 of https://chromiumcodereview.appspot.com/545363002/)
> > >
> > > Reason for revert:
> > > Not all bots have Java 7 yet :(
> > >
> > > Original issue's description:
> > > > Set the javac target and source to 1.7
> > > >
> > > > BUG=336589
> > > > TBR=yfriedman@chromium.org
> > > >
> > > > Committed: https://crrev.com/165c0f17fe5760a3f346940d4fb2574d62cfe53b
> > > > Cr-Commit-Position: refs/heads/master@{#295162}
> > >
> > > TBR=cjhopman@chromium.org,yfriedman@chromium.org
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=336589
> > >
> > > Committed: https://crrev.com/094138696e943744d1489ebb98276b116eafed99
> > > Cr-Commit-Position: refs/heads/master@{#295165}
> >
> > TBR=cjhopman@chromium.org,yfriedman@chromium.org
> > BUG=336589
> >
> > Committed: https://crrev.com/119c6fa8247481d2e36910d30175d0214fd2ece5
> > Cr-Commit-Position: refs/heads/master@{#296630}
>
> TBR=cjhopman@chromium.org,yfriedman@chromium.org,aurimas@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=336589
>
> Committed: https://crrev.com/8be2c3f7a14b6191a5a38f187346ce4a36997a6e
> Cr-Commit-Position: refs/heads/master@{#296632}

TBR=cjhopman@chromium.org,yfriedman@chromium.org,thestig@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=336589

Review URL: https://codereview.chromium.org/599633006

Cr-Commit-Position: refs/heads/master@{#296794}

R=darin@chromium.org

Review URL: https://codereview.chromium.org/600523002

Cr-Commit-Position: refs/heads/master@{#296793}

is in background in WebView.

Previously, we couldn't trigger renderer's WasHidden/WasShown event in WebView because the compositer can't stop there, so the dedicated pause video IPC message was added as a work around.

Now we override the blink's page visibility, so renderer's onHide/onShow methods could be called, and compositer is still running. This patch

- Call ContentViewCore.onHide()/onShow() in AwContents
- Video playback is changed to hook into WasHidden() in RenderMediaPlayerManager to pause video, and remove a bunch of video pause code in browser side.

So, The pause of video capture and playback are both handled in renderer side now. There is no dedicated pause video IPC message.

BUG=414506

Review URL: https://codereview.chromium.org/570183002

Cr-Commit-Position: refs/heads/master@{#296792}

Also fixes some minor issues with how sizes and visible rects are
handled.

BUG=91208

Review URL: https://codereview.chromium.org/569313003

Cr-Commit-Position: refs/heads/master@{#296791}

This is used earlier in CompositeAndReadback.
Its not used any where now, so removing this.

BUG=

Review URL: https://codereview.chromium.org/604903003

Cr-Commit-Position: refs/heads/master@{#296790}

BUG=None
TEST=manual

Review URL: https://codereview.chromium.org/607593003

Cr-Commit-Position: refs/heads/master@{#296789}

BUG=N/A
TEST=unit tests passed.
TEST=manually confirmed keypad key has isKeyPad modifier.

Review URL: https://codereview.chromium.org/590953002

Cr-Commit-Position: refs/heads/master@{#296788}

HyperlinkTextView moved components in 0e6cd43e; this marks it as being exported for use in other components.

BUG=402485
TEST=component build builds

Review URL: https://codereview.chromium.org/602093004

Cr-Commit-Position: refs/heads/master@{#296787}