GitLab

Follow-up to https://codereview.chromium.org/2730183003:
* The types in IDLTypes.h are traits types with no member functions, so
  using CORE_EXPORT does not have any effect and we can drop it.
* Export the entire NativeValueTraits specializations in
  NativeValueTraitsImpl.h instead of only their nativeValue() member
  functions.
  In addition to avoiding some repetition in the code, doing so also solves
  some linkage issues on Windows with debug component builds, where targets
  such as 'webkit_unit_tests' or 'blink_media_unittests' would fail to
  reference the aforementioned specializations and lead to errors like this:

    FAILED: media_blink_unittests.exe media_blink_unittests.exe.pdb
    E:/b/depot_tools/python276_bin/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False link.exe /nologo /OUT:./media_blink_unittests.exe /PDB:./media_blink_unittests.exe.pdb @./media_blink_unittests.exe.rsp
    V8RecordTest.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: static class WTF::Vector<struct std::pair<class WTF::String,int>,0,class WTF::PartitionAllocator> __cdecl blink::NativeValueTraits<struct blink::IDLRecord<struct blink::IDLString,struct blink::IDLLong> >::nativeValue(class v8::Isolate *,class v8::Local<class v8::Value>,class blink::ExceptionState &)" (__imp_?nativeValue@?$NativeValueTraits@U?$IDLRecord@UIDLString@blink@@UIDLLong@2@@blink@@@blink@@SA?AV?$Vector@U?$pair@VString@WTF@@H@std@@$0A@VPartitionAllocator@WTF@@@WTF@@PEAVIsolate@v8@@V?$Local@VValue@v8@@@6@AEAVExceptionState@2@@Z) referenced in function "void __cdecl blink::RecordTestV8Internal::setStringLongRecordMethod(class v8::FunctionCallbackInfo<class v8::Value> const &)" (?setStringLongRecordMethod@RecordTestV8Internal@blink@@YAXAEBV?$FunctionCallbackInfo@VValue@v8@@@v8@@@Z)

  The exception to the rule here is IDLSequence: since it needs template
  parameters of its own, it is not a full specialization of
  NativeValueTraitsBase, and at least win_clang complains when it is
  exported:

    E:\b\c\b\win_clang\src\third_party\WebKit\Source\bindings\core\v8\NativeValueTraitsImpl.h(289,8):  error: 'dllimport' attribute ignored [-Werror,-Wignored-attributes]
    struct CORE_EXPORT NativeValueTraits<IDLSequence<T>>

BUG=685754
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2742453002
Cr-Commit-Position: refs/heads/master@{#455750}

The issue is that PSS::GetModelTypeStoreFactory requires valid PSS which doesn't
have to be available when sync is disabled (for example in guest mode on
ChromeOS). The reason it is currently wired through PSS is that PSS conveniently
has path and blocking task runner required for ModelTypeStore.

I added static GetModelTypeStoreFactory function that takes profile path and
SequencedWorkerPool. It ensures that, for a given path, all task runners use the
same sequence token and thus properly sequneced. Datatypes that wish to be
hosted in shared leveldb database should use this factory function.

I also fixed issue that backend_map_ is accessed from multiple threads and thus
might get corrupt. I wrapped it into a class with lock.

BUG=688533
R=skym@chromium.org

Review-Url: https://codereview.chromium.org/2732333003
Cr-Commit-Position: refs/heads/master@{#455749}

Add arguments to the editing functions.

BUG=676290

Review-Url: https://codereview.chromium.org/2740833003
Cr-Commit-Position: refs/heads/master@{#455748}

This is one of the few CLs refactoring budget pool mechanisms for the
addition of the new WakeupBudgetPool.

- Move TimeBudgetPool into budget_pool.h to keep task_queue_throttler
size manageable.
- Split TimeBudgetPool into BudgetPool (interface) and TimeBudgetPool
(realisation).

There will be a separate CL uncoupling TaskQueueThrottler from BudgetPool.

R=alexclarke@chromium.org,skyostil@chromium.org

BUG=699541

Review-Url: https://codereview.chromium.org/2741473002
Cr-Commit-Position: refs/heads/master@{#455747}

BUG=NONE

Review-Url: https://codereview.chromium.org/2738183003
Cr-Commit-Position: refs/heads/master@{#455746}

Merge internal change: 149537594

BUG=

Review-Url: https://codereview.chromium.org/2740453006
Cr-Commit-Position: refs/heads/master@{#455745}

This CL exposes the Open in New Tab and Open in New Incognito Tab methods of
the Reading List Coordinator as part of the
ReadingListCollectionViewControllerDelegate.

BUG=676290

Review-Url: https://codereview.chromium.org/2745563002
Cr-Commit-Position: refs/heads/master@{#455744}

instead of removing the tab when a peerconnection is garbage collected
this adds a symbol which removes the tab on click.

BUG=416876

Review-Url: https://codereview.chromium.org/2739443002
Cr-Commit-Position: refs/heads/master@{#455743}

DOMDataStore holds a pointer to a separately allocated DOMWrapperMap (which
itself contains a HashMap with a reference to the actual hashtable). This
reduces the number of heap allocations (and pointers to follow to manage
non-main-world wrappers) by one.

Review-Url: https://codereview.chromium.org/2742553002
Cr-Commit-Position: refs/heads/master@{#455742}

We now use MSVC 2015, which supports expression SFINAE.

Review-Url: https://codereview.chromium.org/2739513003
Cr-Commit-Position: refs/heads/master@{#455741}

There's a situation that hits a DCHECK() in
MediaCustomControlsFullscreenDetector when the video become
fullscreen but the page navigates away before the timer fires.
This CL solves the issue by stopping the timer when the
ExecutionContext is destroyed.

This CL also moves the common parts of MockWebMediaPlayer into
EmptyWebMediaPlayer. There are still some other
MockWebMediaPlayers which will be adopted in a follow-up.

BUG=698034

Review-Url: https://codereview.chromium.org/2729613007
Cr-Commit-Position: refs/heads/master@{#455740}

will enable skia CL https://skia-review.googlesource.com/c/9461/

BUG=

Review-Url: https://codereview.chromium.org/2743533002
Cr-Commit-Position: refs/heads/master@{#455739}

This CL fixes REMOVING_DATA_DIR part.
Conceptually, this splits RemoveArcData() into two methods.
- RequestArcDataRemoval(): Requests to remove the data when possible.
- StartArcDataRemoval(): Actually triggers to remove the data.

Note: the state transition cannot be simplified in this CL yet,
because OnSessionStopped(), it is unknown whether the stop is triggered
by RequestDisable() or not (existing race problem, but not regression).
When its state is fixed, the state transition related to REMOVING_DATA_DIR
can also be simplified.

cf) Part1: crrev.com/2737453003

BUG=657687
BUG=b/31079732
TEST=Ran trybots.

Review-Url: https://codereview.chromium.org/2734873002
Cr-Commit-Position: refs/heads/master@{#455738}

Network traffic annotation added to four files in Safe Browsing.

BUG=656607

Review-Url: https://codereview.chromium.org/2697193003
Cr-Commit-Position: refs/heads/master@{#455737}

BUG=617892

Review-Url: https://codereview.chromium.org/2745513002
Cr-Commit-Position: refs/heads/master@{#455736}

After a recent refactoring, all decisions to fetch have been moved into
SchedulingRemoteSuggestionsProvider. One case fall through the cracks:
clearing suggestions (by sign-in/out) when an NTP is open.

This CL fixes the bug by fetching immediately after suggestions get
cleared.

BUG=698991

Review-Url: https://codereview.chromium.org/2736033004
Cr-Commit-Position: refs/heads/master@{#455735}

Previously, UserClassifier used suggestions impressions as activity
signal. This breaks for condensed NTP when impressions are tied to
opening an NTP.

This CL replaces this signal by clicks. Clicks were previously recorded
and not used. After this CL, impressions will stay being recorded. The
reason is that with further changes in the UI, we may need it again. There is a TODO to remove this metric if not used.

This CL also changes default values for activity metrics. The reason is
to make sure that a new user is classified in the middle class.

Lastly, the CL relaxes the thresholds. Currently, we have 67% rare, 33% active users, 1% active consumers. The aim is to move closer towards 55% / 40% / 5%.

BUG=699021

Review-Url: https://codereview.chromium.org/2732243002
Cr-Commit-Position: refs/heads/master@{#455734}

Remove from the UI the suggestions marked as invalid by the backend content
suggestion service.

BUG=699124

Review-Url: https://codereview.chromium.org/2739873003
Cr-Commit-Position: refs/heads/master@{#455733}

Network traffic annotation is added to network request of sync.

BUG=656607

Review-Url: https://codereview.chromium.org/2707363004
Cr-Commit-Position: refs/heads/master@{#455732}

Add the two AppData files, one for Chromium and one for Chrome. The Chrome one
will be filled with the information from the common/google-chrome/google-chrome.info
file and should reflect the current channel (stable, beta, devel). On the other
side the Chromium one should be a general one and it will be reused by
distributions that are packaging the Chromium themselves.

For AppData specification please see:
https://people.freedesktop.org/~hughsient/appdata/

BUG=654190

Review-Url: https://codereview.chromium.org/2424093003
Cr-Original-Commit-Position: refs/heads/master@{#455457}
Committed: https://chromium.googlesource.com/chromium/src/+/d6807b9a7da70dae9191b93d4ec6157187515078
Review-Url: https://codereview.chromium.org/2424093003
Cr-Commit-Position: refs/heads/master@{#455731}

BUG=chromium:699966
TBR=nednguyen@google.com,eakuefner@chromium.org
NOTREECHECKS=true

Review-Url: https://codereview.chromium.org/2743683002
Cr-Commit-Position: refs/heads/master@{#455730}

BUG=699537

Review-Url: https://codereview.chromium.org/2742583004
Cr-Commit-Position: refs/heads/master@{#455729}

In LayoutGrid::applyStretchAlignmentToChildIfNeeded()
we're subtracting the top and bottom border and padding
to the desired height.
If the height is 0px due to the margins on the item
and not enough space on the cell, and the border or padding
are not 0px, then we end up with negative values.

In this patch we protect the call to setOverrideLogicalContentHeight()
to avoid passing a negative value.

BUG=697317
TEST=fast/css-grid-layout/grid-crash-huge-margins-and-min-height-max-content.html

Review-Url: https://codereview.chromium.org/2744593002
Cr-Commit-Position: refs/heads/master@{#455728}

Start tracking user session initialization in local state and use
that flag to determine whether to force a policy load instead of relying
on the oauth token status. This is important because forcing a policy load
when it's not strictly required can lock users out of their accounts.

This flag is not persisted across restarts of ephemeral sessions (including crash-induced restarts) so policy code will force a policy reload after a crash (identical to previous ephemeral behavior, so no behavior change from this CL)

BUG=684031

Review-Url: https://codereview.chromium.org/2711113003
Cr-Commit-Position: refs/heads/master@{#455727}

BUG=698231

Review-Url: https://codereview.chromium.org/2732213006
Cr-Commit-Position: refs/heads/master@{#455726}

This fix is follow up for https://codereview.chromium.org/2682453002 with
more fixes for keyword conflicts resolution. Previous solution was not
handling correctly conflicting engines in model when updating engine.

BUG=697745

R=pkasting@chromium.org, vasilii@chromium.org

TBR=ananta@chromium.org

Review-Url: https://codereview.chromium.org/2736713002
Cr-Commit-Position: refs/heads/master@{#455725}

BUG=698971

Review-Url: https://codereview.chromium.org/2740653002
Cr-Commit-Position: refs/heads/master@{#455724}

Align implementation with spec change https://github.com/whatwg/fetch/pull/437

PSA at https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/BN6tqGLBmuI

BUG=698521

Review-Url: https://codereview.chromium.org/2732853003
Cr-Commit-Position: refs/heads/master@{#455723}

BUG=687269

Review-Url: https://codereview.chromium.org/2740963002
Cr-Commit-Position: refs/heads/master@{#455722}

https://skia.googlesource.com/skia.git/+log/28b1252bab29..08541e8d7f28

$ git log 28b1252ba..08541e8d7 --date=short --no-merges --format='%ad %ae %s'
2017-03-08 msarett Optimize mipmap downsample_2_2 in sRGB mode

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=djsollen@chromium.org

Change-Id: Ib3e72df71504cce948b864ef0ad1b5cc27392da7
Reviewed-on: https://chromium-review.googlesource.com/451941Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#455721}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/fc069168..fbffc377

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org
NOTREECHECKS=true

Review-Url: https://codereview.chromium.org/2741673002
Cr-Commit-Position: refs/heads/master@{#455720}

Revert of [table] Stretching tables when needed due to self-alignment properties (patchset #6 id:120001 of https://codereview.chromium.org/2528253003/ )

Reason for revert:
This patch is causing several important regressions.

Original issue's description:
> [table] Stretching tables when needed due to self-alignment properties
>
> The Self-Alignment properties, align-self and justify-self, apply to
> tables when they are flex or grid items.
>
> This patch addresses only the issue of applying the stretch value, which
> effectively affects the size of the table in those cases.
>
> The justify-self applies also to tables when they are block-level
> boxes, but the alignment feature is still not implemented for that
> case, so for now the related test cases expect no stretching.
>
> Other values of alignment aren't implemented yet for tables, but those
> will be part of future CLs, once somebody files the appropriated bug.
>
> BUG=667785
>
> Review-Url: https://codereview.chromium.org/2528253003
> Cr-Commit-Position: refs/heads/master@{#454743}
> Committed: https://chromium.googlesource.com/chromium/src/+/a90dba1f2dd094e51229dd2e5e059c6b53cee93a

TBR=svillar@igalia.com,rego@igalia.com,cbiesinger@chromium.org,dgrogan@chromium.org,mstensho@opera.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=667785

Review-Url: https://codereview.chromium.org/2740063003
Cr-Commit-Position: refs/heads/master@{#455719}

Currently error member of RequestCore class not initialized. This cause
MSan error in net_unittests. To fix it was initialized by OK value.

BUG=None
R=asanka@chromium.org

Review-Url: https://codereview.chromium.org/2738513006
Cr-Commit-Position: refs/heads/master@{#455718}

This was used to update the Toolbar state, but the Toolbar doesn't
depend on Instant anymore (and hasn't for a long time).

BUG=627747

Review-Url: https://codereview.chromium.org/2736243002
Cr-Commit-Position: refs/heads/master@{#455717}

This patch is trival and only adds the required code to allow closure to
compile without @unrestricted.

R=lushnikov
BUG=None

Review-Url: https://codereview.chromium.org/2723203003
Cr-Commit-Position: refs/heads/master@{#455716}

RemoteWindowProxy won't have a ScriptState in the future, so move the
DCHECKs so it's possible to continue asserting invariants that should
always hold true in WindowProxy.

BUG=527190

Review-Url: https://codereview.chromium.org/2744483002
Cr-Commit-Position: refs/heads/master@{#455715}

Minor differences on Windows bots.

TBR=xhwang@chromium.org
NOTRY=true
BUG=699573

Review-Url: https://codereview.chromium.org/2741693002
Cr-Commit-Position: refs/heads/master@{#455714}

platform/loader has a BUILD.gn, but it does not contain files for
platform:test_support that can be used in blink_platform_unittests
and webkit_unit_tests. This patch moves platform/loader/ files for
the test_support from platform/BUILD.gn to platform/loader/BUILD.gn.

BUG=699369

Review-Url: https://codereview.chromium.org/2732243005
Cr-Commit-Position: refs/heads/master@{#455713}

This patch moves |textDirectionForSelection()| to |EditingStyleUtilities| class
to "EditorCommand.cpp" since it is used only in "EditorCommand.cpp" for
improving code health.

BUG=657237
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2734043004
Cr-Commit-Position: refs/heads/master@{#455712}

This patch makes |rootEditableElementOrTreeScopeRootNodeOf() | to take
|Position| instead of |VisibleSelection| as preparation of reduce usage of
|VisibleSelection| for improving code health.

This patch also replaces deprecated version of |computeVisibleSelection()|
in |InputMethodController::getSelectionOffsets()| since it is called in
after |computeVisibleSelectionDeprecated()|.

BUG=657237
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2742703002
Cr-Commit-Position: refs/heads/master@{#455711}