- 04 Jan, 2018 40 commits
-
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/2de84c0d21c2..aadff7def3d1 $ git log 2de84c0d2..aadff7def --date=short --no-merges --format='%ad %ae %s' 2018-01-04 perezju [Telemetry] Cleanup cros_browser_backend._GetDevToolsClientConfig Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I11979ce94dcc25f97662923f6b99b2369adaa594 Reviewed-on: https://chromium-review.googlesource.com/850432 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526980}
-
Peter Wen authored
Canary has updated to alpha 4. BUG=620034 Change-Id: Ic8ded85e9a06dd7a4a610145ade1df2a027a60e9 Reviewed-on: https://chromium-review.googlesource.com/847938Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#526979}
-
Gauthier Ambard authored
When the animation to fade buttons out completes, the buttons have a transformation translating them. This translation is canceled in the contract animation. But if the contract animation doesn't occur, the hidden buttons keep this translation, making them visually misplaced. This CL fixes it by resetting the position of all elements in the completion of the animator. Bug: 798981 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If84ab49f9fb1b6971f5901a741004dd4c623dcaf Reviewed-on: https://chromium-review.googlesource.com/849952Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#526978}
-
Julien Isorce authored
This allows to re-use generic GLImageTest templates in tests that requires EGL,GLES2. CQ-DEPEND=CL:817563 gl_unittests --gtest_filter=*GLImage* ozone_gl_unittests Bug: 785201 Tests: Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3ce122b69bef136fdf8c544f0b432d438c528f07 Reviewed-on: https://chromium-review.googlesource.com/832226 Commit-Queue: Julien Isorce <julien.isorce@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#526977}
-
Greg Thompson authored
BUG=NONE R=pastarmovj@chromium.org Change-Id: I29b2b3d2b0ecce290f858043d29e8a82b1b6d3a9 Reviewed-on: https://chromium-review.googlesource.com/849996Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#526976}
-
Boris Sazonov authored
This CL removes unused Context parameter from FirstRunPage.shouldSkipPageOnCreate. Bug: 783344 Change-Id: Ia9acd543dfac368c822e6d1d01ca0f5c42c51856 Reviewed-on: https://chromium-review.googlesource.com/849214 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ted Choc (back but slow, ping me) <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#526975}
-
Dominic Battre authored
TBR=rouslan@chromium.org Bug: 799028 Change-Id: I12904a56860ce6e185f6f9c20d2ebb48b43ab54e Reviewed-on: https://chromium-review.googlesource.com/850552Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#526974}
-
Dominic Battre authored
TBR=nasko@chromium.org,nick@chromium.org,rdevlin.cronin@chromium.org Bug: 799022 Change-Id: I7db594de0aaaecda8d3d7f0bcd8cf8ea16abb3c9 Reviewed-on: https://chromium-review.googlesource.com/850393Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#526973}
-
Vadim Petrov authored
Bug: 797280 Change-Id: Ie05b919e7e5f1aab2ebfc54c5f1dca50b4a18a23 Reviewed-on: https://chromium-review.googlesource.com/842864Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Vadim Petrov <lof84@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#526972}
-
Rune Lillesveen authored
Intent-to-ship thread: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/XzdNrEvn4Qk/650SpqXTBAAJ Bug: 657748 Change-Id: I01a7804d2214ac19fb8f58e1f68c23957cf071f7 Reviewed-on: https://chromium-review.googlesource.com/848920Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#526971}
-
Sriram authored
Upstream the below tests from media/track/ to wpt 1. track-large-timestamp.html 2. track-load-error-readyState.html 3. track-load-from-element-readyState.html 4. track-load-from-src-readyState.html 5. track-mode-disabled-crash.html 6. track-mode-not-changed-by-new-track.html 7. track-mode-triggers-loading.html 8. track-mode.html Bug: 782555 Change-Id: Ic76b8f4d8010650b72c031dec3715d274a02a4ff Reviewed-on: https://chromium-review.googlesource.com/850155Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#526970}
-
Rune Lillesveen authored
When a table part box is removed from the layout tree, we may end up with two anonymous layout part siblings which needs to be merged. We move the children of the latter into the former. When children of the latter are themselves anonymous, skip down the layout tree until we find non-anonymous boxes. This will make sure we merge multiple levels of anonymous boxes although it means we will have to recreate the anonymous ancestors of the moved box when the preceding box we are moving it to does not have anonymous descendants. Bug: 181374 Change-Id: I8a14cec2e036fb4e5b937f89c4a35411dcc98785 Reviewed-on: https://chromium-review.googlesource.com/846861Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#526969}
-
stkhapugin@chromium.org authored
Now that everything in ios/ is built with ARC, it's possible to use __weak everywhere instead of unsafe_unretained, except for where the API dictates otherwise, especially: 1. countByEnumeratingWithState:objects:count: 2. getArgument:atIndex: Bug: 717540 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I700f0ce62f7fd5801c4ed2e9bbfed81065b0bf0f Reviewed-on: https://chromium-review.googlesource.com/845686 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#526968}
-
Dominic Battre authored
TBR=tetsui@chromium.org,hirono@chromium.org Bug: 798772 Change-Id: Ib5190f6f5bd9e1aafbb83d06bc0c5cc07ef4a320 Reviewed-on: https://chromium-review.googlesource.com/850352 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#526967}
-
Miguel Casas authored
This CL reorders the declarations of VaapiWrapper methods to follow their definitions [1]. No new code is intended, just moved around. [1] https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md#code-formatting Bug: Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4c546341f5e26c026c50513468dfa79d77cdfe72 Reviewed-on: https://chromium-review.googlesource.com/848650Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#526966}
-
David Bokan authored
Since telemetry ref-builds have now moved past M63 when this was added, and all dependencies have been updated, we can now remove this flag. Bug: 610021 Change-Id: Ic3c4bf9d7ddc5019e18d187f352f8f477b1f0814 Reviewed-on: https://chromium-review.googlesource.com/846529Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#526965}
-
Dominic Battre authored
If a request is redirected from a Google domain to a non-googel domain, the variation header (X-Client-Data) should not be forwarded to the new server. This is implemented by stripping the header in the ChromeNetworkDelegate when a redirect happens. Bug: 794644 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ie11021509997f03ba886f7ed370a93ecba00519e Reviewed-on: https://chromium-review.googlesource.com/836869Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#526964}
-
Elly Fong-Jones authored
In Harmony, the distance between these two elements is supposed to be 3/4 of a layout unit instead of one layout unit, so: 1) Add DISTANCE_BUTTON_IMAGE_LABEL_PADDING to DistanceMetrics 2) Give it the same default value as DISTANCE_RELATED_CONTROL_HORIZONTAL 3) Add a Harmony value for the new DistanceMetric Bug: 794480 Change-Id: Ib7106612dd2c923386cdbf30219ff37180acdedd Reviewed-on: https://chromium-review.googlesource.com/848533Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#526963}
-
Patrik Höglund authored
This dependency is there because rtc_video_decoder_factory.h and a handful other files include video_codec_interface.h. This header file was not tracked, so this dependency could fly under the radar. Once this is done and landed upstream, I plan to move the header to a smaller more focused target; I will update this dependency then. Bug: webrtc:7620 Change-Id: I995b740d2d2f796c5744c9f86194cd56949e83d3 Reviewed-on: https://chromium-review.googlesource.com/847480Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#526962}
-
Dominic Battre authored
external/wpt/pointerevents/pointerlock/pointerevent_pointerlock_supercedes_capture-manual.html times out on all platforms from time to time TBR=mustaq@chromium.org Bug: 798680 Change-Id: I027df6383fbfe78e7183c8b97d941cbf083a2d01 Reviewed-on: https://chromium-review.googlesource.com/848893 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#526961}
-
Boris Sazonov authored
This CL adds AccountManagerFacadeTest.testGetAccounts(). Bug: 789246 Change-Id: I966d6f96dd0a3aeaa2b47404f54ccf736c95fbcd Reviewed-on: https://chromium-review.googlesource.com/846809Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#526960}
-
Dominic Battre authored
TBR=jam@chromium.org Bug: 798969, 798791 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I03fb83897ffea40444af1f74e1b9f6786c035a70 Reviewed-on: https://chromium-review.googlesource.com/850116 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#526959}
-
“Lalit authored
When a timeout happens, we mark a request as complete and fail the missing dumps. However, if the response for the request later comes in, we were hitting a DCHECK when there was no queued request or (worse) we were accidentally fullfilling a different request. Make it so that the dump_guid is checked if a response comes in to match the current request if it exists. Bug: 797677 Change-Id: Idce571b43c1c594f5f240d5ea7e7cd6af73bf78d Reviewed-on: https://chromium-review.googlesource.com/847039 Commit-Queue: Hector Dearman <hjd@chromium.org> Reviewed-by:
Hector Dearman <hjd@chromium.org> Cr-Commit-Position: refs/heads/master@{#526958}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0e59efcd..59d313a7 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I66cfed6e45b10d40e0250a5e7b5ad5112bd10ad8 Reviewed-on: https://chromium-review.googlesource.com/848175Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#526957}
-
Sriram authored
Upstream below tests from media/track/opera/interfaces/VTTCue to external/wpt/webvtt/api/VTTCue/ 1. constructor.html 2. Removed getCueAsHTMLCrash.html infavor of getCueAsHTML.html Bug: 782555 Change-Id: Ib4066a2d71b409d870118d1697dca0e10d926668 Reviewed-on: https://chromium-review.googlesource.com/848698Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#526956}
-
Gary Kacmarcik authored
This is a reland of ba383e4b Original change's description: > Update clipboard API calls to use clipboard permissions. > > This adds permission checks to make sure that the user has granted > appropriate permission for the clipboard API methods. > > Bug: 677564 > Change-Id: I5af221b0e18d45509ff2a8c3856680e598a51dcb > Reviewed-on: https://chromium-review.googlesource.com/804973 > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Raymes Khoury <raymes@chromium.org> > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > Commit-Queue: Gary Kacmarcik <garykac@chromium.org> > Cr-Commit-Position: refs/heads/master@{#525516} Bug: 677564 Change-Id: Id2fd27d775d165713fe3a3b3c6b56387da76835b Reviewed-on: https://chromium-review.googlesource.com/846725Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#526955}
-
Wei-Yin Chen (陳威尹) authored
Link triggering logic to the Reader Mode for Accessibility preference. If "Enable simplified view on all articles" is checked, the triggering heuristics would be the same as "All articles" in flags#reader-mode-heuristics. Bug: 777962 Change-Id: I1dc03969978e00754cd04ccaf5979dc614f02eea Reviewed-on: https://chromium-review.googlesource.com/835428 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#526954}
-
Boris Sazonov authored
This CL reimplements how FirstRunActivity passes FRE parameters to FRE pages. Old implementation caused duplicates of parameters to be saved every time activity is recreated. This could lead to the situation when different FRE pages have different FRE parameters. It also simplifies FirstRunPage and removes overrides of Fragment methods. Bug: 783344 Change-Id: I498356901ebb5235b9924ab017aad874488bf9fc Reviewed-on: https://chromium-review.googlesource.com/848813Reviewed-by:
Ted Choc (back but slow, ping me) <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#526953}
-
Jens Widell authored
Many source files declare a namespace alias `errors` for a specific namespace containing error constants. This practice is incompatible with jumbo/unity builds, when different namespaces are aliased. The by far most common namespace to alias is `manifest_errors`. These aliases are kept, since they are not a problem as long as there are no other conflicting aliases. Other aliases are simply dropped, and the full namespace is used instead. Change-Id: Ie90f7e7a8f8be52b811b0b1e9c9839970669d96c Reviewed-on: https://chromium-review.googlesource.com/848918Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Jens Widell <jl@opera.com> Cr-Commit-Position: refs/heads/master@{#526952}
-
Dominic Farolino authored
Bug: 694430 This addresses the WHATWG FETCH specification change outlined by Anne in the bug, to relax the Request constructor to not throw a TypeError when initializing a Request object with a cross-origin referrer R=yhirano@chromium.org Change-Id: I891d2b29b7c21cbeffd9645b9d1daadba63c2358 Reviewed-on: https://chromium-review.googlesource.com/719781 Commit-Queue: Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Cr-Commit-Position: refs/heads/master@{#526951}
-
Dan Elphick authored
The scheduler is now responsible for choosing which BackgroundFetchJobController runs next. It round-robins through the list of job controllers launching at most one download from each at a time. Previously each JobController would get a new request from the DataManager as soon it completed one, meaning that there would be as many active downloads as there are JobControllers. The new scheduler limits downloads globally and so will prevent too many downloads from happening concurrently. BackgroundFetchScheduler gets requests from a RequestManager (implemented by BackgroundFetchDataManager) and delivers them to a Controller (implemented by BackgroundFetchJobController). Also eliminates MarkRequestAsStarted and related functions as we don't do anything with the info. Bug: 757760 Change-Id: I59f68347e93d278285c83351cbe4e1dd22b91b1b Reviewed-on: https://chromium-review.googlesource.com/776666 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#526950}
-
Darin Fisher authored
Changes SharedWorkerService to live as a member of StoragePartition. Bug: 612308 Change-Id: Ib7a115b031e806954f3dc1a17eda2c305b47c3a6 Reviewed-on: https://chromium-review.googlesource.com/847026 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#526949}
-
Gauthier Ambard authored
Bug: 798517 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie796750577450174de605f356ceaa09573952012 Reviewed-on: https://chromium-review.googlesource.com/849835Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#526948}
-
Dominic Battre authored
Disable DeclarativeContentApiTest.{Dis,En}abledForSp{anning,split}Incognito for network_service_browser_tests due to flakiness TBR=jam@chromium.org Bug: 798969 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I0f58b76ba43f2e17b2002ab0d767332f363a8832 Reviewed-on: https://chromium-review.googlesource.com/849834 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#526947}
-
Peter Hanspers authored
Bug: 798687 Change-Id: Idfa075e10f121fd6a7e09ee56f628610f2332ec7 Reviewed-on: https://chromium-review.googlesource.com/848834 Commit-Queue: Peter Hanspers <peterhanspers@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#526946}
-
Gauthier Ambard authored
The trailing edge of the text field should not be touching the trailing edge of the location bar. Bug: 797663 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I44671acf8ad81638c4eb4d1597be1748ea4988ec Reviewed-on: https://chromium-review.googlesource.com/848997 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#526945}
-
Dominic Battre authored
TBR=paulirish@chromium.org Bug: 798957 Change-Id: Ib3f18197024b947d57359514c672310f42b273cc Reviewed-on: https://chromium-review.googlesource.com/848922Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#526944}
-
Gauthier Ambard authored
This CL creates an AbstractPrimaryToolbar protocol and moves some of the methods from the LegacyToolbarCoordinator to it. It also split the uses of the toolbar coordinator in the BVC in three: - The PrimaryToolbarCoordinator, for the calls only related to the primary toolbar. - The LegacyToolbarCoordinator, for the calls which will be deleted once the old toolbar is removed. - The _toolbarCoordinator (current) for the calls which might be going to both toolbars or undecided yet. This separation makes things clearer in BVC. It will allow an easier transition to the adaptive toolbar as the responsibilities will be cleaner. It also moves the OmniboxFocuser and SideSwipeToolbarInteracting protocols to the toolbar/public folder as they are used by the AbstractPrimaryToolbar. Bug: 798418 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I18822be75c483af7f1b810b66c450f521f720b37 Reviewed-on: https://chromium-review.googlesource.com/846993 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#526943}
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib781af0656c2813212eba6d6b68ac94f8ec8fc54 Reviewed-on: https://chromium-review.googlesource.com/848546 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526942}
-
Christian Dullweber authored
It is best practice to have UNSPECIFIED as first value in an enum for consistent behavior between proto2 and proto3. No one is sending these events yet, so changing the proto should be fine. Bug: 781765 Change-Id: I0b045b8654462f694620144a3f83817043c0e914 Reviewed-on: https://chromium-review.googlesource.com/848973Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#526941}
-