- 28 Sep, 2017 40 commits
-
-
Wei-Yin Chen (陳威尹) authored
Bug: 742386 Change-Id: I39a95db12e9ac08ed4d03146eea4ea9d61c15b8d Reviewed-on: https://chromium-review.googlesource.com/667822Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#505115}
-
Matt Menke authored
NetLog needs to be moved into the network service. The first step is removing it from the BrowserProcess. The DialRegistry is now passed a pointer to a NetLog on construction, which is taken from a URLRequestContextGetter. Bug: 767450 Change-Id: I0dd79758dd05d92045cca56286a6dd0c511c1aa4 Reviewed-on: https://chromium-review.googlesource.com/677551 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#505114}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=torne@chromium.org Bug: 666525 Change-Id: I3600da8b60fb8a8a4d3f2c7e119777a4212afc1d Reviewed-on: https://chromium-review.googlesource.com/688767Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505113}
-
Alex Newcomer authored
can change app grid pages New behavior: Scroll events (ET_MOUSEWHEEL and ET_SCROLL) used to modify the app grid if the mouse was over the grid, and modify the AppListState otherwise. Now, we want scroll events to first try to move the grid. If this succeds, set a timer to keep the stream of scrolling events from also closing the AppListView. If the scroll could not move the grid, allow it to modify the AppListState. I used a timer because there is no reliable way to both determine the end of an ET_SCROLL and the end of a mousewheel scroll. We need to avoid acting twice with one user intent to scroll one surface. The behavior of this change was reviewed by UX/PM and approved for M61. Misc refactoring: - No longer need OnMouseWheel/OnScroll in AppsGridView because AppListView will handle all scroll events. - Broke AppListView::HandleScroll into a few different functions because it was starting to do multiple things. - In HandleScroll, also combined mousewheel and touchpad logic to avoid code duplication. - Added tests to AppsGridView while debugging. Also moved the scroll test from FullscreenAppListPresenterDelegateTest to AppListViewFullscreenTest. TEST=manual and automated BUG: 769356 Bug: Change-Id: I15396b9845404d0c13de916e01ef62ea9af22ae8 Reviewed-on: https://chromium-review.googlesource.com/688637 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#505112}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=boliu@chromium.org Bug: 666525 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I13380dbc5c3339e7b7acdd28c574517b668d4cf2 Reviewed-on: https://chromium-review.googlesource.com/689026Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505111}
-
David Reveman authored
This takes advantage of the animated image support added recently to allow users to capture short looping high-quality mini videos as avatar picture. Videos are created using the following parameters: - 10 photos taken over the interval of 1 second. - Stitched together in a seamless forwards/backwards loop. - Playback at 20 FPS. - Final animation time is 1 second. - Playback is 2X the speed of capture. The profile picture UI has been updated to support capture of motion stills by allowing the user to switch between photo and video capture by clicking a button in the camera element. Bug: 763735 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia921646cdfa649cbe7294d521f5d29f0bddc3035 Reviewed-on: https://chromium-review.googlesource.com/635488 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#505110}
-
Xida Chen authored
This reverts commit 801c6e56. Reason for revert: <INSERT REASONING HERE> Causing test failure: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/56070 Original change's description: > [LayoutNG] Fix crash in ResolveInlineLength > > This patch fixes inline blocks with orthogonal writing mode: > 1. Not to crash in ResolveInlineLength. > 2. Uses the correct side of margins for the inline block. > > Bug: 636993 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng > Change-Id: I83abddd8e910985e6f9d9fba9f93954ef038e41d > Reviewed-on: https://chromium-review.googlesource.com/688523 > Reviewed-by: Emil A Eklund <eae@chromium.org> > Commit-Queue: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505069} TBR=eae@chromium.org,kojii@chromium.org Change-Id: I23d249eecdbb3733c3819307a103d0b3e124fb1d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/690854Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#505109}
-
Dan Elphick authored
This fixes a regression introduced in https://chromium-review.googlesource.com/c/chromium/src/+/636288 Also adds a unit test for DownloadDriverImpl::CreateDriverEntry. Change-Id: Ic456b868f5c51cd87cf6534681708f8c252ab9db Reviewed-on: https://chromium-review.googlesource.com/687055Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#505108}
-
Jeremy Roman authored
This replaces the construction (and destruction) of the map at runtime with a linear search of a compile-time constant structure. We could do this with a binary search, but the number of items in these lists is sufficiently small that a linear search is likely to be as fast as std::lower_bound. Since these maps never need to change, we gain memory locality by having the entire map in an array (and that array can be shared between processes). The array also contains the precomputed size of the schema, avoiding the need for a strlen at lookup time to convert from const char* to StringPiece. Finally, the Get function is modified not to do a map lookup twice (one to determine if it's present, and again to retrieve the value), but instead to do the lookup directly. Change-Id: Ia4c4b6a07b15aa81f48e63c5b40dcee912a7d21d Reviewed-on: https://chromium-review.googlesource.com/678017Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#505107}
-
Maks Orlovich authored
This includes stream 0 all the time, and stream 1 if available from a prefetch. This change does regress some zero-length-read type cases from non-idle being sync to reduce code duplication, which may be worth reconsidering and undoing. This also includes a microbenchmark to measure some of our bookkeeping overhead, which is also improved a bit by this, but it's not the sort of numbers (order of half a microseconds) to get overly excited about. Bug: 719979 Change-Id: I1079d023fd3c555a87ae4175225154467243e6e3 Reviewed-on: https://chromium-review.googlesource.com/682139Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#505106}
-
Xida Chen authored
It is flaky TBR=rouslan@chromium.org NOTRY=true Bug: 769851 Change-Id: I4ba160fe8d0916729be86807253c408a4d853404 Reviewed-on: https://chromium-review.googlesource.com/690799Reviewed-by:
-
Sergey Silkin authored
There is bug in AQ in v1.6.0 which causes very poor video quality in WebRTC when packetization mode 0 is used. The issue is fixed in v1.7 (https://github.com/cisco/openh264/releases/tag/v1.7.0). I modified MediaRecorderHandlerTest/EncodeVideoFrames test to make it pass with new encoder. The test expects encoded frame sizes to be equal or bigger than the hard coded thresholds. But due to changes in RC the new encoder uses different QPs. As result there is difference in frame sizes: the second frame produced by the new encoder is 1 byte smaller than the previous version produced. The test failed because of that. I changed the threshold from 13 to 12 bytes to make it work with the new version (it still works with previous version as well). Bug: webrtc:8070 Change-Id: I58f82be70b12f26bea306f7788d33db9aca47856 Reviewed-on: https://chromium-review.googlesource.com/674868Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Sergey Silkin <ssilkin@chromium.org> Cr-Commit-Position: refs/heads/master@{#505104}
-
Friedrich Horschig authored
This CL introduces the name source and methods to record it. Most of the changes are then code to forward the new parameter of the recording method. The updated signature needs rewiring on: - Android NTP chrome/android/ chrome/browser/android/ntp/ - iOS ios/chrome/browser/ - Chrome Desktop chrome/browser/resources/ chrome/browser/search/ chrome/browser/ui/search chrome/common/ chrome/renderer/resources/extensions/ chrome/renderer/searchbox/ Bug: 767402 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id10b344f2280f9859db4c76cafe276e130f5dc53 Reviewed-on: https://chromium-review.googlesource.com/673187Reviewed-by:Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#505103}
-
David Benjamin authored
The Fuchsia code is not using the legacy X.509 stack. Bug: 706445 Change-Id: I6c2cc42bc302c01d38067657317aa1b958442270 Reviewed-on: https://chromium-review.googlesource.com/690376 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#505102}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/3a5e1fee080c..097900648b0b $ git log 3a5e1fee0..097900648 --date=short --no-merges --format='%ad %ae %s' 2017-09-28 borenet Fix path separators on Windows in zip_utils 2017-09-28 mtklein function santizer is not available on Mac 2017-09-28 brianosman Use wider types to compute bounds area and avoid overflow Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I8bb576e4296e83dbd8998e43bc9ce04c7ffc39e9 Reviewed-on: https://chromium-review.googlesource.com/689860Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#505101}
-
Bo Liu authored
These tests got disabled on M and above due to flakes. However now webview tests no longer runs on K cq bot, meaning these tests have no coverage on cq. Tried running looping the 22 tests that are enabled here 50 times locally without any failure. So enable them with RetryOnFailure and see if there are any flakes on bots. Bug: 615483 Change-Id: I3bc20a1e1b89f3b925db3943441a5bd00efb9c9b Reviewed-on: https://chromium-review.googlesource.com/688798Reviewed-by:
Paul Miller <paulmiller@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#505100}
-
Fredrik Söderquist authored
Passing 'this' (which |object| will be in this case) to LayoutObject::NextInPreOrder, will turn it into a non-obvious way of saying FirstChild. Pass |root| instead of |object| to make the traversal actually pre- order. Bug: 769459 Change-Id: I6bc4c487faab053d02bc16826862234f15e2376e Reviewed-on: https://chromium-review.googlesource.com/690254Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#505099}
-
Alexis Hetu authored
Turning on SwiftShader for Layout Tests on Linux. Added expectations for tests which will require rebaselining. Attempting to reland: https://chromium-review.googlesource.com/c/chromium/src/+/651079 TBR=kbr@chromium.org,hubbe@chromium.org TBR_REASON=A few minor changes to content_browsertests which can be followed up on later Bug: 726075 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2c51376975217a7534b728f23c7881b60dd2f025 Reviewed-on: https://chromium-review.googlesource.com/687276 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#505098}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/5f95f36cac52..79eab23d8f83 $ git log 5f95f36ca..79eab23d8 --date=short --no-merges --format='%ad %ae %s' 2017-09-28 npm Add Length1 in TrueType font streams 2017-09-28 art-snake Implement FakeFileAccess. 2017-09-28 dsinclair Cleanup CFGAS_GEFont methods 2017-09-28 dsinclair Simplify some OS checks to PLATFORM checks 2017-09-28 art-snake Fix load non first pages in linearized document with hints table. 2017-09-28 art-snake Fix infinite loop on form availability check. 2017-09-28 rharrison Remove no-op cast Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I5df7d33b7164e1b10bda6be4d6406aead78177c3 Reviewed-on: https://chromium-review.googlesource.com/690325 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#505097}
-
Matthew Jones authored
This change adds a promo dialog and flag to enable it on every restart. Choosing a setting different from the one the browser is currently in will cause the browser's activity to restart when the dialog is closed. The enabled state of the browser when the promo is in use is driven off of a new shared preference "chrome_home_user_enabled". The new preference takes priority over about:flags. BUG=767738 Change-Id: I4d0b5da6cf47baf338dbbc2fd8ffb85ea9140211 Reviewed-on: https://chromium-review.googlesource.com/683248 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#505096}
-
Zentaro Kavanagh authored
This is a reland of a240cac3 Fix/Workaround for crbug.com/769759: - Disables optimization on a function that causes clang to crash for some targets. Original change's description: > New NTLMv2 Implementation. > > - Supports NTLMv2 with Extended Protection for Authentication (EPA) > and Message Integrity Check (MIC). > - Adds required methods to buffer reader/writers to support NTLMv2 > - Adds optional version/mic fields to all messages > - Removes protocol level tests from HttpAuthHandlerNtlmPortableTest. > A previous CL already implemented all those tests directly against > NtlmClient. The tests at that level only existed to validate that > the behavior of the old and new implementation were the same. > - Future CL updates fuzzer to support v2. > - This CL does not activate NTLMv2. The code still defaults to NTLMv1. > > BUG=chromium:22532 > > Change-Id: I5b6dcbf6cdcf8f671008f60ae49c9bacb4e1d2f3 > Reviewed-on: https://chromium-review.googlesource.com/608620 > Commit-Queue: Zentaro Kavanagh <zentaro@google.com> > Reviewed-by: Asanka Herath <asanka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504808} Bug: chromium:22532 Change-Id: I3c3ec52b2592c4bf8da4bd79fbfe910567b41260 Reviewed-on: https://chromium-review.googlesource.com/689956Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@google.com> Cr-Commit-Position: refs/heads/master@{#505095}
-
Elly Fong-Jones authored
This change: 1) Adds a new class, ContentSettingDomainListView, which draws a titled list of domains; 2) Makes ContentSettingBubbleContents use that new class; 3) Adds a new class, BulletView, which draws a marker bullet for an unordered list; 4) Makes SadTabView and ExtensionInstallDialogView use BulletView. Bug: 700196 Change-Id: I2e1999b452277023ca071c0f8a7457fa405e3f00 Reviewed-on: https://chromium-review.googlesource.com/681852 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#505094}
-
Yuke Liao authored
ContextMenuJsTest.UnsupportedReferrerPolicy is flaky on iPhone 7 iOS 11 devices, and this is only a speculative fix because I couldn't reproduce the flake locally. Bug: Change-Id: I99c7228cdcce1129526b33bb892e0ab8aceb3a14 Reviewed-on: https://chromium-review.googlesource.com/690600Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#505093}
-
proberge authored
Bug: 766806 Change-Id: I1a210ded77cc9ffdc0039fca097c6fdba7ff0131 Reviewed-on: https://chromium-review.googlesource.com/677403 Commit-Queue: proberge <proberge@chromium.org> Reviewed-by:
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=achuith@chromium.org Bug: 666525 Change-Id: If9e66ef88a2d29360ddf0455de2f1489d324c895 Reviewed-on: https://chromium-review.googlesource.com/689106Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505091}
-
Yuke Liao authored
Originally, the coverage.profdata file is always generated as out/Coverage-iphonesimulator/coverage.profdata, and one problem with this setup is that the coverage.profdata can be easily overwritten, which makes it hard to reuse. This CL fixes the issue by generating the file in a user specified output directory. Bug: 757515 Change-Id: I555d8bac887c01eab99ff31b2860d52aeada9f26 Reviewed-on: https://chromium-review.googlesource.com/688299 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
-
arthursonzogni authored
Add a test for https://crbug.com/766149. The issue happens when webview's embedders are trying navigate to javascript-urls while the main document is loading. It causes the main document to stop loading. Navigation to a javascript-url is not a "real" navigation and should not prevent the main document from loading. See the others CLs in this series: [1/2] https://chromium-review.googlesource.com/c/684736. [2/2] This patch. BUG=766149 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: If2e4d2661ad3ab975a53d9e5646a1d3e8956772d Reviewed-on: https://chromium-review.googlesource.com/684834 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#505089}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=dpapad@chromium.org Bug: 666525 Change-Id: I7f56ede89ac9d6c72debb7fa018317539bcf8fc9 Reviewed-on: https://chromium-review.googlesource.com/689101Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505088}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=lfg@chromium.org Bug: 666525 Change-Id: Ie278447778d4b066b1588ecd1c0748221aa14522 Reviewed-on: https://chromium-review.googlesource.com/689025 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#505087}
-
Yusuf Ozuysal authored
-Introduce a new browserservices package for classes that will be shared across customtabs, browseractions and trustedwebactivities. - Move CustomTabsContentHandler to the new package with a rename - Extract the related static calls in CustomTabActivity to a utility class inside the new package. - Also move CustomTabsIntentDataProvider, PostMessageHandler, OriginVerifier to the same package. BUG=769129 Change-Id: I66829c5bb01338cb16089ab3baefe7ec1c79ade6 Reviewed-on: https://chromium-review.googlesource.com/685943 Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
-
Aleksandr Derbenev authored
Fix isolation of traffic_annotation_auditor_unittests again. R=msramek Bug: Change-Id: Ic756bc7371efe4c354d21a8a20ed43b7567539bf Reviewed-on: https://chromium-review.googlesource.com/690395Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Aleksandr Derbenev <alex-ac@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#505085}
-
Mohamad Ahmadi authored
Bug: 767853 Change-Id: I3af50b2eed7e842849ec1b0818be4e21b53e59f1 Reviewed-on: https://chromium-review.googlesource.com/690699 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org> Reviewed-by:
Marc-Antoine Courteau <macourteau@chromium.org> Cr-Commit-Position: refs/heads/master@{#505084}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=estark@chromium.org Bug: 666525 Change-Id: Ia5cfdc5682fdfa8f419de5341dc2868292adb74a Reviewed-on: https://chromium-review.googlesource.com/689110Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505083}
-
Jorge Lucangeli Obes authored
Chrome was setting RLIMIT_DATA under the assumption that RLIMIT_DATA only covered the brk() heap. Starting with https://github.com/torvalds/linux/commit/84638335900f1995495838fe1bd4870c43ec1f67, RLIMIT_DATA also accounts for mmap()-ed memory. This means that on systems with newer kernels the current limit is too low, and Chrome OOMs on large webpages. Increase the limit to 8GB on 64-bit systems. This will make spraying a little easier, but we need a usable browser. BUG=752185 TEST=cat /proc/<pid>/limits: TEST=Max data size 8589934592 8589934592 bytes R=thomasanderson@chromium.org Change-Id: I8b34aad1823fa7f94fcb40703d72c96dc900e769 Reviewed-on: https://chromium-review.googlesource.com/641992Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#505082}
-
wutao authored
We should avoid creating render surface if we are animating opacity with the same value of 1.0f. The opacity value not equal to 1.0f has already been handled in the code. Therefore, in this cl, we modify the IsThreaded to not create cc::Animation if it is animating with same start and target values. Bug: 764575 Test: local with flag ui-show-composited-layer-borders=renderpass Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3b6044382d395c831e6e1abf627ead570d9715c1 Reviewed-on: https://chromium-review.googlesource.com/663535Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#505081}
-
Nicolas Dossou-gbete authored
Bug: 664578 Change-Id: I47437bd37bd3581d070c72c8fe977cc457d81214 Reviewed-on: https://chromium-review.googlesource.com/686875Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#505080}
-
Maks Orlovich authored
This is to permit less-confusing introduction of kSimpleEntryTotalFileCount which also counts the _s file. Bug: 636400 Change-Id: Id4bd67d2f2db4ab2c20a064ec49bdaea8c105e97 Reviewed-on: https://chromium-review.googlesource.com/690482Reviewed-by:
-
Xida Chen authored
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/69862 TBR=schenney@chromium.org NOTRY=true Bug: 755405 Change-Id: I86fa77bad65ad9290b598fd6d5e74bb806b030c7 Reviewed-on: https://chromium-review.googlesource.com/690516Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#505078}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=tbarzic@chromium.org Bug: 666525 Change-Id: I9411427ca99d25dd1081871d3db6400e8d16a418 Reviewed-on: https://chromium-review.googlesource.com/689131Reviewed-by:
-
David Valleau authored
R=cros-printing-dev@chromium.org, skau@chromium.org The file printer_backend_proxy_chromeos.cc was moved to a different file in a recent CL so I have updated the docs. Bug: Change-Id: Ic5c834470e70f3be0cf4e2424957cdcca9a2e03d Reviewed-on: https://chromium-review.googlesource.com/688504Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: David Valleau <valleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#505076}
-
