GitLab

BUG=
TEST=

Review URL: http://codereview.chromium.org/8387037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108003 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102162
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/8432007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108002 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108001 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: http://codereview.chromium.org/8384013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108000 0039d316-1c4b-4281-b951-d872f2087c98

1. hide/show titlebar widget when entering/exiting full screen
2. don't show bookmark bar when in fullscreen mode

BUG=97177
TEST=manual -- 1. Open new tab. 2. Full screen. 3. click on a link in the new tab page. 4. You shouldn't see a line at the top.

Review URL: http://codereview.chromium.org/8414014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107999 0039d316-1c4b-4281-b951-d872f2087c98

R=jam@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/8341129

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107998 0039d316-1c4b-4281-b951-d872f2087c98

Revert 107995 - Fix a ChromeFrame crash which occurs in the background worker thread while dereferencing a NULL automation client.
This crash occurs when the active document is in the process of shutting down while there are active background
requests still pending.

Fix is to ensure that the background thread has been stopped before returning from the UrlmonUrlRequestManager::StopAll
function which gets called during CF shutdown.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=102393

BUG=102393
Review URL: http://codereview.chromium.org/8429011

TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/8431011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107997 0039d316-1c4b-4281-b951-d872f2087c98

BUG=95573
TEST=no visible change

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107985

Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=107990

Review URL: http://codereview.chromium.org/8429005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107996 0039d316-1c4b-4281-b951-d872f2087c98

Fix a ChromeFrame crash which occurs in the background worker thread while dereferencing a NULL automation client.
This crash occurs when the active document is in the process of shutting down while there are active background
requests still pending.

Fix is to ensure that the background thread has been stopped before returning from the UrlmonUrlRequestManager::StopAll
function which gets called during CF shutdown.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=102393

BUG=102393
Review URL: http://codereview.chromium.org/8429011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107995 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:22290
TEST=Manual: create a new user, sign in, then sign out again. No message 'Chrome didn't shutdown correctly...' should appear beneath the address bar.


Review URL: http://codereview.chromium.org/8429006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107994 0039d316-1c4b-4281-b951-d872f2087c98

Fix some minor "gcl lint" results in these files while I'm at it.

Implementation notes:

1. ScanForHostAndCerts tried to do too much: both search the list for an
HSTS preload and also set one limited criterion (check on required_hashes).
It also returned too little, limiting its usefulness. Replaced it with
GetHSTSPreload which just implements the "return a match; prefer exact
match" semantics and returns the HSTSPreload entry. The caller can then
apply their arbitrary decision criterion (as in IsGooglePinnedProperty) or
use any field from the entry (as in ReportUMAPinFailure). This makes its
interface and implementation simpler, and makes it more useful to more
callers.

2. The IsGooglePinnedProperty unit test still passes, in light of (1).

3. I needed to get from a full hostname to an enum value that I can send in
an UMA_HISTOGRAM_ENUMERATION. Baking the enums into struct HSTSPreload was
the most straightforward and least-bloated way of doing that.

BUG=99782
Review URL: http://codereview.chromium.org/8364023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107993 0039d316-1c4b-4281-b951-d872f2087c98

This should not affect official build since requests with pdf mime type already don't get intercepted when pdf plugin is present.

TEST=Verified pdf can be copied in chromium OS file browser.
     unit_tests:GViewRequestInterceptorTest.*
BUG=chromium-os:21560


Review URL: http://codereview.chromium.org/8357019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107991 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit r107985.

BUG=
TEST=

Review URL: http://codereview.chromium.org/8384015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107990 0039d316-1c4b-4281-b951-d872f2087c98

BUG=84918
TEST=none


Review URL: http://codereview.chromium.org/8341094

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107989 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8384002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107988 0039d316-1c4b-4281-b951-d872f2087c98

Skia is being used or not.
Review URL: http://codereview.chromium.org/8430001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107987 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101469
TEST=Manual

Review URL: http://codereview.chromium.org/8418039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107986 0039d316-1c4b-4281-b951-d872f2087c98

BUG=95573
TEST=no visible change

Review URL: http://codereview.chromium.org/8429005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107985 0039d316-1c4b-4281-b951-d872f2087c98

1. Factors out Chrome/Chromium resource generation into a separate
chrome_resources.gyp file.
2. Eliminates repetition between Mac and other platforms.
3. Breaks long "repack" actions out into separate files for greater readability.
4. Eliminates circular dependencies in the Aura shell, the Views components, and
the compositor when utilizing Chrome resources.

BUG=none
TEST=try bots run gyps and build correctly.

Review URL: http://codereview.chromium.org/8425002

TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/8430011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107984 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8430008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107978 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107974 0039d316-1c4b-4281-b951-d872f2087c98

Some last minute string changes for sign in promo.

BUG=102169, 102171, 102173
TEST=
TBR=binji@chromium.org

Review URL: http://codereview.chromium.org/8387031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107972 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:11535
TEST=make sure no thread trelated assertion are happening during mobile activation now when ScopedAllowIO is removed 
Review URL: http://codereview.chromium.org/8414039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107970 0039d316-1c4b-4281-b951-d872f2087c98

Since we haven't done anything more with history and some users are experiencing larger than expected history files, we can probably now be more aggressive about deleting stuff that isn't so useful.

I changed a number of thresholds:

 - We now keep full text indexed data for 3 months instead of 12.

 - We now expire auto subframe visits after 3 dats instead of 30. I added the rationale in a comment.

 - We now expire 32 visits per iteration instead of 10. This number is always kind of a guesstimate anyway of balancing overhead of a query versus overhead of a delete. Now that we're moving up some thresholds, we'll have a bunch of history to expire and I would rather get this over with faster than spending hours spinning the CPU every 30 seconds. This will also come up for users that haven't used their browsers in a while.
Review URL: http://codereview.chromium.org/8343077

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107969 0039d316-1c4b-4281-b951-d872f2087c98

This reverts r107750 since the V8 roll causing
the perf regression has been reverted.

TBR=nsylvain@chromium.org

Review URL: http://codereview.chromium.org/8427005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107968 0039d316-1c4b-4281-b951-d872f2087c98

1. Factors out Chrome/Chromium resource generation into a separate
chrome_resources.gyp file.
2. Eliminates repetition between Mac and other platforms.
3. Breaks long "repack" actions out into separate files for greater readability.
4. Eliminates circular dependencies in the Aura shell, the Views components, and
the compositor when utilizing Chrome resources.

BUG=none
TEST=try bots run gyps and build correctly.

Review URL: http://codereview.chromium.org/8425002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107967 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101833
TEST=None

Review URL: http://codereview.chromium.org/8416056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107965 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98716


Review URL: http://codereview.chromium.org/8400060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107964 0039d316-1c4b-4281-b951-d872f2087c98

I may be able to do better... but I wanted to  get
the tree greened up.

TBR=rtenneti
Review URL: http://codereview.chromium.org/8426006

TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/8431006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107963 0039d316-1c4b-4281-b951-d872f2087c98

This is a re-land of:
http://codereview.chromium.org/8391019/
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107793

Original landing had trouble with message_loop_x.h, due to header
include ordering.  I pulled out the structure that was really needed by
tracked_objects.h into a new file tracked_info.*.  This allows tracked_objects
to inlude this tracked_info, but not have to include the message_loop.h
totality.  I also removed a DCHECK that that was triggering on a test,
and added yet one more file (browser_main.cc) where I removed a #ifdef
for TRACKING_ALL_OBJECTS.  The changes were minor, and I'm hoping to get
clear perf runs with tihs landing, so I'm going to TBR it and reland
early in the morning.



Comments from original landing:

Support is now controlled by the flag:
--enable-tracking
and the default is always on. To turn it off, use:
--enable-tracking=0

All profiler code is compiled now in release and official
builds (in addition to debug, where it was already active),
but most entry points can be disabled (turned into no-ops) 
by a single const bool setting atop tracked_objects.cc (in 
case folks want to revert the perf-impact of this change).

Transition to faster Now() service on Windows for the 
profiler use only.
The TimeTicks::Now() function on Window uses locking
to get a 64 bit time value. This CL transitions 
times used for profiling to more directly use a
32 bit Time interface, which is actually what drives the
64 bit TimeTicks. By using the smaller value, we avoid 
the need for locks, or even atomic operations for the most
part in the tracking system. On linux, we just down-sample
the standard TimeTicks to 32 bits for consistency (clean
ability to snapshot asyncronously without atomics...
but I should verify that such is helpful to performance).

I've also put in yet more cleanup and refactoring.

tbr=rtenneti
bug=101856
Review URL: http://codereview.chromium.org/8414036

TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/8430004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107961 0039d316-1c4b-4281-b951-d872f2087c98

[Re-land of Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107921
with supressions for induced (and planned) leaks) 
PLUS
Removed one line of defensive coding where I set(NULL)
the TLS slote at thread teardown. We're seeing
strange failures on the base unittests, and they
may be related to this.
]

Be extra carful about handling races in access to status_.
This will avoid generating a delta between a null time
and a real time, when status is changing in/around
the run of a task. This won't help with the benign
race for checking status_, but it may help with unit
test tsan complaints.

Leak data aggressively, rather than cleaning up, to
prevent any chance of a data access race between
tracked object testing (which need a near-virgin
global state, and hence must start by cleaning it up), and
other tests, which may have lingering threaded actions, 
that still access some previously created task tracking
data.

Provide more options for flags to enable/disable
tracking. These options might become useful
if we changed the default to not do tracking.

Allow for HTML generation even if the tracking has
changed to being disabled. This is especially useful
for looking at the tracked instances that were
monitored after turning tracking on by default, but
before the command line deactiated tracking.

tbr=rtenneti
bug=102327
Review URL: http://codereview.chromium.org/8425010

TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/8430003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107960 0039d316-1c4b-4281-b951-d872f2087c98

Repair busted tree.

TBR=rtenneti
Review URL: http://codereview.chromium.org/8425013

TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/8430002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107959 0039d316-1c4b-4281-b951-d872f2087c98

Mac base_unittests is still flaky....

Pthread is still sometimes crashing Mac on shutdown.

I'm suspicious that my handlers are tickling it.
This removes a DCHECK(), which checked status in
TLS during the teardown.

TBR=rtenneti
Review URL: http://codereview.chromium.org/8424013

TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/8431003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107958 0039d316-1c4b-4281-b951-d872f2087c98

This browser test tickles the webkit bug described in crbug.com/75604 .
The bug is very hard to repliably reproduce in a layout test, so my plan is
to land this browser_test, update webkit to fix the bug, and update this
test as we garden past the fix.

BUG=75604

Review URL: http://codereview.chromium.org/8404001

TBR=gavinp@chromium.org
Review URL: http://codereview.chromium.org/8427003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107957 0039d316-1c4b-4281-b951-d872f2087c98

X.509 serial numbers should be a positive numbers according to the spec.
However, certificates have been issued with negative serial numbers. Negative
serial numbers are indicated with a most-significant bit of one. Positive
numbers which would have a MSB of 1 have a zero byte prepended to avoid the
ambiguity.

Previously we removing leading zero bytes because we were only matching against
a blacklist of serial numbers, none of which were negative.

This change moves the handling of serial numbers to the place where they are
used, rather than where they are parsed.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8381017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107956 0039d316-1c4b-4281-b951-d872f2087c98

BUG=95573
TEST=no change

Review URL: http://codereview.chromium.org/8418033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107954 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107952 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8418032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107951 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manual: ./build/gyp_chromium with GYP_GENERATOR=ninja shouldn't complain about invalid type 'settings'.


Review URL: http://codereview.chromium.org/8426004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107950 0039d316-1c4b-4281-b951-d872f2087c98

This browser test tickles the webkit bug described in crbug.com/75604 .
The bug is very hard to repliably reproduce in a layout test, so my plan is
to land this browser_test, update webkit to fix the bug, and update this
test as we garden past the fix.

BUG=75604

Review URL: http://codereview.chromium.org/8404001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107949 0039d316-1c4b-4281-b951-d872f2087c98