GitLab

BUG=578963
R=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/1618283006

Cr-Commit-Position: refs/heads/master@{#371095}

* SurfaceViews don't play well with Views on top of them toggling between
  View.VISIBLE and View.INVISIBLE.  Fix this by using View.GONE instead.

* Make logic for hiding the InfoBarContainer when other bottom-of-the-screen
  Views try to take over the screen out of SwipableOverlayView and
  ContextualSearchManager into the InfoBarContainer itself.

* Move logic for hiding the InfoBarContainer when the keyboard is showing
  from SwipableOverlayView#onLayout into InfoBarContainer and make it so
  that the InfoBarContainer listens for global layout changes.

BUG=563947

Review URL: https://codereview.chromium.org/1613513004

Cr-Commit-Position: refs/heads/master@{#371094}

We lost debug output when moving from XML to Proto, now adding it again.

BUG=None
TEST=Manual

Review URL: https://codereview.chromium.org/1622703002

Cr-Commit-Position: refs/heads/master@{#371093}

BUG=580668
TBR=wjmaclean@chromium.org

Review URL: https://codereview.chromium.org/1621743003

Cr-Commit-Position: refs/heads/master@{#371092}

BUG=580661

Review URL: https://codereview.chromium.org/1629563002

Cr-Commit-Position: refs/heads/master@{#371091}

Use the added getActivity and getTabModelSelector for getting access to
WindowAndroid's copy and don't cache Activity inside tab related
classes.

BUG=546736

Review URL: https://codereview.chromium.org/1616073006

Cr-Commit-Position: refs/heads/master@{#371090}

Review URL: https://codereview.chromium.org/1618093009

Cr-Commit-Position: refs/heads/master@{#371089}

Also consolidate the contents saving checking logic in addOrEditBookmark

BUG=579696

Review URL: https://codereview.chromium.org/1610413002

Cr-Commit-Position: refs/heads/master@{#371088}

BUG=573341

Review URL: https://codereview.chromium.org/1581853005

Cr-Commit-Position: refs/heads/master@{#371087}

In the long run, we'll need a real solution to preferences, but for now,
we replace the implementation of PersistentPrefsStore with one that
writes JSON values to file on the mojo:filesystem. The current interface
isn't really a match made in heaven and it doesn't really deal with all
the complexity that we need to worry about (see 580652), but it's
reasonably sandboxed and will work for now.

BUG=557405, 580652

Review URL: https://codereview.chromium.org/1624683002

Cr-Commit-Position: refs/heads/master@{#371086}

Ran through the import script in third_party/sqlite/README.Chromium,
including the SQLite test suite.  No new errors observed.

SQLite changes are at http://www.sqlite.org/changes.html , Chromium
previously used 3.8.7.4.

All patches were applied and the results reviewed to make sure
backported patches were safe to remove, and retained patches were still
covering what was necessary.

Keep fts4 disabled, and also the new fts3 virtual table and unicode61
tokenizer.  Once enabled, these are very hard to disable, and there
doesn't seem to be any pressure to enable them.  Set
SQLITE_DEFAULT_PCACHE_INITSZ to 0 so SQLite does not preallocate 100
pages to pcache (both so Chromium can manage memory, also because our
code disables shared pcache).  Other SQLITE_* flags were reviewed for
applicability, none looked essential.

BUG=579743
R=michaeln@chromium.org

Review URL: https://codereview.chromium.org/1610963002 .

Cr-Commit-Position: refs/heads/master@{#371085}

This CL is basically just plumbing of a result code to an internal
diagnosis page. Decryption is done at the level of the GCM Driver,
while, for desktop, the GCMStatsRecorder is owned by the GCMClient
several layers down, on another thread.

BUG=569127

Review URL: https://codereview.chromium.org/1616113003

Cr-Commit-Position: refs/heads/master@{#371084}

Also reduces duplicate code between platform data fetchers by having things like
sanitation happen in the provider, and makes the data fetchers themselves more
modular.

BUG=577414

Review URL: https://codereview.chromium.org/1586663006

Cr-Commit-Position: refs/heads/master@{#371083}

BUG=514815, 373452
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1615253006

Cr-Commit-Position: refs/heads/master@{#371082}

If a theme provided a replacement frame image, but not a replacement incognito
frame or incognito background tab image, the theme service would synthesize one,
but the tab drawing code would not realize this.  As a result it would cache the
appearance of non-hovered background tabs, leading to visual appearance glitches
since not all those tabs should look the same.

BUG=580677
TEST=Install https://chrome.google.com/webstore/detail/tree-branches/bgdeemcfmmabkdhbnhmkhpadancpkgol?hl=en-US , open an incognito window, open several tabs, and ensure the background tab images line up with the frame and the tab appearance doesn't change abruptly when hovering any such tabs.

Review URL: https://codereview.chromium.org/1623643002

Cr-Commit-Position: refs/heads/master@{#371081}

This means that more classes can just use the CookieStore interface,
rather than depending on a particular implementation of it.

BUG=579653

Review URL: https://codereview.chromium.org/1618943002

Cr-Commit-Position: refs/heads/master@{#371080}

GetNumDisplays() != num_connected_displays()

BUG=576375

Review URL: https://codereview.chromium.org/1614413004

Cr-Commit-Position: refs/heads/master@{#371079}

The context menu on the web page on Windows should be displayed when the long press gesture is released rather than while it is pressed.

This is inconsistent with the way the long press context menu gesture works on Windows. Additionally the long press gesture in Chrome displays the
context menu on the tabstrip and the caption when the touch is released which makes it super confusing.

Changes in this patch are as below:-

1. The RenderWidgetHostViewAura::OnShowContextMenu function now returns a bool indicating whether the context menu should be displayed or not. It currently
   returns false on Windows if the menu is being displayed in response to a touch gesture. If yes then it sets a state indicating that the context menu
   needs to display when the long press gesture is released via a touch up.
   On other platforms it returns true.

2, The WebContentsViewAura::ShowContextMenu function which gets invoked when the context menu is requested by the web page calls the
   RenderWidgetHostViewAura::OnShowContextMenu function and if it returns false does not display the context menu.

3. The RenderWidgetHostViewAura::HandleGesutureForTouchSelection handles the ET_GESTURE_LONG_TAP on Windows and if we have a pending context menu request, it
   calls the WebContentsViewAura::ShowContextMenu function to display the context menu with the menu source now set to mouse.

BUG=562739.
TEST=RenderWidgetHostViewAuraWithViewHarnessTest.ContextMenuTest

Review URL: https://codereview.chromium.org/1602903003

Cr-Commit-Position: refs/heads/master@{#371078}

BUG=546822

The apk is failing comparison because of timestamps not content difference,
so ignore it for now.

Review URL: https://codereview.chromium.org/1624693003

Cr-Commit-Position: refs/heads/master@{#371077}

Brings in https://codereview.chromium.org/1616263006
    roll clang-format 242086:r258123
    New:
    - include sorting (disabled by default for -style=Chromium)
    - a toggle to disable comment formatting (will be needed
      transitionally for blink formatting)
    - bug fixes

BUG=564077
TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1615653012

Cr-Commit-Position: refs/heads/master@{#371076}

BUG=571304

Review URL: https://codereview.chromium.org/1580873003

Cr-Commit-Position: refs/heads/master@{#371075}

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1620323003

Cr-Commit-Position: refs/heads/master@{#371074}

BUG=580211

Review URL: https://codereview.chromium.org/1619273003

Cr-Commit-Position: refs/heads/master@{#371073}

Recent CLs have already made it so URLRequestJob itself calls the
method itself whenever necessary, except when URLRequestJob::Start is
being called, where subclasses were still expected to invoke it.
Most of them were failing to do so, but since nothing cares about the
state after start, and little distinguished between ERR_IO_PENDING and
SUCCESS, everything was still working.  URLRequest now sets its status
itself before it starts a URLRequestJob.

This CL also makes the URLRequest consistently have a status of
ERR_IO_PENDING when it's doing something - there were a number of
paths where this wasn't previously the case.

The state machine changes also coincidentally fix issue 575213,
which regressed in https://codereview.chromium.org/1467603002, so this
CL includes a test for that fix.

In the future, I'd really like to get rid of URLRequestJob::SetStatus,
and have URLRequests manage their own status.

BUG=564250,575213
TBR=jianli@chromium.org, phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/1563633002

Cr-Commit-Position: refs/heads/master@{#371072}

BUG=580337

Review URL: https://codereview.chromium.org/1618003003

Cr-Commit-Position: refs/heads/master@{#371071}

This enables more accurate conics measurements.

TBR=caryclark@google.com
BUG=530095

Review URL: https://codereview.chromium.org/1622623005

Cr-Commit-Position: refs/heads/master@{#371070}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/9509b58596fd..fcf168c77a8a

$ git log 9509b5859..fcf168c77 --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1626633002

Cr-Commit-Position: refs/heads/master@{#371069}

This reduces the lines of code and makes everything a lot clearer.

BUG=563721

Review URL: https://codereview.chromium.org/1615093003

Cr-Commit-Position: refs/heads/master@{#371068}

This is for ag/848680 and ag/848681.

BUG=577929
TEST=http, https, and mailto URLs are still passed from ARC.
 CrOS setting changes are still sent to ARC.

Review URL: https://codereview.chromium.org/1610813003

Cr-Commit-Position: refs/heads/master@{#371067}

Also iron-icons was updated.

BUG=580371

Review URL: https://codereview.chromium.org/1621603002

Cr-Commit-Position: refs/heads/master@{#371066}

This enables the conics-based arcTo impl (as used by Canvas2D).

BUG=578885
TBR=caryclark@google.com

Review URL: https://codereview.chromium.org/1625593002

Cr-Commit-Position: refs/heads/master@{#371065}

https://chromium.googlesource.com/skia.git/+log/7f6a1e078641..32235eac4b5c

$ git log 7f6a1e078..32235eac4 --date=short --no-merges --format='%ad %ae %s'
2016-01-22 bsalomon Factor out xcode c/cpp settings into variables to apply to cmake builds.
2016-01-22 herb Change name from ScaleToSides to SkScaleToSides.
2016-01-22 mtklein Revert of de-proc sk_float_rsqrt (patchset #3 id:40001 of https://codereview.chromium.org/1616013003/ )
2016-01-22 fmalita Anisotropic mipmap fixes

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=benjaminwagner@google.com

Review URL: https://codereview.chromium.org/1629493004

Cr-Commit-Position: refs/heads/master@{#371064}

  * deletes is_hidden
  * computes if a layer is drawn using the effect tree

BUG=575413
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1588093004

Cr-Commit-Position: refs/heads/master@{#371063}

BUG=563613

Review URL: https://codereview.chromium.org/1505343003

Cr-Commit-Position: refs/heads/master@{#371062}

`<link rel=preload>` based resources are could result in a double download
if they weren't discovered by the parser by the time parsing ended. If they
we're not used by that time, they were removed from mem cache entirely.

That behavior is compatible with preloadScanner discovered resources, but
it is not compatible with rel preload, which is intended to be used on
exactly the resources that are not present in markup and therefore will
be discovered late.

This CL fixes the issue, by avoiding to remove from memcache resources
that are there due to `<link rel=preload>`.

BUG=579914

Review URL: https://codereview.chromium.org/1615803004

Cr-Commit-Position: refs/heads/master@{#371061}

BUG=579666
TBR=dbeam@chromium.org

Review URL: https://codereview.chromium.org/1618823005

Cr-Commit-Position: refs/heads/master@{#371060}

This adds a DisplayManager interface that you get from mus. You can
then attach an observer to observe display related changes.

BUG=548429
TEST=none
R=ben@chromium.org

Committed: https://crrev.com/bc2281a7a7576f5b4da85986298322b3c9d2234e
Cr-Commit-Position: refs/heads/master@{#370880}

Review URL: https://codereview.chromium.org/1615023004

Cr-Commit-Position: refs/heads/master@{#371059}

The symbols from egl_native_win were overriding the windowless symbols, causing it to use a window instead.

BUG=none

Review URL: https://codereview.chromium.org/1592563002

Cr-Commit-Position: refs/heads/master@{#371058}

BUG=

Review URL: https://codereview.chromium.org/1618193002

Cr-Commit-Position: refs/heads/master@{#371057}

Pending events in android can occur after the native find in page
has been destroyed, so ensure the bridge is non null before trying
to act on it.

This adds asserts to places where the bridge is not allowed to
be null either.

BUG=489253

Review URL: https://codereview.chromium.org/1628513002

Cr-Commit-Position: refs/heads/master@{#371056}