GitLab

new avatar menu button instead of the old.

BUG=302037

Review URL: https://codereview.chromium.org/53153009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233376 0039d316-1c4b-4281-b951-d872f2087c98

Rather than AutofillDownloadManager obtaining the PrefService to use from
BrowserContext, have AutofillDownloadManager's creator supply it with the
PrefService to use. Incremental step toward abstracting BrowserContext
knowledge out of AutofillDownloadManager.

BUG=303050

Review URL: https://codereview.chromium.org/49303005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233375 0039d316-1c4b-4281-b951-d872f2087c98

Instead of assuming every released resource could be potentially
reusable, manage a list of busy resources and a list of immediately
reusable resources. A busy resource is one which can not be locked for
write.
    
Recheck busy resources before the tile manager is to schedule new tasks,
in AssignGpuMemoryToTiles().
    
If this operation becomes too expensive, the CheckBusyResources()
function should only be called if some resource(s) are returned from the
parent compositor or when ResourcePool releases some resource.

BUG=

Review URL: https://codereview.chromium.org/43753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233374 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/24544004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233373 0039d316-1c4b-4281-b951-d872f2087c98

MessageReceiver is the interface used by the generated proxies and stubs to transmit messages. Connector is responsible for reading and writing those messages on a MessagePipe. A Connector "is a" MessageReceiver so that it can accept outbound messages, and "has a" MessageReceiver so it can dispatch incoming messages.

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/54743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233372 0039d316-1c4b-4281-b951-d872f2087c98

This ensures that no PageGroupLoadDeferrers will be on the stack when
processing ViewMsg_SwapOut, which would lead to an ASSERT.

BUG=312490
TEST=Start a cross-process navigation and show a loop of alerts before commit.
R=cdn@chromium.org, darin@chromium.org

Review URL: https://codereview.chromium.org/50223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233371 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/52093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233368 0039d316-1c4b-4281-b951-d872f2087c98

Add a method to WebDatabaseObserver to close a database without holding
on to an actual WebDatabase. This will make it possible to decouple the
lifetime of WebDatabase and the database thread.

BUG=249502
R=jam@chromium.org

Review URL: https://codereview.chromium.org/50883004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233367 0039d316-1c4b-4281-b951-d872f2087c98

Converts to and from Cast API types. Also fixed a couple issues to
match the API between Cast and Extensions API.

Cast Extensions API is now fully redirected to Cast native APIs. Minus
the conversion of MediaStreamTrack.

BUG=301920

Review URL: https://codereview.chromium.org/47343005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233366 0039d316-1c4b-4281-b951-d872f2087c98

This CL removes code duplication around storage partition related data removal code from BrowsingDataRemover and re-uses StoragePartition::ClearData* method. 

BUG=180118
Test=

Review URL: https://codereview.chromium.org/37843003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233365 0039d316-1c4b-4281-b951-d872f2087c98

Updated expectations to account for tests that will begin failing after the conformance test harness is fixed

BUG=314997
R=zmo@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233326

Review URL: https://codereview.chromium.org/59853009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233363 0039d316-1c4b-4281-b951-d872f2087c98

R=kalman@chromium.org
TBR=pastarmovj@chromium.org
BUG=313906

Review URL: https://codereview.chromium.org/60323006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233359 0039d316-1c4b-4281-b951-d872f2087c98

Added chrome/renderer/nacl and OWNERS

Requires the following blink change: https://codereview.chromium.org/14773025/

BUG=239656
R=jam@chromium.org, marja@chromium.org, teravest@chromium.org

Review URL: https://codereview.chromium.org/14588009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233356 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233353 0039d316-1c4b-4281-b951-d872f2087c98

- events_base (built by most people) - defining some basic utilities.
- events (built by users of aura/views) - the ui::Event type & friends.

Prior to this there was one target, and platforms that did not want ui::Event would exclude those files explicitly, making it hard to build those files on those platforms without breaking other components.

R=sadrul@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/57433011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233347 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233345 0039d316-1c4b-4281-b951-d872f2087c98

Enforces 10px visibility when dragging between displays. This scenario is possibly overlooked in https://codereview.chromium.org/21979005.

BUG=314696
TEST=ash_unittests --gtest_filter=*WindowDragWithMultiDisplays:*WindowDragWithMultiDisplaysRightToLeft

Review URL: https://codereview.chromium.org/57963003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233344 0039d316-1c4b-4281-b951-d872f2087c98

R=jkummerow@chromium.org
TBR=jkummerow@chromium.org
BUG=

Review URL: https://codereview.chromium.org/60733004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233343 0039d316-1c4b-4281-b951-d872f2087c98

Previously, ET_GESTURE_SHOW_PRESS was causing the omnibox to not select
all text. ET_GESTURE_SHOW_PRESS is now ignored by the omnibox.

BUG=313135
TEST=OmniboxViewViewsTest.SelectAllOnTap

Review URL: https://codereview.chromium.org/55893004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233342 0039d316-1c4b-4281-b951-d872f2087c98

BUG=302461
TEST=No new ones. Existing tests cover this code well enough.

Review URL: https://codereview.chromium.org/50293011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233341 0039d316-1c4b-4281-b951-d872f2087c98

An adapter for PrivetDeviceLister that checks /privet/info and outputs only
devices that support /privet/printer/submitdoc.

BUG=311390

Review URL: https://codereview.chromium.org/48113019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233340 0039d316-1c4b-4281-b951-d872f2087c98

- move launcher_button_host.h from launcher/ to shelf/
- rename to shelf_button_host.h

BUG=248353
TEST=None, no functional changes
R=harrym@chromium.org,jamescook@chromium.org

Review URL: https://codereview.chromium.org/57453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233337 0039d316-1c4b-4281-b951-d872f2087c98

Error Log:
[ RUN      ] PrintPreviewTest.WindowedNPAPIPluginHidden
[3852:2708:1106/120416:ERROR:dxva_video_decode_accelerator.cc(421)] Direct3DCreate9Ex failed, HRESULT: 0x8876086a
[3852:2708:1106/120416:ERROR:dxva_video_decode_accelerator.cc(398)] Failed to initialize D3D device and manager
[2672:2864:1106/120416:2596964:ERROR:chrome_views_delegate.cc(172)] NOT IMPLEMENTED
[2672:2864:1106/120416:2596964:ERROR:desktop_root_window_host_win.cc(688)] NOT IMPLEMENTED
[2672:3764:1106/120417:2597915:ERROR:gpu_message_filter.cc(189)] Renderer 3 tried to access a surface for renderer 0
[2672:3764:1106/120417:2597931:ERROR:gpu_message_filter.cc(189)] Renderer 3 tried to access a surface for renderer 0
[2672:3764:1106/120417:2597931:ERROR:gpu_message_filter.cc(189)] Renderer 3 tried to access a surface for renderer 0
[2672:3764:1106/120417:2597931:ERROR:gpu_message_filter.cc(189)] Renderer 3 tried to access a surface for renderer 0
[2904:3556:1106/120418:VERBOSE2:ipc_channel_win.cc(85)] sending message @0B515550 on channel @0B550EA8 with type 262228 (0 in queue)
[2904:3556:1106/120418:VERBOSE2:ipc_channel_win.cc(409)] sent message @0B515550 on channel @0B550EA8 with type 262228
[2672:2864:1106/120418:2598820:ERROR:chrome_views_delegate.cc(172)] NOT IMPLEMENTED
[2672:3764:1106/120418:2599273:ERROR:gpu_message_filter.cc(189)] Renderer 6 tried to access a surface for renderer 0
[2672:3764:1106/120419:2599351:ERROR:gpu_message_filter.cc(189)] Renderer 6 tried to access a surface for renderer 0
[2672:3764:1106/120419:2599366:ERROR:gpu_message_filter.cc(189)] Renderer 6 tried to access a surface for renderer 0
[2672:3764:1106/120419:2599366:ERROR:gpu_message_filter.cc(189)] Renderer 6 tried to access a surface for renderer 0
browser\ui\webui\print_preview\print_preview_ui_browsertest.cc(124): error: Value of: 2
Expected: result
Which is: 1
[  FAILED  ] PrintPreviewTest.WindowedNPAPIPluginHidden, where TypeParam =  and GetParam() =  (4804 ms)
[632/632] PrintPreviewTest.WindowedNPAPIPluginHidden (5614 ms)

> Fix windowed NPAPI plugins covering up dialogs on Win Aura.
> 
> The original fix stopped working with the new style of dialogs, since they're not parented to the WebContents anymore but instead to its parent. It also turns out we don't need to watch out for transient windows, as they're now top level ones with their own HWND so clipping works through the OS and we don't need to do anything special.
> 
> BUG=299224
> R=ben@chromium.org
> 
> Review URL: https://codereview.chromium.org/53153003

TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/63013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233333 0039d316-1c4b-4281-b951-d872f2087c98

In preference to https://codereview.chromium.org/61093002/.

R=sky@chromium.org
BUG=306295

Review URL: https://codereview.chromium.org/59613009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233332 0039d316-1c4b-4281-b951-d872f2087c98

Updated expectations to account for tests that will begin failing after the conformance test harness is fixed

BUG=314997
R=zmo@chromium.org

Review URL: https://codereview.chromium.org/59853009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233326 0039d316-1c4b-4281-b951-d872f2087c98

The notion of whether a context is lost is a property of both the gpu::
context itself and the system providing it. For instance, the content
context provider checks if there is an error in the context or if the IPC
channel backing the command buffer is down. Thus, asking if a context is
lost really should go through the ContextProvider. This patch routes all
lost context checks from cc through the ContextProvider.

Unfortunately, this required reworking the program initialization code
considerably due to the way some DCHECKs were written. The new model is that
the program binding itself is inert upon construction and all initialization
is done in the Initialize() call. This call is still made eagerly for some
expected-to-be-common programs and lazily for the rest. This patch moves
when the linkProgram() call is issued slightly for the eagerly compiled programs,
but it shouldn't make any difference in practice.

This patch also revamps TextureLayerClient to hide the backing context since
cc only makes two calls (check for loss and insert rate limiting token) on
the client's context.

R=piman
BUG=181120

Review URL: https://codereview.chromium.org/51653008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233325 0039d316-1c4b-4281-b951-d872f2087c98

There are conditions that cause a device's clock to go back in time, and then
if the policy is rejected because its timestamp is in the future then no user
can sign-in, and guest sessions can't be started.

This CL removes the timestamp check from policies loaded from the cache;
new policies downloaded from the server or downloaded during enrollment still
have their timestamps checked.

BUG=313906,265507,303508
R=bartfab@chromium.org, xiyuan@chromium.org

Review URL: https://codereview.chromium.org/62453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233323 0039d316-1c4b-4281-b951-d872f2087c98

This should be "pepper_NN", but was coming through as a path.

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/62753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233322 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233319 0039d316-1c4b-4281-b951-d872f2087c98

R=avi@chromium.org

Review URL: https://codereview.chromium.org/62633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233317 0039d316-1c4b-4281-b951-d872f2087c98

BUG=311019
R=atwilson@chromium.org, rogerta@chromium.org, xiyuan@chromium.org

Review URL: https://codereview.chromium.org/47603008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233316 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/61573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233315 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 31f458db.

Revert "Update command state on "load" of a folder"

This reverts commit 778b807f.

These caused the browser_test BookmarksTest.CommandOpensBookmarksTab
to hang on Linux Aura.

BUG=312356,313592,315408
TBR=arv@chromium.org,dbeam@chromium.org

Review URL: https://codereview.chromium.org/62713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233314 0039d316-1c4b-4281-b951-d872f2087c98

BUG=302437

Review URL: https://codereview.chromium.org/44553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233310 0039d316-1c4b-4281-b951-d872f2087c98

We don't actually call this code yet, but we're going to need this code in
order to demo a spinning cube. I've verified that this code draws a cube when
called directly from mojo_shell. It should work when called from sample_app
once we figure out how we want to expose GL to Mojo apps.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/61423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233309 0039d316-1c4b-4281-b951-d872f2087c98

Was not the cause of breakage. See bug for that.

BUG=314916
R=benwells@chromium.org
TBR=benwells@chromium.org

Review URL: https://codereview.chromium.org/60393005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233308 0039d316-1c4b-4281-b951-d872f2087c98

These images were not valid Android 9-patches as their borders did not
correctly indicate the stretchable and static areas of each image.

BUG=314199
R=dtrainor@chromium.org

Review URL: https://codereview.chromium.org/60453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233307 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=rogerta@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/58183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233306 0039d316-1c4b-4281-b951-d872f2087c98

This triggered a DCHECK in https://codereview.chromium.org/51683002/ .

BUG=166689
R=davidben@chromium.org, jam@chromium.org

Review URL: https://codereview.chromium.org/60193004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233305 0039d316-1c4b-4281-b951-d872f2087c98

In r232724, FakeURLFetcher went from being able to return only HTTP/200
or HTTP/500, to being able to return any arbitrary HttpResponseCode.
However, the URLRequestStatus returned was hard coded to FAILURE for
HTTP/5xx and SUCCESS for all other codes.

This patch further modifies FakeURLFetcher to be able to return
arbitrary URLRequestStatus values in addition to an HttpResponseCode.
We no longer hard code the URLRequestStatus based on the
HttpResponseCode being returned. It also updates all call sites that
currently use FakeURLFetcher.

R=achuith@chromium.org, ajwong@chromium.org, akalin@chromium.org, mattm@chromium.org, mmenke@chromium.org, nyquist@chromium.org, sky@chromium.org, tim@chromium.org, vitalybuka@chromium.org
TBR=bengr, sergeyu
BUG=313905
TEST=All existing tests pass trybots and waterfall

Review URL: https://codereview.chromium.org/60923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233304 0039d316-1c4b-4281-b951-d872f2087c98