GitLab

chrome://choose-mobile-network can be launched on a Chromebook without
any cellular modem. This CL changes the UI to handle such case more
gracefully:

- Without overhauling the UI too much, the UI is changed to simply show
  'No networks found'.
- When the Cancel button is pressed, the UI performs nothing.

BUG=714547
TEST=Tested the following:
- Launch chrome://choose-mobile-network on a Chromebook without a
  cellular modem. Verify that the UI shows 'No networks found'.
  Click the Cancel button and verify that the UI doesn't crash.
- Launch chrome://choose-mobile-network on a Chromebook with a cellular
  modem. Verify that the UI can populate a list of networks after
  successfully scanning for networks, and the Connect and Cancel button
  function correctly.

Review-Url: https://codereview.chromium.org/2851863003
Cr-Commit-Position: refs/heads/master@{#468176}

* Make TrustStore implement CertIssuerSource
* Add a method for getting trust/distrust of a certificate
* Remove the TrustAnchor abstraction

All the integrations (including CertVerifyProc) required full certificates anyway, so TrustAnchor ended up being more of a hindrance than benefit.

BUG=649017
TBR=dougsteed@chromium.org

Review-Url: https://codereview.chromium.org/2832703002
Cr-Commit-Position: refs/heads/master@{#468175}

Previously we didn't cache results of collapsed borders computation
during layout or overflow recalculation, so we had to recompute all
collapsed borders before paint invalidation if the table's collapsed
borders are marked invalid.

Now when a table's collapsed borders need to be invalidated, mark all
cells' collapsed borders need to be invalidated [1]. When a cell needs
its collapsed border values (regardless of lifecycle phase), we check
the invalidation flag and update and cache the result when necessary.

As LayoutTableCell::CollapsedBorderValues will be used for both layout
and paint, the include_color paremeter of ComputeCollapsedXXXBorder()
is removed.

As adjacent cells with the same span share collapsed borders, we can
also get the collapsed border from the adjacent cell if its collapsed
borders are valid.

[1] In the next step, we'll only invalidate collapsed borders for
affected cells instead of all cells.

BUG=626748,663208

Review-Url: https://codereview.chromium.org/2846563002
Cr-Commit-Position: refs/heads/master@{#468174}

Everything calling getBindingManager is already on launcher thread.
This removes the last lock in android's ChildProcessLauncher.

BUG=689758

Review-Url: https://codereview.chromium.org/2849943002
Cr-Commit-Position: refs/heads/master@{#468173}

BUG=715371
TEST=tests updated

Review-Url: https://codereview.chromium.org/2841223002
Cr-Commit-Position: refs/heads/master@{#468172}

R=hcarmona@chromium.org
BUG=715866

Review-Url: https://codereview.chromium.org/2848983002
Cr-Commit-Position: refs/heads/master@{#468171}

Make use of the existing PurgeEntriesWithTypeIn to purge the directory
of entries of the type we just migrated. Add a test that ensures this
happens.

R=skym@chromium.org

BUG=716156

Review-Url: https://codereview.chromium.org/2842373004
Cr-Commit-Position: refs/heads/master@{#468170}

BUG=690020

patch from issue 2847643002 at patchset 20001 (http://crrev.com/2847643002#ps20001)

Review-Url: https://codereview.chromium.org/2848683002
Cr-Commit-Position: refs/heads/master@{#468169}

The render surface layer list structure consisted of a top level
list of layers representing render surfaces, along with a list of
layers at each surface representing contributing layers or surfaces.

This CL replaces the render surface layer list with a top level
list of surfaces. Individual surfaces no longer store a list of
contributors.

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2834123002
Cr-Commit-Position: refs/heads/master@{#468168}

Applications sometimes use window.rAF while not presenting, then switch to
vrDisplay.rAF after presentation starts. Depending on the animation loop's
timing, this can cause a race condition where presentation has been started
but there's no vrDisplay.rAF pending yet. Ensure there's at least vsync
being processed after presentation starts so that a queued window.rAF
can run and schedule a vrDisplay.rAF.

BUG=711789

Review-Url: https://codereview.chromium.org/2848483003
Cr-Commit-Position: refs/heads/master@{#468167}

Replacing a TODO with actual store state.

BUG=714256
R=petewil@chromium.org

Review-Url: https://codereview.chromium.org/2841113003
Cr-Commit-Position: refs/heads/master@{#468166}

Revert of Enable HTTP/2 to use a LIFO scheduler to schedule write. (patchset #1 id:1 of https://codereview.chromium.org/2844963005/ )

Reason for revert:
Reverting in hopes of fixing net_unittests. Specifically NSS/ClientCertStoreTest/0.CertAuthorityFiltering . See 716630.

Original issue's description:
> Enable HTTP/2 to use a LIFO scheduler to schedule write.
>
> This CL lands server change 152524616 by yasong.
>
> BUG=488484
>
> Review-Url: https://codereview.chromium.org/2844963005
> Cr-Commit-Position: refs/heads/master@{#467971}
> Committed: https://chromium.googlesource.com/chromium/src/+/c443c00c0c9e10b8ced1064d7da18c3a9668cac2

TBR=bnc@chromium.org,yasong@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=488484

Review-Url: https://codereview.chromium.org/2849983002
Cr-Commit-Position: refs/heads/master@{#468165}

This CL:
* Fixes button spacing in the network details page.
* Fixes the on/off toggle button font and color for network and
  bluetooth
* Replaces incorrect primary/secondary button classes in dialogs
  with action/cancel-button
* Corrects the blue color for action buttons as per UX
* Converts the "add network" section to list-frame / list-item
  to correct borders and spacing.

BUG=710258,710259,710261
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2846763003
Cr-Commit-Position: refs/heads/master@{#468164}

Since there is no equivalent of ScopedComPtr::ReceiveVoid in ComPtr,
we have to mimic ComPtrRef and add ScopedComPtrRef to get the same
convenient void** access. This does introduce some complications for
uses of ScopedComPtr<T>* in templates and in concrete types, but there
aren't very many of those.

BUG=638327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=dalecurtis@chromium.org, thakis@chromium.org, wez@chromium.org

Review-Url: https://codereview.chromium.org/2850683002
Cr-Commit-Position: refs/heads/master@{#468163}

Requested by localization folks. Existing strings are difficult to
understand.

BUG=716574
TEST=none
TBR=cpu

Review-Url: https://codereview.chromium.org/2840323002
Cr-Commit-Position: refs/heads/master@{#468162}

The action will be used in a future changelist, landing soon.

BUG=687231

Review-Url: https://codereview.chromium.org/2847023002
Cr-Commit-Position: refs/heads/master@{#468161}

BUG=715466
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2839413004
Cr-Commit-Position: refs/heads/master@{#468160}

BUG=696009

Review-Url: https://codereview.chromium.org/2714193004
Cr-Commit-Position: refs/heads/master@{#468159}

This change forwards navigator.requestKeyLock() and navigator.cancelKeyLock()
functions to the RenderFrameHostImpl.

System-Keyboard-Lock is a feature to detect the key presses which usually cannot
be received by the browser, and send them to the web page. It contains various
components to achieve the goal. This change is one of them, which receives
JavaScript (or Web Platform API in the design doc) function calls and forwards
them into RenderFrameHost. For detail, please refer to the design doc at,
https://docs.google.com/document/d/1T9gJHYdA1VGZ6QHQeOu0hOacWWWJ7yNEt1VDbLju4bs/edit#heading=h.cgwemqs2j4ta

W3C Working Draft: https://garykac.github.io/system-keyboard-lock/
Intent to implement: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/9pauQUAvrcw/lfbG7eunCAAJ

BUG=680809
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2805763004
Cr-Commit-Position: refs/heads/master@{#468158}

View's native theme.

This fixes a few bugs where we weren't using the right native theme,
whether by not updating after the NativeTheme changes or by trying to
access the NativeTheme before the View is added to a hierarchy (which
yields the default NativeTheme --- for most platforms, this didn't
effectively create a bug as there's only one NativeTheme).

Best example is that now the sad tab respects the GTK native theme.

Get rid of Ash's tray_constants::kBackgroundColor in favor of using the
bubble background color from the NativeTheme.

This is a reland of 097f9cde with fix
for asan failure.

BUG=711183, 693282
TBR=stevenjb@chromium.org,tdanderson@chromium.org

Review-Url: https://codereview.chromium.org/2838273002
Cr-Commit-Position: refs/heads/master@{#468157}

When there are no windows opened, do not change the auto_hide status when
swiping down (or swiping up and then releasing) on the shelf.

BUG=310322

Review-Url: https://codereview.chromium.org/2824233003
Cr-Commit-Position: refs/heads/master@{#468156}

The layers panel ends up stealing focus and disrupting keyboard navigation.

BUG=706699

Review-Url: https://codereview.chromium.org/2819863004
Cr-Commit-Position: refs/heads/master@{#468155}

The follows the same pattern created for chrome activity test rules and test base,
where test rules and test bases share as much same implementation as possible in
the test common classes during the migration. For more on JUnit4 migration, please
check src/testing/android/docs/junit4.md

BUG=640116

Review-Url: https://codereview.chromium.org/2840933004
Cr-Commit-Position: refs/heads/master@{#468154}

https://swiftshader.googlesource.com/SwiftShader.git/+log/dc7759c..35e0ba7
Use pthread mutexes on Linux instead of custom spin lock.
Fixes compilation issue.

BUG=chromium:714412

TBR=kbr@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2850843002
Cr-Commit-Position: refs/heads/master@{#468153}

This reverts commit c54fcea4.

Reason for revert: Broke downstream monochrome build.
https://bugs.chromium.org/p/chromium/issues/detail?id=716425

Original change's description:
> [about:credits] Improve compression by sorting licenses
> 
> Restore the alphabetical order in javascript.
> 
> Saves around 100k when gzip is used, but only 2k for brotli.
> Intention is to have android_webview to use the same copy
> of about:credits in a follow-up, in which case this optimization
> becomes relevant.
> 
> BUG=688077
> 
> Change-Id: I24d62a81c61c2c53f5740f90d0c8094d3b04352e
> Reviewed-on: https://chromium-review.googlesource.com/487725
> Reviewed-by: Richard Coles <torne@chromium.org>
> Reviewed-by: Dan Beam <dbeam@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Commit-Queue: Yipeng Wang <yipengw@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#467537}

TBR=dbeam@chromium.org,torne@chromium.org,agrieve@chromium.org,yipengw@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
BUG=688077

Change-Id: I08d4da9f1c7ab45b15b14973d334feb4485c3ee6
Reviewed-on: https://chromium-review.googlesource.com/490709Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468152}

This is only needed until the next ANGLE roll.

BUG=705865,716432
TBR=geofflang@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2849863003
Cr-Commit-Position: refs/heads/master@{#468151}

All non-test callers of ReportSender use CookiePreferences::DO_NOT_SEND_COOKIES.
Remove the enum altogether.

BUG=716098

Review-Url: https://codereview.chromium.org/2851493003
Cr-Commit-Position: refs/heads/master@{#468150}

Adds two new policies, RemoteAccessHostDomainList and
RemoteAccessHostClientDomainList, which allow specifying a list of
allowed domains. Deprecates the existing RemoteAccessHostDomain and RemoteAccessHostClientDomain policies.

BUG=624620

Review-Url: https://codereview.chromium.org/2682473003
Cr-Commit-Position: refs/heads/master@{#468149}

Linux dmabuf code has recently been moved from ozone to ui/gfx/linux.

This CL adds an owners file with the chromium users that usually work
with dmabuf code.

BUG=

Review-Url: https://codereview.chromium.org/2842393002
Cr-Commit-Position: refs/heads/master@{#468148}

BUG=711307
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2843223004
Cr-Commit-Position: refs/heads/master@{#468147}

This change changes the various base::DictionaryValue::Set* methods to
return a pointer to the newly added Value. This is in response to the
discussion on https://codereview.chromium.org/2845113002/.

Furthermore, this is motivated by the fact that various insert methods
of std::map also return a handle to the just added element.

R=brettw@chromium.org
BUG=646113

Review-Url: https://codereview.chromium.org/2850773002
Cr-Commit-Position: refs/heads/master@{#468146}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/75378bf9..632d0542

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2848923003
Cr-Commit-Position: refs/heads/master@{#468145}

These tests are failing due to scrollbars in the image diff, likely triggered
by changes on http://crbug.com/606395.  Mark them failing for now to get the bot
green again.

BUG=716569
TBR=rogerta

Review-Url: https://codereview.chromium.org/2849953002
Cr-Commit-Position: refs/heads/master@{#468144}

Review-Url: https://codereview.chromium.org/2846983003
Cr-Commit-Position: refs/heads/master@{#468143}

Flip FLAGS_quic_reloadable_flag_quic_remove_multipath_bit to true.
https://codereview.chromium.org/2849543003/

Rename FLAGS_quic_enable_version_39 to
FLAGS_quic_reloadable_flag_quic_enable_version_39.
Merge internal change: 154330328
https://codereview.chromium.org/2848633003/

Include "base/macros.h" in quic_mutex.h
Merge internal change: 154304557
https://codereview.chromium.org/2841283003/

Part of QUIC v39 change: 1) do not ack acks. 2) Send a WINDOW_UPDATE
frame every 20 packets which do not have retransmittble frames.
Merge internal change: 154290226
https://codereview.chromium.org/2846033002/

In QUIC v39, read and write integers and floating numbers in big endian.
Merge internal change: 154287990
https://codereview.chromium.org/2842373003/

Make QuicSession::OnFinalByteOffsetReceived virtual.
Merge internal change: 154212957
https://codereview.chromium.org/2840423003/

Fix packet conservation logic in QUIC BBR.  Protected by
FLAGS_quic_reloadable_flag_quic_bbr_fix_conservation.
Merge internal change: 154129181
https://codereview.chromium.org/2848633002/

QUIC: correctly update local stream state on receipt of trailers after
sending RST. Protected by
FLAGS_quic_reloadable_flag_quic_final_offset_from_trailers
Rename UpdateFlowControlOnFinalReceivedByteOffset to
OnFinalByteOffsetReceived as it is not limited to updating flow control
(also removes streams from locally_closed_streams_highest_offset).
Merge internal change: 154081704
https://codereview.chromium.org/2850523002/

Delete QUIC/SPDY utility methods for parsing headers/trailers.
Merge internal change: 154068097
https://codereview.chromium.org/2850513002/

Remove unused packet parameter from
QuicTimeWaitListManager::ProcessPacket.
Merge internal change: 153857099
https://codereview.chromium.org/2849543002/

Remove unused packet_number parameter from multiple functions in
QUIC.
Merge internal change: 153847178
https://codereview.chromium.org/2846013002/

Deprecate
FLAGS_quic_reloadable_flag_quic_remove_packet_number_from_public_reset.
Merge internal change: 153829126
https://codereview.chromium.org/2846003002/

Some changes to prepare for endian change for QUIC:
1) Make data reader/write be able to read/write integers and floating
numbers in big endian.
2) Make data reader/write be able to read/write 24/40/48/56-bit
integers.
3) Add functions to read/write QuicPacketNumber, QuicStreamId,
QuicStreamOffset in QuicFramer.
Merge internal change: 153820887
https://codereview.chromium.org/2847753002/

Remove std::move from return statements.
Merge internal change: 153819488
https://codereview.chromium.org/2851503002/

BUG=

Review-Url: https://codereview.chromium.org/2850573002
Cr-Commit-Position: refs/heads/master@{#468142}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/5fa840e82c50..fa1d11d0530d

$ git log 5fa840e82..fa1d11d05 --date=short --no-merges --format='%ad %ae %s'
2017-04-28 bpastene devil: Increase timeout of TIME_SET intent in provision_devices

Created with:
  roll-dep src/third_party/catapult
BUG=716441


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ib22b476709fab0f58ed7f1bafcb10372be08b4dd
Reviewed-on: https://chromium-review.googlesource.com/490535
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468141}

If the WebVR document loses focus, check if the new focused element is an
embedding local parent frame. If that's the case, continue presenting.  This
fixes issues with Cardboard-style touch events that are reported as a click at
viewport (0, 0) where the resulting focus loss stopped presentation.

BUG=710863

Review-Url: https://codereview.chromium.org/2847233002
Cr-Commit-Position: refs/heads/master@{#468140}

Manually convert to use new Audit.

BUG=704967
TEST=constructor/mediastreamaudiodestination.html

Review-Url: https://codereview.chromium.org/2835943004
Cr-Commit-Position: refs/heads/master@{#468139}

old: FLAG_##flag: 1
new: FLAG_quic_reloadable_flag_quic_flow_control_faster_autotune: 1
Review-Url: https://codereview.chromium.org/2846673007
Cr-Commit-Position: refs/heads/master@{#468138}

Adds an experimental gesture on Android, which automatically
enters/exits fullscreen when the user rotates their device to/from the
natural orientation of the video.

Disabled by default; see video-rotate-to-fullscreen in chrome://flags

BUG=713225

Review-Url: https://codereview.chromium.org/2830713003
Cr-Commit-Position: refs/heads/master@{#468137}