- 16 Nov, 2020 40 commits
-
-
Tim Sergeant authored
This is a reland of 5d6ecbfb The failing Tast test (ui.ShelfLaunchedApps) has been updated to ensure it continues passing after this CL is landed. This is the second of a chain of 3 CLs: 1. crrev.com/c/2538305: Allow Files app to be pinned by default in ui.ShelfLaunchedApps 2. crrev.com/c/2538857: Add Files app to default shelf pins in second position 3. crrev.com/c/2538307: Update ui.ShelfLaunchedApps to ensure Chrome and Files are always pinned Original change's description: > CrOS: Add Files app to default shelf pins in second position > > This adds the Files app to the spot after the Chrome icon, for new users > only. There's also some variations of the default pin layout controlled > by a Finch experiment, I've moved the Files app up in those layouts for > consistency. > > This change was requested for M88 and will be merged back. > > Bug: 1148519 > Change-Id: Iae54561fec599b813ba97e82a5678fa834a02db2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537214 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> > Auto-Submit: Tim Sergeant <tsergeant@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827272} Bug: 1148519 Change-Id: I9186b43a651dea4c4de9e46f849d35da9cc6062c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538857Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Tim Sergeant <tsergeant@chromium.org> Cr-Commit-Position: refs/heads/master@{#827981}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f46e6201b40b..620cb770e3dd 2020-11-13 syoussefi@chromium.org Fix texture buffer unbind and size query 2020-11-13 senorblanco@chromium.org Wrap a paragraph in DevSetup docs to 100 chars. 2020-11-13 senorblanco@chromium.org Fix some apostrophes, because I'm possessive like that. 2020-11-13 timvp@google.com Vulkan: Suppress VkSubpassDescriptionDepthStencilResolve 2020-11-13 timvp@google.com Add test running flag: --delay-test-start 2020-11-13 senorblanco@chromium.org Fix EGL_ANGLE_platform_extension* filenames in DevSetup docs. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Test: Test: KHR-GLES31.core.texture_buffer.texture_buffer_parametersTest: Test: dEQP-GLES31.functional.texture.texture_buffer.state_query.texture_buffer_size_integer Change-Id: I16f60b0dabd54a7092c51e8a32d8f45f2f00144b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537054Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#827980}
-
My Nguyen authored
Bug: b/173433294 Change-Id: Iabb04f870cc05700bbdf7823c7296ddce221ee15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541943Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#827979}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605516929-4169c4fef8b75b908f60a07df9383038ad3b6191.profdata to chrome-win64-master-1605538580-6a865849c18026af9e6bfd8c91f845d03275941b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7d9224677584f66329589054ed9aeae2d7fc3c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541903Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827978}
-
Thomas Guilbert authored
This reverts commit fc8af8e6. Reason for revert: Crashing on MAC bots https://ci.chromium.org/p/chromium/builders/ci/Mac10.15%20Tests/5816 Original change's description: > Fix Crash in Hung Pages view while in screen reader > > There seems to be a timing issue between the AX queries for > GetText and when the model is updating. Looking at the model > it seems not all TabDestroyed calls are informing the Observers > that the model has changed. > > The TableView uses Virtual AX Children that depends on the > observers to call. Moved the observer call from TabDestroyed to Reset > to handle all delegate_->TabDestroyed() calls defined below: > > - RenderProcessExited > - RenderWidgetHostDestroyed > - TabDestroyed, > - RenderViewHostChanged > - WebContentsDestroyed > > Bug: 1140454 > Change-Id: Ie7fd07d6540b9509b998d5cd95d1fd16f47f9018 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530295 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Mohamed Mansour <mmansour@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#827900} TBR=sky@chromium.org,tapted@chromium.org,robliao@chromium.org,dfried@chromium.org,mmansour@microsoft.com Change-Id: Ifb73fc1762d043fbba1d3a3a8b5744c169b9a88b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1140454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543191Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#827977}
-
Noel Gordon authored
No "(c)" in chrome project copyright notices. Comment only change. No-try: true Bug: 1113981 Change-Id: I35202f41caeff12d3fdae794ae7c6a74af27939f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542927Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#827976}
-
Sebastien Lalancette authored
Tapping anywhere else on the app (e.g. the keyWindow) will make the popover disappear. Bug: 1149618 Change-Id: If7f712cd3498b0a055a364d047105464d58492d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542366 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#827975}
-
Robert O'Callahan authored
Expose v8dbg symbols so that V8's postmortem metadata is accessible in the Chromium binary, if built Exposing the v8dbg postmortem metadata symbols in Chromium builds (when built, which they aren't by default) enables detailed analysis of V8 JS execution by observing binary-level execution: https://robert.ocallahan.org/2020/05/omniscient-js-debugging-in-pernosco.html Bug: 1147409 Change-Id: I8f5863df2c2860ce3120c548e915f95bd16d321c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528209Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#827974}
-
Wenyu Fu authored
HomepageSettings is 100% launched in M83. Cleaning: 1. Feature flag; 2. HomepageEditor and related tests Change-Id: I65c99cbf45014805044a01933e2f971d8393a2d3 Bug: 1148104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536084 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#827973}
-
Luciano Pacheco authored
Add the build rules to build the background page as JS module. Bug: 1133186 Change-Id: Ic2759ebd3475ca01f49f153020a16a99673a4fc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537448 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#827972}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7a9525a7. With Chromium commits locally applied on WPT: eaff997c "[GridNG] Allow stretching in block-axis." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools guidou@chromium.org, armax@chromium.org: external/wpt/mediacapture-streams guidou@chromium.org, emircan@chromium.org, emircan@chromium.org: external/wpt/screen-capture yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I3aa16341bea4c78b99bd9cb7cce8368bf7e18a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541605Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827971}
-
Darren Shen authored
It is never used. Change-Id: Ida1aab177d931ce174c0278aefc8b5a02a761132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539216Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#827970}
-
Nate Chapin authored
NavigatorBase is a newly-added base class for Navigator and WorkerNavigator. Making MediaCapabilities a Supplement of NavigatorBase allows a single class to handle all of the work of exposing the navigator.mediaCapabilities getter for both windows and workers, and greatly reduces boilerplate. Bug: 1147612 Change-Id: I06f0e138a2be9ce0cd170e43c7997cd69340de24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537780 Auto-Submit: Nate Chapin <japhet@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#827969}
-
Nnamdi Theodore Johnson-Kanu authored
Fix regression caused by this cl crrev.com/c/2490785. screenshot: https://screenshot.googleplex.com/5nHRPBM6j8Wkn9H.png Bug: 1148721 Change-Id: I6070847c567f0ccee28a574722996445597c3d3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541226 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#827968}
-
Zhaoyang Li authored
https://chromium.googlesource.com/external/github.com/google/EarlGrey.git/+log/e8573af9803f..891b1b683a7e $ git log e8573af98..891b1b683 --date=short --no-merges --format='%ad %ae %s' 2020-11-12 albertbow Fix xcode complaint of "implicit reference of 'self'". 2020-11-09 chanheepark Move performing action to the main thread to improve stability. 2020-11-09 tirodkar Test rig cleanup 2020-11-09 chanheepark Use common method for snapshotElement: method in GREYScreenshotter. 2020-11-06 chanheepark Add shouldRunOnMainThread method to GREYAction protocol. 2020-11-06 tirodkar Export GREYConstants.h 2020-11-04 mobile-devx-github-bot Use common method for snapshotElement: method in GREYScreenshotter. 2020-11-03 chanheepark Use common method for snapshotElement: method in GREYScreenshotter. 2020-11-03 tirodkar NSTimer Ignoring 2020-11-03 tirodkar FunctionalTest Failure handler cleanup 2020-11-02 mobile-devx-github-bot Fix "variable length array folded to constant array as an extension" 2020-10-29 tirodkar NSRunloop tracking improvements 2020-10-29 tirodkar Multi-window setter API. 2020-10-27 tirodkar Dedupe superview/subview pairs. 2020-10-27 chanheepark Location alert strings cleanup and add iOS 14 string. 2020-10-27 tirodkar Fix type text comment in GREYActions.h 2020-10-23 albertbow Update Demo app's Podfile since EarlGrey now pins to eDO 1.0.1. 2020-10-23 tirodkar Verblose Log docs 2020-10-23 chanheepark Modify system alert text check so it doesn't depend on the iOS version. 2020-10-21 tirodkar Add CLLocationManager to GREYValueType 2020-10-21 tirodkar Successful app launch eDO property. 2020-10-21 chanheepark Internal 2020-10-21 mobile-devx-github-bot Add dismissKeyboard to the Swift EarlGrey wrapper. 2020-10-20 albertbow Update Podspec for 2.2.0 release. 2020-10-19 tirodkar Update GREYLogger docs. 2020-10-16 albertbow Update CHANGELOG.md for 2.2.0 release. 2020-10-09 tirodkar GREYCAAnimationDelegate optimization. 2020-10-09 chanheepark Internal 2020-10-07 tirodkar Internal 2020-10-07 chanheepark Use runloop spinner to wait for the keyboard to appear instead of CFRunLoopRunInMode. 2020-10-06 chanheepark Track completion block for UIView animations for better synchronization. 2020-10-06 tirodkar Device test fix. 2020-10-06 chanheepark Wait for the uppercase keyplane to appear when autocapitalization is on. 2020-10-02 tirodkar Fix runtime-error with functional tests. 2020-09-30 tirodkar Fix Xcode project in OSS 2020-09-29 tirodkar Fix Slide test for Xcode 12. 2020-09-28 chanheepark Minor improvements / cleanups. 2020-09-28 tirodkar Fix nullability in GREYLogger 2020-09-25 tirodkar Verbose Logging Config. 2020-09-24 tirodkar Context Menu support 2020-09-24 albertbow Fix isKindOfClass check in Diagnostics. 2020-09-23 tirodkar Small accessibility refactor 2020-09-18 albertbow Adds C helper functions to transfer array's hosting process in EarlGrey. 2020-09-17 tirodkar Fix iOS 14 selection test. Created with: roll-dep src/ios/third_party/earl_grey2/src Bug: 1146576 Change-Id: Ia6cab97990b3e7ee4edef812cad7a7734cb89186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536814Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#827967}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a73ba689e695..598b98fe2b9b 2020-11-16 chrche@microsoft.com [Loc] Migrate web_audio to localization V2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I996410c33248685d534f0b67778bc01fd8042311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542312Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827966}
-
Tanya Gupta authored
Added logic to call FDT in the tab service to capture the bitmap. Change-Id: I9c0e01641b6393ded8227e82fddd0b63c895e45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533327Reviewed-by:
Kyle Milka <kmilka@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#827965}
-
Michael Checo authored
Screenshot: http://shortn/_5A4TAyrSyR Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I3413faa94c5c451596f4f37dce2d906b55fa35b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527821 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#827964}
-
Dale Curtis authored
This is necessary to help debugging efforts. R=tguilbert Bug: 1148800 Change-Id: If638329d288701b1a95e7215935a4cf424dafcc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542048 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#827963}
-
Jonathan Ross authored
We currently measure Histograms in perf benchmarks. This is done by emitting a trace of all histograms from startup. Then emitting another at the end of tracing. Then in Catapult we calculate differences in uma_metric.html However this has led to issues in the past with mis-calculating buckets of histograms. It also currently breaks down when histogram emitting changes occur near the startup. To help clear this, we want to not record the initial histograms. But instead calculate the differences. Thus emitting only one sample for Catapult to process. We will then reduce the complexity of uma_metric's processing in a follow up change in Catapult. Bug: 1145731 Change-Id: Ia6452984a16914aaf19e66c22d583592835f46df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521106Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#827962}
-
Shrek Shao authored
Proposal approved by privacy: go/client-rendering-api-drawn-to-ukm-review Add collections for Canvas/OffscreenCanvas context type: webgl, webgl2 that have draw calls issued. Tested locally with a list of draw call variants: drawArrays/Elements(Instanced) drawRangeElements MultiDraw variants BaseVertexBaseInstance variants Bug: 1147234 Change-Id: I3ae70f0585f9591a64bef2cb9d50afd72dd2aec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537090Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#827961}
-
James Forshaw authored
This CL removes the support for redirecting the OPM APIs when running under Win32K lockdown. These were added to allow Flash to enable HDCP and with Widevine moving to a utility process are no longer required. Bug: 1148912 Change-Id: Ia5ec0cd54d9ae6fec28b5603693ffde7c725f194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536847Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#827960}
-
Bo Liu authored
BaseInputConnection will keep a reference to the container view, which causes leaks after onDetachedFromWindow. Bug: 1149336 Change-Id: Iee7683092ea6f8878a09de78a09d044d8d29d246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536785 Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Auto-Submit: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#827959}
-
Justin Donnelly authored
Bug: 1149562 Change-Id: Iaf0d7104fd0f90100e7c112d65baa602638163bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542044Reviewed-by:
Orin Jaworski <orinj@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#827958}
-
Vladimir Levin authored
This patch renames a wpt, since the fact that the property is no longer animatable has been approved by csswg. R=chrishtr@chromium.org Change-Id: Ib6e937d6df223755f67c3698a0cb09aba7775fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542368 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#827957}
-
Joel Hockey authored
The current code in FileHelper assumes all windows are Arc. We now check the source and target aura::Window to detect and do the appropriate path translations and share files when necessary with crostini/pluginvm. For example, when crostini is the drag source, we will convert paths such as: <homedir>/file => /media/fuse/crostini_<hash>_termina_penguin/file And do the opposite translation when crostini is the drop target. We also convert paths and share files such as: <cryptohome>/MyFiles/file => /mnt/chromeos/MyFiles/file /media/removable/MyUSB => /mnt/chromeos/removable/MyUSB For PluginVM, the translation is <cryptohome>/MyFiles/file => //ChromeOS/MyFiles/file /media/removable/MyUSB => //ChromeOS/removable/MyUSB Bug: 1144138 Change-Id: I2bb38336537acf13c4797374d6dabe6e518d689e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517346 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Jason Lin <lxj@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#827956}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/02736010cb17..afaca889d46b 2020-11-16 mbonadei@webrtc.org Trigger tests. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I30f12b8d82879b894ac6ff6aeec32f9b6d11fa43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541911Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827955}
-
chrome://omniboxdpapad authored
The |flattenhtml| parameter, which the code previously relied to inline several icons, is not supported (purposefully) by generate_grd(). Addressed as follows: - icon_tabs.svg: Served from chrome://omnibox/, only used there. - cancel_red.svg and check_circle_green.svg: Exposed via chrome://resources/ URLs - ic_download.svg: Inlined in CSS directly, since this WebUI doesn't use <iron-icon> Bug: 1132403 Change-Id: Ib1738228cc90b193b8534ca9b27d1fb571503f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536152Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#827954}
-
Roger McFarlane authored
Bug: 1110384 Change-Id: I4b0fa3a00beadc760bdb4a0c845d651e792fac39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542422Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#827953}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/dd6b36e8801e..2c5b040b5c2a 2020-11-16 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from e5e961722054 to 4ad0019df0f0 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: I9611a1ba0b085925c2f1ba7f74a203f437b96830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541918Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827952}
-
dpapad authored
In this CL updating chrome://management and chrome://browser-switch. Launch Chrome with the following flags to experience dark scrollbars. --enable-features=WebUIDarkMode,CSSColorSchemeUARendering \ --force-dark-mode Bug: 1142291 Change-Id: Ib5abc4a5bca883b01a796890f18320db2349e1a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536795Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#827951}
-
Kartik Hegde authored
Since UDP connections do not guarantee a response from the other side, include a timeout to avoid infinitely waiting. BUG=BUG=b/172994051 TEST=unit_tests --gtest_filter=UdpProberWithFakeNetworkContextTest.* Change-Id: I09a33ef8d21516edfa30ebbe53cb0f6e336eedc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539766 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#827950}
-
rbpotter authored
Enable the 5 zoom related tests that had been disabled with the update enabled in both flag states, as the underlying Blink issue has now been resolved. Make a few adjustments to the ZoomWithoutBubble test, as recent updates to the new UI had caused the test to fail with the update flag on. Bug: 1137905 Change-Id: Iead2dfb1f0dc3eab30553bc8b1e75a353049b5c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538367Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#827949}
-
Koji Ishii authored
Moving to |ComputedStyle| has following benefits: * Reduces the usage of |LayoutObject| in NG code. * Uses first-line style correctly when we have |NGPhysicalFragment|. This patch has no behavior changes. Bug: 1145048 Change-Id: If1298087754286e7a5ec1935fc1ba52d1298770f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536585Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#827948}
-
Nnamdi Theodore Johnson-Kanu authored
Before this CL, if a network APN list is empty or undefined a user is not able to manually enter a custom APN. This CL fixes this issue and allows a user to manually enter a new custom APN Bug: 1146524 Change-Id: I6ec01936cb32eefd2627e4447fe5055c99dd1401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537926 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#827947}
-
Andrew Grieve authored
This reverts commit 86befdda. Reason for reland: Bugs fixed in other CLs (see issue) Original change's description: > Revert "Android: Enable use_debug_fission for official builds" > > This reverts commit 9d3a4611. > > Reason for revert: Official builds failing crbug.com/1144538 > > Original change's description: > > Android: Enable use_debug_fission for official builds > > > > Bug: 1122182 > > Change-Id: I29b579cf7c5e7eb6d2528a6fad28562059698bf8 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508342 > > Reviewed-by: Ben Mason <benmason@chromium.org> > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#822625} > > TBR=agrieve@chromium.org,benmason@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1122182,1144538 > Change-Id: I49cb3f0d42027a5e855cf1aa16f8cd1441f46ca9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513206 > Commit-Queue: Krishna Govind <govind@chromium.org> > Reviewed-by: Ben Mason <benmason@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823080} Bug: 1122182 Bug: 1144538 Change-Id: Id3bcf776146a9bd9e66ec50cd8b9529029479faf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541383 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#827946}
-
Jonathan Freed authored
Bug: 1149344, 1128269 Change-Id: I471ddf82d612de72085629ddaeb29c68b48d6f91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542159 Commit-Queue: Jonathan Freed <freedjm@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Auto-Submit: Jonathan Freed <freedjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#827945}
-
Miriam Zimmerman authored
The Platform.DailyUseTime metric is used to monitor system health on numerous dashboards, and as such it should not expire. BUG=chromium:1089270 TEST=CQ Change-Id: I28d8593a3cf935d4ba7c1b8f4d76d521f8f0b495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541784Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#827944}
-
Gabriel Charette authored
This allowance seems like an unintentional overlook of the fact that DidRunTask() runs microtasks. Microtasks should be treated the same as regular application tasks and not be allowed to implicitly nest application tasks. R=altimin@chromium.org Change-Id: Ie3f9d41d7525e465f813c7e2456cce3f4394ad57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537002 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#827943}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1e5da6b5b505..9e371caae2fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tguilbert@google.com,lgrey@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1047896,chromium:897470 Tbr: tguilbert@google.com,lgrey@google.com Change-Id: I348d2e942e7c3b58d32fcb1c6216cd06e8cd1c6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542306Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827942}
-