- 02 Oct, 2020 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/36366209d412..6d696086211d 2020-10-02 johnstiles@google.com Store a unique_ptr* for a candidate's parent statement. 2020-10-02 egdaniel@google.com Always bind input attachment to all pipelines in subpasses that uses one. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1134454 Tbr: brianosman@google.com Change-Id: Idfac697a3bd46168f0ec2aea96edf73b4c67219e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446756Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813372}
-
Siyu An authored
Bug: 1112095 Change-Id: I3137ed5e2bda1a3408b1c08d5f163e159780a7c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444456Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#813371}
-
Michael Checo authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Ib7591b14f25a67815a9a19eb09745b62d0560631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431411 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#813370}
-
Ted Meyer authored
(use_v4l2_codec || use_vaapi) was being used as a poor proxy for chromeos builds. Also reformat the file. Change-Id: I9eb3615935c7cbc07f7f0918dad40ce80468c760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441733Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#813369}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/be7345166a4f..77107392837f 2020-10-02 rwkeane@google.com [Discovery] Fix MdnsRecord Comparison Bugs 2020-10-02 jophba@chromium.org Add more trace logging to standalone_ impls 2020-10-02 jophba@chromium.org [Minor] fix periods in headers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I174576872ef782a03d747e35cdfb7d585915d397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446752Reviewed-by:
-
Sven Zheng authored
This reverts commit 01d5d6cf. Reason for revert: Breaks lacros builder. https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-builder-rel/4366? Original change's description: > Switch angle_unittests to isolated script API. > > Uses the new 'use_isolated_scripts_api' feature added here: > https://crrev.com/c/2425210 to switch the tests to the ANGLE > standalone testing harness. > > Bug: angleproject:5124 > Change-Id: I363997060874df09653bcb78bb9c57f3cce3f6e7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441149 > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813269} TBR=ynovikov@chromium.org,dpranke@google.com,jmadill@chromium.org Change-Id: I7d8a8b4f312038c40d8090d30b95da23ccc17df2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:5124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446655Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#813367}
-
Aleks Totic authored
NGTableTypes::Columns is not dependent on ConstraintSpace, and can be shared between MinMax/Layouts. It gets cached in LayoutNGTable. Cache is invalidated by LayoutObject bitfield: TableColumnConstraintDirty() TableColumnConstraintDirty gets set when table needs layout (SetNeedsLayout/SetChildNeedsLayout) Cached Columns need to be immutable. Had to modify few parts of code that assumed Columns were mutable, mostly in NGTableAlgorithmHelpers. Some related fixes in ng_length_utils included, will need review. Few minor fixes that were in the same files included too. Bug: 958381 Change-Id: I497c03b2e0b8c8d58b90cde8d0f21f240bac573a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436302 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#813366}
-
David Van Cleve authored
We're seeing a surprising number of "TypeError: Failed to fetch" errors in live testing when executing fetches with accompanying Trust Tokens operations (see the linked bug---internal due to describing metrics, sorry---for more information). Analyzing logs added in crrev.com/c/2416882 shows that these failures are *not* due to an increased incidence of connection-related errors (DNS, ERR_CONNECTION_FAILED, etc), so it seems likely that they could be due to some kind of Fetch API requirement being violated closer to the fetch callsite. This CL adds some temporary logging to fetch_manager.cc that, for failed fetches with accompanying Trust Tokens operations, histograms a reason why the fetch failed. This is the union of: - a new enum that captures each code path into FetchManager::Loader::Failed - a ResourceRequestBlockedReason. I've filed crbug.com/1133944 to track cleaning up these log lines after the investigation has finished. Test: expands trust_token_browsertest to cover some logging cases Bug: 1128174 Change-Id: Idbe424a3b68939a687ea1243cf1b9a681e82e51b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442229Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#813365}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601575120-30d2ff52ccba123fa446e04afa93e5dc42388f0f.profdata to chrome-mac-master-1601661327-f1cf60f844e0debf5bf4063a28b1716a25f6a438.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: If59e218148889559065bee5046033f835ee76884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446758Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/39117d2b244e..e4b0c039a1f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kelvinjiang@google.com,anthonyvd@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1134625 Tbr: kelvinjiang@google.com,anthonyvd@google.com Change-Id: I0f95bb530630bddcad88e49aa5e4456609e7936f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446753Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813363}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c0482f7bd156..9b8970cc0198 2020-10-02 treehugger-gerrit@google.com Merge "Reserve space for frames in AllocRecord." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia4c76bbceafcfca75f862c3e7970e8136dbe7fb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446757Reviewed-by:
-
Akihiro Ota authored
The interactive tutorial uses hard-coded strings to specify text content. Included in this patch: 1. Add tutorial_common.js, which can be used to share code between the tutorial and lesson components 2. Add a function, getMsg(), to fetch localized strings 3. Change some hard coded strings to message IDs 4. Clean up BUILD.gn fr and es) and verify that content gets translated. Bug: 1075752 Test: Manually load the tutorial in several locales (I used Change-Id: I5784f1466f3646e31a41145478db9dfcb766f70e AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254345 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#813361}
-
Anne Lim authored
Bug: 1121806 Change-Id: I8a24e775c3b3955a86d606d199f6ee966f681ea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444431Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#813360}
-
Tommy Li authored
We are no longer using ZeroSuggestVariant. Instead, we are moving to using separate base::Feature flags for each experiment. See here for a discussion about removing this: http://g/chrome-omnibox-team/lNT8EsY1gFI Bug: 1124050 Change-Id: I20fb3d79ad2ab64fb7daf52729449cbad3193e75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430227 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#813359}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8c88c750bd45..b494582b95e5 2020-10-02 bsheedy@chromium.org Revert "Make Catapult build as a part of Chromium under Python 3." 2020-10-02 bsheedy@chromium.org Revert "[Devil] Add install sanity check" 2020-10-02 landrey@webrtc.org Reduce upload completion token usage back to 5% 2020-10-02 dpranke@google.com Make Catapult build as a part of Chromium under Python 3. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1112471,chromium:1114061,chromium:1132297,chromium:1134629 Tbr: oysteine@google.com Change-Id: I7496a084db82d0b09b4e5410b9ed78eb16a38618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446750Reviewed-by:
-
Dave Tapuska authored
The content side was deferring to the gfx:: structs so just use them on the public blink API. BUG=738465 Change-Id: I4f8f449d86310fa80b72054c8465756a17b90f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443534Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#813357}
-
Bo Liu authored
This reduces binary size. Change-Id: I99d5567246baa03865bd822b9b7f6dced1fdecf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446020Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813356}
-
David Bienvenu authored
This reverts commit 1a8fc80a. Reason for revert: <relanding with fix for crbug.com/1132543> Original change's description: > Revert "Make Launch.Modes an enum histogram, not sparse." > > This reverts commit 085b583f. > > Reason for revert: <crbug.com/1132543> > > Original change's description: > > Make Launch.Modes an enum histogram, not sparse. > > > > In response to comment on crrev.com/c/2384332. > > > > Per mpearson@: For enums versus sparses, the underlying UMA > > data / logs will look the same. It's only the implementation > > in Chromium that would be different. > > > > Change-Id: Ia75d78379977f36ec7873d5fb5d52998e6a366d3 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429975 > > Reviewed-by: Peter Boström <pbos@chromium.org> > > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#810438} > > TBR=pbos@chromium.org,davidbienvenu@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Change-Id: Ia7edc131b855a4ceb384b8e2d76055386d1044c6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433060 > Reviewed-by: David Bienvenu <davidbienvenu@chromium.org> > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811005} TBR=pbos@chromium.org,davidbienvenu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ia1a2167c31b5bcb076e9f334151a46e369cc676a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436390Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813355}
-
James Cook authored
Exercise the basic API (create, get, close). This test depends on the parent CL which adds the API for GetDisplayedNotifications. Bug: 1134389 Test: lacros_chrome_browsertests Change-Id: Ia8da142ee0f0ee60af2664098ebd11dc06a2a1f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445851 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#813354}
-
Morten Stenshorne authored
In certain cases it was possible to lay out stuff before and after a spanner in the same column, because we didn't detect that something broke. This was due to an ancient out-of-space check in FinalizeForFragmentation(), which sometimes prevented us from finishing fragmentation correctly (the assumption was that if there's zero space left, this fragment can't fit here (so just return early), but that's not necessarily true). Check correctly for out-of-space in the generic fragmentation machinery instead. This addresses a TODO about DCHECKing that we broke inside when encountering a spanner. Bug: 829028 Change-Id: I86af5dcdf01e44c2b0d05d7c6c04821000b25426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443854 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
-
Lijin Shen authored
PackageManagerUtils#resolveDefaultWebBrowserActivity can return null. The utils should return no in this case. Bug: 1131772 Change-Id: I7421d250e01ca8149e284e474c5c8852a79b3668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436393 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#813352}
-
Thomas Lukaszewicz authored
This CL adds class member getters and setters to the BoxLayout class where needed for the BoxLayoutView properties. Adds a TODO to ensure layout is invalidated when these members are set. Bug: None Change-Id: I13d73c75ca93f9de391b46c7241682ee7ced9a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434561Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#813351}
-
Alexander Cooper authored
While not fully moving the InstallHelpers to a component yet, this reduces their dependency on //chrome specific code, and gets them a step closer to being moved to //components. The main dependencies that needed to be broken were on Tab/TabUtils. Tab was typically used to get the WebContents and the Activity. WebContents are now passed directly in, rather than gotten from the Tab (which in C++ code was gotten from the WebContents anyway...), and are then used to get the top level window and thus the appropriate corresponding activity. In addition to removing these dependencies on TabUtils, the ArCore's install helper *also* now uses ApplicationStatus to track when it is resumed, thus reducing it's dependency on ChromeActivity. This is similar to what Vr does for it's DFM install. VR's install path is a bit different in that it launches an activity for a result, and thus that is not changed quite yet. Bug: 960542 Change-Id: Ia42a73ecd1c491ee9899f8113a2905860b66366a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438639 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#813350}
-
Kai Ninomiya authored
TBR: kbr@chromium.org Bug: 663601, 679058 Change-Id: Ib861dc6a8e40cc2038359a04113db757fb8d210e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446594Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#813349}
-
evliu authored
This is a reland of 6ff69d8a Original change's description: > Move SODA client unit test to Chromium repo > > This CL moves the SodaClientUnitTest from the internal SODA repo to the > Chromium repo. > > Bug: 1124873 > Change-Id: Ib2dabb242f21817a117f379fb0a1b017dd5bcffc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443218 > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: Evan Liu <evliu@google.com> > Cr-Commit-Position: refs/heads/master@{#812968} Bug: 1124873 Change-Id: Ic6de3f55a80d15165a92fb474b41b8999394aa8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444116Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#813348}
-
Nick Harper authored
Change-Id: I87ccef2bb33ee0651a254ac539b8ad21872df6b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437475Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#813347}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/527064f19fb0..a2d9abef043b 2020-10-02 m.maiya@samsung.com Vulkan: Add OES_sample_shading extension entry points 2020-10-02 j.vigil@samsung.com EGL: Add stencil8 to configs 2020-10-02 syoussefi@chromium.org Vulkan: Fix unresolve disagreement between FB and RP If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Test: Test: angle_deqp_egl_tests Change-Id: Ib580f693bbd6403e575d784422a98c584fc09e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446583Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601639725-a3be427f79e9860129010f71f852fe4dbfd505c5.profdata to chrome-linux-master-1601661327-f05ef41a3d878972298e1fd51500deb6e41b0834.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: Ia96b9e8f98febe5246c5f99be64b4ac579781468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446754Reviewed-by:
-
Ghazale Hosseinabadi authored
Based on the feedback we have received from our customers, showing the infobar after detaching the extension is rarely helpful and occasionally misleading. To alleviates some of the pain associated with displaying the infobar after detaching the extension, this CL removes the infobar five seconds after the extension has been detached. In a separate CL, we will update the Cancel button to be in sync with the state. Bug: 1096262 Change-Id: I55f7b2ca13817683a9ace6cab5118731513b9478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386328 Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#813344}
-
Rouslan Solomakhin authored
Before this patch, secure payment confirmation method would return the signature of the challenge that was generated on the browser using the JSON stringification. In order to verify the signature, an issuer would have to stringify JSON as well, but that stringification could be different from how Chrome did it, thus resulting in a rejected transaction. This patch returns Chrome's stringified JSON challenge along with the payment response for secure payment confirmation. The tests to verify this behavior revealed that secure payment confirmation app ignored price changes in modifiers and show promises, so that bug is fixed here as well. After this patch, the issuer does not need to generate the JSON string itself, but instead can verify the values in the JSON string generated and returned by Chrome. Bug: 1123054, 1124747 Change-Id: I0fa8974411635e406a9d2f253b7061b892e06949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388271 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#813343}
-
Mohamed Amir Yosef authored
Bug: 1114655 Change-Id: If1f6a68aa8f42b4e5df16b862022f5547ac08b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442733 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#813342}
-
David Black authored
Flakiness was caused by race conditions in checking for existence of download files. Now, order is maintained across existence checks. Bug: 1130904 Change-Id: I6f4d131ef1c39ef624b87e67f1f61a3704fc634f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444441Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: David Black <dmblack@google.com> Auto-Submit: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#813341}
-
Etienne Bergeron authored
This CL is making the TtsPlatformImpl instance a leaky instance since the singleton is alive for the whole duration of the process. The use of WeakPtr is no longer required. Bug: 1133813 Change-Id: Ie3cedfe53ae419157c51e570e074808eff25bc36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443509Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/69e30b23c45f..da6894f7a9b4 2020-10-02 kimstephanie@google.com Add enforce_fetch to ensure_checkout cmd arg If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1129235 Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: Ibd6a69404da5f4e47ff650e955e1f4ac354b77b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446582Reviewed-by:
-
John Lee authored
Bug: 1105862 Change-Id: Ia79e07ca9ce44a8f95b20d70ddf4afe33901ee66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444171Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#813338}
-
Francois Beaufort authored
This CL makes sure user sees something in the "Pan-Tilt-Zoom" column when camera doesn't support PTZ in about:media-internals page. Bug: 934063 Change-Id: Iaabfcaa0da3a2a89e30b7bc33742fba425a4f942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445153 Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Livvie Lin authored
For accessibility, color should not be the only indicator of a link. Thus, indicate the existence of a link by underlining it on hover. Bug: 1060186 Change-Id: If8a994fa1226e1e30f6238719a6d8f94f25ffbd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441938Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Azeem Arshad authored
This CL adds BarcodeDetection and BarcodeDetectionProvider implementations based on the barhopper barcode detection library. NOPRESUBMIT=true Bug: 1093185 Change-Id: I29b233418108482ebc80bce7c34888fa2081068f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419911Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#813335}
-
Nico Weber authored
The rolled-to clang has a broken feature that's enabled by default. We disable that feature by passing -mllvm -enable-dse-memoryssa=false. In the first CL, we only passed that in cflags, which is normally enough. However, in LTO builds the flag must be present at link time, so the reland adds it to ldflags as well. (On the ToT bots, we force enable-dse-memoryssa to true to check that the problems with the feature are fixed at clang trunk. Don't do this in thinlto builds -- we don't have any tot thinlto bots that run tests anyway.) Bug: 1128966,1128144,1126953 Change-Id: I214b31bd35560d705071e4583df7b019e9f96691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446093 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#813334}
-
Andrew Grieve authored
List of them can be found at third_party/r8/backported_methods.txt Bug: 1056751 Change-Id: I75506b8a8328552429838bca43cc53dd3a82396e Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444180Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#813333}
-
