GitLab

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/ddb714b..221360a

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/1084263002

Cr-Commit-Position: refs/heads/master@{#325329}

R=sheyang@chromium.org
BUG=475701

Review URL: https://codereview.chromium.org/1067633004

Cr-Commit-Position: refs/heads/master@{#325328}

The ability to show ConnectionStats is accidentally removed in a
previous revision (https://crrev.com/1050ee48b1d8fe353bfc7df3b0ea4e5300260f5c).

This CL adds it back with the following additional changes:
1. Instead of having a global remoting.stats, remoting.ConnectionStats is now
   owned by ApplicationContextMenu in app remoting and DesktopConnectedView in
   deskop remoting.
2. Adds the show statistics functionality to desktop remoting.

BUG=476132

Review URL: https://codereview.chromium.org/1089493002

Cr-Commit-Position: refs/heads/master@{#325327}

[ozone] Keep track of pending frames on drm_window when hardware display controller is disabled or when in headless mode.

When display controller is disabled, it used to stop tracking which buffer was the considered front. Surface would fast ack all incoming buffers without presenting them, which means that any one of them could be getting painted into while display controller is off. Upon wakeup, the controller would grab what it thought was the last front buffer, but in practice it was not because of the fast acks. Net result is that it may try to modeset with the buffer GL is painting into, making it hang on a fence in the driver.

This patch removes all knowledge of front buffers from the display controller and explicitly sets it on the window, which tracks it while the controller is off.

BUG=473831

Review URL: https://codereview.chromium.org/1078183003

Cr-Commit-Position: refs/heads/master@{#325326}

It appears that at least in some cases, the linker uses a stricter set of
rules when linking LTO objects, which causes the link to fail in some cases
where an unused function depends on an undefined symbol. This change fixes
all such cases where the error caused the LTO build to fail, by either
moving source files between lists, or by selectively disabling parts of
source files depending on the configuration.

There are more errors like this, which for some reason do not affect LTO. They
can be inspected like this (with a regular Chromium/android build):

$ ninja -C out/Release chrome_shell_apk
$ nm out/Release/lib/libchromeshell.so | grep " U _Z"

BUG=407544
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/1086973003

Cr-Commit-Position: refs/heads/master@{#325325}

This CL adds a new page set ProfileSafeUrlsPageSet, which is used by the
CookieProfileExtender. This CL also hooks up WPR to the CookieProfileExtender.

BUG=472745

Review URL: https://codereview.chromium.org/1070053004

Cr-Commit-Position: refs/heads/master@{#325324}

BUG=

Review URL: https://codereview.chromium.org/1086223002

Cr-Commit-Position: refs/heads/master@{#325323}

Chromium builds its own mojo_shell from forked source.

This logic was originally changed incorrectly:
  https://codereview.chromium.org/1049993002/diff/170001/third_party/mojo/src/mojo/public/mojo.gni
That was clobbered in the latest Mojo->Chromium roll:
  https://codereview.chromium.org/1082343002/diff/40001/third_party/mojo/src/mojo/public/mojo.gni

BUG=NONE
TEST=mojo_shell binary built from chromium repo.
R=jam@chromium.org
TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1087333002

Cr-Commit-Position: refs/heads/master@{#325322}

If there is a slow pending load for a page, and in the meantime the page uses replaceState, the existence of the pending entry could cause a misclassification of the replaceState as SAME_PAGE.

Ensure that SAME_PAGE classification happens only if the pages bear some relationship.

BUG=369661
TEST=Existing tests, NavigationTypeClassification_InPageWhilePending.

Review URL: https://codereview.chromium.org/1082083002

Cr-Commit-Position: refs/heads/master@{#325321}

rtc::P2PTransportChannel expects SetRemoteIceCredentials() to be called
to set remove ICE candidate, but LibjingleTransport was never calling
it, and instead it was passing ICE credentials as part of remote
candidates. Fixed LibjingleTransport to call SetRemoteIceCredentials()
explicitly whenever it receives a new candidate.

BUG=476775

Review URL: https://codereview.chromium.org/1070233004

Cr-Commit-Position: refs/heads/master@{#325320}

ajwong is not actively working on the project anymore.

BUG=None

Review URL: https://codereview.chromium.org/1088743004

Cr-Commit-Position: refs/heads/master@{#325319}

Property trees use values computed by PreCalculateMetaInformation,
so it's unfair to count this time against CalcDrawProps in the
draw properties benchmark.

Review URL: https://codereview.chromium.org/1082163003

Cr-Commit-Position: refs/heads/master@{#325318}

The dashboard is currently confused about which direction indicates an
improvement. This CL makes that explicit.

BUG=470272

Review URL: https://codereview.chromium.org/1057823005

Cr-Commit-Position: refs/heads/master@{#325317}

BUG=

Review URL: https://codereview.chromium.org/1089133002

Cr-Commit-Position: refs/heads/master@{#325316}

BUG=477436

Review URL: https://codereview.chromium.org/1090703002

Cr-Commit-Position: refs/heads/master@{#325315}

BUG=429053
TEST=gpu_unittests
R=piman@chromium.org

Review URL: https://codereview.chromium.org/1067733003

Cr-Commit-Position: refs/heads/master@{#325314}

For the full list of changes, see
https://github.com/chromium/web-page-replay/compare/94d7e2a...4e4d540.

WebPageReplay moved the method has_sni() from certutils to platformsettings,
and renamed it to HasSniSupport(). This CL fixes the one location where
has_sni() is used, and also fixes the stubs.

BUG=477130

Review URL: https://codereview.chromium.org/1087093002

Cr-Commit-Position: refs/heads/master@{#325313}

Since we do not know the future behavior of browser CDMs, and have no way to block persistent state or distinctive identifiers, assume that such CDMs always provide such access.

Review URL: https://codereview.chromium.org/1086013002

Cr-Commit-Position: refs/heads/master@{#325312}

The large profiles are typically too new to be used with the reference builds.

BUG=476882

Review URL: https://codereview.chromium.org/1090453002

Cr-Commit-Position: refs/heads/master@{#325311}

Remove obsolete private Pepper interface private/ppb_talk_private.h,
associated Pepper plumbing code, strings, and chrome::PepperTalkHost.

These are no longer needed as support for Pepper GTalk has been
dropped.

BUG=392002
TEST=browser_tests

Review URL: https://codereview.chromium.org/1088183003

Cr-Commit-Position: refs/heads/master@{#325310}

BUG=477154

Review URL: https://codereview.chromium.org/1055933006

Cr-Commit-Position: refs/heads/master@{#325309}

BUG=462581

Review URL: https://codereview.chromium.org/1072533003

Cr-Commit-Position: refs/heads/master@{#325308}

For devices with Remora/Shark requisition webview is still disabled (http://crbug.com/464049)

webview is disabled for these tests:
* WizardControllerProxyAuthOnSigninTest* (http://crbug.com/452452)
* ProxyAuthOnUserBoardScreenTest* (http://crbug.com/452452)
* Tests that are based on LoginManagerTest/OobeBaseTest and are not yet parametrized (http://crbug.com/477402)

BUG=475529, 452452, 472664, 464049, 477402
TBR=jhawkins@chromium.org

Review URL: https://codereview.chromium.org/1079083002

Cr-Commit-Position: refs/heads/master@{#325307}

This is not a functional change, it only updates the interfaces and
call sites in preparation for switching to a vsync based video
rendering pipeline.

Some notes:
- Plumbs a VideoRendererSink into the the rendering pipeline; similar to
how we have an AudioRendererSink.
- A couple VideoRendererSink mocks are introduced which will be short
lived. Like audio, we will need fakes which can pump consumption tasks.
- The "PaintCB" callback has been temporarily placed on the new sink
interface such that in the field experiments can be run comparing the
performance of the video rendering approaches.
- Finally nukes Player_X11 since setting up a vsync renderer just for
unused tool code isn't worth the effort.
- Since compositor callbacks may stop due to visibility changes, the
new VideoRendererImpl will use a countdown timer to pump video playback
as frames expire; expired frames will not count as dropped.
- Since canvas/WebGL requires frame updates in the background a new
method has been added to VideoFrameCompositor to return the current
frame if it was updated with 250ms, or to request a new one and return
the updated one.

Subsequent work:
- sunnyps@ will be switching VideoFrameProviderClientImpl over to using
a BeginFrameObserver, which will ultimately drive the Render() callbacks.
- dalecurtis@ will land the VideoRendererAlgorithm which powers the new
rendering pipeline.

BUG=439548
TEST=everything works as is.

Review URL: https://codereview.chromium.org/1053113002

Cr-Commit-Position: refs/heads/master@{#325306}

Make dialog modal to suggest apps dialog.
Fix issue where webview content would steal focus from dialog when user
hits tab.

BUG=439448

Review URL: https://codereview.chromium.org/1068883005

Cr-Commit-Position: refs/heads/master@{#325305}

Review URL: https://codereview.chromium.org/1059963003

Cr-Commit-Position: refs/heads/master@{#325304}

BUG=477154

Review URL: https://codereview.chromium.org/1080003003

Cr-Commit-Position: refs/heads/master@{#325303}

The new URLRequestContext disables alternate protocols
to ensure that the Data Reduction Proxy secure proxy check
request goes out over vanilla HTTP so that it can be
intercepted by middleboxes.

Also, secure proxy check is now done on IO thread.

BUG=437080

Review URL: https://codereview.chromium.org/981633002

Cr-Commit-Position: refs/heads/master@{#325302}

Review URL: https://codereview.chromium.org/1035983003

Cr-Commit-Position: refs/heads/master@{#325301}

Revert of Fix scroll regression when specifying an extension id. (patchset #4 id:60001 of https://codereview.chromium.org/1064573003/)

Reason for revert:
It might cause the failures of:
-ExtensionSettingsCommandsConfigWebUITest.testChromeSendHandler
-ExtensionSettingsWebUITest.testChromeSendHandled

http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/1149

Original issue's description:
> Fix scroll regression when specifying an extension id.
>
> Issue was caused because scrolling the page should happen after the
> extensions are visible.
>
> BUG=473002
>
> Committed: https://crrev.com/4eaeca8aa713e9b7b1f214413bfdac87956fd51d
> Cr-Commit-Position: refs/heads/master@{#325278}

TBR=kalman@chromium.org,dbeam@chromium.org,rdevlin.cronin@chromium.org,hcarmona@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=473002

Review URL: https://codereview.chromium.org/1088183004

Cr-Commit-Position: refs/heads/master@{#325300}

This CL adds the FakeServer+Android infrastructure for injecting a
bookmark. There is also some minor refactoring done in fake_server.cc to
reduce code duplication.

BUG=365774

Review URL: https://codereview.chromium.org/1083463003

Cr-Commit-Position: refs/heads/master@{#325299}

Ozone loads display configurations asynchronously. Due to this the internal
display is not always known when Maximize Mode is triggered.

Update ScreenOrientationController to become an observer even when there is no
internal display ready yet. That way, once it becomes ready, it is able to
process accelerometer events.

TEST=ScreenOrientationControllerTest.InternalDisplayNotAvailableAtStartup
BUG=chrome-os-partner:38796

Review URL: https://codereview.chromium.org/1080553002

Cr-Commit-Position: refs/heads/master@{#325298}

The windows bots were incorrectly doing 64-bit builds, and the
debug bots (both mac and win) were incorrectly doing shared builds.

TBR=phajdan.jr@chromium.org
BUG=454413
CQ_EXTRA_TRYBOTS=tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Review URL: https://codereview.chromium.org/1086163002

Cr-Commit-Position: refs/heads/master@{#325297}

BUG=462581

Review URL: https://codereview.chromium.org/1061803004

Cr-Commit-Position: refs/heads/master@{#325296}

This patch implements the Notification.data property for persistent
notifications, where the data is stored in the Notification Database.

The data associated with non-persistent notifications will never leave
Blink, so no changes are required in Chromium to support this.

As an implementation-defined limit, the size of the data will be
limited to a maximum of 1024^2 characters, with a UMA histogram tracking
the size of what developers are trying to store. The limit can then be
adjusted in future releases to match this more accurately, or as an
argument to introduce such a limit in the specification.

Further layout tests are being introduced in the following CL:
  https://codereview.chromium.org/1052693002

BUG=442129

Review URL: https://codereview.chromium.org/1052683002

Cr-Commit-Position: refs/heads/master@{#325295}

The switch to wall clock time used playback rate incorrectly when
calculating the wall clock time. Instead of multiplying by the
rate it should be divided.

BUG=477165
TEST=new unittest

Review URL: https://codereview.chromium.org/1085133002

Cr-Commit-Position: refs/heads/master@{#325294}

Summary of changes available at:
https://pdfium.googlesource.com/pdfium/+log/eddab44..b330016

This should fix the ARM/linux cross compile.

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_arm_compile
BUG=477162

Review URL: https://codereview.chromium.org/1059463004

Cr-Commit-Position: refs/heads/master@{#325293}

This makes DisplayItemList no longer retain individual display
items when caching into a picture is enabled, except when
tracing is also enabled (so that per-item trace output can
still be produced). Instead, only an SkPicture representation
is retained. This avoids the memory cost of storing both the
SkPicture representation (which is needed for raster performance)
as well as the individual display items.

BUG=476073

Review URL: https://codereview.chromium.org/1077033004

Cr-Commit-Position: refs/heads/master@{#325292}

Convert URLFetcherFile tests to use a shared test fixture.

BUG=471069

Review URL: https://codereview.chromium.org/1087883002

Cr-Commit-Position: refs/heads/master@{#325291}

These people are no longer active in the project, so remove them from
OWNERS because they're not expected to do code reviews.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1090673002

Cr-Commit-Position: refs/heads/master@{#325290}