- 03 Dec, 2018 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/eec53b64a610..89808a631e39 git log eec53b64a610..89808a631e39 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 achuith@chromium.org tast_test_stages: Launch VM outside cros_sdk shell 2018-12-03 zentaro@chromium.org cros image test: Update tss group baseline for oobe_config Created with: gclient setdep -r src/third_party/chromite@89808a631e39 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I56fc84a29929d20e721fd1c1355173021c3a429a Reviewed-on: https://chromium-review.googlesource.com/c/1358766Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613303}
-
Saman Sami authored
This parameter is currently ignored. It was added with the intention of importing a SharedImage multiple times with different internal formats for RGB emulation, however an alternative solution that does not require this parameter is creating two different SharedImages wrapping the same GpuMemoryBuffer, with one SharedImage having a special usage flag that indicates RGB emulation. See http://crrev.com/c/1348974 Bug: 882591 Change-Id: Ia48d3dd78321f1c3f20816e5c1856ef23c56cda1 Reviewed-on: https://chromium-review.googlesource.com/c/1359058Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#613302}
-
Giovanni Ortuño Urquidi authored
This make it easier to write tests while still maintaining the flexibility of the fakes. Also gives more descriptive names to the adapter objects paths. This makes the adapter object paths easier to distinguish from future device, service, characteristic, and descriptor object paths. Bug: 870192 Change-Id: I716809e757ab2ddf4a261fa2105e2224ec982ee1 Reviewed-on: https://chromium-review.googlesource.com/c/1358117Reviewed-by:
Ovidio Henriquez <odejesush@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#613301}
-
Oleh Prypin authored
This is a reland of e14ed878 With correct output path to v4l2/v4l2_stubs.{h,cc} Original change's description: > Make a GN template for generate_stubs.py > > Make it produce a source_set which can be depended on rather than directly including sources into the parent target. > > Bug: chromium:682122 > Change-Id: I7ad9f94459f187481e656e3513eabb3e2a6f92a1 > Reviewed-on: https://chromium-review.googlesource.com/c/1348042 > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Oleh Prypin <oprypin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611117} Bug: chromium:682122, chromium:909020 Change-Id: I1d34d5bb0dc9f4f72a444e9463669793c3f5a171 Reviewed-on: https://chromium-review.googlesource.com/c/1356703Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Oleh Prypin <oprypin@chromium.org> Cr-Commit-Position: refs/heads/master@{#613300}
-
Robert Flack authored
This reverts commit 902bd031. Reason for revert: The DCHECK is regularly failing on telemetry_perf_unittests, sample https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/73315: [9072:11232:1203/091954.734:FATAL:latency_tracker.cc(468)] Check failed: !pending_finished_lag_report_. Backtrace: base::debug::StackTrace::StackTrace [0x6F0548A6+102] base::debug::StackTrace::StackTrace [0x6F05387B+27] logging::LogMessage::~LogMessage [0x6F0A4A07+151] ui::LatencyTracker::CalculateAverageLag [0x5FB5FDD1+3281] ui::LatencyTracker::ComputeEndToEndLatencyHistograms [0x5FB5CC83+8595] ui::LatencyTracker::OnGpuSwapBuffersCompleted [0x5FB5AAAE+494] ui::LatencyTracker::OnGpuSwapBuffersCompleted [0x5FB5A6E4+260] viz::SoftwareOutputSurface::SwapBuffersCallback [0x5F92B4B0+64] base::internal::FunctorTraits<void (__thiscall viz::SoftwareOutputSurface::*)(bool),void>::Invoke<void (__thiscall viz::SoftwareOutputSurface::*)(bool),base::WeakPtr<viz::SoftwareOutputSurface>,bool> [0x5F92BB7C+76] base::internal::InvokeHelper<1,void>::MakeItSo<void (__thiscall viz::SoftwareOutputSurface::*)(bool),base::WeakPtr<viz::SoftwareOutputSurface>,bool> [0x5F92BA62+130] base::internal::Invoker<base::internal::BindState<void (__thiscall viz::SoftwareOutputSurface::*)(bool),base::WeakPtr<viz::SoftwareOutputSurface>,bool>,void __cdecl(void)>::RunImpl<void (__thiscall viz::SoftwareOutputSurface::*)(bool),std::tuple<base::Wea [0x5F92B98F+111] base::internal::Invoker<base::internal::BindState<void (__thiscall viz::SoftwareOutputSurface::*)(bool),base::WeakPtr<viz::SoftwareOutputSurface>,bool>,void __cdecl(void)>::RunOnce [0x5F92B804+84] base::OnceCallback<void __cdecl(void)>::Run [0x6F008900+80] base::debug::TaskAnnotator::RunTask [0x6F0566EB+859] base::MessageLoopImpl::RunTask [0x6F0D0656+886] base::MessageLoopImpl::DeferOrRunPendingTask [0x6F0D0B79+73] base::MessageLoopImpl::DoWork [0x6F0D15F0+400] base::MessagePumpForUI::DoRunLoop [0x6F0DA8BE+62] base::MessagePumpWin::Run [0x6F0D9837+119] base::MessageLoopImpl::Run [0x6F0CFF63+483] base::RunLoop::Run [0x6F189298+488] base::Thread::Run [0x6F2A0367+375] base::Thread::ThreadMain [0x6F2A0B58+1272] base::PlatformThread::GetDefaultThreadStackSize [0x6F292C86+406] BaseThreadInitThunk [0x74C8338A+18] RtlInitializeExceptionChain [0x770C9902+99] RtlInitializeExceptionChain [0x770C98D5+54] Original change's description: > Add Latency.AverageLag metric > > This CL adds a float value scroll_update_delta_ for GSU deltaY and > a time component for last coalesced event to latency_info. > And also adds implementation for Event.Latency.Scroll.AverageLag > metrics, which measures an average distance represents the lag > between finger movement and page scroll. > > detail of the metric see the design doc: > https://docs.google.com/document/d/154jddNiKtxELBvrjLz9v6A7sA1J3iwQQzySHgtY12Oo/edit?pli=1#heading=h.zf3l6o8vecuv > > Change-Id: I64adef4ebf107185ad4fd1eeec276ea527e1c5ef > Reviewed-on: https://chromium-review.googlesource.com/c/1239260 > Commit-Queue: Ella Ge <eirage@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611206} TBR=kenrb@chromium.org,rkaplow@chromium.org,tdresser@chromium.org,nzolghadr@chromium.org,eirage@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I08d00db01093c787afff59d6ed9714b9bf7ab746 Reviewed-on: https://chromium-review.googlesource.com/c/1359299Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#613299}
-
Jonathan Backer authored
This makes sure that when a RasterDecoderContextState context is lost that we follow the same logic for GLES2 decoder context loss. Change-Id: Ia46c54311cf8ae696b4b464cfb33b365601843f9 Reviewed-on: https://chromium-review.googlesource.com/c/1355338Reviewed-by:
-
Andrey Lushnikov authored
The --disk-cache-dir flag allows to use custom disk cache folder instead of using the one inferred from user data directory. BUG=882431 R=caseq Change-Id: I2da7e1c4b72eda32bccf6851c66ce44c1aaa837d Reviewed-on: https://chromium-review.googlesource.com/c/1359038Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#613297}
-
Ben Mason authored
This allows the 32-bit build of the shared library to overwrite the one built via the 64-bit build. Bug: 908115, 893125 Change-Id: I0ede727cfced2dd5285f75594f08b8c3450e8a27 Reviewed-on: https://chromium-review.googlesource.com/c/1357312Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#613296}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d758e32610cb..f0b761f116f6 git log d758e32610cb..f0b761f116f6 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 enga@chromium.org Implement timeline fences in Dawn Created with: gclient setdep -r src/third_party/dawn@f0b761f116f6 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I2d88b5fcbbfe4d15a173ab562115b02aefb08909 Reviewed-on: https://chromium-review.googlesource.com/c/1358809Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0a1293c2e432..f9910ea25812 git log 0a1293c2e432..f9910ea25812 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 kjlubick@google.com [canvaskit] Add profile mode 2018-12-03 fmalita@chromium.org [skottie] Surface composition markers in CK 2018-12-03 reed@google.com add != for SkFont 2018-12-03 herb@google.com Clean up handling of lambda capture to use refs correctly 2018-12-03 kjlubick@google.com [canvaskit] remove POC Nima code Created with: gclient setdep -r src/third_party/skia@f9910ea25812 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: I06cc898945ffc9ef5209ceeed0ec0b48d12e83d4 Reviewed-on: https://chromium-review.googlesource.com/c/1358763Reviewed-by:
-
David Benjamin authored
Bug: none Change-Id: I71a0dbbe87ca76015107f61dbff9647ba33041bc Reviewed-on: https://chromium-review.googlesource.com/c/1359310Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#613293}
-
Xing Liu authored
This CL hides detail like download file size or percentage for in progress download notification. Now we only show "Downloading" in the notification text. Bug: 901393 Change-Id: I25a2f660c9004e6e5aafd671cfae291cea6bd5bd Reviewed-on: https://chromium-review.googlesource.com/c/1359053Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#613292}
-
Meilin Wang authored
Add an accessible window title called "Assistant" for Assistant container view, thus ChromeVox can read the window title when invoking multilayered shortcut:Search + a > w. Bug: 910559 Test: local compile and manually test. Change-Id: Ia71e08567cf448abce1e9a5d59b9fe50f34be8a2 Reviewed-on: https://chromium-review.googlesource.com/c/1357650 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#613291}
-
François Doray authored
Prior to this CL https://chromium-review.googlesource.com/1093015, the UserDataKey of a class T derived from WebContentsUserData<T> was the address of a static member variable of WebContentsUserData<T>. Storage had to be allocated for that static member variable. Unfortunately, it was not possible to allocate the storage if T was an exported class. Since https://chromium-review.googlesource.com/1093015, the UserDataKey of a class T derived from WebContentsUserData<T> is the address of a local static variable in a static method of WebContentsUserData<T>. Unfortunately, since the method is defined in a header file (it has to because it is part of a templated class), it can be instantiated multiple times and return different values if it is referenced from different components (e.g. in a component build). With this CL, the UserDataKey of a class T derived from WebContentsUserData<T> is the address of a static member variable of T. This solution works fine with exported classes, but it requires adding macros to declare/define the static member variable in T. TBR=avi@chromium.org Bug: 589840 Change-Id: Ie618c09f1ab5db1e11ac3e7a86405577872e932f Reviewed-on: https://chromium-review.googlesource.com/c/1354402 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#613290}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7808a519be73..d87b09662ee8 git log 7808a519be73..d87b09662ee8 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 joenotcharles@google.com More context when _load_codereview_impl asserts Created with: gclient setdep -r src/third_party/depot_tools@d87b09662ee8 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:908466 TBR=agable@chromium.org Change-Id: Iaccfc54f9a3362befb6c1bc7cad0b7a020634f31 Reviewed-on: https://chromium-review.googlesource.com/c/1358764Reviewed-by:
-
Mike Reed authored
Bug: 899689 Change-Id: Ie69dda53e3be3b2ec1113cea5f763e2e016f26bd Reviewed-on: https://chromium-review.googlesource.com/c/1358693 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#613288}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c10a023a66f2..66f0d2c1e7b5 git log c10a023a66f2..66f0d2c1e7b5 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 jmadill@chromium.org Make Framebuffer attachments angle::Subjects. Created with: gclient setdep -r src/third_party/angle@66f0d2c1e7b5 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I59224d226ee6fcd3829c7e66663a8239eccf813e Reviewed-on: https://chromium-review.googlesource.com/c/1358808Reviewed-by:
-
Tatiana Buldina authored
Bug: chromedriver:2677 Change-Id: I77946071bac5c924e2c56745f93309cada417fae Reviewed-on: https://chromium-review.googlesource.com/c/1358510Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#613286}
-
Giovanni Ortuño Urquidi authored
On real devices, AdapterPropertyChanged is called for each property in the adapter before AdapterAdded is called. During this, the adapter should be included when returning GetAdapter and all its properties should be accessible (though they will be empty). Changes TestBluetoothAdapterClient to match this behavior but instead of calling AdapterPropertyChanged for all properties, we call it for the two that are used in tests "Powered" and "Discovering". Bug: 870192 Change-Id: I501cfb8ad2665aee27314188e5a7f667e2209ebf Reviewed-on: https://chromium-review.googlesource.com/c/1358101Reviewed-by:
-
Scott Violet authored
This way Window::GetBoundsInScreen() returns screen coordinates. BUG=none TEST=covered by tests Change-Id: I701247ec7005b3f8bcedacbe7345154b51287a67 Reviewed-on: https://chromium-review.googlesource.com/c/1359305Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#613284}
-
Kristi Park authored
[NTP] Determine shortcut title direction by the first strong character and adjust RTL for edit shortcut dialog fields Determine text direction using the first strong character instead of whether the text contains any RTL character. Also add direction support in the edit shortcut dialog fields LTR browser: https://screenshot.googleplex.com/11Z58bTugPV.png https://screenshot.googleplex.com/ne61RSr24qg.png https://screenshot.googleplex.com/fr28i5Zzceh.png RTL browser: https://screenshot.googleplex.com/ZEGVSdiOsTS.png https://screenshot.googleplex.com/cNtF8s6htp9.png https://screenshot.googleplex.com/RHoZu97GL8y.png Bug: 910385 Change-Id: I842c1479e3a3003e218d58d5ccfa511fdddc4963 Reviewed-on: https://chromium-review.googlesource.com/c/1357637 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#613283}
-
Dale Curtis authored
Apparently zero byte, nullptr packets can still be attached to memory, who knew! BUG=852093,910896,910898,910928 TEST=local run shows no leaks. R=tmathmeyer Change-Id: Iff90057b02e37cb67b9d443ffeb92695e6e5c7f8 Reviewed-on: https://chromium-review.googlesource.com/c/1359060Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#613282}
-
Sebastien Marchand authored
Bug: 863441 Change-Id: Icd11498ed8f396c5506ae995da34d375af8f7655 Reviewed-on: https://chromium-review.googlesource.com/c/1355989 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#613281}
-
Ovidio Henriquez authored
This change implements two new helper methods for site settings that organize the chooser exceptions in a way that allows their corresponding site exceptions to be grouped under the same exception. The structure of the objects returned by GetChooserExceptionListFromProfile(), described in jsdoc notation, is the following: { chooserType: string, displayName: string, object: Object, sites: Array<!SiteException> } The objects in the sites array follow the same structure as the non-chooser exceptions. Design doc: https://docs.google.com/document/d/1MPvsrWiVD_jAC8ELyk8njFpy6j1thfVU5aWT3TCWE8w Bug: 854329 Change-Id: I92a654da2ef9d1d0f045df0a35eaf70a1940b44e Reviewed-on: https://chromium-review.googlesource.com/c/1357605 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#613280}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d80259d35e66..0c172a6b74fc git log d80259d35e66..0c172a6b74fc --date=short --no-merges --format='%ad %ae %s' 2018-12-03 dneto@google.com Allow Float16/Int8 for Vulkan 1.0 (#2153) 2018-12-03 stevenperron@google.com Validate uses of ids defined in unreachable blocks. (#2146) 2018-12-03 dneto@google.com Set expected version number for cpp interface test (#2154) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@0c172a6b74fc The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I5db1b8128d90e2c2e38f3b1156d74859c780205e Reviewed-on: https://chromium-review.googlesource.com/c/1358762Reviewed-by:
-
Mike Wasserman authored
Register Ash's root windows and aura::Env in single-process mash. Keep a warning & TODOs for multi-process Mash ui_devtools support. Encapsulate server init and the switch and port definitions. An earlier CL was incorrect and caused a crash (uploaded here as PS1): https://chromium-review.googlesource.com/c/chromium/src/+/1324373 Bug: 896977 Test: ui_devtools works well on Chrome OS single-process Mash. Change-Id: Ie962343b1e121529933b5118791b767e80507684 Reviewed-on: https://chromium-review.googlesource.com/c/1334006 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#613278}
-
Thomas Guilbert authored
This CL turns on the new RemotePlayback pipeline by default. There are still some issues to address, but none of them are blocking. Due to the relatively small use of this feature, it is best to turn the feature on by default, to get the coverage we need. The extended period of time between M72 branch cut and M72 stable cut will be used to merge back any unforeseen regressions that pop-up. NOTE: This change might lead to regressions or improvements of various tests. Bug: 790766 Change-Id: I3e2ed2073da6a28b5ec6cb1ee6d2dd1851df1fde Reviewed-on: https://chromium-review.googlesource.com/c/1338887 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#613277}
-
Roger McFarlane authored
This CL adds unittests which validate that a collection of independent randomized encodings of a given input string can be decoded to recover the portions common to most/all users. Bug: 896719 Change-Id: Ibe3305b62ddcf643bef6979589a1011427cfcbd2 Reviewed-on: https://chromium-review.googlesource.com/c/1357642 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#613276}
-
Eric Karl authored
Fixes two small issues preventing SkiaRenderer from running on Android: - Enablment flags not forwarded via RendererSettings. - gles2::FeatureInfo not available on SkiaOutputSurfaceImplOnGpu. Bug: 809726 Change-Id: I66de6c577eaa4d4b1eb6e6ae45c5036ae0b098f0 Reviewed-on: https://chromium-review.googlesource.com/c/1352248 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#613275}
-
Anastasia Helfinstein authored
Bug: None Change-Id: I9ffe55a11ba54c6c56694b166b762254cc19d4c1 Reviewed-on: https://chromium-review.googlesource.com/c/1355919Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#613274}
-
Antoine Labour authored
Bug: None Change-Id: Icb435aae59f43ace9c52af6a67ddcb331181ad91 Reviewed-on: https://chromium-review.googlesource.com/c/1359318Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#613273}
-
Brian Sheedy authored
This reverts commit 06b8660d. Reason for revert: Hitting DCHECK: [FATAL:latency_tracker.cc(399)] Check failed: (event_timestamp - last_event_timestamp_).InMilliseconds() >= 0 Original change's description: > Use mocked VR controller for scrolling > > Switches all VR instrumentation tests for scrolling using the Daydream > controller to use the Chrome-side controller mock instead of the > VrCore-side emulation via intents. The latter has always been somewhat > flaky, so this should help reduce VR test flakiness. > > Bug: 902938 > Change-Id: I560cda2129357c49bdfa3d095836e6ebd1b23da8 > Reviewed-on: https://chromium-review.googlesource.com/c/1341061 > Reviewed-by: Christopher Grant <cjgrant@chromium.org> > Reviewed-by: Ian Vollick <vollick@chromium.org> > Commit-Queue: Ian Vollick <vollick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#613107} TBR=vollick@chromium.org,cjgrant@chromium.org,bsheedy@chromium.org Change-Id: I40d8cf660d35a14ee4269010f5da749a2e91daad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 902938 Reviewed-on: https://chromium-review.googlesource.com/c/1359311Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#613272}
-
Bailey Berro authored
This change removes the attached method override from the smb-share-dialog component. Bug: chromium:887135 Change-Id: Id6a7b06a2b2b9ea4d0da5dc04cb14f7143c0c312 Reviewed-on: https://chromium-review.googlesource.com/c/1340860 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#613271}
-
Gauthier Ambard authored
This CL removes the cap on the font size used to display the instructions on the empty TableView background in ReadingList. Bug: 911174 Change-Id: Iaadd7cd0e9d070a0052847daa513e3f1ae1b50b7 Reviewed-on: https://chromium-review.googlesource.com/c/1358465 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#613270}
-
Lei Zhang authored
PrinterCapabilitiesTest is in printer_capabilities_unittest.cc inside components/, but is not built as part of components_unittests. Instead, it it built as part of components_browsertests, but does not appear in the list of tests. Fix the build rules so it builds in components_unittests as a proper test. Move printer_capabilities_unittest.cc next to printer_capabilities.cc. Change-Id: I6be9606a97968e26de5528ee395e044d92f1ed9c Reviewed-on: https://chromium-review.googlesource.com/c/1357616Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#613269}
-
Jinsuk Kim authored
https://crrev.com/c/1135874 left out checking gamepad events by mistake. This CL fixes it by adding the check against GenericMotionEvent in the content ui event handler. Tested on https://html5gamepad.com with a USB gamepad. Bug: 906347 Change-Id: I2bd0890f2533e70a772dbb0b005d69bf086d1595 Reviewed-on: https://chromium-review.googlesource.com/c/1356727Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#613268}
-
rbpotter authored
- Delete ticket items and other unused files in data/ - Complete TODOs in handler - Remove unused strings Bug: 908705 Change-Id: Ie02a00ad6b8ada56b3d327d75e2ad841e534cb9f Reviewed-on: https://chromium-review.googlesource.com/c/1357527 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#613267}
-
braveyao authored
This checkbox is set as checked by default at present. With some new features, as getDisplayMedia and dynamic change capture source, it's more reasonalbe to set it as unchecked by default. Also it will help to count the requirement of audio capture during presenting. Bug: 892201 Change-Id: I36c253bf1c862a31d99927be79c2072332cb1622 Reviewed-on: https://chromium-review.googlesource.com/c/1356713Reviewed-by:
Qiang Chen <qiangchen@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#613266}
-
Danyao Wang authored
This makes it more clear which WebStateObserver callbacks are called when. This change does not contain any function changes. Bug: 903497 Change-Id: Ie774c191ffc2681a7cf1df90089ea25e90a381ac Reviewed-on: https://chromium-review.googlesource.com/c/1359296Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#613265}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f1684ef61ea6..eec53b64a610 git log f1684ef61ea6..eec53b64a610 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 djmm@google.com Update luci schedule with M72 branch info Created with: gclient setdep -r src/third_party/chromite@eec53b64a610 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ic6e1cf287cd77d28501648600c530f725c6569d4 Reviewed-on: https://chromium-review.googlesource.com/c/1358807Reviewed-by:
-
