GitLab

BUG=741214

Change-Id: I2184b489044fc07de51ca3abbe4d5a5836138411
Reviewed-on: https://chromium-review.googlesource.com/567244
Commit-Queue: Tim Song <tengs@chromium.org>
Reviewed-by: Gustavo Sacomoto <sacomoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488124}

after a refactoring at http://crrev.com/ad6d8a9bbf9bd5e2.
As a follow-up of the refactoring, this CL inlines the alias to its users
in //base and //cc.

base: :StaticAtomicSequenceNumber is an alias of base::AtomicSequenceNumber
Change-Id: I343885b85cce413148ccd6aa9e5fa94913d7fecc
Reviewed-on: https://chromium-review.googlesource.com/568063Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488123}

This is one of the efforts to organize core/dom files.
See https://docs.google.com/spreadsheets/d/1OydPU6r8CTj8HC4D9_gVkriJETu1Egcw2RlajYcw3FM/edit?usp=sharing
for details.

See the similar CL, https://chromium-review.googlesource.com/c/569532/, as I did for
intersection_observer.

Bug: 738794
Change-Id: I1eb0b47341df4880faddc2df6c7ae9f1dd6ccdb7
Reviewed-on: https://chromium-review.googlesource.com/576597Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488122}

The network change observer notifies the offline signal later than the
actual failure in download request. The controller will immediately
retry since the state is still online.

This CL adds a delay to the retry logic, so it potentially can wait
for an actual online timing to retry.

Bug: 746082
Change-Id: I42e519618538f6db857b1c173a5bada828c6512d
Reviewed-on: https://chromium-review.googlesource.com/575572Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488121}

- Remove unused requesting_origin_
- Make destructor private
- Remove unused GetAcceptState() declaration

Change-Id: Ie8a8984d2a6975568cd8b26e57c0844c88acb594
Reviewed-on: https://chromium-review.googlesource.com/575737Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488120}

TBR=dimu@chromium.org

Change-Id: I951bdaf7e4c7ddc6bfd7b8f7d178c4990c28d870
Reviewed-on: https://chromium-review.googlesource.com/578216Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488119}

Update a few of the extensions unittests for native bindings. In
particular, create a NativeBindingsExtensionSystem in the
ModuleSystemTest in order to allow for catching and reporting
errors, and update a few of the JS files to handle either
native or JS-based bindings.

Bug: 653596
Change-Id: I0bfc04ef01887422fb87c050da9aec056b00d0c9
Reviewed-on: https://chromium-review.googlesource.com/574692
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488118}

https://skia.googlesource.com/skia.git/+log/7e872caaf618..e32500f0642d

$ git log 7e872caaf..e32500f06 --date=short --no-merges --format='%ad %ae %s'
2017-07-19 reed Assume HQ is handled by pipeline, delete legacy code-path
2017-07-19 brianosman Strip out unused tracing macros
2017-07-19 bsalomon Remove GrBackendTextureDesc
2017-07-19 halcanary SkPDF:  minor cleanups of skpdfdevice

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=caryclark@chromium.org

Change-Id: Ie5ac9a80e2e2f267ce87a168a3e3d2b7dd985ad5
Reviewed-on: https://chromium-review.googlesource.com/578721Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488117}

Even though our dialogs are modal, it was still possible to execute
keyboard commands on the background content by clicking on the dialog
background, which refocuses the document body and allowed commands
to execute.

Bug: 742972
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I01f9cb3060fd6a91a6fa5a832578f3f245712e0c
Reviewed-on: https://chromium-review.googlesource.com/575252Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488116}

In chrome/browser/safe_browsing, srt_chrome_prompt_impl.h includes a
generated Mojo header that comes from chrome_prompt.mojom inside
components/chrome_cleaner.

Change-Id: Ic7eb79c41dd06f8abb96b9845ba719a1dec10e54
Reviewed-on: https://chromium-review.googlesource.com/577309Reviewed-by: Robert Shield <robertshield@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488115}

And some related cleanup.

R=eae@chromium.org

Change-Id: I8b11f587877af569e188770004b09fc888c6fcc1
Reviewed-on: https://chromium-review.googlesource.com/578576Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488114}

Implement parseShorthand for border-[bottom|left|right|top], column-rule, flex-flow, list-style and text-decoration.

All these shorthand properties call the same helper function
ConsumeShorthandGreedilyViaLonghandAPIs. Hence these properties are grouped in
one cl.

This cl also removes ConsumeShorthandGreedily from CSSPropertyParser, 
as it is now fully replaced by ConsumeShorthandGreedilyViaLonghandAPIs.

Bug: 668012
Diff: https://gist.github.com/3747ac6e05e864871ac92f82fd49a822/revisions
Change-Id: Ice96f50a33c609bab24f5ab677b942ed4d424e97
Reviewed-on: https://chromium-review.googlesource.com/575608Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488113}

Bug: 746084
Change-Id: I7fe25557ded4264887bb092107bf4a5c51988b36

Change-Id: I7fe25557ded4264887bb092107bf4a5c51988b36
Reviewed-on: https://chromium-review.googlesource.com/576408
Commit-Queue: Kelvin Poon <kelvinp@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488112}

Bug: 743118
Change-Id: I8f17eb898daf9d39ea270435b259b0a7bc15e5cb
Reviewed-on: https://chromium-review.googlesource.com/571293Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Blaise Bruer <allada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488111}

Bug: 735358
Change-Id: Ibe2a98bd93c1e6288e7c8e9a3633f21e3433350a
Reviewed-on: https://chromium-review.googlesource.com/577390Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488110}

EmbeddedContentPainter::IsSelected() is used to decide if paint 
 selection or not.
This function is strange because it refers selection_start/end.
That's because seletion_start/end means offset in the layout object
 and since replaced element neither be text nor have child 
LayoutObject.
Thus we should just consider SelectionState is kNone or not.

Bug: 739062
Change-Id: I249d8c2acef959ad437f3a636a490f42b61270e0
Reviewed-on: https://chromium-review.googlesource.com/575126Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488109}

This CL does the following:
1) If we choose a tool that is a "mode", the palette tray stays active.
2) If a tool that is a "mode" is active, tapping the palette tray deactives the tool.
3) Remove the checkmarks (because they can't be seen anymore with #2).
4) Add a seperator between tools that are "actions" and tools that are "modes".

Test: ash_unittests --gtest_filter="PaletteTrayTest.*"
Bug: 742524
Change-Id: I70d6e07a460250e7a22059973de036146dd753a6
Reviewed-on: https://chromium-review.googlesource.com/572066
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488108}

Add the following metrics for WebSocket SafeBrowsing lookups:

* SafeBrowsing.WebSocket.Result is recorded for every WebSocket handshake that
  is checked.
* - SafeBrowsing.WebSocket.Elapsed.Safe
  - SafeBrowsing.WebSocket.Elapsed.Blocked
  - SafeBrowsing.WebSocket.Elapsed.Abandoned
  Record the time in milliseconds spent performing the SafeBrowsing lookup,
  including time spent on the interstitial page if applicable, broken down by
  result.

Because clicking "Back to safety" on the interstitial results in navigating away
from the page, it is recorded as "Abandoned", not "Blocked" as might be
expected. I haven't found a circumstance in which "Blocked" is recorded.

Tested manually with about:histograms.

Bug: 644744
Change-Id: I4ec902e122f48482c6c4d54537ce8035bbac92fc
Reviewed-on: https://chromium-review.googlesource.com/569942Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488107}

This allows onSafeBrowsingHit to be invoked with BackToSafety, even if
there is no page to go back to.

This is an issue for malicious subresources, since we actually navigate
backward. In this case, we load about:blank instead.

Bug: 746756
Test: run_webview_instrumentation_test_apk -f SafeBrowsingTest#testSafeBrowsingOnSafeBrowsingHitForSubresourceNoPreviousPage
Change-Id: I0e31d195ed7f87abeab3901725dc245c88f65299
Reviewed-on: https://chromium-review.googlesource.com/578577Reviewed-by: Selim Gurun <sgurun@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488106}

This patch introduces |AdjustSelectionStartToAvoidCrossingEditingBoundaries()|
for moving code for adjusting selection end code from
|AdjustSelectionToAvoidCrossingEditingBoundaries()| to simplify it for improving
code readability.

This patch is a preparation of the patch[1] and similar to the patch[2].

[1] http://crrev.com/c/575297: Refactor
VisibleSelectionTemplate::AdjustSelectionToAvoidCrossingEditingBoundaries()
[2] http://crrev.com/577338: Move code for adjusting selection end to avoid
crossing editing boundaries to a function

Bug: 230267
Change-Id: I25e020af333983e0e797c21eff2d934d6a03a589
Reviewed-on: https://chromium-review.googlesource.com/576606Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488105}

This CL fixes an issue where the sort button was not being updated when
the selected folder's children were updated.

Bug: 741308
Change-Id: I9876950def769551664a0d26f273b6ef6bdc0cc0
Reviewed-on: https://chromium-review.googlesource.com/569531
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488104}

Export intermediate keyboard states as UMA if it's
lingering too long (5 seconds).

- Made the UMA be exported on HIDDEN
- Checked chrome:histograms and confirmed only HIDDEN is exported.

Bug: 742724
Test: manually tested with a little tweak in the code.
Change-Id: I5954f1c169441ef80b70c08b3515cee1b11bfcb2
Reviewed-on: https://chromium-review.googlesource.com/572606Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Keigo Oka <oka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488103}

We previously moved the two classes from stack to heap in order to make
TextNodeHandler also work with LayoutNG by polymorphism. However, the
on-going prototype (*) doesn't work in this way. Furthermore, we might
need a TextNodeHandler that works with both legacy and NG in order to
handle mixed layout tree.

Therefore, this patch makes the two classes stack allocated again.

(*) https://codereview.chromium.org/2968803002

Bug: 721957
Change-Id: I84ed1bff2acd92685fd53555e7b8f8ba62dbd4c3
Reviewed-on: https://chromium-review.googlesource.com/578715Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488102}

The KeyedServiceDependencyManager marks contexts as live in order to
detect when a context is used after shutdown is initiated. Ensure that
Profile contexts are marked as live by calling
BrowserContextDependencyManager::GetInstance()->MarkBrowserContextLive(this);
from the Profile constructor.

Bug: 745729

Change-Id: Icaa7950d77c1e33cbc098da8282ba3ff7f6977f3
Reviewed-on: https://chromium-review.googlesource.com/576339Reviewed-by: Elliot Glaysher <erg@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488101}

BUG=none

Change-Id: I0e5f8febd45ef6580ae829a10b7660d78095461a
Reviewed-on: https://chromium-review.googlesource.com/577908
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488100}

This CL rewrites usages of leveldb::DB::Open() to leveldb_env::OpenDB(),
exposing memory usage of leveldb databases to Chrome's tracing.

The only API difference of leveldb_env::OpenDB() is related to how it returns
its result:

1. It returns (via output parameter) std::unique_ptr<leveldb::DB>, while
   leveldb::DB::Open() returns a raw leveldb::DB pointer.

2. It doesn't modify output parameter on failure, while leveldb::DB::Open()
   returns (writes) nullptr.

Both of these changes are consistent with Chrome's guidelines.

Under the hood leveldb_env::OpenDB() uses leveldb_env::DBTracker to open and
expose databases to Chrome's tracing. See crrev.com/2855953002 for details.

Finally, this CL does two more things:

1. Adds a presubmit check to enforce usage of leveldb_env::OpenDB().

2. Fixes existing memory dump providers that already dump some leveldb
   databases to properly attribute their memory usage. Further work on
   those MDPs is tracked by crbug.com/735269.

BUG=711518

Review-Url: https://codereview.chromium.org/2953473002
Cr-Commit-Position: refs/heads/master@{#488099}

When the Play Store app search feature is enabled, we have
separators between items in the SearchResultTileItemListView.
We have to skip those separators while indexing items.

BUG=739410
BUG=739841

Review-Url: https://codereview.chromium.org/2972243002
Cr-Commit-Position: refs/heads/master@{#488098}

- Use current_cpu instead of target_cpu.
- Explicitly wrap the Android case with |is_android|.

Change-Id: I849c34ccafc3cdd89d164b01bf00ffb0292476f4
Reviewed-on: https://chromium-review.googlesource.com/569319Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488097}

This patch does two things broadly...

1) If an empty block clears a float, we set the previous inflow
   position to the empty block *minus* the margin strut.

   This matches edges behaviour. I couldn't determine a sane behaviour
   for the other user agents.

2) If we resolve our BFC offset as a result of a child potentially
   clearing floats, *and* we have unpositioned direct float children,
   we set the previous inflow position to the top border edge, and
   reset the margin strut.

   I think this broadly matches other UAs behaviour, there is a note
   which I added about only forcing our BFC to resolve if
   unpositioned_floats_ contains the right type of float, but this
   can be looked at later.

Bug: 635619
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I80ad01e12ad91f302b927103050055cffc6121f2
Reviewed-on: https://chromium-review.googlesource.com/577267Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488096}

Since integers returned by SelectionStartEnd() don't relate 
each other except start LayoutObject == end LayoutObject.
To emphasize that for readability, we should split it.

Bug: 739062
Change-Id: I81011fcbdbff0f17c3ff8917e1dca1101b89712e
Reviewed-on: https://chromium-review.googlesource.com/577432Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488095}

Bug: 746402
Change-Id: I61685489f1a96ea5fc89b2a553462d470d53b28b
Reviewed-on: https://chromium-review.googlesource.com/578552Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488094}

Also fix some typos.

Change-Id: I8dac5e543e118865726c81c399d27a258c602307
Reviewed-on: https://chromium-review.googlesource.com/578007Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488093}

This CL corrects a typo in the aria-describedby for lockScreenSecondary.

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5ab0d3ca4c684dfbec3601d29d1dfcb0f33ec343
Reviewed-on: https://chromium-review.googlesource.com/578430Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488092}

R=eae@chromium.org

Change-Id: Ib267b515d4620ffa31de2ade2cdd4739c99027b9
Reviewed-on: https://chromium-review.googlesource.com/578391
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488091}

Bug: 741980
Change-Id: I0f6d8c4b7a076a6ccaf8e3de692b3ad657e94cfc
Reviewed-on: https://chromium-review.googlesource.com/578688Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488090}

Revert of Disable COM Initialization on SchedulerWorkers When COM_INIT_CHECK_HOOK_ENABLED() (patchset #1 id:1 of https://codereview.chromium.org/2978253002/ )

Reason for revert:
Causes

base/task_scheduler/scheduler_worker.h(199,40):  error: private field 'backward_compatibility_' is not used [-Werror,-Wunused-private-field]
  const SchedulerBackwardCompatibility backward_compatibility_;

Original issue's description:
> Disable COM Initialization on SchedulerWorkers When COM_INIT_CHECK_HOOK_ENABLED()
>
> This change will allow for the detection of tasks running in
> TaskScheduler that fail to post their task in a COM STA Task Runner
> instead.
>
> BUG=706512
> TBR=gab@chromium.org
> Previously Reviewed at https://chromium-review.googlesource.com/c/549223/
>
> Review-Url: https://codereview.chromium.org/2978253002
> Cr-Commit-Position: refs/heads/master@{#487625}
> Committed: https://chromium.googlesource.com/chromium/src/+/122a24f59d90a1b225e00b3ab6c9fd37fd365b8f

TBR=gab@chromium.org,rnk@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=706512

Review-Url: https://codereview.chromium.org/2983143002
Cr-Commit-Position: refs/heads/master@{#488089}

https://chromium.googlesource.com/native_client/src/native_client.git/+log/015356a98e44..01a28a6069a9

$ git log 015356a98..01a28a606 --date=short --no-merges --format='%ad %ae %s'
2017-07-19 thomasanderson Add missing dependency on exe_and_shlib_deps

Created with:
  roll-dep src/native_client
BUG=745773


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
TBR=mseaborn@chromium.org

Change-Id: Iead54c72a7c511750ff4a4c16526e85505fd708c
Reviewed-on: https://chromium-review.googlesource.com/578714
Reviewed-by: <nacl-deps-roller@chromium.org>
Commit-Queue: <nacl-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488088}

Now we migrated ArcService classes into KeyedService,
so these are destructed on Profile destruction.
With this CL, the lifetime of ArcServiceManager, ArcSessionManager
and KeyedService classes becomes nested, i.e., now
while KeyedService is alive, ArcServiceManager and ArcSessionManager
are alive.

BUG=672829
TEST=Ran try, and run on DUT.

Change-Id: Iadeea98b19ea6eb6fb93cdb91f9bd1cf4b973794
Reviewed-on: https://chromium-review.googlesource.com/574986
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Yusuke Sato (in China Mon-Thurs, may be offline) <yusukes@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488087}

The Site Details page currently only shows two options in the drop-down menu
for each permission, 'Allow' and 'Block'. This change adds a third option to the
list, which shows the default option, similar to the Page Info bubble.

The "Site Details" page that opens should show matching permissions to those
seen in the Page Info bubble, including the defaults - e.g. Javascript should be
"Allow (default)", Popups should be "Block (default)", and Camera should be
"Ask (default)". Navigating to chrome:settings/content/camera and toggling the
"Ask before accessing (recommended)" option should then make the Site Details
page for for https://permission.site show "Block (default)" next to the Camera
permission.

Bug: 656758
Change-Id: I74cd332c44d8fcb1ab5c700e4fa394ce74fe973b
Test: With the #enable-site-details flag turned on, navigate to
https: //permission.site, open the Page Info bubble, and click "Site settings".
Reviewed-on: https://chromium-review.googlesource.com/558541
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488086}

After migrating last ones, description will become mandatory.

BUG=734762

Change-Id: I2b839c5255841fd98a6e0799af928d03f4f0a84d
Reviewed-on: https://chromium-review.googlesource.com/578570
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488085}