- 06 Apr, 2020 40 commits
-
-
Ryan Daum authored
Gives hosted webviews the same facility that normal cast applications have to enable devtools debugging for themselves and their inner contents. Bug: internal b/152230325 Test: manual Change-Id: I80b60c0d26d5de6183325c7dfb36ced3b459de35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136140 Commit-Queue: Ryan Daum <rdaum@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#756823}
-
Xing Liu authored
This CL plumbs the image loader, a wrapper of image fetcher, to tile service. Bug: 1058534 Change-Id: I1fa98246bf5f9527a9d15bdf9b88c15180e8b5e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137672 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#756822}
-
Ian Wells authored
Change-Id: I9d6530e96c781b3be2f5d5363950569a9a64175f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137485Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#756821}
-
Elly Fong-Jones authored
These tests end with an asynchronous close of the dialog's widget. This means that, depending on the current weather, either the view under test (owned by the widget) will be destroyed before or after the test ends. This *currently* doesn't usually cause problems, because Widget::Close calls DialogDelegate::Cancel, which sets the object's state so that ~ExtensionInstallDialogView doesn't do anything. However, if ::Cancel is ever not called, these tests will start to flakily pass or fail depending on whether the async close finishes before or after the test ends. This change causes the tests to wait for the close to complete, to make their execution deterministic. It also removes some dead code. As part of "fixing" issue 851167, r566186 added a MAYBE stanza for one of these tests, but never actually used it. Bug: 851167 Change-Id: Ifeac4c7791a79ea8a7c9fab7c398ea87bd62646a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136866Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#756820}
-
Mustafa Emre Acer authored
Bug: 1063566 Change-Id: I631ba68718cf69c5972555d7826b089e27fa5150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137872Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#756819}
-
chrome://termsRoman Sorokin authored
This is a reland of 5d12d84a Original change's description: > Make chrome://terms on Chrome OS same as on desktops > > To show "Google Chrome and Chrome OS Additional Terms of Service" > > Bug: 1058348 > Change-Id: I1b37825fe6970bbc7cc59f0c1b26041e350c8fa4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132419 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756677} TBR=alemate@chromium.org,tedchoc@chromium.org Bug: 1058348 Change-Id: I5af75f5a1e503e4a0f6b125aba749e610e7319a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138012Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756818}
-
Etienne Pierre-doray authored
This CL adds Jobs API perftests as a way to show use case and measure performance overhead. Local results (mac laptop): Naive: No-Op = 4627 tasks/ms BusyWait = 793 tasks/ms Dynamic: No-Op= 14771 tasks/ms No-Op disrupted= 14285 tasks/ms BusyWait= 791 tasks/ms BusyWait+disrupted= 750 tasks/ms Loop around: No-Op= 14044 tasks/ms No-Op disrupted= 13386 tasks/ms BusyWait= 773 tasks/ms BusyWait disrupted= 729 tasks/ms Change-Id: I0d625293fa95dc5a4f4f8dfc01eb84b9b5d438f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943539Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#756817}
-
Tommy Steimel authored
This CL attaches the Kaleidoscope tab helper when Kaleidoscope is enabled. Bug: 1053587 Change-Id: I1cc9b39df58ff754298e14b647527dfd913c477b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132376Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#756816}
-
Ken Rockot authored
This changes how deps checking is implemented for mojoms, though functionally the end result is the same. Given write_file's support for JSON emission, sources_list and deps_sources_list files are now combined into a single JSON "build metadata" file for each target. These are accumulated recursively and used to derive a set of acceptable imports against which mojoms are checked during an intermediate build step. This CL moves the logic from mojom_bindings_generator.py to mojom_parser.py and rolls it into the parsing step rather than being its own separate build step. Bug: 1060471 Change-Id: I4a6ae5e719c819b7db893c4e64ca013262b83688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132957Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#756815}
-
Carlos Knippschild authored
Bug: 1053262, 1053263, 1050654 Change-Id: I14071508b62855d65349763aae50c3a11dec8b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136120 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#756814}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7767e4fa4792..029854ebc997 git log 7767e4fa4792..029854ebc997 --date=short --first-parent --format='%ad %ae %s' 2020-04-06 mathias@chromium.org Follow punctuation standards for release note text Created with: gclient setdep -r src/third_party/devtools-frontend/src@029854ebc997 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I32b5064f50420badffee0fb932d04556567aab7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138051Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756813}
-
Andres Calderon Jaramillo authored
CL:2134417 and predecessors fixed ProvidePictureBuffersWithVisibleRect() so that GetRectSizeFromOrigin() is used to calculate the texture dimensions and the coded size of a VideoFrame. However, I forgot to update the test implementation of VideoDecoder (TestVDAVideoDecoder). This test does just that to be consistent with CL: 2134417. Bug: b:153085451 Test: ran video.DecodeAccel.* on kevin, kukui, and veyron_minnie. Change-Id: I647bed4271da186e0658fb5ba03e5c991f27d6d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136846Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#756812}
-
Michael Thiessen authored
Bug: 1052429 Change-Id: Ie47119c0352f94b4120f104f31726b3a991fabdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137813 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Auto-Submit: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#756811}
-
John Delaney authored
This change fixes flakes found in the ConversionHostTest suite. These flakes are currently caused by a race between storage initialization and test profile deletion. If the test profile is deleted prior to the storage initialization task finishing, the task can hang in the middle due to so undefined behavior of operating on the db causing the test to timeout. These tests do not need a real ConversionManager and only require a valid pointer. This change allows ConversionHostTest to specify a TestConversionManager which is injected via new layer of abstraction, the ConversionManagerProvider. It also switches ConversionManager to an impl pattern rather than marking all methods virtual. This test manager does not need to initialize a storage layer, fixing the timeout issue. This is also a pre-requisite for https://crrev.com/c/2012883, which requires a mock manager to fully test ConversionHost functionality. Bug: 1051334 Change-Id: I376382c2d859e7c2ee8512227d40657082348310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135061 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
-
Alex Turner authored
There are two deduplication steps currently in the filter list generation procedure. One simply removes duplicated rules. The other consolidates rules that differ only by the domains to which they apply. The removal of duplicated rules should be done before the consolidation step as the current ordering can lead to domains being repeated in a rule. Bug: 1067711 Change-Id: I3126e28f8232c0b5eaf8c021432542fad4e5ca03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134776Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#756809}
-
Jana Grill authored
The user policy will control the permission for using ADB sideloading on a per-user basis. It currently has two possible values, 0 (disallow) and 1 (allow), but it is of type int-enum to allow future extensions. Apart from this policy the behavior is controlled by the type of the user. Additionally a separate device policy will be added for managed devices. The functionality for managed ADB sideloading is currently hidden behind a feature flag. This CL only contains the initial definition of the policy and the corresponding preference, along with wiring them together. Bug: 1053908 Change-Id: I7a24468adb6ba5374e3a4c1561e94c18e4330093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122528 Commit-Queue: Jana Grill <janagrill@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#756808}
-
David Bertoni authored
The ExtensionApiTest.ContentScriptStylesInjectedIntoExistingRenderers was disabled on 2012-06-22 for being flaky. It is no longer a valid test. Bug: 120762 Change-Id: Id3b89ec7e04a83c1b38cea3d671672b7ca3277c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132670Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#756807}
-
Jian Li authored
Bug: 1044139 Change-Id: I5b8c19c2f57f6dc1e713df96f5ece54298a69a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138151Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/26e6018d..6be23fae Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5f5c5f8d74e34fdc7f3b2ad9b83cf93d62eb68f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136430Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756805}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I824978c39a257e4c8a1fe2809cf5fad38ca300f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137549Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#756804}
-
Tommy Li authored
With the new suggestion headers that are coming, go/omniboxtransparency, some rows are going to have need to paint headers above the OmniboxResultView. I considered adding the header to OmniboxResultView, but this didn't make sense for reasons detailed in some in-code comments. So I'm adding a new lightweight OmniboxRowView class to be a parent of both the OmniboxResultView and the optional header View that sits right above it. The header View is not implemented yet. Bug: 1052522 Change-Id: I693fa2dec0aa194da69f5fc744fe1099817f5ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130814 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#756803}
-
Marijn Kruisselbrink authored
Bug: 1067102 Change-Id: Ie2ea46a7973577421ce543b8bccf1850543480ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134686Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#756802}
-
Tibor Goldschwendt authored
Adds the button as specified by the doodle specification. Button doesn't do anything yet. Button action will be added in follow up CL. Bug: 1039910 Change-Id: I62bf6379c9c36fce2cd3ad0e53a2d471f0dea140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135903 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#756801}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/f175adffa9d2..c2fb0f637ece git log f175adffa9d2..c2fb0f637ece --date=short --first-parent --format='%ad %ae %s' 2020-04-06 rharrison@google.com Rolling 5 dependencies and updating exceptions (#1035) Created with: gclient setdep -r src/third_party/shaderc/src@c2fb0f637ece If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I5e8bde85db0cb708da69eb89054ece35b83335cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137662Reviewed-by:
-
Xiaohan Wang authored
This arg is almost enabled on all platforms (except Fuchsia) and actually controls very few files. Most of the mojo media related features are controlled by subsidiary buildflags like ENABLE_MOJO_CDM. This CL removes this arg to make the code cleaner. Bug: 1067786 Change-Id: I49cb56afefc08902734ab861c87cbbf98cc6366f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133851Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#756799}
-
Lily Chen authored
From M83 to M88. TBR=morlovich@chromium.org Bug: 953306 Change-Id: Ic2fa5a9a841dbf0fbb4831f5f2d181cc141090d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135837Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#756798}
-
Natalie Chouinard authored
Add a pixel diff threshold to NTP render tests to mitigate flakinesss on Android CFI bot. Additional detail in linked bugs. Bug: 945293, 1068294 Change-Id: Ia49455905dbb9f3ce2ff1809a73c8b0f30ff7f6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137811Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#756797}
-
Rainhard Findling authored
* Change the string of the button of the safety check password check child from "Change password(s)" to "Review". Bug: 1015841 Change-Id: I32a9cc39fd078d53828d8c4e6b7bc8f8bfa897c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132384Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
-
Adithya Srinivasan authored
Bug: 1066200, 1045608 Change-Id: I953209f3da2799fdf8b4383794023c33b010dab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134615Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#756795}
-
David Van Cleve authored
(This fixes a linter complaint from crrev.com/c/2136864. An alternative would be NOLINTing the constructor.) R=jbroman Bug: None Change-Id: I4a950ecf92062da310e5fc9c8631cbe9e5041443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136044Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#756794}
-
Chunbo Hua authored
Change-Id: I7d98c3641a033b6c66d88edf5f6b1943126058a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136483Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#756793}
-
Mike Dougherty authored
This reverts commit 9ac29612. Reason for revert: Breaks downstream build. Original change's description: > [ios] Plumb Browser to VoiceSearchController > > VoiceSearchCoordinator needs a Browser to access a Browser-scoped > FullscreenController. > > Bug: 790886 > Change-Id: I24acae364cb64ecc011375045feab66e58dd432e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132852 > Commit-Queue: Chris Lu <thegreenfrog@chromium.org> > Reviewed-by: Mark Cogan <marq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756754} TBR=marq@chromium.org,thegreenfrog@chromium.org Change-Id: I6ad6ae1d99efd9915ecb19cfcdd572f1d46b9d76 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 790886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138252Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#756792}
-
Dan Harrington authored
Bug: 1044139 Change-Id: Ie5aeea0f8e21d840fb0d83b93417be18e2edcf24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135015Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#756791}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/bf277d6ad924..b726d1c21aa6 git log bf277d6ad924..b726d1c21aa6 --date=short --first-parent --format='%ad %ae %s' 2020-04-06 ddrone@google.com Merge "Add Track::Global constructor" Created with: gclient setdep -r src/third_party/perfetto@b726d1c21aa6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I6ff61b30062105d1f5f2df065b13dcf60d2d66f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137547Reviewed-by:
-
Brian Salomon authored
Skia has supported RGB8 for some time. Bug: skia:7533 Change-Id: I69cf7f5050742ec7d074424648d220365184ef56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134664Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#756789}
-
Bettina authored
For the password protection warning dialog for saved paswords, up to three domains are shown. The domains are retrieved from the signon_realms. However, the signon_realms might not be eTLD+1 which means it will be empty string. To fix this, the same url formatting should be done as the password check to keep it consistent. Bug: 1067401 Change-Id: I2bad2d38a936fb1aea821822087184e998128c6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133974 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#756788}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/59b20e348f4d..9508a74c93b3 git log 59b20e348f4d..9508a74c93b3 --date=short --first-parent --format='%ad %ae %s' 2020-04-06 rwkeane@google.com Discovery: Multi Network Interface E2E Tests Cleanup Created with: gclient setdep -r src/third_party/openscreen/src@9508a74c93b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I79a086d7b4aea88b6dd050dcce4f412309208946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137657Reviewed-by:
-
James Cook authored
Fix: I missed one case where we look up an element with the wrong name when the feature is enabled. Original description: SplitSettingsSync adds some text to the OOBE sync consent dialog. Update test expectations to match, otherwise the test will fail when we flip the flag. Bug: 1067212 Test: browser_tests --enable-features=SplitSettingsSync Change-Id: I5273f94c389f0cb4c2a6f0ac9149e9d65ec24106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136881 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#756667} TBR=xiyuan@chromium.org Change-Id: I5273f94c389f0cb4c2a6f0ac9149e9d65ec24106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136871Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#756786}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I7489f975e049b53be8b7646d543336cf9fbd4dcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137655Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#756785}
-
Adam Langley authored
I cannot reproduce the error, even under ASAN. But crashing with an illegal instruction is pretty telling and from inspection, the bug seems pretty clear. Thanks C++. (Patchset one is a clear revert. See diff from PS1 to PS2 for the fix.) This reverts commit b4647037. > Revert "webauthn: support non-standard default credProtect levels." > > This reverts commit 6361e1e8. > > Reason for revert: > FidoGetAssertionTaskTest.TestSignSuccessWithFake in device_unittests has been failing on debug builds after this change. > Here is the list of failing builds on the Linux Tests (dbg)(1) bot since this change: > https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/87976 > https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/87977 > https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/87978 > https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/87979 > https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/87980 > > Original change's description: > > webauthn: support non-standard default credProtect levels. > > > > In the latest CTAP 2.1 draft, an authenticator can have a default > > credProtect level other than one. Previously, Chromium couldn't > > distinguish level one from not-specified thus, first, this change adds > > that distinction. > > > > Then there are additional complexities because Chromium sets a default > > credProtect level of two for discoverable credentials, but we don't want > > to override an authenticator default of three. Therefore the credProtect > > level for a request becomes a property that can only be resolved in the > > context of the specific authenticator that will receive the request. > > > > We already have a property like this: the Android ClientDataJSON > > extension. Thus pull these meta-level request properties into a > > different structure so that MakeCredentialRequestHandler can craft > > per-authenticator requests from that when needed. > > > > This isn't perfectly clean because the Windows API acts as an > > authenticator, but is actually a front for many authenticators. So we > > have to stuff |cred_protect_enforce| in the request object, despite it > > being a meta-level property. > > > > BUG=1057126 > > > > Change-Id: Id1c02d4689492d597f5f29674166b97a8e720d2f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130869 > > Reviewed-by: Martin Kreichgauer <martinkr@google.com> > > Commit-Queue: Adam Langley <agl@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#756380} > > TBR=agl@chromium.org,martinkr@google.com > > Bug: 1057126 > Change-Id: Ibc43ae6f841115ade183aab5c4fbfd2c01e90986 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136280 > Reviewed-by: Joey Arhar <jarhar@chromium.org> > Commit-Queue: Joey Arhar <jarhar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756505} Bug: 1057126 Change-Id: I2c2d275499be1c86d4456e5221d18a5848d5f05d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136482 Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#756784}
-
