Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 16 Jul, 2016 29 commits
  3. 15 Jul, 2016 11 commits
    • rdevlin.cronin's avatar
      [Extensions] Clean up unnecessary copy · 21876dec
      rdevlin.cronin authored 
      BUG=None

Review-Url: https://codereview.chromium.org/2153243003
Cr-Commit-Position: refs/heads/master@{#405903}
      21876dec
    • ericrk's avatar
      Disable GPU raster for OSX 10.9 · 51630e3e
      ericrk authored 
      crbug.com/611310 contains a report of a rendering issue on 10.9. As I
haven't been able to repro locally, I was hoping to get more data on
this issue during beta/canary, but no additional reports have come in.
In order to allow us to launch to stable with lower risk, this CL
disables GPU raster on 10.9, which only accounts for ~7% of mac users.

We may re-enable this for M53 Beta M54 Canary in order to track down the
issue in question, and hopefully launch to 10.9 in M53.

BUG=611310
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2151393002
Cr-Commit-Position: refs/heads/master@{#405902}
      51630e3e
    • donnd's avatar
      [TTS] Handle showing of a Context Menu more gracefully. · b09e3678
      donnd authored 
      When the TTS UX is showing and the user activates a context menu,
the selection controller gets an event sequence that's confusing,
causing a tap-selection to show the selection handles.

This change hides the Contextual Search UX, and adds a state where
the selection controller knows to ignore the next event that would
show the selection handles, when a context menu has just been shown.

This change cleans up a sequence implicated in a crash, so that
won't be reproducible through triggering the Context Menu anymore.
(Issue 562353)

BUG=628436,562353

Review-Url: https://codereview.chromium.org/2150213002
Cr-Commit-Position: refs/heads/master@{#405901}
      b09e3678
    • dfalcantara's avatar
      [Payments] Add ability to bold parts of addresses · 92f4c6ac
      dfalcantara authored 
      * Add the ability to bold parts of a label.

* Add the ability to show a tertiary label in the PaymentOption, which
  will later be used for phone number display.

* The phone number is passed in to the PaymentOption using the new constructor
  via the AutofillAddress class.

See crbug.com/626833 for screenshots.

BUG=603635,626833

Review-Url: https://codereview.chromium.org/2135573004
Cr-Commit-Position: refs/heads/master@{#405900}
      92f4c6ac
    • shaktisahu's avatar
      Changed NavigationController access to through tab in Java code · 8b75c19b
      shaktisahu authored 
      Currently most of the chrome UI code access NavigationController through
WebContents. However for Blimp mode there is no WebContents and hence
needs a different way to access NavigationController. In this CL, a
NavigationHandler interface was written that can be directly
accessed from tab. This would be used throughout clank UI. Chrome and
blimp versions would implement this interface.
BUG=612080

Review-Url: https://codereview.chromium.org/2087543002
Cr-Commit-Position: refs/heads/master@{#405899}
      8b75c19b
    • kozyatinskiy's avatar
      [DevTools] Replace SetScriptSourceError with ExceptionDetails in protocol · ce719653
      kozyatinskiy authored 
      BUG=591496
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2146333003
Cr-Commit-Position: refs/heads/master@{#405898}
      ce719653
    • hcarmona's avatar
      [MD Settings] Make Passwords and Autofill actionable if tap will work. · 710345ad
      hcarmona authored 
      BUG=624722
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2111643005
Cr-Commit-Position: refs/heads/master@{#405897}
      710345ad
    • ccameron's avatar
      Mac h264: Add GLImage copy support for non-rectangle targets · b6c2d97f
      ccameron authored 
      The target just needs to be bound as an FBO color attachment, so we
don't even have to deal with coordinate conversion math.

BUG=626861

Review-Url: https://codereview.chromium.org/2144423003
Cr-Commit-Position: refs/heads/master@{#405896}
      b6c2d97f
    • v8-autoroll's avatar
      Update V8 to version 5.4.166. · 81ddea89
      v8-autoroll authored 
      Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/de0a832e..1d801c6f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2150223003
Cr-Commit-Position: refs/heads/master@{#405895}
      81ddea89
    • krasin's avatar
      Launch CFI for virtual calls on Linux x86-64. · 01f474c4
      krasin authored 
      This is the second incremental step towards the full CFI launch.
In the first step, we enabled LinkTimeOptimization (LTO) for the
official Chrome builds. In this step we add Control Flow Integrity
checks for all virtual calls.

The remaining part is to add bad-cast checks to ensure the forward-edge
Control Flow Integrity works as planned. That remaining part will
require more work on reducing the overhead for size and speed by these
CFI checks, so we don't enable them right away.

The expected Perf impact by this CL:

- Chrome binary size is increased by 5%,
- Some of the benchmarks are slowed down by up to 3.5%.

Note that before making it slower, we made it faster by implementing
virtual const propagation and a number of heuristics for automatic
devirtualization in LLVM which sped up some layout benchmarks by up to 7%
(see https://crbug.com/580389 and https://crbug.com/617283)

If there's a higher (negative) impact, we'll be willing to roll this
feature back, but please allow the Perf bots to work for a day or two
to collect more detailed statistics on the regressions, as it will help
us to identify ways to speed it up (most likely, by inventing new ways
for automatic devirtualization).

BUG=464797

Review-Url: https://codereview.chromium.org/2140373002
Cr-Commit-Position: refs/heads/master@{#405894}
      01f474c4
    • kmackay's avatar
      [Chromecast] Make ALSA rendering delay either accurate or kNoTimestamp · dcb4ac86
      kmackay authored 
      Update the ALSA backend so that the calculated rendering delay is either
accurate, or kNoTimestamp. We no longer try to guess the correct delay
timestamp. Note that this requires callers of GetRenderingDelay() to
correctly handle the kNoTimestamp case.

BUG= internal b/30034408

Review-Url: https://codereview.chromium.org/2133293003
Cr-Commit-Position: refs/heads/master@{#405893}
      dcb4ac86