GitLab

Nvidia Shield gamepads report some buttons using usage numbers
from the Consumer usage page instead of the Button usage page
which is typical for gamepads. This CL adds logic to check for
several common usages outside the Button page and append them to
the end of the gamepad button array.

It also fixes the Xbox One S gamepad mappings to add these buttons.
The names of the mapping functions for the original firmware and
updated firmware were previously reversed; this is also fixed.

Fixed in this CL:
* [Mac/Linux] Xbox One S Guide button, original FW, Bluetooth
* [Mac/Linux] Xbox One S Guide/Back buttons, 2016 FW, Bluetooth
    (These devices are already well-supported on Windows.)
* [Mac/Win/Linux] Nvidia Shield 2015 Guide/Back/Extra buttons, USB
* [Win/Linux] Nvidia Shield 2017 mapper added, USB/Bluetooth

A mapper for Nvidia Shield 2017 was not added on Mac. The gamepad
is not recognized as a HID gamepad over USB and does not stay
connected over Bluetooth.

Note that some Consumer key codes have other meanings on some
platforms that may cause Chrome to navigate away from the current
page.

BUG=847692

Change-Id: I4edafc0507c553ebdc4daac0b5a6f1ecfeb7c1ed
Reviewed-on: https://chromium-review.googlesource.com/1091633Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575710}

It's very easy to forget checking for !db, which explains crbug.com/860228.
Now Execute does the check for us. The caller must designate a value
to be passed to the result callback in the case of db failure.

BUG: 864592

Change-Id: Ie4e1ac0bcd60e9e0c8c30413af10d44ff0175b47
Reviewed-on: https://chromium-review.googlesource.com/1140277
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575709}

Bug: 787924
Change-Id: I4da50acf43aa180cd62ea5e2210c5d54adda1dcf
Reviewed-on: https://chromium-review.googlesource.com/1140673Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575708}

Disable ShelfLayoutManagerTest.FlingUpOnShelfForFullscreenAppList
Disable WindowSelectorTest.RoundedEdgeMaskVisibility

Tbr: xiyuan, xdai
Bug: 864467, 864465
Change-Id: I77a0dbcddad5176575f0dc5991beb9eef8090167
Reviewed-on: https://chromium-review.googlesource.com/1140683Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575707}

This is a reland of 5cab33d1

In Patchset 2, it also makes the widget insensitive to mouse events
while animating closed.

This fixes the crash triggered when the user clicks on the results list
while the popup is animating closed. It also makes the popup no longer
change its highlighted match in response to mouseover events.

We also are insensitive to gesture events while closing, but we do not capture
them.

Original change's description:
> Omnibox UI Refresh: Implement popup open and close opacity animations.
>
> This eases in and out the Omnibox popup opacity over 82ms as it opens
> and closes. This matches the animation spec provided by UX.
>
> Bug: 823535
> Change-Id: Ic2add1f57f63ae6d043812f2bd5a766f84d302c9
> Reviewed-on: https://chromium-review.googlesource.com/1081198
> Commit-Queue: Tommy Li <tommycli@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Ali Juma <ajuma@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#564295}

TBR=ajuma@chromium.org

Bug: 823535, 857486
Change-Id: Ie497eefd007ae30a9098be30f55f63dc51adecc3
Reviewed-on: https://chromium-review.googlesource.com/1138514
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575706}

This function initializes the login screen multiple times, which views login did
not support.

Bug: 859559
Change-Id: I57f3282b12c604074f9d34760f9804c18eee2d09
Reviewed-on: https://chromium-review.googlesource.com/1125129Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575705}

Render: https://screenshot.googleplex.com/gTB6H033JFQ

Bug: 854369
Change-Id: I0dea118fe75090aa7bd4b54b31168768777c7d93
Reviewed-on: https://chromium-review.googlesource.com/1112664
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575704}

Removing mock-vr-service.js and using xr-device-mocking instead to
reduce the amount of code duplication.

Change-Id: If44a1365da855d1b789404fd21e31c92c0bbf8f5
Reviewed-on: https://chromium-review.googlesource.com/1140283
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575703}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/dcf3638e..b1e14adb

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I69cb1df8fa91cfc67aca8ee70e87602be33fb5af
Reviewed-on: https://chromium-review.googlesource.com/1140137Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575702}

Change-Id: Icbc23ea507b5fe09a5bfb1d38d1f40e84c0d4e99
Reviewed-on: https://chromium-review.googlesource.com/1136980
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575701}

In virtual/layout_ng this test has been passing for a while.

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual/layout_ng/fast/inline/styledEmptyInlinesWithBRs.html

a local bisect reveals this is the fix:
https://chromium-review.googlesource.com/1132532

Bug: 714962
Change-Id: Idbe3cf1a463596d2cc99f38360cad255af0bcdb8
Reviewed-on: https://chromium-review.googlesource.com/1140367Reviewed-by: Peter Mayo <petermayo@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575700}

external/wpt/css/css-shapes/shape-outside/values/shape-margin-001.html
external/wpt/css/css-shapes/shape-outside/values/shape-outside-shape-arguments-000.html
have both been passing on Linux for the whole of the flakiness
dashboard history.

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external/wpt/css/css-shapes/shape-outside/values/shape-margin-001.html%20external/wpt/css/css-shapes/shape-outside/values/shape-outside-shape-arguments-000.html

Bug: 441840
Change-Id: I4a9d6c92c0d8708a010f390e949eba81d713afc3
Reviewed-on: https://chromium-review.googlesource.com/1140371Reviewed-by: Peter Mayo <petermayo@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575699}

The CL moves as much as possible from AutofillPopupViewNativeViews to
AutofillPopupBaseView (parent for the generation drop-down). At the same time
AutofillPopupViewViews implements the stuff specific for it and irrelevant for
the new views prompts. AutofillPopupViewViews is gonna be deleted soon anyway.

Bug: 851021
Change-Id: I4711c29220c841356e5a7d8adca0cd5c222c8cde
Reviewed-on: https://chromium-review.googlesource.com/1136633Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575698}

The purpose of the added test is to ensure the reliability of the feature as
well as detecting flakiness that could be caused by race conditions.

The test is marked as MANUAL_ to avoid it running on the regular commit queue
trybots.

To run the test manually on Android, increasing various timeouts is needed:
out/android_release/bin/run_content_browsertests --gtest_filter=*WebRtcImageCaptureStressBrowserTest* --test-launcher-retry-limit=0 --ui-test-action-max-timeout=60000 --shard-timeout=60
The above sets the timeout to 1 minute, which should be more than enough for 10 photos.

Bug: 857530
Change-Id: Ibf4f78d43dc3cbe24687710f48bf311f7bb0bfd4
Reviewed-on: https://chromium-review.googlesource.com/1135703
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575697}

Also added unit tests and updated TestPersonalDataManager.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic65ad3a3a6688cf0cbd8ccc75038e0a6557cde00
Reviewed-on: https://chromium-review.googlesource.com/1139090Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575696}

BUG=836871

Change-Id: If259500c8f226ff198586f56a3d711565791b488
Reviewed-on: https://chromium-review.googlesource.com/1140433
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575695}

The worker's onmessage handled needs to be wrapped in a step_func()

Change-Id: Icfbad1936d9c9bd7fbd5522ce64f667f2699ef0d
Reviewed-on: https://chromium-review.googlesource.com/1139179
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575694}

Bug: 680407,621126
Change-Id: I4be6aeb3cdce35c89abaea8ce756aba456aa36b9
Reviewed-on: https://chromium-review.googlesource.com/1138794Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#575693}

Some Chrome OS services actually rely on this being OK since they don't
have the PID of the target process available. Presumably they would fail
if DCHECKs were enabled.

This removes an unnecessary DCHECK so that such code can be exercised in
chromium tests.

Bug: None
Change-Id: Id546644aae7222eaf76b9a279f0c99af0764573c
Reviewed-on: https://chromium-review.googlesource.com/1140280Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575692}

Bug: 857533
Change-Id: I9a62b52edad78b30cc25dc15f7f098ce3a82bc46
Reviewed-on: https://chromium-review.googlesource.com/1140374
Commit-Queue: Bruno Kim Medeiros Cesar <brunokim@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575691}

In fullscreen, when the mouse moves to the upper border of the screen, a
slide-down menu will show. When the user enables showing toolbar in
fullscreen, a native title bar will also appear. In such case, our tab
strip and toolbar should show underneath the title bar.

This CL reuses the Cocoa browser's menu and mouse tracking classes, and
implements a Views based FullscreenToolbarController to track the mouse
activities and menu progress so the top UI would show in appropriate
position.

BUG=831219

Change-Id: Ia30c9cb74819a866ae39cc3e696affb94350efbf
Reviewed-on: https://chromium-review.googlesource.com/1130001Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575690}

We decided to skip the finch trial for adding these new UMA metrics,
so remove the flag kPresentationFeedbackEveryFrame added earlier.

Bug:851088

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I63eacff9d616594d340b983a0fe373c24e790032
Reviewed-on: https://chromium-review.googlesource.com/1136069Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575689}

When the flag is on, Polymer 2 is used everywhere. When off, Polymer 1 is used.

Bug: 862472
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Iefdbf6448c0c69b6f22df1a3db57db29e29607da
Reviewed-on: https://chromium-review.googlesource.com/1137706
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575688}

This is a partial reland of b035cfda

Original change's description:
> Disallow QuitCurrent*Deprecated() on RunLoops with Quit*Closure()s.
>
> Use of RunLoop::QuitCurrent*Deprecated() is deprecated, and risky,
> potentially causing unexpected early-exits if run under a different
> RunLoop to the one intended.
>
> If a caller has taken a Quit*Closure() from the RunLoop then we now
> assume that they intend to use it to quit the loop, and therefore use
> of QuitCurrent*Deprecated() with it must be unintentional.
>
> Bug: 844016
> Change-Id: Ib181d0cb34cdba2af29f557646cbe631101bc6b0
> Reviewed-on: https://chromium-review.googlesource.com/1082980
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571499}

Bug: 844016
Change-Id: I0666631fa736244c18f8848b317b41762881c748
Reviewed-on: https://chromium-review.googlesource.com/1121296Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575687}

Don't allow Explore on Content to re-show itself in response to a tap on
the toolbar button until any previously set content is fully removed
from the sheet.

Also, go directly to the hidden state when tapping on the scrim when the
peek state is disabled.

BUG=863568

Change-Id: I5f6fea7fe637b4f346542321de6716899b6bf8fc
Reviewed-on: https://chromium-review.googlesource.com/1139112Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575686}

This type was introduced for server LoFi before Previews had
blacklisting support. It did 3 things: bypassed cache, loaded original
request, and disabled previews.

Previews are disabled by the 5 minute rule after an opt out, so that
functionality is covered (if users have disabled their blacklist, they
will not be served the preview because of a new 5 second rule, but this
scenario is not supported by default).

Bypass cache is not important, as LoFi images, litepage, etc are using
vary to control resources based on added headers, so not setting the
various previews headers handles this (in the case of client LoFi,
range requests are used instead of vary).

Since we are using a reload type that gets the original requested URL,
we handle that case as well.

This also adds dependency injected Clock for testing the ignored
blacklist functionality.

Bug: 863569
Change-Id: Ia1f05f6242522f883903742301025fb6d3c71044
Reviewed-on: https://chromium-review.googlesource.com/1137022Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575685}

BUG=b:110439301

Change-Id: I3ab1081653fbca1c1f427f2621d181f2fe0c1bc3
Reviewed-on: https://chromium-review.googlesource.com/1128326Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575684}

https://android.googlesource.com/platform/external/perfetto.git/+log/3d33483bb985..debca810f01d


git log 3d33483bb985..debca810f01d --date=short --no-merges --format='%ad %ae %s'
2018-07-17 hjd@google.com Merge "perfetto-ui: Add dingus test double library"
2018-07-17 hjd@google.com perfetto-ui: Add dingus test double library


Created with:
  gclient setdep -r src/third_party/perfetto@debca810f01d

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Iebad06e41a79ae03969ec5cce0c197b699b2ee80
Reviewed-on: https://chromium-review.googlesource.com/1140414
Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575683}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/9e945c84d2be..004af3cf8045


git log 9e945c84d2be..004af3cf8045 --date=short --no-merges --format='%ad %ae %s'
2018-07-17 dgarrett@chromium.org Revert "chrome_committer: Hardcode GCE service account."


Created with:
  gclient setdep -r src/third_party/chromite@004af3cf8045

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Iab1c07aab14afff52078df885670fa522cb8c8f9
Reviewed-on: https://chromium-review.googlesource.com/1140258Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575682}

Makes fling speed feel more natural.

Bug: none
Test: flashed, flinged
Change-Id: I8b181dbe0e9dec00f1e7a91799bbd83e86bea48b
Reviewed-on: https://chromium-review.googlesource.com/1140503
Commit-Queue: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org>
Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575681}

The previous DCHECK meant that we can't introduce a new type in the
future without breaking old clients. Instead, just ignore types we
don't know about.

Bug: 864428
Change-Id: Iaa31e2b0e6d501e14fcc1fa840110fc22f5c100a
Reviewed-on: https://chromium-review.googlesource.com/1140058Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Florian Uunk <feuunk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575680}

Bug: 826367
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6f3659b846ecf118e1c5710a77ba020ba6eb2d25
Reviewed-on: https://chromium-review.googlesource.com/1123692Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575679}

This is a reland of 4714a9fc (PS1 is the original CL)

Reverted @ https://chromium-review.googlesource.com/c/chromium/src/+/1137893
for a perf regression.
Suspected cause : |IncomingTaskQueue::message_loop_scheduled_| wasn't
equivalent to |was_empty| after all since |incoming_queue_| being empty
doesn't mean |outgoing_queue_| is empty (hence setting a bit to false
when both |outgoing_queue_| and |incoming_queue_| are empty is important
to avoid scheduling more than necessary.

Original change's description:
> [MessageLoop] Refactor ScheduleWork and TaskAnnotator logic out of IncomingTaskQueue
>
> This was extracted from
> https://chromium-review.googlesource.com/c/chromium/src/+/1088762/17
> in an attempt to simplify it (and is now a precursor to it).
> (MessageLoop::Controller was IncomingTaskQueue::MessageLoopController
> there but after grokking the resulting CL it's simpler under MessageLoop
> as done in this CL)
>
> This CL splits the logic in IncomingTaskQueue which took care of
> scheduling the MessageLoop into a dedicated class. In that follow-up CL:
> MessageLoopTaskRunner will interact directly with the task Observer and
> take IncomingTaskQueue completely out of the picture (merely a data
> structure holding various task queues at that point).
>
> IncomingTaskQueue also took care of detaching on MessageLoop shutdown
> which was moved to the new Controller class as well.
>
> message_loop.cc is the best place for this extracted logic as it all
> pertains precisely to MessageLoop's implementation detail (how
> ScheduleWork should be invoked).
>
> This CL simplifies locking as well by having a clear separation between
> the two locks instead of two locks in the same class used
> interchangibly. |incoming_queue_lock_| is now strictly for incoming
> tasks. |message_loop_lock_| is now strictly for
> ScheduleWork()/DisconnectFromParent().
>
> Note: |message_loop_scheduled_| was dropped as it was redundant (always
> equal to |!was_empty|).

This last statement was incorrect. The equivalent of
|message_loop_scheduled_| was incorporated into |was_empty| in PS2 of this
reland.

>
> Performance wise, the perf tests show that this change is a noop :
>  * While BasicPostTaskPerfTest became simpler (executed less code) with
>    this CL :
>      The new BasicPostTaskPerfTest w/ MockObserverSimulatingOverhead
>      reintroduces that overhead to show that it's still the same (or
>      slightly in favor of this CL).
>  * And the IntegratedPostTaskPerfTest are the same.
>  * Augmented perf tests to 30 seconds which yields more reliable results.
>    (and ran old ones under 30s mode too when comparing)
>  * Results :
>      https://docs.google.com/spreadsheets/d/100wYvbCI_dJ7gRnQiSsYaTb5OJnbF_muL6LyQWJLXSU/edit
>
> Bug: 860252
> Change-Id: I22de2409d52414524cc125b0e2fe08e2c516fcbe
> Reviewed-on: https://chromium-review.googlesource.com/1127262
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Reviewed-by: danakj <danakj@chromium.org>
> Reviewed-by: kylechar <kylechar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574048}

Bug: 860252
Change-Id: Ibe52413366e9b3ff38c9cb51616f9b8938ca68ad
Reviewed-on: https://chromium-review.googlesource.com/1137894Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575678}

Creates the provider that will contain the buttons to bring up manual
fallbacks for autofill. Gated behind the manual fill flag.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia36af25fc1e45f92e892b72a058b92d00c135b9c
Bug: 845472
Reviewed-on: https://chromium-review.googlesource.com/1135323
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575677}

They are replaced by
- Memory.Experimental.Renderer2.V8
- Memory.Experimental.Renderer2.V8.AllocatedObjects

The corresponding CL in V8 that removes recording:
https://chromium-review.googlesource.com/c/v8/v8/+/1101197

Bug: 852415
Change-Id: I1357ced8536386d7083666edc66862661e073e84
Reviewed-on: https://chromium-review.googlesource.com/1101033
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575676}

In the touch layouts, LOCATION_BAR_ICON_SIZE is 20, but kFaviconSize is 16, leading to different location bar icon image sizes depending on what icon is displayed and causing the omnibox text to jump when the icon size changes. For example, when typing a url, the 20px globe icon is displayed; wheras when typing a search url, the default search provider's favicon is displayed if available, which for Google is the 16px G icon. To avoid this, we set the location bar icon's size as LOCATION_BAR_ICON_SIZE, which is large enough to contain all icons. This is not an issue in other layouts, where both constants are 16.

Bug: 860295
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie9bc7a1b0b6b5a1f3dc6f4d2239d8fc2305c5063
Reviewed-on: https://chromium-review.googlesource.com/1135700
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575675}

Null ptr checks were missing on context_provider_wrapper, resulting
in crashes after a GPU context loss.

BUG=863752

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I4b6f1fc394deb3f5567fee1da6f74b66aa7db79d
Reviewed-on: https://chromium-review.googlesource.com/1140282Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575674}

Bug: 864585
Change-Id: Id88cbb9f2d0cb487bf1285988d015b356633916c
NoTry: True
Tbr: robliao@chromium.org, ellyjones@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1140533Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575673}

Vertically center custom background images. kCSSBackgroundPositionTopCover
was previously added to align custom backgrounds, change this to
kCSSBackgroundPositionCenterCover.

Bug: 862789
Change-Id: I7905f21bcb8f54fd2710784b4dc16da8820ec1dd
Reviewed-on: https://chromium-review.googlesource.com/1140364Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575672}

Rather than VRDisplayHost calling into a specific device to request
a session, this change allows VRDisplayHost to choose the correct
device to match the options.

VRDisplayHost is no-longer tied to a single device, and there is now
only one VRDisplayHost per VRServiceImpl.

VRDisplayInfo and VRMagicWindowProvider should be returned as part of
session creation, which will be addressed in followups.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ic305b3f1243f91b512da34ac936fe14bfb4a8d76
Reviewed-on: https://chromium-review.googlesource.com/1107484
Commit-Queue: Bill Orr <billorr@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575671}