GitLab

Modify the three "real" implementations of SafeBrowsingDatabaseManager
to enable lookups for "ws:" and "wss:" URLs.

This change doesn't cause SafeBrowsing checks to be performed on
WebSocket URLs. No ws: or wss: URLs will be passed to the
SafeBrowsingDatabaseManager yet. It just ensures that they will actually
be looked up when a future change causes them to be checked.

This change is required for both designs described in the "WebSocket
SafeBrowsing Support" design document:
https://docs.google.com/document/d/1iR3XMIQukqlXb6ajIHE91apHZAxyF_wvRoB5JGeJYPs/edit

BUG=644744

Review-Url: https://codereview.chromium.org/2925233002
Cr-Commit-Position: refs/heads/master@{#478553}

This layout test has been marked as flaky on Windows and Linux, but looks flaky
also on Mac.

A failure log is:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/47093

TBR=tzik@chromium.org
NOTRY=true

Bug: 731518
Change-Id: I9e37d6f69e0146a192a31ce46b14b1219de52395
Reviewed-on: https://chromium-review.googlesource.com/530885Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478552}

BUG=561800

Review-Url: https://codereview.chromium.org/2926383003
Cr-Commit-Position: refs/heads/master@{#478551}

BUG=561800

Review-Url: https://codereview.chromium.org/2926793002
Cr-Commit-Position: refs/heads/master@{#478550}

Helper classes in usb_device_handle_unittest.cc don't fit to OnceCallback
migration, as they are copied and passed to others.
This CL updates them to pass new callbacks for each use to avoid the
copy of callbacks.

Bug: 714018
Change-Id: Ifb70901439ae92b6b049b84534283c39ebc40ee0
Reviewed-on: https://chromium-review.googlesource.com/527549Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478549}

- Add ServiceWorkerUtils::IsServicificationEnabled() for easier check.
  Currently this simply internally check --enable-network-service &&
  PlzNavigate enabled.
- Disable request interception via Network provider if servicified code
  path is enabled (temporarily; otherwise various DCHECK could fail)
- Small fixes in ServiceWorkerURLLoaderJob

BUG=715640

Review-Url: https://codereview.chromium.org/2931033005
Cr-Commit-Position: refs/heads/master@{#478548}

This CL replaces ScopedVector with std::vector<std::unique_ptr>
in components/history.
ScopedVector is deprecated, see bug.

BUG=554289

Review-Url: https://codereview.chromium.org/2906953003
Cr-Commit-Position: refs/heads/master@{#478547}

Having ScriptValue in ErrorEvent creates a cycle reference between
blink and v8 and causes memory leak. Fix it by using wrapper tracing.

BUG=701695,501866

Change-Id: I3235bc52f95e9fb54ab37e234269ffe5374f10c6
Reviewed-on: https://chromium-review.googlesource.com/527547
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478546}

This CL makes FrameFetchContext work after detached from the underlying
frame and document, in order to support use-cases currently covered by PingLoader.

After detached, FrameFetchContext stops notifying, but keeps enforcing
security checks by storing the security information when detached. One important
TODO is ShouldBlockFetchByMixedContentCheck which is not implemented in this CL
because MixedContentChecker requires a real Frame instance.

Bug: 695939
Change-Id: I0fee9d39cd996a5546fe8378910386d9de7dc27d
Reviewed-on: https://chromium-review.googlesource.com/518743
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478545}

This patch introduces |AdjustInlineBoxPositionForTextDirection()| which is
split from |ComputeInlineBoxPosition()| to reduce source code size of
|ComputeInlineBoxPosition()| for improving code health.

BUG=707656
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2928083003
Cr-Commit-Position: refs/heads/master@{#478544}

This patch chagnes |ComputeInlineBoxPosition()| to avoid to reuse local
variable |equivalent| by introducing two const-variable and another call
site of |ComputeInlineBoxPosition()| to explicitly denotes what value is
used, e.g. |downstream_equivalent| or |upstream_equivalent|, for improving
code health.

BUG=707656
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2933513002
Cr-Commit-Position: refs/heads/master@{#478543}

EnsurePreInsertionValidity() was the only callsite of
CheckAcceptChildGuaranteedNodeTypes().

Bug: 730412
Change-Id: I3f623f6f2511c8634f3832739ac064975547a7d9
Reviewed-on: https://chromium-review.googlesource.com/530606Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478542}

This is a refactoring CL and does not change behavior.

This CL...
 - moves CreateWorkerThread() from 'protected' to 'private'.
 - moves getters from 'public' to 'protected'.
 - renames GetThreadableLoadingContext() to CreateThreadableLoadingContext()
   because this returns a newly created context.
 - adds class-level comments and thread checks.

Bug: 673711, 719775
Change-Id: I855e43eba5f51858cf0afb68a074682de8ef0523
Reviewed-on: https://chromium-review.googlesource.com/527714Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478541}

Cr-Commit-Position: refs/heads/master@{#478540}

Adds the following under the "vk" trace marker group:
- ShowKeyboardInternal
- ShowKeyboardContainerWindow
- ShowKeyboardContainer
- KeyboardLayoutSetChildBounds
- OnTextInputStateChanged
- HideKeyboard
- ReloadKeyboardIfNeeded
- EnsureCaretInWorkArea
- MoveKeyboardToDisplay
- MoveKeyboardToTouchableDisplay
- MoveKeyboardToDisplayInternal
- LoadContents

BUG=725789

Review-Url: https://codereview.chromium.org/2923493002
Cr-Commit-Position: refs/heads/master@{#478539}

BUG=
TBR=jbroman@chromium.org

Review-Url: https://codereview.chromium.org/2936533002
Cr-Commit-Position: refs/heads/master@{#478538}

DataChannelManager manages a set of factory functions to create
DataChannelHandler instances to handle named data channels. So once the peer
creates a new data channel, DataChannelManager can automatically handle it.
Lifetime of a DataChannelHandler is consistent with the MessagePipe it received:
it deletes itself once the MessagePipe is closed.

BUG=650926

Review-Url: https://codereview.chromium.org/2907073003
Cr-Original-Commit-Position: refs/heads/master@{#478442}
Committed: https://chromium.googlesource.com/chromium/src/+/4a15f818c5fdbd1e2c44bf102047ecd9b2c166e2
Review-Url: https://codereview.chromium.org/2907073003
Cr-Commit-Position: refs/heads/master@{#478537}

This CL prevents a needless copy of the first disallowed load callback
but in general should just give us more meaningful stack traces in
crashes.

Bug: 731714
Change-Id: I24e536effe048886a054f1a4ac8a2b2ee493363a
Reviewed-on: https://chromium-review.googlesource.com/530244
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478536}

TBR=junov@chromium.org

Bug: 732140
Change-Id: I95acb83bf7e2d62fa559c618b8e32a893c19bd69
Reviewed-on: https://chromium-review.googlesource.com/530467
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478535}

BUG=730537

Review-Url: https://codereview.chromium.org/2925053003
Cr-Commit-Position: refs/heads/master@{#478534}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/be1b0570..0b040040

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2931293002
Cr-Commit-Position: refs/heads/master@{#478533}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0e39219e..be1b0570

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2935583003
Cr-Commit-Position: refs/heads/master@{#478532}

BUG=726972

Review-Url: https://codereview.chromium.org/2927573004
Cr-Commit-Position: refs/heads/master@{#478531}

(Also base_unittests, which is removed from build repo config in https://chromium-review.googlesource.com/c/530188/ )

BUG=707029, 731217

Review-Url: https://codereview.chromium.org/2930193002
Cr-Commit-Position: refs/heads/master@{#478530}

BUG=732100
TBR=agrieve

Review-Url: https://codereview.chromium.org/2931283002
Cr-Commit-Position: refs/heads/master@{#478529}

The following layout tests are flaky on Mac:
* http/tests/shapedetection/shapedetection-cross-origin.html
* virtual/mojo-loading/http/tests/shapedetection/shapedetection-cross-origin.html

BUG=732103
TBR=xianglu@chromium.org,qyearsley@chromium.org,mcasas@chromium.org,jeffcarp@chromium.org,mcgreevy@chromium.org,dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2928293002
Cr-Commit-Position: refs/heads/master@{#478528}

Cr-Commit-Position: refs/heads/master@{#478527}

TBR=mikecase@chromium.org,hzl@chromium.org

Change-Id: Id7187e1fa622103d5a8e02f4404d42a5ebcd6a5b
Reviewed-on: https://chromium-review.googlesource.com/529976Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478526}

auth_error_email_button_ is always null.

BUG=None

Review-Url: https://codereview.chromium.org/2923933003
Cr-Commit-Position: refs/heads/master@{#478525}

An arm_version 6 file assumes that __clang__ means that clang's assembler is
being used, while it only really identifies clang is used as preprocessor.

Luckily, it looks like only the armv7 assembly code in boringssl is incompatible
with clang's built-in assembler.

BUG=732066,124610
TBR=davidben

Review-Url: https://codereview.chromium.org/2932043004
Cr-Commit-Position: refs/heads/master@{#478524}

Remove unnecessary explicit for zero-parameter constructor in
AwContentBrowserClient and AwJavaScriptDialogManager.

BUG=
TEST=
R=sgurun@chromium.org

Review-Url: https://codereview.chromium.org/2935533002
Cr-Commit-Position: refs/heads/master@{#478523}

TBR=bpastene@chromium.org

Bug: 662623
Change-Id: I66d80b04d27fe63ed00649e28a3430d01ec02611
Reviewed-on: https://chromium-review.googlesource.com/530514Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478522}

BUG=732061
TBR=oysteine@chromium.org

Review-Url: https://codereview.chromium.org/2932233002
Cr-Commit-Position: refs/heads/master@{#478521}

TBR=brettw

Bug: none
Change-Id: I0772178c0dae3355c32c375108df6e32a30f228f
Reviewed-on: https://chromium-review.googlesource.com/530225Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478520}

This CL moves more implementation files of public/web/ classes to
core/exported/. Files moved:

- WebDOMMessageEvent.cpp.
- WebContextFeatures.cpp.
- WebLanguageDetectionDetails.cpp
- WebPluginDocument.cpp.
- WebSearchableFormData.cpp
- WebScopedWindowFocusAllowedIndicator.cpp.

Bug: 712963
Change-Id: Ib9c92047516cd5401fd6f6406c1b9967f6d49b86
Reviewed-on: https://chromium-review.googlesource.com/530427Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478519}

Revert of ChromeDriver: Handle key events properly on Mac (patchset #6 id:440001 of https://codereview.chromium.org/2656903005/ )

Reason for revert:
Speculative, might have caused https://crbug.com/732053

Original issue's description:
> ChromeDriver: Handle key events properly on Mac
>
> Fixes devtool's emulation of key input events to emulate
> os key event for OSX.
>
> BUG=667387
>
> Review-Url: https://codereview.chromium.org/2656903005
> Cr-Commit-Position: refs/heads/master@{#478407}
> Committed: https://chromium.googlesource.com/chromium/src/+/fa84ab9619de73a61d305c7459fc186e99b0d291

TBR=dgozman@chromium.org,rohitrao@chromium.org,pfeldman@chromium.org,luoe@chromium.org,erikchen@chromium.org,allada@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=667387

Review-Url: https://codereview.chromium.org/2932223002
Cr-Commit-Position: refs/heads/master@{#478518}

gcc has been deprecated in the NDK for a while.

The blocker here was binary size, but after
https://codereview.chromium.org/2897283002 that's fixed – clang-built binaries
on Arm are now a few 100 kB smaller than with gcc. (The Android kernel is
now also built in this configuration that we are going to use.)

Given that Android supports 6 ISAs, this will probably break
some bot that I don't know about. If that happens, please file
a bug for that and revert. This should be safe to revert.

I ran these perf try jobs:
 tools/perf/run_benchmark try android-one blink_perf.dom
 tools/perf/run_benchmark try android-one blink_perf.bindings
 tools/perf/run_benchmark try android-one thread_times.key_silk_cases
 tools/perf/run_benchmark try android-nexus5X blink_perf.dom
 tools/perf/run_benchmark try android-nexus5X blink_perf.bindings
 tools/perf/run_benchmark try android-nexus5X thread_times.key_silk_cases
Results:
 https://bugs.chromium.org/p/chromium/issues/detail?id=481675#c31

BUG=481675

Review-Url: https://codereview.chromium.org/2901093007
Cr-Commit-Position: refs/heads/master@{#478517}

webrtc::VideoFrameBuffer can now support more than I420 and native
buffers, so the new VideoFrameBuffer::Type() function should be used to
determine what kind of buffer it is, and access to I420 data should be
done by first calling VideoFrameBuffer::ToI420(). The deprecated
functions in WebRtcVideoFrameAdapter will be removed eventually, but
this needs to happen in several steps synced with WebRTC CL:s in order
to not break anything in the process.

Another change with this CL is that WebRtcVideoFrameAdapter::ToI420()
can be called even if the frame is already in I420, it would previously
crash otherwise.

BUG=webrtc:7632

Review-Url: https://codereview.chromium.org/2925313002
Cr-Commit-Position: refs/heads/master@{#478516}

BUG=728735

Review-Url: https://codereview.chromium.org/2933693002
Cr-Commit-Position: refs/heads/master@{#478515}

EditorDialog.dismissDialog() incorrectly overrides
Dialog.dismissDialog(). This prevents correctly dismissing the dialog on
older versions of Android, e.g., Kit Kat and Jelly Bean.

Bug: 730829
Change-Id: Idf43f85bf3c6e7ebd15f3b73bfdabf8bcc8161cb
Reviewed-on: https://chromium-review.googlesource.com/530344Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478514}