GitLab

It has the same value as |is_nested_|, but is CrOS-specific. Use
|is_nested_| instead.

Bug: 755413
Change-Id: I64b425acab7c61617088fd976f97767d429ad351
Reviewed-on: https://chromium-review.googlesource.com/861983Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530579}

Decryption failures indirectly cause other components to fail. Having
visible logs of this event will speed up triaging and diagnosis of
various bugs we receive from the wild.

Change-Id: If002145041a811cfd2dc719fad7c6f3d55988ae6
Reviewed-on: https://chromium-review.googlesource.com/876424
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530578}

Using wpt-import in Chromium 46f11d03.
With Chromium commits locally applied on WPT:
e8a79119 "Fixed wpt csp reporting tests and moved over chrome internal ones"
ea343b08 "[css-grid] Fix for flexible tracks, gutters and spanning items"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/10383

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
kpaulhamus@chromium.org:
  external/wpt/webauthn

TBR=kereliuk

No-Export: true
Change-Id: I872f3dc120c958a49737598cfeede7113ca2a17a
Reviewed-on: https://chromium-review.googlesource.com/876442
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530577}

Found by compiling with libc++ on Windows.

Bug: 801780
Change-Id: I7e4fe3e00570a16669be87120a6973912d120f58
Reviewed-on: https://chromium-review.googlesource.com/875373Reviewed-by: Zijie He <zijiehe@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530576}

GLApplyScreenSpaceAntialiasingCHROMIUMES3Test are currently
crashing on devices not supporting GLES3.
Check this before running the tests.

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib46a9fdc6d893118d624af4ded854f642e651e2d
Reviewed-on: https://chromium-review.googlesource.com/873354Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530575}

Bug: None
Change-Id: I06b55da87770ad574bfebc607302437946a258ff
Reviewed-on: https://chromium-review.googlesource.com/875415Reviewed-by: May Lippert <maybelle@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530574}

Split out a PaintTextClipMask method and make that virtual instead of
PaintFillLayerTextFillBox. Move PaintFillLayerTextFillBox to
BoxPainterBase and call PaintTextClipMask for the bits that differ.

Bug: 803382
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ie44a64a6e70eac8a5a1029650fd206fc9b2852f7
Reviewed-on: https://chromium-review.googlesource.com/874074Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530573}

https://skia.googlesource.com/skia.git/+log/e201ebc99515..b1b80f7de422

$ git log e201ebc99..b1b80f7de --date=short --no-merges --format='%ad %ae %s'
2018-01-18 jvanverth Remove tonal color from DrawShadow internals
2018-01-18 halcanary SkQP: better logging
2018-01-19 brianosman Be more explicit checking for render targets with MSAA render buffers
2018-01-19 reed remove code from old picture serial guard
2018-01-19 robertphillips Fix handling of red support for GalliumLLVM renderer
2018-01-19 update-docs Update markdown files
2018-01-18 reed add shadermaskfilter
2018-01-18 reed validate paint setters in readbuffer
2018-01-18 csmartdalton Extract a GrCCPathParser class that is decoupled from atlas ops
2018-01-18 ethannicholas SkSL now supports ternary lvalues
2018-01-18 reed detect fixed overflow in drawPoints
2018-01-18 reed check for inconsistent counts in drawTextRSXform
2018-01-18 robertphillips Move GrOpFlushState out of GrDrawingManager and onto the stack
2018-01-17 halcanary SkQP: fix broken JUnit tests & report output
2018-01-18 reed turn assert into check for text
2018-01-17 ethannicholas sk_in array is now sized correctly in SPIR-V output
2018-01-17 bsalomon Remove old command buffer ES3 tex storage limitation
2018-01-17 bsalomon Remove GrGLCaps::fTextureRedSupport
2018-01-17 ethannicholas cleaned up SkSL constant handling
2018-01-17 robertphillips Remove GrSurfaceProxy::MakeWrapped (take 2)
2018-01-17 reed use safemath::mull for buffer sizes

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=halcanary@chromium.org

Change-Id: I2c3f3b512000ad36dfb5de86d1e0730b9b9e685d
Reviewed-on: https://chromium-review.googlesource.com/875921Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530572}

The tests produced invisible subpixel differences.

TBR: trchen@chromium.org
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I949c670ba6ee4192fb498206411309cc7e0ff2a6
Reviewed-on: https://chromium-review.googlesource.com/876495Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530571}

This change implements delete for SMB on SmbFileSystem and
SmbProviderClient. This does not support recursive deletes.

Test: Verified via ui.
Bug: 757625
Change-Id: Ife9f1002a398877255cdbc642ba6c69c47ba82bc
Reviewed-on: https://chromium-review.googlesource.com/875412
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530570}

This was regressed by https://chromium-review.googlesource.com/865939

Change-Id: Id5d0cc587e4ea29c3e705fec1112b4b1301f3e78
Reviewed-on: https://chromium-review.googlesource.com/875124
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530569}

The last callback needs to be run, otherwise the WindowManagerState is
still waiting on an ack.

Also adds test coverage.

BUG=none
TEST=none

Change-Id: I2861e59b28248f610df15106a7d23d640838ad02
Reviewed-on: https://chromium-review.googlesource.com/875244Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530568}

Bug: 769401
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I6f4f5b375e06809d85a1d24c4b6d3a8a137bcc6d
Reviewed-on: https://chromium-review.googlesource.com/867414
Commit-Queue: Doug Turner <dougt@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530567}

This CL changes DeviceSensorEventPump and DeviceOrientationEventPump to
use BindOnce.

Bug: 714018
Change-Id: Ib33b3fbf2dd7203aed695e1cb1242b8ada2a931b
Reviewed-on: https://chromium-review.googlesource.com/816035Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530566}

Disabling smoothness.gpu_rasterization.top_25_smooth/
http://www.youtube.com as the test is quite flakey

Bug: 803869
Change-Id: I128b6bc6ad680bcdcc3495a32f490c32328e76bf
Reviewed-on: https://chromium-review.googlesource.com/876493
Commit-Queue: Ashley Enstad <ashleymarie@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#530565}

* Correctly focuses SSID or passphrase field
* Correctly enables 'connect' button as soon as valid input is typed
* Defaults 'Connect' button to disabled to avoid initial blink
* Sizes the dialog correctly when just a passphrase is required
* Uses the new dialogs correctly from the 'Network not available'
  screen in login/oobe.

Bug: 795718,797891
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie81d3c16db56d8a0c020da3e001f9118b638974b
Reviewed-on: https://chromium-review.googlesource.com/869116
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530564}

This reverts commit b2ca5e69.

Reason for revert: findit identified it as a cause of test flakiness

Original change's description:
> Update download notification browser tests.
> 
> Use NotificationDisplayService instead of MessageCenter in tests.
> 
> Bug: 783018
> Change-Id: I2bc849e90f5f899144d015c83755f8eade62e185
> Reviewed-on: https://chromium-review.googlesource.com/867291
> Commit-Queue: Evan Stade <estade@chromium.org>
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#530411}

TBR=dtrainor@chromium.org,estade@chromium.org

Change-Id: Id0df60959dde79702423141bf57fbfd795b65053
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 783018
Reviewed-on: https://chromium-review.googlesource.com/876562Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530563}

The existing in-progress implementation of ozone/drm over mojo IPC
assumed that the ozone host would use a mojo ServiceManager provided
at initialization that it could use to launch and connect to the DRM
and cursor services. However, when used in a src/content context (such
as would be the case in Chrome), there is no service manager available
at ozone initialization time. Instead, content::GpuProcessHost
notifies the ozone host later from the browser I/O thread when the GPU
process containing the DRM and cursor services is running.

This CL refactors the ozone/drm/mojo implementation to isolate the
acquisition of mojo pipes into a separate class that supports both
styles of pipe acquistion: either by the use of a ServiceManager or
via an asynchronously injected dependency on content.

This CL also restructures the launch of the DRM thread itself so that
it can be deferred until after the GPU sandbox is initialized in a way
that does not depend on the use of legacy IPC message filters.

BUG=620927

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Icfb2261326cd1d5d6e2769d9801c02a744e1102a
Reviewed-on: https://chromium-review.googlesource.com/861749
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530562}

- Add the necessary calls to SetUp-/CleanUpEnvironment.
- Also be more explicit to distinguish finder_ vs browser_options

Bug: 801578
Change-Id: I689bf0fdfb1bdf5fe1b1b8e9e3ca8403edbce6bf
Reviewed-on: https://chromium-review.googlesource.com/876426
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#530561}

Although |delegate_| is a mandatory parameter of TrayBubbleView,
it became possible to be null during the life time of TrayBubbleView
with the introduction of ResetDelegate.
As a result, sometimes MouseMovedOutOfHost is called after ResetDelegate
is called.
MouseMovedOutOfHost itself is called very rarely. See the description in
https://crrev.com/23200007 and the comment in the function.

BUG=788991

Change-Id: Id595941884cf7b2c5064dfd7e07890751a2dbabe
Reviewed-on: https://chromium-review.googlesource.com/875570Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530560}

Check for duplicate sync ids within sessions native data. If any is
encountered, then clear those sync ids, and let them be re-assigned.
This effectively destroys the link a placeholder has with sync data,
if duplicates are present. This may cause a partial regression for
clients in existing broken states, affected synced tabs will
subsequently disappear from other devices view. But it will also clean
up any broken state before a race condition was removed.

Bug: 639009
Change-Id: I5f1372107167ae5c5d7b598c982830bd51bb3d26
Reviewed-on: https://chromium-review.googlesource.com/862394
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530559}

This reverts commit 4c196784.

Reason for revert: Failed downstream on the x64 Android bots. 'Unused resources'.

Original change's description:
> Reland "VR: Add dynamically-toggled icon in Daydream Home"
> 
> This reverts commit 0c357720.
> 
> Original change's description:
> > Revert "VR: Add dynamically-toggled icon in Daydream Home"
> > 
> > This reverts commit 559f95d6.
> > 
> > Reason for revert: Fails APK validation because of 'missing Daydream icons'.
> > 
> > Original change's description:
> > > VR: Add dynamically-toggled icon in Daydream Home
> > > 
> > > This CL adds the ability to show the Chrome icon in Daydream Home, which
> > > launches Chrome in VR mode, behind a feature flag.
> > > 
> > > We're able to do this by enabling/disabling the component that adds the
> > > icon at runtime.
> > > 
> > > Bug: 802080
> > > Change-Id: I878202c110d2a7bd092173457de73ce1578d2ff6
> > > Reviewed-on: https://chromium-review.googlesource.com/867512
> > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> > > Reviewed-by: Yash Malik <ymalik@chromium.org>
> > > Reviewed-by: David Trainor <dtrainor@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#529842}
> > 
> > TBR=mthiesse@chromium.org,dtrainor@chromium.org,ymalik@chromium.org
> > 
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> > 
> > Bug: 802080
> > Change-Id: I9a01dc2dcfaa0e5de07ccc16671721d61beb6feb
> > Reviewed-on: https://chromium-review.googlesource.com/874781
> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#530252}
> 
> TBR=mthiesse@chromium.org,dtrainor@chromium.org,ymalik@chromium.org
> 
> Change-Id: Id5738ec9f9e67ef52d57d99af33e450b0af6e0ad
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 802080
> Reviewed-on: https://chromium-review.googlesource.com/875070
> Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#530531}

TBR=mthiesse@chromium.org,dtrainor@chromium.org,ymalik@chromium.org

Change-Id: Idcd8f40b0f49c9959619e5cbf6ed0dcee6b615d2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 802080
Reviewed-on: https://chromium-review.googlesource.com/876263Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530558}

Currently GaiaScreenHandler talks to backend via
SigninScreenHandlerDelegate. In the views based login screen,
SigninScreenHandlerDelegate will not be initialized, so the connection
layer is changed to LoginDisplayHost.

Bug: 792579
Change-Id: I781bcc1cae28b12bfabf33ed5e216bff591ebb35
Reviewed-on: https://chromium-review.googlesource.com/875170Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530557}

Ensure that the ExtensionTestMessageListener in the OpenPopupViaAPI()
call is only instantiated if the user specifies via the method's param.

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1a6e555161e208ce0db5de23ab868d1c25697bd4
Reviewed-on: https://chromium-review.googlesource.com/874431Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: catmullings <catmullings@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530556}

NOTRY=true

Bug: 801334
Change-Id: I1b512bb392791e150bc045506bdf6264ea976a41
Reviewed-on: https://chromium-review.googlesource.com/876500Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530555}

Disabling v8.browsing_mobile/browse:social:tumblr_infinite_scroll
on Android One Perf due to consistent flakiness

NOTRY=true

Bug: 803870
Change-Id: I3f6882b697d62dc9c8f0c5d07356fb1e65aefe90
Reviewed-on: https://chromium-review.googlesource.com/876503
Commit-Queue: Ashley Enstad <ashleymarie@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#530554}

This is a CL to solve the issue raised by 789959. The root of the
problem is that Android ashmem regions have a very different security
model than regular Posix shared memory regions:

- On Posix: the region doesn't have any associated read/write/exec
  protection mask, mmap() uses the file descriptor's access mode
  to determine if writable mappings are allowed. E.g. if the
  descriptor is opened with O_RDONLY, then an mmap() with PROT_WRITE
  will fail with an EACCES error.

- On Android: the Ashmem region has its own read/write/exec protection
  mask, and the file descriptor's access mode is ignored at mmap()
  time. Also, it is possible to change the region's protection mask
  through an ioctl(), that only allows dropping privileges. In other
  words, once a region has been turned read-only, it cannot be turned
  back to read-write, and any future mmap() attempts are affected
  (existing mappings that are read-write survive though).

- Also, there is no reliable way in Posix or Android to duplicate a
  file descriptor as read-only (even when /dev/fd/ or /proc/self/fd/
  are available), and no way to re-open an existing Ashmem region
  as read-only. This means that all Ashmem file descriptors have
  read-write access anyway.

Chromium code assumes that it is possible to create read-only
descriptors to shared memory region, then send them through IPC
to another process. On Android, this cannot work because all
descriptors are read-write anyway.

This CL works as follows to route around the issue, in the least
invasive possible way:

- On Android, add a "read_only_" flag to each SharedMemoryHandle
  instance, indicating that it is intended to only allow read-only
  mappings. This can be set with SetReadOnly() and tested with
  IsReadOnly(). Also ensure the flag is properly maintained
  when copying the handle instance, or sending it through IPC.

- Add a method called SetRegionReadOnly() to the
  Android version of the SharedMemoryHandle. This drops the write
  access bits from the _region_, making all future mappings _not_
  writable.

- Ensure that SetRegionReadOnly() is called at Map() time, when
  needed.

- Ensure that the region is sealed read-only when it is sent
  through IPC or Mojo through a read-only handle on Android.

- Modify the FieldTrial code to set the region read-only as soon
  as possible. This happens after the writable mapping has been
  created, and used by the PersistentMemoryAllocator, so it only
  affects processes that receive the region's file descriptor
  (i.e. sandboxed processes on Android).

  Also add a unit-test to verify that this works properly.

- Modify the user script loader to set the region read-only
  as soon as it has been populated. The code clearly throws
  away the original writable mapping before returning a read-only
  SharedMemory instance, so this should not create any problem.

  NOTE: This code is likely not used on Android yet, but better
  be safe than sorry.

- Fix content browser sensor-related tests, which used to map
  a shared memory region writable _after_ a read-only descriptor
  to it had been sent through Mojo to clients.

- Fix DeviceSensorHost implementation to ensure that its
  StartPolling() method always sends read-only file descriptors
  to the callback argument (crbug.com/793519, not Android-specific).

Also:

- Add ashmem_get_prot_region() to third_party/ashmem/ashmem.h,
  necessary to retrieve a region's current protection mask.
  This shall probably go into another CL.

- Fix a bug where Ashmem regions were blindy created with PROT_EXEC
  permission, even if the CreateOptions::executable bit was false.

- Add a unit-test to verify that anonymous region that are not
  created with CreateOptions::executable set to true cannot be
  mapped with PROT_EXEC. This test is Android-specific. It turns
  out that it fails on Linux (because /dev/shm is mounted on a
  tmpfs partition without the 'noexe' option, and there is no
  other way provided by the system to restrict PROT_EXEC-inducing
  mprotect() calls for these).

Bug: 789959,793519
Change-Id: Ibb02eddedd84f95462d7f8b94d3f2a100b983661
Reviewed-on: https://chromium-review.googlesource.com/805238
Commit-Queue: David Turner <digit@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530553}

This is pre-work for getting UiDevTools working on Mac.

There's a few places that still won't compile on Mac as-is, and a few
where there was no getting around USE_AURA ifdefs, but all of that
will get isolated out into Aura-only paths when the Mac implementation
is added.

Bug: 769352
Change-Id: I191409f522f8470f7f94146dd708fcb27bb5e8f0
Reviewed-on: https://chromium-review.googlesource.com/871850Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530552}

This patch tries to reduce the number of runtime crashes that
happen on certain x86 devices running ARM binaries through
a machine code translation engine like Intel's Houdini.
See the corresponding bug entry for full details.

This is done by providing a new API (crazy_set_debugger_support())
that allows the legacy linker to disable GDB support for release
builds.

A new GN configuration variable [1] is also provided to generate
debuggable release builds, if needed.

[1] chromium_android_linker_enable_release_debugging

BUG=796938
R=rmcilroy@chromium.org, primiano@chromium.org, pasko@chromium.org

Change-Id: I01d6bf5674ae0334f80811b3a13e3622e867a9ad
Reviewed-on: https://chromium-review.googlesource.com/875966Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530551}

Currently, the quality of the favicons retrieved for the first time
when reading partner bookmarks through Sole is quite low. This fix adds
a higher desired resolution to the requests for favicons and greatly
improves their appearance.

Bug: 801363
Change-Id: I27c83b6f43352327895e6d27849f299044f1701a
Reviewed-on: https://chromium-review.googlesource.com/862728Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530550}

The DeviceMotionEvent spec:
https://w3c.github.io/deviceorientation/spec-source-orientation.html#devicemotion
says the DeviceMotionEvent's DeviceRotationRate "must be expressed in
degrees per second (deg/s)". This CL changes the implementation to be
the same as the spec.

Related post and discussion at blink-dev:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ple1o7bFqEs

Bug: 541607
Change-Id: I8cd5a8fadeebf49deb1126685d267495da7b4c3c
Reviewed-on: https://chromium-review.googlesource.com/658330
Commit-Queue: Jun Cai <juncai@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530549}

This CL updates the TODO numbers of the Adaptive Toolbar from a generic
bug to bugs number specific to the place where the TODO is.
It also updates the omnibox state when the toolbar is updated by BVC.

Bug: 799438
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I878ff2d1f1a59f460f953b3c5a5c26ce39bc2b7b
Reviewed-on: https://chromium-review.googlesource.com/873130
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530548}

An "empty" size is always passed to AddClient, so the argument can be
removed. This also allows simplifying the caching logic (since the
size is always empty, which won't create a cache entry.)

Also change the find()+insert() sequence for |clients_| to use
only insert() instead, saving a hash lookup. Simplify the SizeAndCount
constructor since it never needs any non-zero initialization.

Bug: 803224
Change-Id: I7efc7a130e8e93c1e2680116c429cb93e57d2d3f
Reviewed-on: https://chromium-review.googlesource.com/876086Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#530547}

https://chromium.googlesource.com/catapult.git/+log/51d9354bb0d4..3318544c51d4

$ git log 51d9354bb..3318544c5 --date=short --no-merges --format='%ad %ae %s'
2018-01-19 perezju [Telemetry] Migrate browser_test_case to new API

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ibc61a4afec896919d94905ce0066809cb55a9f6e
Reviewed-on: https://chromium-review.googlesource.com/875917
Commit-Queue: <catapult-deps-roller@chromium.org>
Reviewed-by: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530546}

This reverts commit d875cacb.

Reason for revert:  Probably causing other crashing (see bug)

Original change's description:
> Android: Simplify DeviceFormFactor.isTablet()
> 
> Rather than provide a setIsTablet(), just move the resource from
> chrome->ui and have DeviceFormFactor use it directly.
> 
> Change-Id: Ie867fc604aa223a6c4896124e3dfe80c09675593
> Reviewed-on: https://chromium-review.googlesource.com/769348
> Reviewed-by: Theresa <twellington@chromium.org>
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Commit-Queue: agrieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#518274}

TBR=yfriedman@chromium.org,tedchoc@chromium.org,twellington@chromium.org,agrieve@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 794551
Change-Id: Iec913f6b1d36f188326cb0f0b8a52138c8a3b456
Reviewed-on: https://chromium-review.googlesource.com/876262Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530545}

This CL is in preparation for device change event migration to blink.
This change will allow MediaDevicesManager to translate enumeration
results before sending them to the renderers.

Bug: 793297
Change-Id: I30f3533efb7c7eac8b7db5ab97fb6b155b28d99e
Reviewed-on: https://chromium-review.googlesource.com/869638
Commit-Queue: Chandan Padhi <c.padhi@samsung.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530544}

The existing WiredDisplayPresentationReceiver implementation works on
Mac, but only with mac_views_browser=1.  This is expected to be enabled
by default soon enough that we aren't pursuing a separate Cocoa
implementation.

This change adds a function to media_router_feature.h so
PresentationReceiverWindow::Create can still be linked on Mac, in case
mac_views_browser is enabled, but tells WiredDisplayMediaRouteProvider
not to call it when running under Cocoa.  This also allows more
WiredDisplayMediaRouteProvider test paths to be enabled for Mac.

Bug: 777654
Change-Id: Ia9a3406c6865165023c10da4588988efe072d9d1
Reviewed-on: https://chromium-review.googlesource.com/864488Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530543}

This removes the use of the deprecated method
DictionaryValue::SetString in WebUIDataSourceImpl.

It also fixes an unintended side effect where

WebUIDataSourceImpl::Add{Localized}String("foo.bar", value)
would create a nested 'foo' dictionary in the JS string
list, causing "foo.bar" to fail to localize when using
loadTimeData.getString('foo.bar').

Bug: None
Change-Id: I1da5f7da168acb681b93bbacccd361bea07800a7
Reviewed-on: https://chromium-review.googlesource.com/875158Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530542}

Pending entry should only be discarded for new download manager or for
passkit download. Old download manager is fullscreen and omnibox has to
show download URL, instead of web view URL.

Bug: 802880
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie2d00d9b29e91a315d846262da2298e23e57ac53
Reviewed-on: https://chromium-review.googlesource.com/871041Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530541}

Bug: 802172
Change-Id: I5841fe34ee7226611a5ad2c66cf3c971fd40c670
Reviewed-on: https://chromium-review.googlesource.com/873977
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530540}