GitLab

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/8228009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110861 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110860 0039d316-1c4b-4281-b951-d872f2087c98

Move some arrow anchor/location logic; etc.
Expose non-const |chevron|, and |location_entry_view|.
Add a setter for BubbleDelegateView's |anchor_view|.

BUG=98323
TEST=ExtensionInstalledBubbles function as before.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110824

Review URL: http://codereview.chromium.org/8590047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110858 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rdsmith
BUG=104886
TEST=None
Review URL: http://codereview.chromium.org/8470011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110857 0039d316-1c4b-4281-b951-d872f2087c98

The goal was to avoid alloc/free during the thread
teardown callback, and this CL provides a very simple
and clear implementation.

r=rtenneti
BUG=104696
Review URL: http://codereview.chromium.org/8597017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110856 0039d316-1c4b-4281-b951-d872f2087c98

I'm reverting because this test is consistently failing on all bots. Remember
that it's the committer's responsibility to ensure that his change lands
safely.

======================================================================
FAIL: special_tabs.SpecialTabsTest.testAboutAppCacheTab: "Test App Cache tab to confirm about page populates caches."
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/mnt/data/b/build/slave/Linux__deb_/build/src/chrome/test/functional/special_tabs.py", line 317, in testAboutAppCacheTab
    self._VerifyAppCacheInternals()
  File "/mnt/data/b/build/slave/Linux__deb_/build/src/chrome/test/functional/special_tabs.py", line 207, in _VerifyAppCacheInternals
    [])
  File "/mnt/data/b/build/slave/Linux__deb_/build/src/chrome/test/functional/test_utils.py", line 232, in StringContentCheck
    msg='"%s" missing from content.' % s)
AssertionError: "Manifest" missing from content.

BUG=102517
TEST=none
Review URL: http://codereview.chromium.org/8533018

TBR=dyu@chromium.org
Review URL: http://codereview.chromium.org/8473011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110855 0039d316-1c4b-4281-b951-d872f2087c98

is throttled.


BUG=98498
TEST=*ExtensionSettings*


Review URL: http://codereview.chromium.org/8491033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110854 0039d316-1c4b-4281-b951-d872f2087c98

This is instead of http://codereview.chromium.org/8566054/ and should allow the refactoring code to proceed.

BUG=chromium:103427
TEST=See issue


Review URL: http://codereview.chromium.org/8550003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110853 0039d316-1c4b-4281-b951-d872f2087c98

local quota) by adding a WriteOptions flag to Set and using FORCE when
writing from sync.

Otherwise sync will effectively be permanently disabled when the settings are
over quota.


BUG=103514
TEST=*ExtensionSetting* (unit_tests, browser_tests)


Review URL: http://codereview.chromium.org/8587025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110852 0039d316-1c4b-4281-b951-d872f2087c98

timezone change.

BUG=104667
TEST=none
R=ben@chromium.org,stevenjb@chromium.org
TBR=ben@chromium.org,stevenjb@chromium.org


Review URL: http://codereview.chromium.org/8605006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110851 0039d316-1c4b-4281-b951-d872f2087c98

wrong InputMethodDescriptor. In this test case we end up in
MaybeChangeCurrentKeyboardLayout with value.string_list_value.size()
== 5 so that we don't  reset current_input_method_ and instead pass in
current_input_method_, which is empty. Another possible fix is to
change the if to be !value.string_list_value.empty(). Not sure if
that's the right fix though.

BUG=104674
TEST=none
R=yusukes@chromium.org


Review URL: http://codereview.chromium.org/8561025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110850 0039d316-1c4b-4281-b951-d872f2087c98

The new tab button mouse enter is handled in the tab strip controller to ensure
an accurate hover indication (the button is an odd shape).

XIB Changes: Update the new tab button's cell class to the new NewTabButtonCell.

BUG=104326
TEST=Hover over the new tab button, it should light up. Hover slightly to the right of it, it shouldn't light up.


Review URL: http://codereview.chromium.org/8566036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110849 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8536054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110848 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=trybots


Review URL: http://codereview.chromium.org/8604010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110847 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98716
Review URL: http://codereview.chromium.org/8470006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110846 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110845 0039d316-1c4b-4281-b951-d872f2087c98

This fixes time() on Linux 3.1.

BUG=104084
TEST=trybots


Review URL: http://codereview.chromium.org/8536053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110844 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104872
TEST=none
TBR=shess

Review URL: http://codereview.chromium.org/8500011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110843 0039d316-1c4b-4281-b951-d872f2087c98

These will be used to resume hash generation when a download is interrupted and later resumed.

BUG=None.
TEST=SecureHashTest.TestSerialization


Review URL: http://codereview.chromium.org/8588057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110842 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=trybot runs


Review URL: http://codereview.chromium.org/8570021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110841 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110838 0039d316-1c4b-4281-b951-d872f2087c98

ObserverListThreadSafe was overkill since there was only two threads
involved, and only one observer.

Add MessageLoop member variables to various test classes that need it
(ObserverListThreadSafe had a hack that made it unnecessary before.)

BUG=103732
TEST=Start with a clean profile and set up sync.  about:profiler shouldn't
show ObserverListThreadSafe::Notify calls with sync threads anymore.


Review URL: http://codereview.chromium.org/8586014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110836 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104190, 103535
TEST=Fixes right clicking on Fedora per bug.


Review URL: http://codereview.chromium.org/8561006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110835 0039d316-1c4b-4281-b951-d872f2087c98

- Adding button and checkbox css to history and downloads.
- Tweaked checkbox styles for history.

R=estade@chromium.org,csilv@chromium.org
BUG=None
TEST=Look at checkboxes and buttons on history/downloads without feeling
nauseous.


Review URL: http://codereview.chromium.org/8598017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110834 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8590046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110833 0039d316-1c4b-4281-b951-d872f2087c98

Now that we are doing a hard-cut-over to Aura, remove a bunch of *Views based classes that are obsoleted by Aura. Also remove a bunch of Wayland stuff, since any future Wayland integration is likely done as an implementation detail of Aura, not Views.

Specifically:

- views-desktop (classes and NativeWidgetView[s])
- NativeWidgetViews subclasses in Chrome (Constrained Windows, NTCVV, NTCCV, BrowserFrameViews et al).
- RWHVV, NWKEV
- NativeViewHostViews

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8598024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110832 0039d316-1c4b-4281-b951-d872f2087c98

Rebase ExtensionInstalledBubble on the new views bubble.

Move some arrow anchor/location logic; etc.
Expose non-const |chevron|, and |location_entry_view|.
Add a setter for BubbleDelegateView's |anchor_view|.

BUG=98323
TEST=ExtensionInstalledBubbles function as before.

Review URL: http://codereview.chromium.org/8590047

TBR=msw@chromium.org
Review URL: http://codereview.chromium.org/8473006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110831 0039d316-1c4b-4281-b951-d872f2087c98

Adding reduced version of sdk at 1387 to chrome tree.

BUG=None
TEST=None
R=noelallen@google.com

TBR

BUG=None
TBR=bradnelson@google.com

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110830 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

R=csilv@chromium.org

Review URL: http://codereview.chromium.org/8600007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110827 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110826 0039d316-1c4b-4281-b951-d872f2087c98

TBR=steveblock

Review URL: http://codereview.chromium.org/8566058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110825 0039d316-1c4b-4281-b951-d872f2087c98

Move some arrow anchor/location logic; etc.
Expose non-const |chevron|, and |location_entry_view|.
Add a setter for BubbleDelegateView's |anchor_view|.

BUG=98323
TEST=ExtensionInstalledBubbles function as before.

Review URL: http://codereview.chromium.org/8590047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110824 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
R=noelallen@google.com

TBR

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110822 0039d316-1c4b-4281-b951-d872f2087c98

Force navigation to non-numeric hostnames with ports (e.g. "abc:81").  This restores the pre-Chrome-15 behavior for these inputs.

BUG=103598
TEST=Typing "abcdefg:123" in the address bar should attempt to navigate, not search, by default.
Review URL: http://codereview.chromium.org/8510024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110821 0039d316-1c4b-4281-b951-d872f2087c98

Correctly score intranet URLs with typed_counts of 0 as UNVISITED_INTRANET if they are on known hostnames.

BUG=103470
TEST=On a clean profile, type an intranet host (e.g. "go/") and hit enter; then paste a different address on that host (e.g. "go/shuttlealerts") and hit enter; then in a new tab, paste that second address again and verify that the default action is to navigate rather than search.
Review URL: http://codereview.chromium.org/8497050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110820 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104790
TEST=Launch app, verify that upgrade is not detected inappropriately.
Review URL: http://codereview.chromium.org/8588066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110819 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8601002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110818 0039d316-1c4b-4281-b951-d872f2087c98

Added AwaitSyncCycleCompletion function to all tests after signing into sync to allow for full sync before proceeding.
Added Autofill sync test and Credit card sync test.
Changed test page from google.com to local web file using http server.

Disabled SyncIntegrationTest class in FULL suite due to History backend crash when logging into the sync server.

TEST=none
BUG=104227
Review URL: http://codereview.chromium.org/8510075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110816 0039d316-1c4b-4281-b951-d872f2087c98

While printing for print preview, we don't want to get the source frame
css information because it is not used.

BUG=none
TEST=printing works as expected after code changes.


Review URL: http://codereview.chromium.org/8566055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110815 0039d316-1c4b-4281-b951-d872f2087c98

Disables OutOfProcessPPAPITest.Crypto test on ASAN.

BUG=104832
TEST=ASAN bot runs green
TBR=dmichael@chromium.org, noelallen@chromium.org

Review URL: http://codereview.chromium.org/8550004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110814 0039d316-1c4b-4281-b951-d872f2087c98