GitLab

The size of dbus_bool_t and the size of bool are different.
The former is always 4, whereas the latter is usually 1.

The misuse of these types causes subtle memory issues
where some D-Bus functions read 4 bytes from a bool pointer,
or write 4 bytes to it. These functions take void* so
type checking didn't help.

TEST=tools/valgrind/valgrind.sh ninja/dbus_unittests
BUG=none


Review URL: http://codereview.chromium.org/7573001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95512 0039d316-1c4b-4281-b951-d872f2087c98

TEST=client works with seccomp sandbox.
BUG=None

Review URL: http://codereview.chromium.org/7575016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95511 0039d316-1c4b-4281-b951-d872f2087c98

Using the WebKit LayoutTests as a template, you can now specify slow or failing
tests to the header generating script.


Review URL: http://codereview.chromium.org/7563021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95510 0039d316-1c4b-4281-b951-d872f2087c98

BUG=90547,60149
TEST=net_unittests

Review URL: http://codereview.chromium.org/7492059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95509 0039d316-1c4b-4281-b951-d872f2087c98

1. Moves temporary color definition to gfx, declares some function as virtual for override,
removes const from some functions so that the override function is able to modify local data.
2. Cache cursor bounds and compute it (along with display_offset_) when necessary. 
3. Introduce SelectionModel (not derivable) for visual cursor positioning.

BUG=90426
TEST=--use-pure-views text editing
Review URL: http://codereview.chromium.org/7461102

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95508 0039d316-1c4b-4281-b951-d872f2087c98

omnibox.OmniboxTest.testContentHistory
omnibox.OmniboxTest.testOmniboxSearchHistory

BUG=91617
TEST=Run the above tests

Review URL: http://codereview.chromium.org/7564034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95507 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/7572029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95504 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95502 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=hamaji
Review URL: http://codereview.chromium.org/7511017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95501 0039d316-1c4b-4281-b951-d872f2087c98

platforms.

TBR=apatrick
Review URL: http://codereview.chromium.org/7575019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95499 0039d316-1c4b-4281-b951-d872f2087c98

See also http://crrev.com/95103

BUG=87632
TEST=Official build logs show Breakpad symbols being uploaded to crash server.

Review URL: http://codereview.chromium.org/7562002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95498 0039d316-1c4b-4281-b951-d872f2087c98

Test currently fails due to a NOTIMPLEMENTED() call from r93120. Marked as
FAILS until bug is fixed so the GPU bots are green.

BUG=89964
TEST=gpu_tests --gtest_filter=GpuPixelBrowserTest.WebGLTeapot


Review URL: http://codereview.chromium.org/7563024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95497 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7523051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95496 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7575015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95495 0039d316-1c4b-4281-b951-d872f2087c98

Previously, we were setting the wmclass properties differently depending on how closely the DE we were running in was conforming to the ICCM standard. Now we just do the right thing all the time.

BUG=20587
TEST=none


Review URL: http://codereview.chromium.org/7562022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95492 0039d316-1c4b-4281-b951-d872f2087c98

BUG=89733
TEST=None
TBR=jamescook@chromium.org

Review URL: http://codereview.chromium.org/7572030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95491 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:86890
TEST=Run the modified PyAuto tests on all platforms.


Review URL: http://codereview.chromium.org/7548024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95490 0039d316-1c4b-4281-b951-d872f2087c98

values instead of 32bit values.

On gzip compressed locales files, this saves 17k total.

Bump the cached theme pak version so the caches get rebuilt.

BUG=76285
TEST=Covered by unit tests and manually tested installing themes.

Review URL: http://codereview.chromium.org/7555003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95487 0039d316-1c4b-4281-b951-d872f2087c98

This addresses a potential corner case where we end up marking an already
existing private key as unextractable while importing a corresponding
certificate into a hardware (unextractable slot).

BUG=chromium-os:15838
TEST=Added a new unit test


Review URL: http://codereview.chromium.org/7466006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95486 0039d316-1c4b-4281-b951-d872f2087c98

The check here was a bad idea in the first place, I didn't think this through carefully enough.

BUG=chromium-os:18677
TEST=Run chrome, open vpn or 8021x connection dialog, quit; ensure chrome does not crash.

Review URL: http://codereview.chromium.org/7578010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95485 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91715
Review URL: http://codereview.chromium.org/7578008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95484 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91710
TBR=vangelis@chromium.org
Review URL: http://codereview.chromium.org/7566043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95483 0039d316-1c4b-4281-b951-d872f2087c98

Windows.

I committed with the wrong change description-- This has nothing to do will
fullscreen exit bubble, it has to do with data pak files).

Review URL: http://codereview.chromium.org/7549005

TBR=tony@chromium.org
Review URL: http://codereview.chromium.org/7575017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95482 0039d316-1c4b-4281-b951-d872f2087c98

Move all performance tests under chrome/test/perf.
This also gets rid of directories containing only 1-2 files.

BUG=90905
Review URL: http://codereview.chromium.org/7578004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95481 0039d316-1c4b-4281-b951-d872f2087c98

Windows.

BUG=30743
TEST=

Review URL: http://codereview.chromium.org/7549005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95480 0039d316-1c4b-4281-b951-d872f2087c98

With this change we save the expanded/collapsed state of the sync promo to preferences.

BUG=
TEST=Collapsed the promo and verified that it stayed collapsed on the next launch.


Review URL: http://codereview.chromium.org/7566026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95478 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

R=evan@chromium.org

Review URL: http://codereview.chromium.org/7574004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95477 0039d316-1c4b-4281-b951-d872f2087c98

Rename profile to user.

BUG=
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95434

Review URL: http://codereview.chromium.org/7566019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95476 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7511014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95475 0039d316-1c4b-4281-b951-d872f2087c98

TEST=ran tests
BUG=none
TBR=apatrick@chromum.org


Review URL: http://codereview.chromium.org/7575005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95474 0039d316-1c4b-4281-b951-d872f2087c98

On Windows the send buffer size of UDP socket has a much smaller value
than the PseudoTcp's send buffer size. This causes PseudoTcp to flood
the UDP socket and results in a EWOULDBLOCK, however the code doesn't
handle this properly but simply treat the packet as lost. This happens
very often and causes Windows host to be very janky.

BUG=91495
TEST=None

Review URL: http://codereview.chromium.org/7508015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95473 0039d316-1c4b-4281-b951-d872f2087c98

BUG=90887
TEST=Find a way to trigger a print preview generation failure, then reload the print preview tab.

Review URL: http://codereview.chromium.org/7577001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95471 0039d316-1c4b-4281-b951-d872f2087c98

Eventually, we need to remove all current instances of AllSources(). One by
one, they need to either changed to listen to a specific notification source,
or (in very few cases where we actually are listening for a global
notification) they need to work correctly in the presence of multiple profiles,
in which case they'll be turned to AllBrowserContextsAndSources().

This patch, in addition:
- Deletes more unused notifications.
- Changes a few AllSources() calls to listen to specific objects.

BUG=87457
TEST=none


Review URL: http://codereview.chromium.org/7548022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95469 0039d316-1c4b-4281-b951-d872f2087c98

BUG=76112
TEST=None

R=evan@chromium.org

Review URL: http://codereview.chromium.org/7461132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95467 0039d316-1c4b-4281-b951-d872f2087c98

BUG=4823
TEST=right-click an html page, save it, restart the browser. The item should continue to appear in the downloads history (ctrl-j).
Review URL: http://codereview.chromium.org/7277073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95466 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=order of buttons should be correct for profile management ui

Review URL: http://codereview.chromium.org/7554001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95464 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95463 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7564013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95462 0039d316-1c4b-4281-b951-d872f2087c98

BUG=87457
TEST=none


Review URL: http://codereview.chromium.org/7508035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95458 0039d316-1c4b-4281-b951-d872f2087c98

BUG=90774
TEST=When "Personal Options" page has error, click error link twice.


Review URL: http://codereview.chromium.org/7465098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95455 0039d316-1c4b-4281-b951-d872f2087c98