- 19 Dec, 2019 40 commits
-
-
Caleb Rouleau authored
It seems we are somehow hitting the overall 4000 second timeout, which prevents us from getting logs. Attempt to timeout earlier so that we get some logs. Bug: 1035590 Change-Id: I293d2772ccd2cc87b66b47c1954ecb802c8f0ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974705 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#726225}
-
Kent Tamura authored
The new behavior matches to Edge and Firefox. Bug: 908632 Change-Id: I0dbb861e93836284a0c474cc486650dab27dc7b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973333 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#726224}
-
Anand K. Mistry authored
There are two problems with trying to unmount sshfs if Crostini is not running: 1. The unmount will fail, resulting in distracting log spam 2. Unnecessary blocking of suspend, which increases time to suspend Bug: 1035686 Change-Id: I12e4724b77db55ebfa241f1fa765821861824c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974293 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#726223}
-
Zhenyao Mo authored
BUG=941163 TEST=bots R=kbr@chromium.org Change-Id: I3ea45662ac87730fb8166a59e4af76401fb6f49d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974623 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#726222}
-
Kent Tamura authored
The new behavior matches to Edge and Firefox. Bug: 625710 Change-Id: I27de8b769712062f548eb9d2274544d1ec0ff073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973435 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/61e3d1746f00..60e4a93e3e4d git log 61e3d1746f00..60e4a93e3e4d --date=short --first-parent --format='%ad %ae %s' 2019-12-18 fmayer@google.com Merge "Move symbolizer to src/profiling/symbolizer." Created with: gclient setdep -r src/third_party/perfetto@60e4a93e3e4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I729112a7c6fcea60f66e26d79ac328d7a8ddde5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974591Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726220}
-
Chase Phillips authored
Bug: 1033609 Change-Id: Ibe109738738e8610bb71024d9201627251df4eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869379 Commit-Queue: Chase Phillips <cmp@chromium.org> Auto-Submit: Chase Phillips <cmp@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#726219}
-
Brian Sheedy authored
Switches uses of PrintResult to PerfResultReporter in the base_perftests target and whitelists it for conversion to histograms before uploading to the perf dashboard. Bug: 923564 Change-Id: I0947dd98f842b072af7f7637db2191bb4a299992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968239Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#726218}
-
Khem Raj authored
time element is deprecated on new input_event structure in kernel's input.h see [1] This starts to fail the build on libcs( musl ) which has already implemented the 64bit time_t and enabled it for 32bit arches, compiler complains that it can not file structure member called 'time' in input_event struct This patch ensures that we use portable defines in a backward compatible way [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=152194fe9c3f BUG=1033635 Change-Id: Ifd9f8aa4e8844ac9b4d3598cbe4a6474fe2726f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972680Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#726217}
-
Navid Zolghadr authored
Change-Id: Ic84c334db97272e92449953113c3789f27d7c4cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971658Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#726216}
-
Julie Jeongeun Kim authored
This is a part of effort for using [RaisesException] when synchronously rejecting a promise. It uses [RaisesException] for //third_party/blink/renderer/modules/bluetooth. Bug: 1001114 Change-Id: Iddb31cbbf71637ae989ea634f78207dfd9289c43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971049 Commit-Queue: Julie Kim(OoO til Jan 01) <jkim@igalia.com> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#726215}
-
Demetrios Papadopoulos authored
This page is no longer used anywhere other than Chrome OS Settings. Bug: 1026455 Change-Id: I033b7d8c1936349802a8dafb092ab74bae36d452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973354 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#726214}
-
Fergal Daly authored
Currently on mac and win the callback is not run, leading to a situation where the browser process does not send an IPC to the renderer, leaving the renderer blocked on the dialog. This was making the bfcache tests in https://crrev.com/c/1955245 fail on mac and win. On linux, dialogs always behave if suppressed. Also fix a bug in the mac code where it attempts to store the callback inside both the helper and the ShellJavascriptDialog. Only the helper actually gets it. Bug: 1030133 Change-Id: I7fe66eb9950f9f51e9be833224a43ba1cb003a39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973517 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6037820448a9..a892219ced42 git log 6037820448a9..a892219ced42 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@a892219ced42 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I29270af60ee3581fc69488f4fb8f55a7617d924b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974608Reviewed-by:
-
George Steel authored
Move metrics from KeyframeEffect::Create() body to IDL [Measure] and merge the two keys into a new one with the proper name. This in preparation for changing it in the next CL. Split from crrev.com/c/1921343 Bug: 981894 Change-Id: I7f42597e507e1c4354804a907474aeb0be6bc840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966501 Commit-Queue: George Steel <gtsteel@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#726211}
-
kylechar authored
|needs_sync_tokens| was set false as a performance optimization when the display compositor and browser UI shared a command buffer. This never happens anymore outside of tests so it can be removed. Bug: 869250 Change-Id: If963d69323cb87638ae34cca08132b49e6abdd0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973966 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#726210}
-
Alexey Baskakov authored
This CL implements and enables BMO-launching of the Settings system web app from AppList and Shelf on ChromeOS. Work done to reuse existing functionality: - Extract ConvertDisplayModeToAppLaunchContainer util function. - Expose CreateWebApplicationWindow and NavigateWebApplicationWindow functions out of WebAppLaunchManager. Bug: 1034386 Change-Id: Ie9301e94237c020e0746b2a0b1686a21879ed2a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971040 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#726209}
-
Ken Rockot authored
Migrates some directories off of deprecated base::Bind, base::Callback, etc, and onto the newer APIs. Specifically this covers components/safe_browsing/ and the minimal set of necessary client updates. Fixed: 1007726 Change-Id: If8dacb296ded88cf07bf55193c1458b4962b2cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974993Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#726208}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=dalecurtis@chromium.org Bug: 1023677 Change-Id: I94c1a00eb137653946a3dd26d0afb24d838caa70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957561 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#726207}
-
Nate Chapin authored
This removes the need for custom pause/unpause logic for ScriptedAnimationController in Document. Also, construct ScriptedAnimationController in the Document constructor, rather than lazily. It will get initialized on the first frame, so we're not saving much by deferring its initialization. This simplifies a bunch of logic around its handling in Document, and guarantees that its lifetime will be predictable for leak detection. TBR=creis@chromium.org Bug: 1029822 Change-Id: Ia30db6b7dac25c834152ae546364d77ff089fca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970259 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#726206}
-
Alex Cooper authored
Refactor XRSessionOptions and XRRuntimeOptions to use an enum, XRSessionMode, where appropriate rather than a pair of bools. As the WebXr spec evolved, the mojom definitions evolved with it. Now that WebVr has been removed and the spec has been solidified, this refactors portions of the mojom to fit better and simplify the code. As a result, a blink-side enum was able to be replaced with this new mojom enum. Unfortunately, a device-side enum was not able to be removed, but it was able to be scoped to just the SessionMetricsHelper. Hopefully future cleanup will enable removal of this enum as well. A couple of changes are worth calling out specifically: Some slight behavior changes were added, which fit with the expectations of the code. Namely, some runtimes that only checked for "immersive", and not "environment_integration", now assert that the request is for "ImmersiveVr", which more closely reflects reality. XrRuntimeManager::GetRuntimeForOptions was also cleaned up from a more complicated set of if-blocks to a switch statement. Fixed: 1035205 Change-Id: I09f39d4a80f1454d5a9aa58fb785169ba5338510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973156Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#726205}
-
Lambros Lambrou authored
This CL reverts http://crrev.com/36980fe26e8d2e0ce2929e22d2e87ea3f88c02e5, to re-enable LocalHotkeyInputMonitorMac. It also adds back the dependency on google_toolbox_for_mac, needed for the code to build. Bug: 1035613 Change-Id: I6e83cc225ab3cbde9f6a1be78caf5afd6295db66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975036 Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#726204}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d94b7f19dbf6..979775099f35 Created with: gclient setdep -r src-internal@979775099f35 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1028270,chromium:1030991,chromium:992370 Tbr: jbudorick@google.com Change-Id: If4eecad3c93d840c65211fcc5ae93983ba92228d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974785Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726203}
-
Mitsuru Oshima authored
I think these code somehow survived when we removed special case for 1.25. Bug: None. Test: None Change-Id: Ie3c1df84a4ed28e3117bfef412cc3acf037ff931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974838Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#726202}
-
James Cook authored
With SplitSettingsSync the "Apps" toggle is controlled by OS sync settings and it isn't a registered UserSelectableType. Ensure PeopleHandler doesn't try to select non-registered types. See bug for repro steps. Fixed: 1035615 Test: added to unit_tests Change-Id: I63c2454de6f2e86705b89ce8e7407bd1d84c6216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974848 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#726201}
-
James Cook authored
This existed to support the pre-SplitSettings view of Android app info, but SplitSettings has been the default since M78. android_apps_subpage.js/html are still used and will be moved under //c/b/resources/settings/chromeos in a follow-up CL. Delete android_apps_page_test.js as well. The existing android_apps_subpage.js/html are still tested via the tests in //c/test/data/webui/settings/chromeos/apps_page_test.js I manually verified that OS and browser settings still load properly, both with and without the AppManagement flag enabled. Fixed: 1006152 Change-Id: Ia81b2e09822f45f8545949e7ea734b3d94c969f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974315Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#726200}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d04ef219ddbf..aa39e6f58369 git log d04ef219ddbf..aa39e6f58369 --date=short --first-parent --format='%ad %ae %s' 2019-12-18 dberris@chromium.org Dashboard: Do not assume that a path has a parent Created with: gclient setdep -r src/third_party/catapult@aa39e6f58369 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1033485 Tbr: sadrul@google.com Change-Id: Id80624224a2b5af1076110f25446d15f72f9f395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975010Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e82d88538072..4fd7fccd6db5 git log e82d88538072..4fd7fccd6db5 --date=short --first-parent --format='%ad %ae %s' 2019-12-18 chrisforbes@google.com Regres: Roll deqp forward to latest 1.1.6 Created with: gclient setdep -r src/third_party/swiftshader@4fd7fccd6db5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I338a5905f7df6d49bf35550a3466c49ecca09dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974783Reviewed-by:
-
Caleb Rouleau authored
This will make it clearer what the root cause of an error is. Bug: 1035590 Change-Id: I760ace1c4b420c3b751915528f7ff049f5af0571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974677 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
-
Mitsuru Oshima authored
* Consolidate wallpaper animation into cross fade animation. It is now handled in WallpaperWidgetController. * Make each classes' responsibility more clear. WallpaperView: Responsible for just drawing wallpaper WallpaperWidgetController: Responsible for applying effects and animation. WallpaperController/OverviewWallpaperController: make decision what property to set, when to apply animation. * This will fix 1035568. There are tests that checks animation, and not sure why it didn't catch the issue, but it should be able to catch now. * This also fixes 1030747 by using the display's bounds, not bounds in display_managed_info, which does not provide the correct bounds when the panel orientation is rotated like krane. It was causing 'center' effect. Bug: 1030747, 1035568 Test: Updated existing test to test more correctly. Test for 1030747 T.B.D. Change-Id: I0f24bbc8a4db9fad72ef9b97d907efcbb66ac57f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967741 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:Sammie Quon <sammiequon@chromium.org> Reviewed-by:
-
Charlie Hu authored
Wire everything instead of only url from navigation info to navigation params in TestRenderFrame::BeginNavigation. After fixing crbug.com/972089, frame policy is captured at BeginNavigation and the snapshot value is used in CommitNavigation. Previously, the value comes directly from frame owner element. TestRenderFrame::BeginNavigation previously only set url in navigation params which is used to commit navigation. This results in tests not able to get frame policy. Specifically ScriptContextTest.GetEffectiveDocumentURL failed when it is not supposed to because of this reason. Change-Id: I1e35620e6c9ad86438f3975901c85afc5c6a88a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968256Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#726195}
-
Adithya Srinivasan authored
Currently, after activation and adoption, both AX trees for the newly activated page and the portal have their parent_tree_id set to each other, which can lead to a stack overflow when trying to retrieve the root BrowserAccessibilityManager. This CL breaks this cycle by unsetting the parent_tree_id of the detached WebContents' AX tree. Bug: 1033999 Change-Id: Ibd0b6f4f9af28df2795574728800438a7ec5dd12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972234Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#726194}
-
Askar Aitzhan authored
Experiment: CloudPolicyOverFcm.gcl. Bug: 939039 Change-Id: I709bb13a4002952f8f3a29bb1536434b63c0fe58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964074 Commit-Queue: Askar Aitzhan <askaraitzhan@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#726193}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c3ebb9a4. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." fadf6027 "[css-pseudo] Recalculate viewport units in ::marker" 044ad8ad "[OT-PW] Make it work with OOP-R" 2ad15546 "Make interpolation-testcommon.js support composition" 9899425d "[css-layout-api] IntrinsicSizes Implementation" 7d838af7 "[scroll-to-text-fragment] Apply :target CSS pseudo-class to match." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I2c2c2f48ee43ea0c90b3bef4cb8a9549bf9dd1e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974001Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726192}
-
Marijn Kruisselbrink authored
And use that to fix test flakiness caused by the listener in NativeFileSystemDirectoryHandleImpl::GetEntries sometimes not being deleted on the right sequence. Bug: 1035115 Change-Id: I03f404db002e8deb6cad885ba189e48333676a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972774Reviewed-by:
-
Max Moroz authored
https://chromium-review.googlesource.com/c/chromium/src/+/1906472 has broken the ability to run arbitrary testcases without any expectations. This CL introduces an explicit option --no-expectations that disables expectation parsing and test results post-processing. This mode is useful for generating code coverage reports, as it may work with any arbitrary testcases (passed via --test-list=) and also should be running faster than the default mode, though likely not significantly faster, hence I did not measure that aspect. Bug: 957581 Change-Id: I3c91cb55ba0cad73fa6b39d386c1b37949332ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974699Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#726190}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f64e958e897a..c880346ba5d1 git log f64e958e897a..c880346ba5d1 --date=short --first-parent --format='%ad %ae %s' 2019-12-18 reed@google.com Detect when perspective is really affine, and update the matrix as we handoff 2019-12-18 mtklein@google.com Reland "roll clang_win" 2019-12-18 mtklein@google.com demote -fsanitize=pointer-overflow to warning 2019-12-18 herb@google.com Only checksum and query a valid descriptor 2019-12-18 bsalomon@google.com "fix" formatting of auto generated cpp from fp Created with: gclient setdep -r src/third_party/skia@c880346ba5d1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: Id9bb6bf1eb4c7bebc8dda0d7ea6cfc6557659024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974781Reviewed-by:
-
Simon Que authored
This reverts commit d2613d46. Reason for revert: Retrying after increasing and reconfiguring RBE workers. This CL will land if win_chromium_compile_dbg_ng remains stable over the course of a day in MTV. Original change's description: > Revert "infra: Migrate builders to Goma RBE (Win Week 4)" > > This reverts commit cde0fa7b. > > Reason for revert: large number of builds on win_chromium_compile_dbg_ng failing w/ goma issues, e.g. > > https://ci.chromium.org/p/chromium/builders/try/win_chromium_compile_dbg_ng/461710 > https://ci.chromium.org/p/chromium/builders/try/win_chromium_compile_dbg_ng/461518 > > Original change's description: > > infra: Migrate builders to Goma RBE (Win Week 4) > > > > CI: > > -win32-archive-rel > > -win32-archive-dbg > > -Libfuzzer Upload Windows ASan > > -Windows deterministic > > -Mojo Windows > > -win-celab-builder-rel > > -win-asan > > -Win 10 Fast Ring > > -win-annotator-rel > > -win-pixel-builder-rel > > -win32-arm64-rel > > -WebRTC Chromium Win Builder > > -WebRTC Chromium FYI Win Builder > > -WebRTC Chromium FYI Win Builder (dbg) > > -win-swangle-x86 > > -win-swangle-x64 > > -win-swangle-tot-angle-x86 > > -win-swangle-tot-angle-x64 > > -win-swangle-tot-swiftshader-x86 > > -win-swangle-tot-swiftshader-x64 > > > > Try: > > -win_archive > > -win_mojo > > -win-asan > > -win-annotator-rel > > -win-swangle-try-x86 > > -win-swangle-try-tot-angle-x86 > > -win-swangle-try-x64 > > -win-swangle-try-tot-swiftshader-x86 > > -win-swangle-try-tot-angle-x64 > > -win-swangle-try-tot-swiftshader-x64 > > -win-libfuzzer-asan-rel > > -win10-blink-rel > > -win7-blink-rel > > -win10_chromium_x64_rel_ng_exp > > -win-celab-try-rel > > > > Schedule of migration: > > https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 > > > > Bug: 950413 > > Change-Id: I476de2fe97d88f3b636b97b91457b0b61ffe30d1 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924184 > > Reviewed-by: Aaron Gable <agable@chromium.org> > > Commit-Queue: Simon Que <sque@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#724036} > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 950413 > No-Try: true > Change-Id: I1a8eab16c75972803d4867f172e4da77ef2f3c41 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967566 > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Auto-Submit: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#724696} TBR=sque@chromium.org,agable@chromium.org,bpastene@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 950413 Change-Id: I873e02a4ffc5e8d23c7cd17d9c0231d48226e0bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971630Reviewed-by:
Simon Que <sque@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#726188}
-
Rakesh Soma authored
login attempt. Bug: 993430 Change-Id: I2f632393463bfa530b98e3c604d8b368cfff0024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954539 Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#726187}
-
Brian White authored
Bug: 871934 Change-Id: I00dfc3b02b12159af95090c13e5aaab1b45364f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969984Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#726186}
-
