- 06 Nov, 2020 40 commits
-
-
Samuel Huang authored
Bug: 1040645 Change-Id: I5b53f8145f1d1d5c363995cef7653f882e7c351c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521052Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Samuel Huang <huangs@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#824691}
-
Jeffrey Kardatzke authored
This implements slice header parsing and the rest of the overall decode flow. It does not handle POCs, DPB, ref pic lists, etc. yet, those will be added next. BUG=chromium:1141237,b:153111783 TEST=media_unittests Change-Id: Ib0173316ff8b25db9222d791e9dc8660ec282dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518132 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#824690}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3476ca348bd0..612ded0654a0 2020-11-05 srisser@google.com Merge changes I3c4f10f7,I5b7ddc75 2020-11-05 capn@google.com Fix Android.bp build after SPIRV-Tools update If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I61277cc4495a9e9af2f4af15015edd1b48dc9880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522357Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824689}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/56ea854ec5e7..d30f01144708 2020-11-05 lexa.knyazev@gmail.com Metal: Early loop exit during attachments clear 2020-11-05 syoussefi@chromium.org Vulkan: Defer clears even if following command is scissored If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: Iedf09f5593ce22ea9c90ec8312ca0109d5e1430f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522359Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824688}
-
Liquan (Max) Gu authored
Changes: * Moved CPRService#mInvokedPaymentApp into PRService. * Refactored isInvokedInstrumentValidForPaymentMethodIdentifier() so as to be explicit about its dependency on mInvokedPaymentApp. Bug: 1144527 Change-Id: I605dc470b41dd191cd362986963022c0f39dbddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520097 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824687}
-
Tomasz Wiszkowski authored
This change introduces PageClassification for SearchActivity and brings back the SearchActivity suggestions. The unique ID allocated to Search Activity will help us clear up any inconsistencies in offered suggestions, address SA directly and eliminate the use of the INVALID_SPEC PageClassification (currently reported by SA). Bug: 1143557 Change-Id: I3f48074079a9046d7aea25af9f5f2dc1f84ba268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516970Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#824686}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I7c8cb3b7066c2fb984c5011e526f30e2b5a20468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522351Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824685}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I016112d7c72fda76754d6f5805d2734a082ece65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522360Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824684}
-
Daniel Hosseinian authored
Collapsing the sidebar does not trigger the thumbnail bar's intersection observer. Therefore, toggling annotation mode does not cause the thumbnails to regenerate to reflect the updated PDF contents. Hide the thumbnails to trigger the intersection observer when annotation mode is turned on. Bug: 1136319 Change-Id: I778be1b28f76354a9186abc64d5e471b2ae6cb62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460226 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#824683}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ac59b0e049f7..5689d6741bc4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iead9447eca583213ba5627191be71e8168bf5ff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521776Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824682}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d42713de7aa3..2b6b0f45ff05 2020-11-05 enrico.galli@intel.com Add support for Tint's HLSL writer as a Toggle 2020-11-05 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 77f7bb5b005d to 795bf4c71637 (10 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I19d761e101fd14c5993d49a6a89a6a99c80268de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522000Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824681}
-
Ilya Sherman authored
Weilun is sufficiently trained up for reviewing testing config changes. Will eventually remove this entry in favor of listing as a general metrics OWNER, but this is a stepping stone in the meantime. R=sweilun Bug: None Change-Id: If40902f38b8473b6a46eba6e08d2ed8088156838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522398 Auto-Submit: Ilya Sherman <isherman@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#824680}
-
Bettina Dea authored
Client side detection is currently enabled on Android but there was no check to prevent visual detection from being done and is causing crashes in PaintPreviewTracker on beta. Bug: 1146121 Change-Id: If37cd5abe52ebb25fa7fb7ae126cd934c6a74cf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521353 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#824679}
-
Akira Baruah authored
Adds a function to CastMetricsServiceDelegate that Cast embedders can override to set platform-specific limits for local metrics storage. Also cleans up changes from https://crrev.com/c/2505741 to use `constexpr` and multiples of 1024 for default values for consistency. Bug: b/172356230 Test: metrics_unittests Test: cast_metrics_unittest Change-Id: Ib920e4438baf56dff64bcca3f9bcabca77fd354e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518833Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Akira Baruah <akirabaruah@google.com> Cr-Commit-Position: refs/heads/master@{#824678}
-
Taylor Bergquist authored
Adds a mechanism for skipping the opacity check to Label and applies it to the tab title label. Bug: 1139395 Change-Id: I1c182b735964856be971d59af1c28ab29011d99c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518277 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#824677}
-
James Zern authored
with functions that can legitimately fail when under memory pressure the fuzzer should exit gracefully rather than abort(). + add some more error detail to output Bug: chromium:1140448 Change-Id: I1a8582a939e0a5b2b8631c95c0464658c99063e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521107Reviewed-by:
Urvang Joshi <urvang@chromium.org> Commit-Queue: James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#824676}
-
Charlene Yan authored
http/tests/devtools/sources/debugger-ui/debugger-inline-values.js TBR=smcgruer@chromium.org Bug: 1146221 Change-Id: Ic09d947b0e8c2474cab3c0742cb5f19c211186cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522408Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824675}
-
Bailey Berro authored
This changes adds the CpuPrimeSearch Routine to the SystemRoutineController interface. Bug: 1128204 Change-Id: I281b8438227889cff8ed8439c715efc2827df6cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466364 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#824674}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1604555639-2f2f2fa36ecdca58ddc4d326e800aa99e915018c.profdata to chrome-win32-master-1604588329-6f5ba33f1a6962e1b0406a8222a4664471a1f39d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4d76d357005672bbd9c287fc667be06846514573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522150Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824673}
-
Collin Baker authored
The original GetSlotIndexForTabModelIndex served two purposes: getting the slot for an existing tab, and getting the insertion index for a new slot. This splits it into separate methods with common logic remaining in a shared method. The logic had a bug when requesting the first tab of a group while tabs just before it are animating closed. This bug is fixed. To help debug the associated crash, CHECKs are added. Bug: 1138748 Change-Id: I6e0d797bb70e9aa1da813dbf1fecf228290e55b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515363 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#824672}
-
Toni Barzic authored
AppUninstallDialog::InitializeCheckbox gets the app URL domain, and changes the first domain character to upper-case, assuming that the domain is non-empty. This may not be case if the app URL is an IP address. BUG=1084451 Change-Id: I5c43ff22fa3474a1c0ff0bcf79afd53de9beb26e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521043Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#824671}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Iab9bae069e1badd18d6a17d48ac921a564e3094f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522292Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824670}
-
Yicheng Li authored
When clicked, the help button will open a help article in a new browser window, so that it's on top of the dialog but the user can return to the dialog. Bug: b:156258540, b:144861739 Change-Id: I1ff8f49e9926ed57f27f2eaca307d5180d574091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518442 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824669}
-
Ilya Sherman authored
* Histograms measuring frequencies should typically include context via some baseline event as a comparison point. * Clean up the docs around directly measuring what you want and around naming. R=mpearson@chromium.org Bug: None Change-Id: Id6250c37a2ec499f38ae148bc1daa1a3c451a10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462373 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Auto-Submit: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#824668}
-
Tommy Martino authored
Greatly improves robustness of fragment generation Bug: 1136043 Change-Id: Ic424fc2548bc773c049e973c967d0152489ff765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521104 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#824667}
-
Sinan Sahin authored
Tbr: majidvp Bug: 1146218 Change-Id: Ieef5a89bc717ab4814c4ddbdba8cd11b47ba4df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522400Reviewed-by:
Sinan Sahin <sinansahin@google.com> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#824666}
-
Peter Boström authored
Adds reference to chromium-chrome-browser-ui-views-reviews@google.com as a preference to individual reviewers. Bug: None Change-Id: I5bae9a9806315105ba389d651b78da303548cc06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522495 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#824665}
-
Charlene Yan authored
Change-Id: I7cef19d51a8760ecf3ecf9c37b826adb94bc890d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522410 Auto-Submit: Charlene Yan <cyan@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#824664}
-
Erik Chen authored
This provides EMEA time-zone coverage for lacros/crosapi changes. Change-Id: Ie987fb3aec72aeb30d43ba09631c1fd84b42b93d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521870Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#824663}
-
Chris Thompson authored
This changes the units from "seconds" to "ms", since the underlying histogram time functions log TimeDelta data in milliseconds. This doesn't affect the logged data, only how it displays on the dashboard, so we don' t need to create a new histogram for this and can just update the unit. Change-Id: I8df03c321e2c9f92aa0f47750715ab3e22ef234c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522331 Auto-Submit: Chris Thompson <cthomp@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Chris Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#824662}
-
Tom Anderson authored
This allows us to see which calls are blocking within the context of chrome://tracing. BUG=None R=sky Change-Id: I576657f4cba0f978c025202f0f10c7ac6bcc374c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522311 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#824661}
-
Tommy Li authored
Bug: 1069833 Change-Id: I8e2dee39bc3dd7b9ce75f900deb9d11fbc458358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519369Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#824660}
-
Roberto Moura authored
Create a plus sign button that sticks to right of the thumb strip. It has a plus sign and a transparency gradient and is shown when the plus sign cell is not visible. This is done so that the user can open a new tab even if they haven't scrolled to the end of the collection view. When the user scrolls the collection view or when the toolbars are shown, check whether the user has scrolled past the end of the scroll view and, if so, hide the plus sign button. Show it otherwise. Rename one of the LayoutSwitcherStates from "Full" to "Grid". Add the constats that specify the new thumb strip plus sign button's dimensions to the grid constants file. Add a |didChangeLastItemVisibility| method to the grid view controller delegate. Create a CGFloat property |fractionVisibleOflastItem| inside the grid view controller, which indicates the visibility fraction of the last item. Only call |didChangeLastItemVisibility| on the delegate if the value of |fractionVisibleOflastItem| changes. Bug: 1094335 Change-Id: I056d6d0ece4eb22f84e4904208bd0e83d9b93389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485167 Commit-Queue: Roberto Moura <mouraroberto@google.com> Auto-Submit: Roberto Moura <mouraroberto@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#824659}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I8c32c28d7a5519f5232a99b023b8667167d21ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521780Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824658}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5689d6741bc4..e3fee63a19d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9cb176a364d8ebcebd9486556e0cccfd98df631a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522118Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824657}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/ce0db01e081f..9abc1e30cfe5 2020-11-05 medinaandres@google.com [application_agent test] Updated use of protos If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1144985 Tbr: jophba@chromium.org Change-Id: If64cb8b9e9e6b16416819c23a739a6d3083e9f3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522354Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824656}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1604545021-6b268e7944932acdec58448c2452d297c1502b9f.profdata to chrome-win64-master-1604588329-37596c07bf301a8ab7d867a3b0140d934526b155.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0fbc8beaea6a7996fa752d9eaaf9d95e19402c6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521217Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824655}
-
kylechar authored
There are occasional crashes accessing an empty |overdraw_surface_recorder_|. Even if |show_overdraw_feedback| is true creation of the recorded can fail, so using that bool to guard access isn't correct. Check if the recorded exists before accessing it instead. Also unconditionally reset |nway_canvas_| since it can be created even if recorder creation fails. Bug: 1143631 Change-Id: Ie00eeb11d84eedd589f7d99e62bbb80ab3d16bc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521050 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#824654}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I155f31760ea0c25daaecbd5aff45847ca610fcd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522358Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824653}
-
Dominic Farolino authored
R=haraken@chromium.org, kouhei@chromium.org, nasko@chromium.org, talp@chromium.org Bug: N/A Change-Id: I2e9f819e501b57e4e2b2aa1de324ede3a039dd6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519216Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#824652}
-