- 24 Aug, 2018 40 commits
-
-
Giovanni Ortuño Urquidi authored
WebAppPolicyManager would like to skip shortcut creation because there is a separate policy to create them. So we add that option to AppInfo and plumb it all the way down to BookmarkAppHelper Bug: 876175 Change-Id: I09f460efe7c3809856bde77ebe4570de6ae8845e Reviewed-on: https://chromium-review.googlesource.com/1186220 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#585788}
-
Pavol Marko authored
Bug: none Change-Id: Iee909eb8c049aa69cb94d41b9170be0dc0272983 Reviewed-on: https://chromium-review.googlesource.com/1115223 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#585787}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b44922e7..8f582e98 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib6f6fc9d34bf7a057a52fce6e7d38602e0a99148 Reviewed-on: https://chromium-review.googlesource.com/1188032Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585786}
-
Giovanni Ortuño Urquidi authored
Changes TestBookmarkAppInstallationTask in pending_bookmark_app_manager_unittest.cc to notify the test that Install is called. Then the test saves a copy of the used AppInfo to compare to the app info originally passed to PendingAppManager. This helps make sure AppInfo is correctly plumbed from PendingAppManager up until BookmarkAppInstallationTask which will use it to install the app. Bug: 876173 Change-Id: Iac87fc6e941f1da239717b306f1be44b18704320 Reviewed-on: https://chromium-review.googlesource.com/1186213 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
Some actions (currently "New Incognito Tab" and "Recent Tabs") open as page in the current tab. Keyboards would be implicitly dismissed by Android but an open Accessory closes only when the page changes. This causes the activity to update its bounds too late and leave a patch on the newly renderd page. Therefore, this CL causes all accessory elements to be dismissed once any action is selected. Bug: 877029 Change-Id: I92a3174c7c7ffcb7e94e3b39b3a26b0eb7a4f1f3 Reviewed-on: https://chromium-review.googlesource.com/1188303Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#585784}
-
Hayato Ito authored
BUG=877361 TBR=bokan@chromium.org Change-Id: Id1bd59c7e430c0c65eeab1a4a9b25d39aa0de9ef Reviewed-on: https://chromium-review.googlesource.com/1188008Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#585783}
-
Robert Liao authored
This reverts commit 934c869c. Reason for revert: The Light variant will no longer be used in the Start Menu tile. Original change's description: > Include/use light variants of the Start Menu tile in the installer. > > BUG=722573 > > Change-Id: I117497dd31d6270e2284ee54c59a142d620128ab > Reviewed-on: https://chromium-review.googlesource.com/1016241 > Commit-Queue: Greg Thompson <grt@chromium.org> > Reviewed-by: Scott Graham <scottmg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551856} TBR=scottmg@chromium.org,grt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 722573 Change-Id: I57d96212235b86298ed06558074d0c6985d66ea8 Reviewed-on: https://chromium-review.googlesource.com/1187782Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#585782}
-
Hayato Ito authored
This reverts commit 42ad79bb. Reason for revert: [chromium sheriff] A culprit of test failures: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28724 single_process_mash_browser_tests Run on OS: 'Ubuntu-14.04' Max shard duration: 0:03:53.214620 (shard #3) Min shard duration: 0:01:18.857780 (shard #0) failures: LoginPromptBrowserTest.LoginPromptForXHRWithoutCredentialsCancelled LoginPromptBrowserTest.TestTwoAuths LoginPromptBrowserTest.ShowCorrectUrlForCrossOriginMainFrameRedirects LoginPromptBrowserTest.CancelRedundantAuths LoginPromptBrowserTest.CancelLoginInterstitialOnRedirect LoginPromptBrowserTest.ShouldReplaceExistingInterstitialWhenNavigated LoginUtilsTest.MashLogin LoginPromptBrowserTest.IncorrectConfirmation LoginPromptBrowserTest.TestBasicAuth LoginPromptBrowserTest.TestCancelAuth_Manual LoginPromptBrowserTest.NoLoginPromptForXHRWithBadCredentials LoginPromptBrowserTest.SupplyRedundantAuths LoginPromptBrowserTest.SupplyRedundantAuthsMultiProfile LoginPromptBrowserTest.LoginPromptForXHRWithoutCredentials LoginPromptBrowserTest.TestDigestAuth LoginPromptBrowserTest.AllowCrossdomainPromptForSubframes LoginPromptBrowserTest.ShouldNotProceedExistingInterstitial LoginPromptBrowserTest.TestCancelAuth_OnBack LoginPromptBrowserTest.TestCancelAuth_OnForward LoginPromptBrowserTest.BlockCrossdomainPromptForSubresources LoginPromptBrowserTest.TestCancelAuth_OnNavigation LoginPromptBrowserTest.ShowCorrectUrlForCrossOriginMainFrameRequests Original change's description: > Add tests for single process mash > > Moves plain Mash tests to FYI waterfall, while retaining a login test on the > main waterfall as a sanity check. > > Bug: 874090 > Change-Id: I86c60344610c2a4f99b35f9116c5366771a16c64 > Reviewed-on: https://chromium-review.googlesource.com/1175222 > Commit-Queue: Ryan Cui <rcui@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585665} TBR=jamescook@chromium.org,sky@chromium.org,rcui@chromium.org Change-Id: Ib9b9258b47e766d43ac7f3dc6b3c65aacf1230f4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 874090 Reviewed-on: https://chromium-review.googlesource.com/1188165Reviewed-by:
-
Thomas Tangl authored
Screenshot before: https://drive.google.com/file/d/1docQTG83IMfNalyaJn8VOZ_bWIbMFq0J/view?usp=sharing Screenshot after: https://drive.google.com/file/d/1u6gCMPVEqsLy9fkuxhqGlrqpBYQzSmj_/view?usp=sharing Bug: 861649 Change-Id: Iecef069e5fe5007711c0b8b7191e9c3534c367f6 Reviewed-on: https://chromium-review.googlesource.com/1186723 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#585780}
-
Olivier Robin authored
Also clear frames on navigation as it is needed for the DCHECK to pass. Bug: 851636 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia154d52a338018b83967199ced25f9987d65242a Reviewed-on: https://chromium-review.googlesource.com/1184720 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#585779}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/de2476bcaacf..199b69092bef git log de2476bcaacf..199b69092bef --date=short --no-merges --format='%ad %ae %s' 2018-08-23 hjd@google.com traced_probes: Push cpu first in FtraceEventBundle Created with: gclient setdep -r src/third_party/perfetto@199b69092bef The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:113091178 TBR=perfetto-bugs@google.com Change-Id: Idb61e06fdac0514a4e41a23f3c03ac6afbdf3afa Reviewed-on: https://chromium-review.googlesource.com/1188103Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585778}
-
Kouhei Ueno authored
and remove obsolete comments. Bug: 803774 Change-Id: Ifa7c7c287fa11f312d62a3f9b18e79be7f47c572 Reviewed-on: https://chromium-review.googlesource.com/1187858Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#585777}
-
Mirko Bonadei authored
Bug: webrtc:9453 Change-Id: Ibdf5ca427ba85d0d5f5a8890b50a9c1d0b502a2c No-Try: True Reviewed-on: https://chromium-review.googlesource.com/1188134 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#585776}
-
Jérôme Lebel authored
Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I31063198861ed9431a65aba872c688ef9a8ac58d Reviewed-on: https://chromium-review.googlesource.com/1186738Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#585775}
-
JunHo Seo authored
This reverts commit cf158e84. Reason for revert: A converted test snav-media-elements.html becomes flaky Original change's description: > Snav: Convert some legacy js-tests to testharness - 2 > > Convert list: > snav-display-contents-crash > snav-div-in-anchor > snav-fully-aligned-horizontally > snav-fully-aligned-vertically > snav-hidden-focusable-element > snav-imagemap-area-not-focusable > snav-imagemap-area-without-image > snav-imagemap-overlapped-areas > snav-imagemap-simple > snav-media-elements > > Bug: 803086 > > Change-Id: Iebe20bba5868fec1e1c38f2a188346432c42d568 > Reviewed-on: https://chromium-review.googlesource.com/1184945 > Reviewed-by: Hugo Holgersson <hugoh@vewd.com> > Commit-Queue: JunHo Seo <junho0924.seo@lge.com> > Cr-Commit-Position: refs/heads/master@{#585694} TBR=kochi@chromium.org,szager@chromium.org,junho0924.seo@lge.com,hugoh@vewd.com Change-Id: Id2448339f31a707ed9f6c769cd71dec0d500d11c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 803086 Reviewed-on: https://chromium-review.googlesource.com/1188262Reviewed-by:
Hugo Holgersson <hugoh@vewd.com> Commit-Queue: JunHo Seo <junho0924.seo@lge.com> Cr-Commit-Position: refs/heads/master@{#585774}
-
Kamila authored
In Guest mode, Site Settings link found in the Page info bubble, leads to chrome://settings/, not to the site content settings, as the content settings are not visible. Changes: -Removed the Site Settings button from guest mode. Note: Enabling just the Site Settings would require a complicated refactoring of privacy section. Bug: 823703 Change-Id: Ie3f6ecb3c7b11eeb7652808eefb8608222525830 Reviewed-on: https://chromium-review.googlesource.com/1185097 Commit-Queue: Kamila Hasanbega <hkamila@google.com> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#585773}
-
Hayato Ito authored
BUG=877104 TBR=yosin@chromium.org Change-Id: Id80de4171d13f32333d3ce93b330cf308a3c561a Reviewed-on: https://chromium-review.googlesource.com/1188059Reviewed-by:
-
Matt Falkenhagen authored
context_ may be null. It's not easy to cleanly abort in this case since the function returns a value. Since context_ is just used for some bookkeeping, just skip that when it's null. Bug: 877350 Change-Id: I696d08999fe6aa861be206381a4c162e3faa4758 Reviewed-on: https://chromium-review.googlesource.com/1188002Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#585771}
-
Kunihiko Sakamoto authored
and add a link to the mime-type definition. Bug: 874752,876968 Change-Id: I63be125a714e716fa83becc23e812db453fa1a9d Reviewed-on: https://chromium-review.googlesource.com/1188163Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Hiroki Nakagawa authored
In WorkerThread::PerformShutdownOnWorkerThread(), DidTerminateWorkerThread() may induce the main thread to destroy the instance of WorkerThread, so accessing |this| after the function call is dangerous. This CL avoids it. Bug: 853520 Change-Id: If0b57ceb05fce97fa4d28d7ca9defb76e39d1c27 Reviewed-on: https://chromium-review.googlesource.com/1183005Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#585769}
-
Chromium WPT Sync authored
Using wpt-import in Chromium cdcf168c. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23217 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I5ddd65d21249999e5a3a7f6155762cb72e3d71eb Reviewed-on: https://chromium-review.googlesource.com/1188034 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#585768}
-
Boris Sazonov authored
This CL reimplements parent_accounts preference row in AccountManagementFragment to fix alignment issues on older Android versions. Instead of providing custom preference layout via aapt:attr, TextMessagePreference is used. This CL also specifies child_content selectability in XML file. Bug: 877136 Change-Id: I2428c693d3f688b33b6c727df0210465f1ab37d7 Reviewed-on: https://chromium-review.googlesource.com/1187153Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#585767}
-
Gauthier Ambard authored
This CL disable the "scroll to top" action when tapping the status bar when fullscreen is enabled. Bug: 876716 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If2a199be39da0de596e8d945e9fc4c42c65ad009 Reviewed-on: https://chromium-review.googlesource.com/1185098Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#585766}
-
Eriko Kurimoto authored
This is the window to show ChromeVox log history. In this patch, the page is created without any contents. Bug: 874349 Change-Id: I6782686f82a8eeab6d85f9c8cc6686564615b1ce Reviewed-on: https://chromium-review.googlesource.com/1175586Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#585765}
-
Yoichi Osato authored
This patch marks them deprecate at M73. Bug: 671907 Change-Id: I0ba155ad98ff0add788b9089e65cb0a3ea03b3f5 Reviewed-on: https://chromium-review.googlesource.com/1180840Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#585764}
-
Richard Li authored
The comments link is: https://chromium-review.googlesource.com/c/chromium/src/+/1164848#message -a1a1783bcd50bae7f7ba603c9a24c070d62327f1 Change-Id: I6fa64d07308c40b98bcc7c620ea21c714ef85704 Bug: 789854 Reviewed-on: https://chromium-review.googlesource.com/1182960Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Kai Ninomiya authored
This is a almost entirely a copy of the necessary parts of the Raster command decoder. Implements one dummy command (called Dummy) which will be replaced by real commands. Bug: 868192 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iccc1274fb251896b404573de4738b5b37b16b316 Reviewed-on: https://chromium-review.googlesource.com/1147251Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#585762}
-
Yoshisato Yanagisawa authored
Bug: 874754 Change-Id: I20f052a821568a3ab811562c713962acef8cb52a Reviewed-on: https://chromium-review.googlesource.com/1188164Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#585761}
-
Tonko Sabolčec authored
This CL includes: - Add build rule +components/prefs to os_crypt component. - Add a preference key creation. - Implement utility tool to get/set the preference. Bug: 791541 Change-Id: I50835a6edeb62aaef28566d08162accf7789c8eb Reviewed-on: https://chromium-review.googlesource.com/1183361Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Tonko Sabolčec <tsabolcec@google.com> Cr-Commit-Position: refs/heads/master@{#585760}
-
Khushal authored
If the same image is being displayed by multiple compositors, the decode tasks currently use the same ImageDecoder protected by a common mutex. This leads to janks in the case of animated images where the tasks from different compositors to decode the same image can not execute in parallel. For animated images in particular, using the same decoder also results in defeating the internal caching in the decoder. The decoder currently caches dependent frames assuming that a decode for frame n will be followed by a decode request for frame n+1. If different compositors use the same decoder and run different timelines for the same animation, the decode requests can run out of order and defeat this caching causing a re-decode of the complete dependency chain. To avoid this, assign a GUID to each compositor which is passed through to blink via the PaintImageGenerator callback for requesting a decode. This allows the ImageFrameGenerator to assign different decoders to each compositor, and also allow the decode work to run in parallel. R=chrishtr@chromium.org TBR=vmpstr@chromium.org Bug: 872753 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I338b9a31550df1dcfaf777a3e8372d1828fa0043 Reviewed-on: https://chromium-review.googlesource.com/1185793 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#585759}
-
Alexandre Courbot authored
This method has no user besides its own unit test, and we want to remove all non-const methods from VideoFrameLayout. BUG=876986 TEST=built vdatest and Chromium. Change-Id: I5f332416c25a747685f2194989a61df225bb1159 Reviewed-on: https://chromium-review.googlesource.com/1186286 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#585758}
-
Khushal authored
Bug: 876789 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie06484b957bd4d60b9377ad55f356280867acba6 Reviewed-on: https://chromium-review.googlesource.com/1187717Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#585757}
-
Yoshifumi Inoue authored
NOT READY FOR COMMIT To commit this patch, I need to do: - Rebaseline 9500+ layout files for linux, mac, win, since existing implementation doesn't conform the spec[1] - Fix DOM distiller bug[3] It depends on textContent(true) to have newline for <br> https://github.com/chromium/dom-distiller/issues/10 WebTextTest.testGenerateOutputBRElements should have spec complaint test expectation - Fix CrSettingsSiteDetailsPermissionTest.All change expectations to have <option>s This patch implements Element#innerText to conform the spec[1]. Pass rate of WPT is changed from 78 failures to 6 failures for 213 test cases. The design doc is https://goo.gl/VW9xxe. The differences of current implementations are: - No more leading/training newlines - No more trailing whitespaces - At most two newlines between sequences of <p> and <div>. - Contents of <select>, <optgroup> and <option> in result. - No newline for <br> for disconnected element. Note: Handling of <select>, <optgroup> and <option> aren't conformed with the spec[1] since the spec[1] requires to implement Element#innerText specific CSS handling, ::first-line, ::first-letter, text-transform etc, for contents of <option>. I filed the issue[2]. [1] https://html.spec.whatwg.org/multipage/dom.html#the-innertext-idl-attribute [2] https://github.com/whatwg/html/issues/3797 innerText for <select>, <optgroup> and <option> TBR=alexmos@chromium.org TBR=dpapad@chromium.org TBR=dmazzoni@chromium.org TBR=skyostil@chromium.org Bug: 651764, 859410 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I48a02db0347d8ebd189f3ef608b31a4a93d89e84 Reviewed-on: https://chromium-review.googlesource.com/1114673 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#585756}
-
Gauthier Ambard authored
This CL fixes an issue where the LongPress InProductHelp wasn't displayed after displaying the BottomToolbar help as the event was registered. This CL registers the bottom_toolbar_opened event when the tip is shown. It also fixes a couple a minor issues in the bubble presenter. Bug: 877004 TBR: nyquist@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id8c3906c6026ae84d1de09d9c953c2cea887f81d Reviewed-on: https://chromium-review.googlesource.com/1186410Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#585755}
-
Kouhei Ueno authored
Before this CL, Signed Exchange parser implementation in Chromium expected the b1 format [spec-b1]. This CL switches the parser implementation to expect the updated specification which we will snapshot as the b2 format in near future, and deprecate support for parsing the b1 format. Overview: - The magic strings and version specifiers are changed from b1 -> b2. - RequestUrl was a part of cbor_headers in b1, but is now located in the prologue section. - As a result, SignedExchangePrologue is now split into two: {BeforeFallbackUrl, FallbackUrlAndAfter} - Signature message bytes are now encoded using custom binary format (was CBOR in b1) - cbor_headers no longer go through enc(dec(original_bytes)), fixes crbug.com/863499 Note: fallbackUrl redirect on parse fail (crbug.com/874323 ) is to be addressed in separate CL. [spec-b1] https://tools.ietf.org/html/draft-yasskin-httpbis-origin-signed-exchanges-impl-01 Bug: 803774, 863499, 876968 Change-Id: Ib172411e075472dcaae21af9c7460af5b5cf4e52 Reviewed-on: https://chromium-review.googlesource.com/1183053 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: -
Kent Tamura authored
This is a regression by http://crrev.com/579748. If we request opening multiple file choosers, and one of the corresponding blink::FileChooser object is deallocated before calling its OpenFileChooser(), ChromeClientImpl had a stale pointer. ChromeClientImpl should have Vector<scoped_refptr<FileChooser>> instead of Vector<FileChooser*>. Bug: 877269 Change-Id: I296e6ac83b858e1b74fecff87e7a2fa7f9b96765 Reviewed-on: https://chromium-review.googlesource.com/1188009Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4c6514490e96..2a53275c38fb git log 4c6514490e96..2a53275c38fb --date=short --no-merges --format='%ad %ae %s' 2018-08-24 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 c40974417610..221fa26170ae (4 commits) 2018-08-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-23 herb@google.com Move mask rendering to its own routine 2018-08-23 herb@google.com Simplify lifetime of scaler context for remote cache 2018-08-23 bsalomon@google.com Add support for dynamic state GP textures in Vulkan backend. 2018-08-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-23 bungeman@google.com Make create_test_font less global-ish. 2018-08-23 mtklein@google.com Revert "match sRGB primaries with skcms" 2018-08-23 reed@google.com don't recurse forever 2018-08-23 allanmac@google.com Missing Makefile 2018-08-23 allanmac@google.com Fix HotSort benchmark and typo 2018-08-23 fmalita@chromium.org [skottie] Guard against missing solid layer color property 2018-08-23 fmalita@chromium.org [skottie] Ref-counted ResourceProvider 2018-08-23 herb@google.com Make calling convention usable by remote cache 2018-08-23 halcanary@google.com SkQP: test_apk.sh tool 2018-08-23 mtklein@google.com match sRGB primaries with skcms 2018-08-23 robertphillips@google.com Switch GrTextTarget from drawPath to drawShape 2018-08-23 robertphillips@google.com Fold directFilterRRectMaskGPU into directFilterMaskGPU 2018-08-23 herb@google.com Introduce SkGlyphCacheInterface 2018-08-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-23 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms e8e06f9724b0..5f03dc9abfb1 (1 commits) Created with: gclient setdep -r src/third_party/skia@2a53275c38fb The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I5fe039fb3cb19f7e13e663e453f2aab57523e4d0 Reviewed-on: https://chromium-review.googlesource.com/1187924Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585752}
-
Eriko Kurimoto authored
Trivial error Change-Id: I5c18977781576bf4353ca7154d24962f81e38a9e Reviewed-on: https://chromium-review.googlesource.com/1184730Reviewed-by:
-
David Jean authored
Added a function to remove all items from a section, so that only that section can be regenerated dynamically. Bug: 826094 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia873e56b0bbb8d9527b719d665ed536dddf83d41 Reviewed-on: https://chromium-review.googlesource.com/1186401 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#585750}
-
Hayato Ito authored
NOTRY=true TBR=yosin@chromium.org BUG: 877300 Change-Id: If8e8cc5af93f55e9a848d46fa6e1196990d62081 Reviewed-on: https://chromium-review.googlesource.com/1187845 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
-
