GitLab

This reverts commit fe2b5e8c.

Reason for revert: Deterministic failure: org.chromium.chrome.browser.multiwindow.MultiWindowUtilsTest#testAreMultipleChromeInstancesRunningFirstInstanceKilledFirst (status FAILURE)

Original change's description:
> Reland "[Multi-Instance] Add method to detect Multi-Instance"
> 
> This is a reland of 621c283e
> 
> Looks like activities were being preemptively killed on test-n-tablet.
> This caused a failure with the way CallbackHelper was used.
> 
> Reverted due to failing on test-n-tablet.
> > Reason for revert:
> > testAreMultipleChromeInstancesRunningFirstInstanceKilledFirst
> > failing on test-n-tablet
> > https://ci.chromium.org/p/chrome/builders/ci/test-n-tablet
> 
> Original change's description:
> > [Multi-Instance] Add method to detect Multi-Instance
> >
> > This change provides a simple method to detect if Chrome is in
> > multi-instance mode.
> >
> > Bug: 1071925
> > Change-Id: I3b82e5fe7a97e923f67f0ca49735c724f9ed4f17
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155017
> > Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
> > Reviewed-by: Theresa  <twellington@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#762344}
> 
> Bug: 1071925
> Change-Id: Ifcfc192011b0ddf4fdb7b9cc5ecae90b63ae4fb5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167992
> Reviewed-by: Theresa  <twellington@chromium.org>
> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#763387}

TBR=twellington@chromium.org,ckitagawa@chromium.org

Change-Id: Ic4d476aef66df41ef0b428efce6718ffc6043520
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1071925
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171918Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763594}

Bug: 1068808
Change-Id: I4304a8ac713558880ac9f584a8ddfefce82cbc76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171798
Auto-Submit: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763593}

This allows a metric to declare its sampling to exactly match another,
not just in frequency but also which pages are sampled in/out.  This
will allow sampling for interdependent metrics which otherwise have
to be unsampled in order to be accurately compared.

It is activated by having a Finch parameter string give the name of
the control metric instead of an integer that is the sampling rate.

Some functionality was broken out into other functions for easier
testing.

Bug: 766909
Change-Id: I1d5f3a248722e44d4d5790f9581dc6d8b1eaa0e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151107Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763592}

This preview type (known as LPR) is a rather heavy-weight page
optimization that is being turned down on the server side and so the
code can be fully removed now in Chromium.

Notes:
* This preview rewrote the displayed URL in the Omnibox and in History.
* This preview used page_id in ChromeUINavigationData, which is no
  longer needed and is removed.
* This preview had tight integration with DataReductionProxy which is
  also being turned down. Sorry for the merge conflicts.

Bug: 1073125
Change-Id: I53b11defbf8bccbe44038fe198b656a762a5b060
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161311
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763591}

This migration code is still needed. This CL extends the expiry of this
histogram in order to re-evaluate whether or not it's still needed in
the future.

Fixed: 1052957
Change-Id: I68214185e927ed9df05a501c0a29a27e2ea5d46a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168197Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763590}

https://pdfium.googlesource.com/pdfium.git/+log/88040c56ba07..488a283aa8a9

git log 88040c56ba07..488a283aa8a9 --date=short --first-parent --format='%ad %ae %s'
2020-04-28 thestig@chromium.org Simplify CPWL_Edit::DrawThisAppearance().
2020-04-28 thestig@chromium.org Fix a /Parent reference in xfa_pages_8_0.fragment.

Created with:
  gclient setdep -r src/third_party/pdfium@488a283aa8a9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I43b25dbd6be89ce8e8580d57baf7d2916194e218
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171496Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#763589}

https://swiftshader.googlesource.com/SwiftShader.git/+log/71c49f8eab3d..941293d512fe

git log 71c49f8eab3d..941293d512fe --date=short --first-parent --format='%ad %ae %s'
2020-04-28 amaiorano@google.com Eliminate use of Vulkan header BEGIN_RANGE/END_RANGE/RANGE_SIZE enums

Created with:
  gclient setdep -r src/third_party/swiftshader@941293d512fe

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I42019421768927bcf1c960e0dca524318deacaf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168907Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#763588}

This test became flaky on macOS after r763057 because the code to
initialize the adapter when calling BluetoothTest::WithDefaultAdapter()
was accidentally removed on macOS. This patch restores this logic,
copying what is done on other platforms.

Bug: 1076005
Change-Id: If709274183b668022d55c69f8b9d2a09a9c7dd1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171442
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763587}

This patch matches the BottomSheet's close logic to its open logic
with respect to the TabObscuringHandler. Now the sheet doesn't try
to unobscure if it never obscured in the first place. Tests have been
added to ensure this behavior.

Change-Id: Ia685a4577f829a94a081c674c67171758220d54c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168631
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763586}

This CL moves the conversion from premul alpha bitmap to unpremul into
SkBitmapTocursorImage(), instead of the caller. This wasn't being used
in Aura/X11 but present in Ozone/X11.

Also change the input parameter to a const reference.

Change-Id: I1768643e45472735e5ad7886b61f4443f8b74876
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167276Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Cr-Commit-Position: refs/heads/master@{#763585}

R=kinuko@chromium.org,chlily@chromium.org

Change-Id: I458a6041b260f6902cab03e765cd761ec39f84c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159709
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763584}

Prior to this change, the host will always make at least two service
calls, one to heartbeat and one to log that it heartbeated.  This
dance is left over from the design which used Buzz as the signaling
channel.  Since both heartbeat and log calls go to the same service
API now, there isn't much value in having two separate calls.

In this CL, we will add a couple of fields to the heartbeat message
and populate them for every heartbeat.  The backend service will
determine whether or not they need to be persisted in the Directory.

Change-Id: I6f1f9ca18b903c63a36ad78ec1bc94869db64dd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170174
Commit-Queue: Gary Kacmarcik <garykac@chromium.org>
Auto-Submit: Joe Downing <joedow@chromium.org>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763583}

Bug: chromium:1073602
Change-Id: I104b2237d451e967187c30d2bb2f3b67282fcd26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168804Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Taylor <deadbeef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763582}

* remove unused protobuf import
* remove unused response_time and server_response_time from
  StreamModelUpdateRequest

Change-Id: I41437d693fdc29feee2019de6e5e7d19753bd68e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170419
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Ian Wells <iwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763581}

This allows us to draw it in exactly the place defined by
the spec. It will also make showing and hiding the close button
with animation easier later. In addition, when the expand button
is added it cannot be place in the BubbleFrameView, which
does not currently support buttons other than close.

Note: The spec called for the button to be 20x20, but here
I've got with 24x24 which is the default size for all
BubbleFrameView dialog bubbles. Tap targets should be as
large as possible for accessibility. The icon is still positioned
to spec with respect to the edge of the bubble view.

Bug: 1055150
Change-Id: I5949986ccc8682a778fdc215e1512b97f16345aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165869
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Abigail Klein <abigailbklein@google.com>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763580}

Plumb cros_healthd's new event interface through
ServiceConnection, and add support to the fake
to be able to test adding observers.

Bug: chromium:1067638
Change-Id: Iafb62397509025835115d8f604db17fc3f3f6955
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166398
Commit-Queue: Paul Moy <pmoy@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763579}

Remove hidden attribute and add template with dom-if for incognito
tooltip. This fixes the tab focus regression issue.

Bug: 1073749
Change-Id: I13e52e2c690a3e60aea6354aac4604f7fd5eca1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164888
Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763578}

This CL performs a few renames, given that the original names had become
outdated given these classes' new responsibilities:

OsSettingsLocalizedStringsProvider => OsSettingsManager
OsSettingsPerPageStringsProvider => OsSettingsSection
*StringsProvider => *Section

Additionally this class adds a virtual AddHandlers() function which will
be used to migrate handlers to each *Section class in upcoming CLs.

Bug: 1069849
Change-Id: Ic68ca8d406b491039aee36676a626c3d82727376
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169483Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763577}

We are missing loadingFailed when the request was successfull,
tried to commit in the renderer but failed to do so. In that case
NavigationRequest::state_ can be CANCELING or READY_TO_COMMIT.
Changing to HasCommitted() should do the trick.

One such scenario would be renderer-initiated navigation that was
also canceled in the renderer.

Bug: none
Change-Id: I819b1b487715c8c7aed5cd14fa4727b5fd94b3cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161572Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Yury Semikhatsky <yurys@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763576}

Arm64 tests are now running on CI, so test suites can be enabled on
FYI for debugging.

Bug: 1042512
Change-Id: Icd2b4736202847db885155341891af44382fcdaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161775
Commit-Queue: Stephen Roe <steveroe@google.com>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763575}

Part of re-implementing the Switch Access Menu in native views.

This change adds plumbing for the component extension to open the menu
at a specified location with specified actions available.

This code is currently not used, but will be in a follow-up change.

Relnotes: N/A
Bug: 973719
Change-Id: I0e5acacc0afd62d08fdd977ce42b1c935efa0756
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153594Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#763574}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/06cce0bd8dab..80edd3ccc6e2


Created with:
  gclient setdep -r src-internal@80edd3ccc6e2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC yukishiino@google.com,hendrich@google.com,tommycli@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1064181
Tbr: yukishiino@google.com,hendrich@google.com,tommycli@google.com
Change-Id: I029f49fbdaf1cd50bf2c8ed920193a601ad2179b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171236Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#763573}

Sign-in UI cannot be dismiss without asynchronous calls. This was
previously ignored. The new architecture is more strict, don't allow
to ignore callbacks.
To prepare the transition to the new architecture, all sign-in UI has
to be managed by the SceneController.
The SceneController already supports asynchronous dismiss of the sign-in
UI.

Adding AUTHENTICATION_OPERATION_ADD_ACCOUNT command to add secondary
accounts.

   crrev.com/c/2161007 GoogleServicesCoordinator
=> crrev.com/c/2160911 AccountTableViewController
   crrev.com/c/2161027 SettingsTableViewController
   crrev.com/c/2165732 Fixing tests

Bug: 971989
Change-Id: I8306a2d8613992bbf750abbe2a90a1ab4a1ac641
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160911
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Nohemi Fernandez <fernandex@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763572}

OzoneDrmMojo is 100% on. This is 2nd CL to remove more Legacy IPC code in ozone.
Another CL(3/3) will remove ui/ozone/common/gpu/ozone_gpu_message_params.h and related files.

Bug: 620927,806092
Change-Id: Id5cdca9f98677a617a551999d89864f10b753115
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167765Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kramer Ge <fangzhoug@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763571}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c301c370..004a4047

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I710b21554a5fdd6ca2dc9861c94b28a683b7af75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170469Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#763570}

This patch renames subtree-visibility to the new name:
content-visibility.

This should be the last time we rename this feature, since the latest
name was resolved on by the CSSWG.

R=aleventhal@chromium.org, cbiesinger@chromium.org, chrishtr@chromium.org, futhark@chromium.org

Change-Id: I6b82b918288341a2fd984fca3e19eb6dca777dca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168007
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763569}

https://android.googlesource.com/platform/external/perfetto.git/+log/9a90474af88f..97a467a3b1f0

git log 9a90474af88f..97a467a3b1f0 --date=short --first-parent --format='%ad %ae %s'
2020-04-28 nuskos@google.com Merge "Add the new gesture_scroll_id field so its in the proto ready for use."
2020-04-28 hjd@google.com Merge "Bazel: Add Java target for merged config proto"

Created with:
  gclient setdep -r src/third_party/perfetto@97a467a3b1f0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I8cb2fee247355e190b526a2f3eff5a2a80aa25dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171276Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#763568}

Fixed: 1071573
Change-Id: Ib1b283f204a73cac07b8adc900e228f31eac3308
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171322
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763567}

Move the routine to serialize true computed values to their CSSValue
representations (and its helpers) from ComputedStylePropertyMap into
ComputedStyleUtils. This will be used by animations code in dependent
patches.

Bug: 1056197, 1057307
Change-Id: Ib972c9800216e39a7f84fa68c6d408618c1653c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168647Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: George Steel <gtsteel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763566}

https://chromium.googlesource.com/angle/angle.git/+log/1f9e2a8feb5a..1398080cdd77

git log 1f9e2a8feb5a..1398080cdd77 --date=short --first-parent --format='%ad %ae %s'
2020-04-28 jmadill@chromium.org Capture/Replay: Simplify .gni integration.

Created with:
  gclient setdep -r src/third_party/angle@1398080cdd77

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: cnorthrop@google.com
Change-Id: Iee53c70e75edfc730bc9b9ae80731deb2343ffff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170804Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#763565}

Bug: 966270
Change-Id: If95c97606cfe0fde5d61ea1d3e2a441a9dd311dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165677Reviewed-by: James Vecore <vecore@google.com>
Commit-Queue: Jon Mann <jonmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763564}

This patch fixes some gap logic and removes DCHECKs that were invalid.

Bug: 1075908
Change-Id: I79e4359e14e9d10135c918abecb9c4031fd4e945
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171257
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763563}

This patch renames AssistantImageDownloader to ImageDownloader and share
it with Ambient mode.

Bug: b/153499730
Test: passed current unittests
Change-Id: I9fc2a875381184f4f370f400c27597b8ba5964d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148129
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763562}

*Rich autocompletion background*

Currently, autocompletion is limited to when the user types a prefix of
the URL. E.g. 'wiki' can autocomplete 'wiki.org/thecookinglist - top
awesome recipes'.

Rich autocompletion will allow autocompletion even when the input is
from the suggestion title or not the beginning of the URL. E.g.
'thecoo' and 'awesome reci' will also autocomplete
'wiki.org/thecookinglist - top awesome recipes'.

Design doc with further details: go/richomniboxautocompletion

*This CL*

This is the 2nd CL for rich autocompletion. As a prerequisite for
non-prefix autocompletion, e.g. allowing 'y' to autocomplete '[x]y[z]',
this CL adds support for multiple discontinuaous selections to the
Textfield view class and its underlying TextfieldModel and RenderText
classes.

Multi-selection is not used at the moment, and thus this CL will not
have user facing changes. Followup CLs will use the feature and will be
behind flags.

Bug: 1062446
Change-Id: I6e1e6a8bc44b3e3a6ef8dcd45537edc2d683ac0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108780
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763561}

CreateCombobox is now known as CreateAndAddCombobox.

Change-Id: I6143d33c0ee9efdf7c0a63d20deb6d23e9bb969d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169377
Auto-Submit: Robert Liao <robliao@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763560}

Last call was removed here:
https://chromium-review.googlesource.com/c/chromium/src/+/1162438/

Change-Id: I606f03de97b4b4239d8ca202d61501025b76ed53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171318
Commit-Queue: Bo <boliu@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Auto-Submit: Bo <boliu@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763559}

Aligns the implementation with the spec.
https://github.com/WICG/ua-client-hints/issues/77 discusses which Task
type it should be queued on.

Bug: 1070934
Change-Id: I3461f7f1a2e6346717e568008b9879f20d39a82e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166103Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Aaron Tagliaboschi <aarontag@chromium.org>
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763558}

Chrome OS doesn't use or support the old wake on WiFi flag. This change
removes all associated code.

BUG=chromium:1074118
TEST=Compile.

Change-Id: Ice29ea77301ddbdcffdc34eedaa65254ec3bdb77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163040
Auto-Submit: Abhishek Bhardwaj <abhishekbh@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763557}

The first idea was to allow |limit| in HitTestCulledInlineAncestors() to
be nullptr and just exit when we reach the first LayoutBox ancestor, but
that wasn't good enough, as that would still trigger DCHECK failures in
LayoutInline::HitTestCulledInline(), because neither
ContainingNGBlockFlow() nor NGInlineCursor work if the container is a
fragmentainer.

Therefore, just skip hit-testing of culled inlines that are contained by
a fragmentainer / column for now.

This is needed by CL:2134294

Bug: 829028, 1043787
Change-Id: I22348d69b5159de56614fe28ce5456b87643afe6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170000Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763556}

crrev.com/c/2084088 implemented the necessary plumbing from blink to cc
to support composited scroll-linked animations. This patch completes the
ticking logic in cc.

Major changes include:
 - Passing ticking_animations_ to cc::AnimationTimeline and ticking
   animations from AnimationTimeline such that cc::Animation does not
   need to be aware of upper level concepts such as ScrollTree.
 - Splitting ticking methods for time/scroll linked animations.
 - Using KeyframeEffect::Pause() instead of Tick() for scroll linked
   animations.
 - Updating KeyframeEffect::last_tick_time_ to base::Optional to be
   compatible with both time/scroll linked animations.

Bug: 1023508
Change-Id: Ic1952c06205dea6ef2eaed37eceb86ae35db9c91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106820
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763555}