- 02 May, 2018 40 commits
-
-
Chong Zhang authored
The original patch (Patchset 3) was reverted due to flaky tests under Linux TSan: https://crrev.com/c/1036490 This patch fixed the issue by using a wait condition runloop. --- Original Description --- Background: * Currently |TaskManager| tracks network usage through |net::NetworkDelegate|, which is not supported with Network Service. * https://crrev.com/c/978607 Tried to get the info from |content::WebContentsObserver| but failed due to too many corner cases. This CL: 1. Introduced |NetworkService::GetTotalNetworkUsages() => (array<NetworkUsage> total_network_usages);| 2. Updated |TaskManagerImpl| to query the above API 1/sec when active. (e.g. While showing the UI or queried by extensions.) 3. Still use the old codepath when Network Service was disabled. Note that |NetworkService| receives network usage reports from |URLLoader::NotifyCompleted()|, and we could improve the frequency when necessary. The API may be useful for |data_reduction_proxy| as well, see: https://docs.google.com/a/google.com/document/d/1qJYdvt0USWAHbJ9hvCkfauZ9ItMoyYCY2w0Fodvse0M/edit?disco=AAAAB203Cv8 Bug: 822415 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I96f4b3456b4fa8f599b76fbe614d1c724a9c9007 Reviewed-on: https://chromium-review.googlesource.com/1038803Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#555553}
-
John Chen authored
Now that issue 826150 has been resolved, remove some debugging output that was added to Python test script for investigating that issue. Changes include: * Lower verbose logging level from 4 to default (3), by reverting part of r546473. * Stop running ps command upon timeout, by reverting r538464. Change-Id: I29f41ef40e7f2a94b932b1c2204ac19e19db986c Reviewed-on: https://chromium-review.googlesource.com/1036644Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#555552}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 718ccb47. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16698 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox TBR=kereliuk No-Export: true Change-Id: I8f1b378d9ff2298854e59ee793fbabee91752f88 Reviewed-on: https://chromium-review.googlesource.com/1040385 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#555551}
-
Victor Costan authored
For historical reasons, OnRegistrationStored() is called when the promise returned by ServiceWorkerContainer.register() is resolved, which happens before the registration is written to disk. This means OnRegistrationStored() implementations cannot assume that ServiceWorkerContextCore will be able to retrieve the registration. This CL renames the method to a more appropriate name. A follow-up CL will add an OnRegistrationStored() method, which will be called when the registration is written to the database. TBR=benwells Bug: 729800 Change-Id: If273b3008ff55e4d5cd8f5be9e0e6090da2e5390 Reviewed-on: https://chromium-review.googlesource.com/1039083 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#555550}
-
John Chen authored
Change the initial DevTools connect timeout from 1 second to 2 seconds. While a timeout of 1 second was sufficient for Linux and Mac, it turned out to be too short for Windows, where a normal successful connection usually takes very close to 1 second. Change-Id: I685ac9aa45a7ce250f2af718959661c59dcf8f0d Reviewed-on: https://chromium-review.googlesource.com/1037806Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#555549}
-
Wenzhao Zang authored
1) Added a new auth method |AUTH_ONLINE_SIGN_IN|. There's no transition between this auth method and others (except for AUTH_NONE). 2) Because the existing code in |LoginAuthUserView| accesses |LoginScreenController| directly, think there's no need to add the click callback to |LoginAuthUserView::Callbacks|. 3) The //chrome portion of this CL is borrowed from https://chromium-review.googlesource.com/c/chromium/src/+/1012575 which is on a slightly different issue. 4) Will need a follow-up CL to update the spec. Bug: 836336 Change-Id: Ic604c6c0f5f53533f824b5c0089f44dfdbeb7f73 Reviewed-on: https://chromium-review.googlesource.com/1036800Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#555548}
-
Peter Kasting authored
If every call site has to check this manually, there's no reason to do it on the caller side. BUG=none TEST=none Change-Id: I0b897cc03c3aaa7daa817a4718c62b7362ab72f2 Reviewed-on: https://chromium-review.googlesource.com/1038799 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#555547}
-
Bo Liu authored
Rather than affecting all sub frames as well. There should be no behavior change if OOPIF is disabled. When OOPIF is enabled: * on Chrome, marks the foreground tab MODERATE, so that it maintains the default binding when the app is in the background. This changes gets us the desired behavior where the main frame but not sub frames keeps MODERATE. * Android WebView probably wants the ability to control subframes, but that's probably years away from ready, at which point child process importance probably needs to be revisited again. So essentially just ignoring it for now. Bug: 813232 Change-Id: I045dcbc607eb51a7e43c7b1455ff994298e20272 Reviewed-on: https://chromium-review.googlesource.com/1038759Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#555546}
-
Allen Bauer authored
Bug: 839000 Change-Id: I000a3aae3e5c9373baadc9f3c4d693e91ae07725 Reviewed-on: https://chromium-review.googlesource.com/1040671Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#555545}
-
John Chen authored
The following two Java tests no longer appear to be flaky: PageLoadingTest.testShouldBeAbleToNavigateBackInTheBrowserHistoryInPresenceOfIframes PageLoadingTest.testShouldBeAbleToNavigateBackInTheBrowserHistory Bug: chromedriver:653 Change-Id: Iaa0f991a2a3ee785a7505da77e82738622857950 Reviewed-on: https://chromium-review.googlesource.com/1040307Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#555544}
-
https://chromium.googlesource.com/angle/angle.git/+log/d8ffd75616c1..9aef36705b66 $ git log d8ffd7561..9aef36705 --date=short --no-merges --format='%ad %ae %s' 2018-04-27 jmadill Vulkan: Implement masked color clears. 2018-04-27 jmadill Vulkan: Take serials in PipelineDesc::updateShaders. 2018-04-30 jmadill Fix ASSERT macro generating extra code in MSVC. 2018-05-01 jmadill Vulkan: Use ShaderType enum. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: If65ea4ed2a0025e44dc6f098d0a081bd85db3033 Reviewed-on: https://chromium-review.googlesource.com/1040352Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555543}
-
Xiaohan Wang authored
- Roll src/media/cdm/api/ 163f87884..d12602556 (1 commit) 2018-04-26 xhwang cdm: Mark CDM_10 interface as stable - Update Chromium to use the latest stable CDM_10 interface, e.g. now cdm::ContentDecryptionModule is not defined anymore. - Use an std::array kSupportedCdmVersions to store information about supported and enabled (by default) CDM interface versions. - Simplify IsSupported* functions. - Add static assert to make sure the CDM Host interface for a supported CDM interface is also supported. - Add static assert to make sure experimental CDM interface is never enabled by default. NOPRESUBMIT is specified to workaround the media presubmit on histogram enum UMA style check. See https://crbug.com/772494. NOPRESUBMIT=true Bug: 733821 Test: No functionality change. Change-Id: I236a24106354ea9210e703bae5a13dc4238f93d3 Reviewed-on: https://chromium-review.googlesource.com/1035783 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#555542}
-
Chris Blume authored
The LSI allocators previously did not store a copy of the last generated LSI. As a result, many call sites would have to keep their own copies. Now that the LSI allocators have their own copies, the call sites can be updated to no longer store a separate copy. VideoFrameSubmitter is one such call site. BUG=759031 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia4fde6fdb870c87d1852edd1f4a33a89f7cc9743 Reviewed-on: https://chromium-review.googlesource.com/1034390 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#555541}
-
Katie D authored
This is part of a change to allow Select-to-Speak to work in tablet/touch only mode. This change allows the extension to tell the EventHandler that capturing should being, allowing Select-to-Speak to start capturing touch events or mouse events without the 'search' key having been clicked. This change does not cause any behavior changes at this time, because there is no current way to enter the SELECTING state without holding down the search key first. In a follow-up change, this pathway will be activated when a user will click a button in the ash system shelf. That button is not yet hooked up. To see a complete demo, see https://chromium-review.googlesource.com/c/chromium/src/+/1031550. Bug: 753018 Change-Id: I3be60fa338ce32e2a99ce7e21d9d7cab503ac4e0 Reviewed-on: https://chromium-review.googlesource.com/1036534 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#555540}
-
Johannes Henkel authored
It's probably an oversight that this is missing; also adding a comment to the header file for next time. Andrey thank you for pointing me at network_param_ipc_traits.h. R=caseq Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I21e278de132e0b3e465c3e27d25201b6878270e3 Reviewed-on: https://chromium-review.googlesource.com/1038808Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#555539}
-
Min Chen authored
crash in mash. Add RunAllPendingInMessageLoop to make it happy in mash. Bug: 838595, 837092 Change-Id: Ib5fbd2857c41fc4de3254b6f31a4bb6809864d76 Reviewed-on: https://chromium-review.googlesource.com/1040533Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#555538}
-
Daniel Cheng authored
This is the first step in a multi step plan to simplify the number of injection points core exposes for testing: 1. Simplify existing DummyPageHolder tests that don't need custom clients. These can be trivially migrated to the new DummyPageHolder and PageTestBase implemented in step 3. 2. Rename DummyPageHolder and PageTestBase to DummyPageHolderDeprecated and PageTestBaseDeprecated. 3. Implement new DummyPageHolder and PageTestBase based on WebViewHelper. 4. Migrate tests that don't need custom clients to the new DummyPageHolder or PageTestBase. 5. Migrate tests that need custom clients by migrating the hooks from ChromeClient / LocalFrameClient to WebViewClient, WebWidgetClient, or WebFrameClient as appropriate. 6. Remove DummyPageholderDeprecated and PageTestBaseDeprecated. Bug: 734748 Change-Id: I37a4b60770b6d76933ff475253f7b15dcf8df26d Reviewed-on: https://chromium-review.googlesource.com/1020814 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#555537}
-
Sahel Sharify authored
Bug: 838971 Change-Id: Ic296d7e5792ed38cc636b1f84d7d3d2e1ac229cb Reviewed-on: https://chromium-review.googlesource.com/1037424 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#555536}
-
David Bokan authored
When an iframe loads its first or a new document we might swap out the FrameView. When this happens, the validity of a candidate for implicit promotion will change so we should reevaluate at that time whether any candidates should be promoted. Also disabled implicit root scroller in frameElement-frame test since it causes promotion of the frame which leads to pixel differences in the output. When/if this feature ships we should rebaseline this test. Bug: 838683 Change-Id: I55f3a49af8670897a31e63fd58469f5121b32671 Reviewed-on: https://chromium-review.googlesource.com/1036843Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#555535}
-
Kevin Marshall authored
This is a reland of 7891d057 The underlying issue in crbug.com/838703 was fixed and "lint_test_expectations.py" Works On My Box(TM). TBR=scottmg@chromium.org Original change's description: > Fuchsia: Explicitly check that all file dependencies exist. > > Wrap file path references with "EnsureFileExists()" which acts as a > simple identity function, except for invalid paths for which it > raises IOErrors. > > Bug: 837200 > Change-Id: Ie718cd5517415b375ed3bf5d5112d59b32074c04 > Reviewed-on: https://chromium-review.googlesource.com/1037778 > Reviewed-by: Scott Graham <scottmg@chromium.org> > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555137} Bug: 837200 Change-Id: I21713adc9e8d9fcaab06957a25255de3ee6e596e Reviewed-on: https://chromium-review.googlesource.com/1038963Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#555534}
-
Karan Bhatia authored
r551018 introduced an override for ReadyToCommitNavigation method on ChromeExtensionWebContentsObserver. However it failed to call its superclass implementation. Fix it. BUG=696822 Change-Id: I882c8af072f942e65072fb06e3b2209d2e983c1c Reviewed-on: https://chromium-review.googlesource.com/1039158Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#555533}
-
https://pdfium.googlesource.com/pdfium.git/+log/d3b0f7cc78e6..303f9a3afc4a $ git log d3b0f7cc7..303f9a3af --date=short --no-merges --format='%ad %ae %s' 2018-05-02 dsinclair [xml] Simplify the CFX_XMLParser parse methods 2018-05-02 dsinclair [xml] Rename CFX_XMLParser::ParseTextChar 2018-05-02 hnakashima CFWL_MonthCalendar::GetTodayText() includes "Today" string. 2018-05-02 hnakashima Pass DPI as CFX_Size in XFA_DrawImage. 2018-05-02 dsinclair Cleanup XFA document properly on failed load 2018-05-02 dsinclair Add a CFX_XMLDocument class. 2018-05-02 hnakashima Remove out params from CalculateAccWidthAndHeight. Return CFX_Size. Created with: roll-dep src/third_party/pdfium BUG=chromium:837578 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia4cf7f68b647c08a999794d10f270247e6e803fa Reviewed-on: https://chromium-review.googlesource.com/1040358Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555532}
-
Michael Lippautz authored
Compute estimated marking time in PostSweep were both, marked bytes and marking time, refer to the same garbage collection cycle. Bug: chromium:830196, chromium:757440 Change-Id: I80ea0c028ba7668f05b94b1acbe9b0c38afa801a Reviewed-on: https://chromium-review.googlesource.com/1039566 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#555531}
-
Sigurdur Asgeirsson authored
Bug: 755840 Change-Id: I3f27b8a1138690f2b9ed9cd6af442bc1758a5f38 Reviewed-on: https://chromium-review.googlesource.com/1028453Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#555530}
-
Danyao Wang authored
This fixes WebPageReloadNavigation and NativeContentReload in navigation_and_load_callbacks_inttest with WKBasedNavigationManager. Bug: 807428 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I04cf18663fed453c8d4093a67fe988298acd87fc Reviewed-on: https://chromium-review.googlesource.com/1040276Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#555529}
-
Max Morin authored
Missed in https://chromium-review.googlesource.com/c/chromium/src/+/1004634. Bug: 803102 Change-Id: I9366f75252bfcf9009491dfbfae481bee40e042c Reviewed-on: https://chromium-review.googlesource.com/1039809Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#555528}
-
Peng Huang authored
Add a flags argument for SwapBuffers, PostSubBufferCHROMIUM, wapBuffersWithBoundsCHROMIUM and CommitOverlayPlanesCHROMIUM. This flags will be used to indicate if the client want to receive presentation feedback and VSync update. Bug: 776877 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Icd22dbbc493f7982fec9cc5310f404a9ef5d477b Reviewed-on: https://chromium-review.googlesource.com/1033582 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#555527}
-
Mark Pilgrim authored
Bug: 773295 Change-Id: I14ef40e378fa6cceb68d31342ef9bf35eb7f7ab3 Reviewed-on: https://chromium-review.googlesource.com/1040085Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#555526}
-
Xiaohui Chen authored
Push native assistant state into voice interation controller so existing UI elements logic could be reused. Bug: b/78193960 Test: locally build Change-Id: I6fbaf74db41263fbdd184bed37e8f29a21578c6f Reviewed-on: https://chromium-review.googlesource.com/1040351Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Qiang Xu <warx@google.com> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#555525}
-
Hiroshige Hayashizaki authored
This CL 1. Maps std:x|y URLs to std:x (according to the draft spec [1]), 2. Then maps to std-internal://x/index.js (not spec'ed [2]) in GetInternalURL(), 3. Then retrieves and serves the script contents for std-internal: URLs in GetSourceText() using ui::ResourceBundle() from blink_resources.pak. The source JavaScript files for Layered APIs are placed under third_party/blink/renderer/core/script/resources/layered_api and bundled into blink_resources.pak. This CL introduces std: and std-internal: schemes that are used in Blink side (std: is user-facing while std-internal: is mostly invisible for users) but not outside Blink. [1] Spec: https://github.com/drufball/layered-apis/blob/master/spec.md [2] Implementation design doc: https://docs.google.com/document/d/1V-WaCZQbBcQJRSYSYBb8Y6p0DOdDpiNDSmD41ui_73s/edit Bug: 829084 Change-Id: I61fc0a2f17d937db6e859303ab8a84e4b2b87850 Reviewed-on: https://chromium-review.googlesource.com/1013321 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#555524}
-
Jialiu Lin authored
No SB APIs will be triggered if users are in incognito mode. If enterprise configures the PasswordProtectionWarningTrigger to PASSWORD_REUSE, no Gaia reuse ping sent, and Chrome triggers the OnPolicySpecifiedPasswordReuseDetected() with is_phishing_url set to false. By default, Chrome triggers the OnPolicySpecifiedPasswordReuseDetected() with is_phishing_url set to true, when modal warning is shown. OnPolicySpecifiedPasswordChanged() is triggered when we detect a sync password change. TBR=markusheintz@chromium.org Change-Id: Ia3a9e6f1c70f47d4e1ec8b14feb58d94e85fbd62 Bug: 811467 Reviewed-on: https://chromium-review.googlesource.com/1022111 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Georges Khalil <georgesak@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#555523}
-
Evan Stade authored
Bug: none Change-Id: I7f3f331b0023077348049edbfb9ce104bee7a293 Reviewed-on: https://chromium-review.googlesource.com/1040306Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#555522}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f9ab22385ead..38a08436886e $ git log f9ab22385..38a084368 --date=short --no-merges --format='%ad %ae %s' 2018-05-02 khushalsagar fonts: Reland push font remoting. 2018-05-02 reed check for finite vertices 2018-05-02 angle-skia-autoroll Roll third_party/externals/angle2/ 47155b171..78feddc28 (5 commits) 2018-05-02 reed use SkLeftShift in case the first arg is negative 2018-05-02 reed check for 0x8000 before calling abs 2018-05-01 herb Add the filter rec bypass to make canonical strike descriptors Created with: roll-dep src/third_party/skia BUG=chromium:831354 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I2e0bf369d9581b066ce31b0c003b9c5a14482f9b Reviewed-on: https://chromium-review.googlesource.com/1040529Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555521}
-
edchin authored
This CL enables undo close all tabs in the tab grid by serializing the current window. The undo operation deserializes the saved closed window. Current known issue is that snapshots are erased when WebStates are closed. Another CL will deal with keeping snapshots around long enough for undo operations. Bug: 804567 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I12cf8c11d1e067a7de1b9a6ce44d207810619eb8 Reviewed-on: https://chromium-review.googlesource.com/1036257Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#555520}
-
Jared Saul authored
Bug: 839029 Change-Id: I11bb3eb81a3e2ac04bd8f99332756e8529b94f7b Reviewed-on: https://chromium-review.googlesource.com/1040535 Commit-Queue: Jared Saul <jsaul@google.com> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#555519}
-
Dave Schuyler authored
This CL renames references to answer layout to old-style layout to be clearer about what refers to the old style answer layout. Some uses of old-style answer formatting in entities were also cleaned up. Bug: None Change-Id: I6812c7d005cb9c945b8a36e89668d062cda4558a Reviewed-on: https://chromium-review.googlesource.com/1040538Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#555518}
-
Jeremy Roman authored
Change-Id: I43d203b91343e0c8458a1b5c0af7252dddb00a0e Reviewed-on: https://chromium-review.googlesource.com/1038607Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#555517}
-
Alexander Timin authored
This patch only plumbs ObserverType to CalculatedThrottlingState, but does not modify logic yet. This patch is extracted from http://crrev.com/c/956224 by ryansturm@ to unblock dedicated worker throttling and load throttling work. R=ryansturm@chromium.org,alexclarke@chromium.org TBR=toyoshim@chromium.org Change-Id: I4b554a48a7f5a247eac7687de93b68ac37dea07e Reviewed-on: https://chromium-review.googlesource.com/1039805Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#555516}
-
Mark Pilgrim authored
(split off from https://chromium-review.googlesource.com/c/chromium/src/+/1035543 ) This adds GetSharedURLLoaderFactory(), which returns a SharedURLLoaderFactory owned by the SystemNetworkContextManager and backed by the SystemNetworkContext. Bug: 773295 Change-Id: I5301e9785d913dd27cdc36e7ef4f759290e1ecf5 Reviewed-on: https://chromium-review.googlesource.com/1037943 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#555515}
-
Peter Kasting authored
* Removed initial TabStrip* arg, no one was using it. * Changed names from e.g. TabStripAddedTabAt() to OnTabAdded() to shorten and make consistent with other observer OnXXX() names. * Changed TabStripMaxXChanged() to OnTabsMaxXChanged() in keeping with the meaning change in https://chromium-review.googlesource.com/c/chromium/src/+/1038789 . * Changed override order in GlassBrowserFrameView to match base class. BUG=none TEST=none Change-Id: Ibf29362d818d8f63e34c168d428173bca6e2a257 Reviewed-on: https://chromium-review.googlesource.com/1038796 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#555514}
-