GitLab

This is the revert of crrev.com/b77864ad
Turns out that fix causes crbug.com/775526.
In the mean time, revert won't re-trigger the crbug.com/759007 as it's
fixed by crrev.com/9990e87e.

Bug: 759007
Bug: 775526
Change-Id: I2cd5acefb3d8588613629a99dde592f648650a93
Reviewed-on: https://chromium-review.googlesource.com/757718Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515211}

Also fixes the bugs that were uncovered from adding these checks.

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iecac97f4b91c24bc3aeae4b2fc336e39c25df781
Reviewed-on: https://chromium-review.googlesource.com/759690Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Yixin Wang <wangyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515210}

Those tests calls UIView -frame on a background thread which
is an error on iOS 11.0+ causing the tests to fail.

Bug: 782760
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-eg
Change-Id: Iadb1e5d917724dbc6d1341d4de3dcbe2fcf7f3cd
Reviewed-on: https://chromium-review.googlesource.com/758867Reviewed-by: Elodie Banel <lod@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515209}

Those tests calls UIView -frame on a background thread which
is an error on iOS 11.0+ causing the tests to fail.

Bug: 782760
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-eg
Change-Id: I83d4338263bde003000be22ff38ef7199a35da64
Reviewed-on: https://chromium-review.googlesource.com/760361
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Elodie Banel <lod@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515208}

AVDA used to receive a "frame hidden" signal from WMPI.  This would
let it give up the overlay in case some other frame needs it.

Now that DialogOverlayImpl destroys the overlay when the WebContents
is hidden / etc., this isn't needed.  It will be handled normally.

Bug: 782827
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I9b5857f3b37545da2c44462de0424b00de8cb3ae
Reviewed-on: https://chromium-review.googlesource.com/759143Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515207}

For net::NetworkQualitiesPrefsManager.

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie4fddd3363d078dc468d3df61aac1d6336c8ac49
Reviewed-on: https://chromium-review.googlesource.com/760216Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515206}

"Distribution" is likely a word which implies "an old mechanism without IncrementalShadowDOM".
SupportsAssignment would be better here.

Bug: 776656
Change-Id: Id1cfbbb9df054b7f0a47352c15aaf0bd57203792
Reviewed-on: https://chromium-review.googlesource.com/760117
Commit-Queue: Hayato Ito <hayato@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515205}

This CL adds some extra info re. support for encrypted streams to
the chrome://gpu video acceleration entry, to avoid the duplication
of formats described in the bug.

Bug: 783100
Change-Id: I06bf1bd450e71cdf2db88ec27f4ffff98814accb
Reviewed-on: https://chromium-review.googlesource.com/760478Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515204}

Promotes ResizeObserver to stable

Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/z6ienONUb5A

LGTM1 from dglazgov, LGTM2 from foolip, LGTM3 from chrishtr on Oct 17

Bug: 612962
Change-Id: I3dc59fd0ab725acc6f40bf5a3bbd70de5e889f0f
Reviewed-on: https://chromium-review.googlesource.com/754562
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Cr-Commit-Position: refs/heads/master@{#515203}

We want UKM scroll latency reporting to work for --enable-viz (i.e. for the
case when display compositor is in the GPU process). This means that we need to
report these metrics in LatencyTracker::ReportUkmScrollLatency, not in
RWHLatencyTrcker::ReportUkmScrollLatency.

This CL adds ukm::SourceId to LatencyInfo. The source id is set on the
LatencyInfo object in RWHLatencyTracker::OnInputEvent. This way LatencyTracker
(which does not have access to RWHDelegate) can use the ukm::SourceId from
LatencyInfo when reporting UKM scroll latency.

TBR=sadrul@chromium.org

Bug: 717629
Change-Id: Ib449bcaaf6153b67d2ffdf2f28bf4749f78c80fa
Reviewed-on: https://chromium-review.googlesource.com/744702
Commit-Queue: Mikhail Fomitchev <mfomitchev@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515202}

Service and Manager classes used to depend on each other, making
their initialization timing complicated.

This CL moves more logic into Manager, such that the dependency cycle
is broken, Service no longer depends on Manager. As a result of this
simplification, there is now no need to keep track of both the aggregate
list (previously Service#extensions_) as well as the two sublists
(Manager#apps and Manager#extensions). Manger now only keeps track of
the sublists, and some unnecessary linear searching has been eliminated.

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3bdc0e9b630cc1adf98034ee4fda862b17dbfbfa
Reviewed-on: https://chromium-review.googlesource.com/745903
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515201}

Bug: 720786
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I80e08d02f49e452596a21e4a91f0d0d7f3810236
Reviewed-on: https://chromium-review.googlesource.com/758484
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515200}

|description_class| array can be empty. Add conditional to handle if so.

Bug: 783194
Change-Id: I3f023e7b279f2eceaa6ea4432f68a2c09de19171
Reviewed-on: https://chromium-review.googlesource.com/760660Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515199}

https://chromium.googlesource.com/angle/angle.git/+log/d80f2944cf13..70b715c9b8bc

$ git log d80f2944c..70b715c9b --date=short --no-merges --format='%ad %ae %s'
2017-11-07 yunchao.he ES31: Add test for DispatchCompute with rendering program
2017-11-03 jiawei.shao Skip hasMappedBuffer check in draw validations in WebGL contexts
2017-10-26 jiawei.shao ES31: Support EXT_geometry_shader in GLSL compiler
2017-10-31 jgilbert KHR_create_context with GLES forbids _KHR reset notification enum.
2017-11-07 jmadill Move LazyResource::resolveImpl to the cpp.
2017-11-08 jmadill Link interface blocks in ProgramImpl::link.
2017-10-31 jgilbert attachmentsHaveSameDimensions should not compare depths.
2017-10-30 cwallez Split pixelBuffer from pack/unpack state
2017-11-06 cwallez Add back dirty bits for pack / unpack buffer binding
2017-11-06 jmadill Rename UniformLinker.cpp/h to ProgramLinkedResources.
2017-11-07 oetuaho Size const unsized arrays without an initializer
2017-10-27 oetuaho Only store innermost array offset in VariableLocation
2017-10-24 geofflang Disallow null pixel data for TexSubImage that have non-zero size.
2017-11-07 jmadill Pass InterfaceBlockLinker to ProgramImpl::link.

Created with:
  roll-dep src/third_party/angle
BUG=781729


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: I895af7e8c73982e88413866985c1ca9649d585ae
Reviewed-on: https://chromium-review.googlesource.com/760656Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515198}

The fetchForms... uses an empty form name to fetch all the forms.
This conflicts with the empty form name for filling formless checkouts.

Add a specific parameter and fix the javascript method to fill these fields.


Bug: 780050
Change-Id: Ia9fc514db6118a79af40dcd12b2312387f7ae726
Reviewed-on: https://chromium-review.googlesource.com/747101
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515197}

Now that crbug.com/755119 has been fixed, remove TODO and add a
NOTREACHED for BACKOFF behaviour which we don't currently support.

In reality the NOTREACHED is very unlikely to trigger as you'd need to
launch 15+ background fetches simultaneously, which is very unlikely for
a flagged feature.

Bug: 755119
Change-Id: Ic70d056486e695e7953a8c58515eca31c1d3f935
Reviewed-on: https://chromium-review.googlesource.com/758781Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515196}

SetCursor has no effect today unless a commit takes place
afterwards. This is fixed by making it possible to commit
contents before a surface has a delegate and there's a
surface tree host (STH). That allows us to add a surface to
a STH and then submit a valid frame that can be captured.

Bug: 
Test: exo_unittests --gtest_filter=PointerTest.SetCursor
Change-Id: I4e6688b2a83b971cd935a70f91642e075b079cb4
Reviewed-on: https://chromium-review.googlesource.com/760541Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515195}

This reverts commit 3c722d42.

Reason for revert: Causing another log explosion: https://bugs.chromium.org/p/chromium/issues/detail?id=783221

Original change's description:
> Re-Reland: Add UKM Document.OutliveTimeAfterShutdown
> 
> This is basically same as https://chromium-review.googlesource.com/c/chromium/src/+/722301
> This fix originally caused a log explosion (crbug/776334). Now UKM is
> moved from a browser to a service, this problem has been fixed
> (crbug/733995).
> 
> This CL adds a new UKM Document.OutliveTimeAfterShutdown, that is
> recorded when a Document object survives 5, 10, 20 or 50 garbage
> collections after detached. If a document outlives such long time, the
> document might be leaked. The UKM would be very useful to know where such
> leaky documents exist and to fix them.
> 
> Design doc: https://docs.google.com/document/d/1fbs5smdd-pBLLMpq7u8EkyddZILtI7CZPJlo_AA1kak/edit?usp=sharing
> 
> Bug: 757374
> Change-Id: Ib8e3fdb0e8ed06842588d73a6e235208ccbcfbba
> Reviewed-on: https://chromium-review.googlesource.com/722301
> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Chris Palmer <palmer@chromium.org>
> Reviewed-by: Steven Holte <holte@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#510029}
> Reviewed-on: https://chromium-review.googlesource.com/757885
> Cr-Commit-Position: refs/heads/master@{#515098}

TBR=palmer@chromium.org,hajimehoshi@chromium.org,haraken@chromium.org,holte@chromium.org

Change-Id: Ic0be7a1aac8f420ac37290682d5251b0a80b0de3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 757374
Reviewed-on: https://chromium-review.googlesource.com/760398Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515194}

Test:
  ninja -C out/debug
  ./content/shell/tools/breakpad_integration_test.py \
      --build-dir=out/debug \
      --binary=out/debug/Content\ Shell.app/Contents/MacOS/Content\ Shell

Bug: 466890
Change-Id: I82eefcca87be76371e13cd7e9a1802a39e6a604e
Reviewed-on: https://chromium-review.googlesource.com/755796Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515193}

UpdateDataProvider::GetData needs this function in order to determine
the disable/enable state of an extension.

Bug: 782765
Change-Id: I99a199265b606a9aefcc660e85b341b71b4f3bd5
Reviewed-on: https://chromium-review.googlesource.com/755155Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515192}

TCGETS2 is not defined in sys/ioctl.h; it might implicitly end up including
asm-generic/ioctls.h but that's not guaranteed (see musl, for example).

Change-Id: Icd5bc4ae4de63dfb8439d0e3b9f8f82b6a100e10
Reviewed-on: https://chromium-review.googlesource.com/758842Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#515191}

Bug: 780378
Change-Id: I7b61822c1789d21599ae73b14566f2abe169f0d2
Reviewed-on: https://chromium-review.googlesource.com/760045Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515190}

We want to know how many folders users have. This will
inform upcoming decisions on whether we should do the folder
re-design.

Bug: 780107
Change-Id: Ifc2c77b403b0eab1d156c81f8e628e6417808893
Reviewed-on: https://chromium-review.googlesource.com/752683Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515189}

TBR=jam@chromium.org
NOTRY=true

Bug: None
Change-Id: I90345966a79118b3fba2a4a003009e88ea688fb9
Reviewed-on: https://chromium-review.googlesource.com/760484
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515188}

Bug: 781570
Change-Id: Icaed643a358f2414dcf3fdf84bee6b6453a744ef
Reviewed-on: https://chromium-review.googlesource.com/758926Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515187}

Current video detector is broken with Viz enabled. Move parts of
ash::VideoDetector that need to be run in Viz process into
viz::VideoDetector and notify ash::VideoDetector over mojo.
I don't expect any regressions in behaviour. One improvement is that
when the video activity is happening in an occluded window, the new
video detector does not report that activity, whereas the old video
detector did.

Test: There are unit tests. I also tried --mash, --mus,--enable-viz,
and no flags manually for a chromeos build on my workstation. Also
tried --mash and --mus and no flags manually on a link chromebook.

BUG=775035

Change-Id: I5098492edaf5cce08f9ba6c50a5d7482eb739426
Reviewed-on: https://chromium-review.googlesource.com/702044Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515186}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1d8babac..90e31088

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Ifa492d5feb492b424fbff3d4ff751eca60a41ecc
Reviewed-on: https://chromium-review.googlesource.com/760201Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515185}

Bug: 780857
Change-Id: I8c43090ab96daec09997fb0cb24a55c09bb464a7
Reviewed-on: https://chromium-review.googlesource.com/751686Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515184}

BUG=762816
TEST=covered by unit test

Change-Id: I240054a306f67762b4cfb072dbd83c61b2a7b0d2
Reviewed-on: https://chromium-review.googlesource.com/760196Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515183}

This allows blink to register associated to frame interfaces. One
example would be DevToolsFrontend, which could be implemented
directly in blink, but must be associated for relative ordering
with navigations.

Bug: 776009
Change-Id: I9657a8eb9ae758008f55e482dd91330e3b15a761
Reviewed-on: https://chromium-review.googlesource.com/728726
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515182}

ThumbnailTabHelper already watched for RVH created/deleted
notifications, but not for RenderViewHostChanged.

Bug: 778248
Change-Id: Ic6106c9f810c584163723563c9af801e80faf0fc
Reviewed-on: https://chromium-review.googlesource.com/758244
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515181}

Bug: 
Change-Id: Ic35a7274fdc4d0c5f952b4f8e8e3d8f48e055e86
Reviewed-on: https://chromium-review.googlesource.com/756867Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515180}

Use ShowInactive, add tab stops

Bug: 717091
Change-Id: I53a709caf11df5dc9ef902616307c00404855bd8
Reviewed-on: https://chromium-review.googlesource.com/715440
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515179}

This reverts commit 43d70d5d.

Reason for revert: cause system_health.memory_desktop.browse:media:youtube to crash

(BUG:783198)

Original change's description:
> When calling UseRenderPass() to restore, ensure it runs.
> 
> UseRenderPass() has two use cases, either to set up a render pass
> as the framebuffer for drawing at the start of the draw, or to restore
> us back to that state after making some intermediate change to which
> framebuffer is bound.
> 
> UseRenderPass() has some optimizations where it can return false and
> not do anything, if it detects that we don't want to draw the render
> pass. The first use case, in DrawRenderPass() makes use of this return
> value to avoid drawing anything.
> 
> Other callers to UseRenderPass() do not check the return value because
> we're already drawing the pass and they are trying to restore state. If
> it early outs for these it would be unexpected and produce bugs.
> 
> Currently DecideRenderPassAllocationsForFrame modifies render passes to
> try avoid such bugs, but there are other ways to encounter the bug.
> 
> This changes UseRenderPass() to never early out so the latter cases will
> not avoid resetting the framebuffer. The former case can avoid
> UseRenderPass() entirely by checking CanSkipRenderPass(). If it is true,
> then it does not need to be drawn.
> 
> Also, we will now ensure that UseRenderPass() is called after using a
> ScopedUseGrContext when drawing a RenderPassDrawQuad. Currently on errors
> it would early out before restoring the framebuffer, which could cause
> bugs for the next quads in the RenderPass. This was introduced when the
> UseRenderPass() call was moved out of the ~ScopedUseGrContext()
> destructor in https://codereview.chromium.org/2203033005.
> 
> This all came up via https://chromium-review.googlesource.com/c/chromium/src/+/757027#message-b6e905925e834419ff448e2093a392053d5d321a
> 
> R=​enne@chromium.org, wutao@chromium.org
> 
> Bug: 782044, 738190, 782042
> Change-Id: Ib4662c5fee3f326642add12bbfe3d51e51dff1c9
> Reviewed-on: https://chromium-review.googlesource.com/757049
> Commit-Queue: danakj <danakj@chromium.org>
> Reviewed-by: enne <enne@chromium.org>
> Reviewed-by: Tao Wu <wutao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#515043}

TBR=danakj@chromium.org,enne@chromium.org,wutao@chromium.org

Change-Id: I2acd86c21290c053b1801732599c1ab355161469
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 782044, 738190, 782042
Reviewed-on: https://chromium-review.googlesource.com/760557Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#515178}

This pass focuses on ML::SNTA in same scope as RunLoop variable
Scripted via https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=skyostil@chromium.org

Bug: 781352
Change-Id: I80d1a181146b7134b86dde70b41c18f5af954ebf
Reviewed-on: https://chromium-review.googlesource.com/758928
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515177}

Bug: 779674
Change-Id: I9994ac449b67e7840437c37550cfb6a55e1b0e7c
Reviewed-on: https://chromium-review.googlesource.com/748777Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515176}

Also removes redundant errorprone flags.

BUG=777511

Change-Id: If6fdbcb1d364a8b7ed0a7aaa32ef721a838c2fb8
Reviewed-on: https://chromium-review.googlesource.com/759085Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515175}

The HTML based username detector is time-consuming. This CL introduce caching for results.

Cache is implemented as a field of PasswordAutofillAgent.

Bug: 699530
Change-Id: I7ec4e787cde66e5ff8c9067d7d9c73a90cae7b0a
Reviewed-on: https://chromium-review.googlesource.com/753735
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515174}

This reverts commit f0f62408.

Reason for revert: Failing tests were on FYI. Tests to monitor have been moved to main - PSA, updated docs, and updated Sheriff-o-matic instructions are coming (or have recently come). Thanks for being a diligent sheriff!

Original change's description:
> Revert "Add FYI tests with new navigation manager enabled."
> 
> This reverts commit 8cf24989.
> 
> Reason for revert: Enabling these flags on bots causes this test to fail 
> 
> https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.fyi%2FEarlGreyiOS%2F33304%2F%2B%2Frecipes%2Fsteps%2Fios_chrome_integration_egtests__iPhone_6s_iOS_11.0___2_%2F0%2Fstdout
> 
> 
> Original change's description:
> > Add FYI tests with new navigation manager enabled.
> > 
> > Bug: 780828,734150
> > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
> > Change-Id: I4c4bf7965c6420e3c3213982361296fe7861d61e
> > Reviewed-on: https://chromium-review.googlesource.com/756885
> > Reviewed-by: Mike Baxley <baxley@chromium.org>
> > Commit-Queue: Menglu Huang <huangml@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#515029}
> 
> TBR=baxley@chromium.org,huangml@chromium.org,danyao@chromium.org
> 
> Change-Id: I70250679380f7eb6ddd2c04130b11264a50ca8ef
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 780828, 734150
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
> Reviewed-on: https://chromium-review.googlesource.com/759837
> Reviewed-by: Sergio Collazos <sczs@chromium.org>
> Commit-Queue: Sergio Collazos <sczs@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#515100}

TBR=baxley@chromium.org,sczs@chromium.org,huangml@chromium.org,danyao@chromium.org

Change-Id: Ica3877ce1a91d878a5bd4acc875f2bcfbdb44aa2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 780828, 734150
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/760616Reviewed-by: Mike Baxley <baxley@chromium.org>
Commit-Queue: Mike Baxley <baxley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515173}

It is only used with the default WindowTreeClient and we can get that
from aura::EnvTestHelper. This eliminates one constructor parameter.

Also make WaitForAllChangesToComplete() work in both mus and non-mus
so we can use it in tests that run under both classic ash and mash.

Bug: none
Test: mash_browser_tests, views_mus_unittests, views_mus_interactive_ui_tests
Change-Id: I881d8f30fbe6c0c5a180aa73718895e9bcac90bd
Reviewed-on: https://chromium-review.googlesource.com/758507
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Elliot Glaysher <erg@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515172}