- 09 Feb, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/295aca65583b..7ecf0be48e58 Created with: gclient setdep -r src-internal@7ecf0be48e58 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:927962 TBR=mmoss@chromium.org Change-Id: I108a6234eb5b4c0c465c4cb4d563d592b158047a Reviewed-on: https://chromium-review.googlesource.com/c/1460985Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630608}
-
Yi Su authored
If the bottom toolbar of tab grid is not in compact layout or remote tabs page, it is transparent and should not respond to tapping events unless the new tab button is being tapped, so that user can tap the tabs behind the toolbar. Bug: 924106 Change-Id: Ie6406d23553bcb168053688f89c0a90fc2eee3ae Reviewed-on: https://chromium-review.googlesource.com/c/1460443 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#630607}
-
bsheedy authored
Temporarily disables VrBrowserNativeUiTest#testOverflowMenuAppears, as it's proven to be significantly more flaky than the other pixel tests. TBR=donnd@chromium.org Bug: 930296 Change-Id: I245dc7749c60dd0493412a05ad1bf6faae92c454 Reviewed-on: https://chromium-review.googlesource.com/c/1461796Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#630606}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b7a70665. With Chromium commits locally applied on WPT: 14c11107 "Implement `Sec-CH-Lang`" c49d046d "Initial support for WorkletAnimation.playbackRate" 70938d55 "Fix remaining preload tests flaking on wpt.fyi" af3b056c "[WPT] [wasm] Add JS-API tests for wasm threads" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: If2714d4b993beda1c616ee996c4aea4fa62a66ae Reviewed-on: https://chromium-review.googlesource.com/c/1461498Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630605}
-
Chris Cunningham authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/4b75b8bab993..41268576ad9a $ git log 4b75b8bab..41268576a --date=short --no-merges --format='%ad %ae %s' 2019-02-08 chcunningham avformat/mov.c: require tfhd to begin parsing trun 2019-02-08 chcunningham avformat/mov: validate chunk_count vs stsc_data Created with: roll-dep src/third_party/ffmpeg Bug: 906384, 919573 TBR: dalecurtis@chromium.org Change-Id: Iaeefcddc5324bb48b3c74a0ebaae20a794266f1b Reviewed-on: https://chromium-review.googlesource.com/c/1461682Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#630604}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2b0553ce59c3..75d577fbf801 git log 2b0553ce59c3..75d577fbf801 --date=short --no-merges --format='%ad %ae %s' 2019-02-09 natlee@microsoft.com Fixed Bug where array initialized with same name of 2019-02-08 jmadill@chromium.org Add fuzzer for xxHash. 2019-02-08 syoussefi@chromium.org Vulkan: implement eglSwapInterval 2019-02-08 jmadill@chromium.org Make .gni files always use LF endings. Created with: gclient setdep -r src/third_party/angle@75d577fbf801 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ibb2c35c28b2e9e429e091c75aa969ebc2478788d Reviewed-on: https://chromium-review.googlesource.com/c/1461461Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630603}
-
Jimmy Gong authored
- Introduces a method that attempts to resolve an SmbUrl and returns whether it was able to. - This new method will be used to determine if a hostname was resolved during dynamic hostname resolution. Bug: 922273 Test: compiles Change-Id: I9c15a2ccfd07cd8f4f8c888c3358c42b74253984 Reviewed-on: https://chromium-review.googlesource.com/c/1444598 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Auto-Submit: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#630602}
-
Josh Nohle authored
This class is used for the batch computation of key proofs needed for CryptAuth v2 Enrollment. The lone method ComputeKeyProofs() takes a list of key-payload pairs and returns a list of key proof strings, ordered consistent with the input list. The key proofs are used by CryptAuth to verify that the client has the appropriate key material. The CryptAuth v2 Enrollment protocol requires the following key proof formats: - Symmetric keys: The HMAC-SHA256 of the payload, using a key derived from the symmetric key. Specifically, HMAC(HKDF(|key|, salt="CryptAuth Key Proof", info=|key_handle|), |payload|) - Asymmetric keys: A signed, unencrypted, and serialized SecureMessage proto, with the following parameters: - signature_scheme = ECDSA_P256_SHA256, - encryption_scheme = NONE, - verification_key_id = |key_handle|, - body = |payload|, signed with the private key material. The protocol also demands that the |random_session_id|, sent by the CryptAuth server via the SyncKeysResponse, be used as the payload for key proofs. In the future, key crossproofs might be employed, where the payload will consist of other key proofs. Requirements: - An instance of this class should only be used once. - The input list, |key_payload_pairs|, cannot be empty. - Currently, the only supported key types are RAW128 and RAW256 for symmetric keys and P256 for asymmetric keys. Bug: 899080 Change-Id: I3db6dfedd15ef7a51b4ef8953dfb4fc84c5bd550 Reviewed-on: https://chromium-review.googlesource.com/c/1460310 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#630601}
-
Matt Menke authored
This CL makes HttpProxyConnectJob use CommonConnectJobParams, adding ProxyDelegate to the CommonConnectJobParams object. This is the last ConnectJob type to use the struct, so this CL also removes the legacy ConnectJob constructor. This is part of an effort to flatten the socket pools. https://docs.google.com/document/d/1g0EA4iDqaDhNXA_mq-YK3SlSX-xRkoKvZetAQqdRrxM/edit Bug: 472729 Change-Id: I4d3e4b99469ddb9a275e0668b4c827f405a73a3d Reviewed-on: https://chromium-review.googlesource.com/c/1446790 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#630600}
-
Becky Zhou authored
Bug: 930344, 925564 Change-Id: Ib087bcaf222a7c51a2a5a1e5368c873ad1afc21b Reviewed-on: https://chromium-review.googlesource.com/c/1460111Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#630599}
-
Kristi Park authored
Add browser tests for dark mode on local NTP. These test if dark mode is properly applied on start-up and when dark mode is toggled. Also now checking if the ThemeInfoChanged observer is fired in the dark mode InstantService unit test. Change-Id: I240b9a85f060298c19b25c49d6831010f4fbf433 Reviewed-on: https://chromium-review.googlesource.com/c/1459577Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#630598}
-
Javier Ernesto Flores Robles authored
Bug: 918522 Change-Id: I125e8d3477fa52b980b8d38a65a5a2360da425b7 Reviewed-on: https://chromium-review.googlesource.com/c/1461677Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#630597}
-
ssid authored
The UniqueProtoDatabase can be destroyed in any thread at creation time when the posted tasks are dropped at shutdown. So, remove the dcheck. BUG=929902 Change-Id: Ib0ff347d110001b8164d813bfb007e20b5ca8ec3 Reviewed-on: https://chromium-review.googlesource.com/c/1459756 Commit-Queue: ssid <ssid@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#630596}
-
James Cook authored
Otherwise accidental double or triple clicks result in strange selections of the icon images. Bug: 783107, 774391 Change-Id: If0493f3a7546d9bc318c622bab30b36ae1e98547 Reviewed-on: https://chromium-review.googlesource.com/c/1461596 Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#630595}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1ec1b5c17001..471510ee209e git log 1ec1b5c17001..471510ee209e --date=short --no-merges --format='%ad %ae %s' 2019-02-08 tsepez@chromium.org Fix logic botch in CJX_Object::SetAttribute(). Created with: gclient setdep -r src/third_party/pdfium@471510ee209e The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I1939ab132c928f145f9c49ca81767f4f27ee6348 Reviewed-on: https://chromium-review.googlesource.com/c/1461459Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/be39f713e530..706a7cd1e826 git log be39f713e530..706a7cd1e826 --date=short --no-merges --format='%ad %ae %s' 2019-02-08 herb@google.com Clearify code around hasImage and hasPath 2019-02-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 7fb0b73b1aa7..9686153413f3 (1 commits) 2019-02-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 cd4f1fbaabce..2b0553ce59c3 (7 commits) 2019-02-08 reed@google.com update dox for pathmeasure Created with: gclient setdep -r src/third_party/skia@706a7cd1e826 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: Icfc0f82f3a4b571a5612b84fe9853b91e62262d0 Reviewed-on: https://chromium-review.googlesource.com/c/1461460Reviewed-by:
-
Mustafa Emre Acer authored
This CL adds push_proto.py which is a adapted from hrome/browser/safe_browsing/push_file_type_proto.py. It's used to push generated binary protos to the Google Cloud Storage Bucket. The CL modifies the proto generator to write two copies of the binary proto instead of one. The second copy is put under a versioned directory so that it's easier to copy it to the Google Cloud Storage bucket as a whole. Bug: 640835 Change-Id: I99c7831ee4117802777180fd67e19ae1d131a8cf Reviewed-on: https://chromium-review.googlesource.com/c/665967 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#630592}
-
Adam Langley authored
In the authenticator options, the “up” flag doesn't mean that user presence is required, it means that the authenticator supports obtaining it. So, firstly, rename that field to correctly reflect the semantics. Secondly, implement this in the virtual CTAP2 device. (The purpose of this field is a little unclear: creating a credential unconditionally requires user-presence in the spec. Therefore an authenticator that's not capable of testing it can never create any credentials and would appear to be useless. But there we go.) Change-Id: I129f825a3732da1e0521182f2dc1bc4c9e26e038 Reviewed-on: https://chromium-review.googlesource.com/c/1450640 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#630591}
-
Hiroki Nakagawa authored
This CL renames DedicatedWorkerFactory(Client) to DedicatedWorkerHostFactory(Client) because of following reasons: - DedicatedWorkerFactory creates DedicatedWorkerHost, not DedicatedWorker. - SharedWorkerFactory that creates SharedWorker lives in a renderer process, while DedicatedWorkerFactory lives in the browser process. Bug: 731604, 906991 Change-Id: I451ab85d4e6fc5b492b5a26bec931dd571d50f6c Reviewed-on: https://chromium-review.googlesource.com/c/1459874Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#630590}
-
Stephen Martinis authored
Adds network_service_headless_browsertests and headless_python_unittests to the main set of chromium gtests. These suites are pretty quick to run, and the headless bot which used to run them is being deleted. This ensures these tests continue to run. Also disables a test which fails on ASAN. Bug: 893662, 930356 Change-Id: Ieebf22d1de013c5f476bccdf1bb1d77090f989e4 Reviewed-on: https://chromium-review.googlesource.com/c/1461093 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Auto-Submit: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#630589}
-
Xing Liu authored
This CL adds an API in NotificationManagerProxy to take ChromeNotification struct when sending notification, to avoid duplicate variable used in ChromeNotificationBuilder. Also this will enfore NotificationManagerProxy code path. Bug: 898269 Change-Id: I4dac598a56da3bb3b2a647445e1b47fe4ead42ce Reviewed-on: https://chromium-review.googlesource.com/c/1437774 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#630588}
-
Justin Cohen authored
End the 2 week slimnav experiment, revert the feature back to disabled. Bug: 925617 Change-Id: Ia9cc075676ae47184ec1a8691b2316f65a926510 Reviewed-on: https://chromium-review.googlesource.com/c/1460441Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#630587}
-
Martin Kreichgauer authored
When U2F requests that go through the native WebAuthn API on Windows time out, the modal OS dialog for the request gets dimissed but the JS request promise never gets resolved because the originating tab fails the focus check in sendResponseToActiveTabOnly(). This appears to be caused by a race between the cryptotoken-side focus check racing against Windows dismissing its dialog after receiving the WebAuthNCancelCurrentOperation() call. As a workaround, skip the focus check for all register timeouts. Bug: 930015 Change-Id: I8f44e44a4a26d499e6681331d808af58eabbb573 Reviewed-on: https://chromium-review.googlesource.com/c/1461331 Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#630586}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I8ad9ac0ce5185d47529a9e24c53c404777bc4492 Reviewed-on: https://chromium-review.googlesource.com/c/1461458Reviewed-by:
-
Vlad Tsyrklevich authored
This is a reland of dcea6896 once the headless_browsertests issue in https://crbug.com/929873 has been fixed. CQ-DEPEND=CL:1460068 Original change's description: > Add GWP-ASan hook to macOS crashpad handler > > Add the GWP-ASan UserStreamDataSource to the macOS crashpad handler. > The GWP-ASan hook determines when an exception is related to GWP-ASan > and reports additional debug information. > > Bug: 912286 > Change-Id: I1cd0227ca8aade1bd17e25b83832cdb8f3e58d5e > Reviewed-on: https://chromium-review.googlesource.com/c/1457461 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#629881} Bug: 912286 Change-Id: I9cac247b9e9b81c97f16da74dc95f21de6f9d6e6 Reviewed-on: https://chromium-review.googlesource.com/c/1460120Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#630584}
-
Donn Denman authored
Removes the about:flag for Contextual Search, and takes ownership of the other contextual-search related flags that are still in use. Also some minor cleanup of flag ownership for other projects while we're here. Change-Id: I6a728f67cb336875b65ccfc266ea8d792c21284a Reviewed-on: https://chromium-review.googlesource.com/c/1435964Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#630583}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/37a08a2a..b3e709a8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I18bb092404afcc2f687a76cb9d91c2d4bef598fe Reviewed-on: https://chromium-review.googlesource.com/c/1461309Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630582}
-
Sebastien Marchand authored
Notifying the observers that we have tried to refresh the value but that it failed adds some useless complexity. Bug: 771478 Change-Id: I2f44a115f087fbdad583627b0552ecb466866610 Reviewed-on: https://chromium-review.googlesource.com/c/1461330 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#630581}
-
Vlad Tsyrklevich authored
Fix missing includes pointed out by git cl lint. Change-Id: Idc50ba106c1fead5729988368ec46f25e9b0290b Reviewed-on: https://chromium-review.googlesource.com/c/1455467 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#630580}
-
Kalvin Lee authored
The "grit newgrd" command was found broken from a previous refactor. This change addresses the error. R=thestig@chromium.org Change-Id: Ia3fb3c2d06a43d0f8223ccd14febdb71153972b6 Reviewed-on: https://chromium-review.googlesource.com/c/1461345 Auto-Submit: Kalvin Lee <kdlee@chromium.org> Commit-Queue: Kalvin Lee <kdlee@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#630579}
-
Danyao Wang authored
The failing expectations are required because hasEnrolledInstrument() is not yet turned on by default in Blink. These tests pass when running Chrome with --enable-features=PaymentRequestHasEnrolledInstrument. Bug: 915907 Change-Id: I2189bfedad813e7942c7ddbd44aac78d1b895a30 Reviewed-on: https://chromium-review.googlesource.com/c/1461313 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#630578}
-
Esmael El-Moslimany authored
paper-icon-button-light replacements: - action menu button on the bookmarks toolbar - action menu button for each bookmark entry - cr-expand-button - cr-toolbar-selection-overlay X button In cr-toolbar-search-field, the search icon button was changed from a a paper-icon-button. cr-expand-button ripple logic was changed to be consistent with other controls. The ripple is held when focused using the tab or shift+tab. The ripple stays until the control is blurred or clicked with a pointer. Bug: 736891 Change-Id: Ibe0107a096a967cb72ffef795ec983f1c28d18b2 Reviewed-on: https://chromium-review.googlesource.com/c/1436144Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#630577}
-
Matt Menke authored
And rewrite most HttpProxyClientSocketPool tests in terms of it. The only remaining tests are for HTTP auth, client certs, socket tagging, or for cases that return a socket on failure, all of which include some aspect of testing the socket pool as well, and will be delth with in future CLs. This CL also changes type of the |respect_limits| argument to HttpProxyConnectJob to a bool, from a ClientSocketPool::RespectLimits. HttpProxyConnectJob is otherwise unchanged. The HttpProxyClientSocketPool class is going to be merged into the TransportClientSocketPool class, but we'll still need these tests. This is part of an effort to flatten the socket pools. https://docs.google.com/document/d/1g0EA4iDqaDhNXA_mq-YK3SlSX-xRkoKvZetAQqdRrxM/edit Bug: 472729 Change-Id: Ic0570a7e48ad012da793723bbecbdf04d3659586 Reviewed-on: https://chromium-review.googlesource.com/c/1446563 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#630576}
-
Nektarios Paisios authored
Exposes get_SelectionRanges and SetSelectionRanges methods on Windows for working with arbitrary selection endpoints The existing get_selection and SetSelection APIs in IAccessible2 are limited because they can only work with offsets in IA2Hypertext. This patch adds two additional APIs get_selectionRanges and SetSelectionRanges that enable working with arbitrary selection endpoints, similar to how the DOM selection API works. R=dmazzoni@chromium.org, thakis@chromium.org Bug: 916794 Change-Id: Id4db856408e4200f44ee5afa140091156d5f6adc Reviewed-on: https://chromium-review.googlesource.com/c/1385544Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#630575}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/7fb0b73b1aa7..9686153413f3 git log 7fb0b73b1aa7..9686153413f3 --date=short --no-merges --format='%ad %ae %s' 2019-02-08 schuffelen@google.com Early exit in es2::Context::drawElements on count=0. Created with: gclient setdep -r src/third_party/swiftshader@9686153413f3 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/123716871 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I03c5d5c98ca3a42c285ae6584f6fa6bdb343ea7d Reviewed-on: https://chromium-review.googlesource.com/c/1461457Reviewed-by:
-
Vlad Tsyrklevich authored
Change-Id: I67eb6e51a30747d6d58dd725003769aaf3b3632e Reviewed-on: https://chromium-review.googlesource.com/c/1455468 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
OverridePercentageResolutionBlockSize is a much better name. Change-Id: I3600fb4d7b711ec1e69991ca3bbcb671fd67e68d Reviewed-on: https://chromium-review.googlesource.com/c/1448174 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#630572}
-
Tommy C. Li authored
For the context menu for suggestions project, this adds the confirmation bubble for Remove Suggestion (from history). This bubble is not yet hooked up to anything, but is just the UI. Screenshots here: go/context-menu-for-suggestions Bug: 929477 Change-Id: I60b7c481c45bb2d1c61584961ad8f69a86e7f9b1 Reviewed-on: https://chromium-review.googlesource.com/c/1461328Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#630571}
-
Scott Violet authored
We use SetTransform() for scrolling sliding browser controls in tablet mode. BUG=930021 TEST=covered by test Change-Id: I8357b66e3feaebc6c61be00fe206cb3811a9b477 Reviewed-on: https://chromium-review.googlesource.com/c/1460113 Commit-Queue: Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#630570}
-
Erik Jensen authored
https://crrev.com/c/1459634 caused rpath_link to be set unconditionally, but not used if gcc_target_rpath was set. This led to an "assignment had no effect" error. Change-Id: Ic5a2167391d49d008f78fa37fdd62bbaa3704eca Reviewed-on: https://chromium-review.googlesource.com/c/1461354Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Cr-Commit-Position: refs/heads/master@{#630569}
-
