GitLab

This reverts commit 81bd4926.

Reason for revert: Causes failures on several bots, e.g. https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Mac10.11%20%28dbg%29/9004

The CL description notes that it may be easier to disable than revert, but in this case the CL is small and the failing test is one of the only ones added, so reverting seems easiest.

Original change's description:
> Import wpt@ed50cf49edc57e2e2d3b2b0381fc1f1070e23835
> 
> Using wpt-import in Chromium 3543d97c.
> 
> Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/136
> 
> Background: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
> 
> Note to sheriffs: If this CL causes a small number of new layout
> test failures, it may be easier to add lines to TestExpectations
> rather than reverting.
> Directory owners for changes in this CL:
> rouslan@chromium.org, mathp@chromium.org:
>   external/wpt/payment-request
> 
> TBR=qyearsley@chromium.org
> NOEXPORT=true
> 
> Change-Id: Ie7007ae595b681df80870b9bc4a9b759dfc8c24c
> Reviewed-on: https://chromium-review.googlesource.com/520464
> Reviewed-by: Blink W3C Test Autoroller <blink-w3c-test-autoroller@chromium.org>
> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
> Commit-Queue: Blink W3C Test Autoroller <blink-w3c-test-autoroller@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#476321}

TBR=qyearsley@chromium.org,blink-w3c-test-autoroller@chromium.org
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Change-Id: Ia338baddf9d439c157e05c048e5d0f4533746fe2
Reviewed-on: https://chromium-review.googlesource.com/522223Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476541}

Cr-Commit-Position: refs/heads/master@{#476540}

BUG=721559

Review-Url: https://codereview.chromium.org/2908673002
Cr-Commit-Position: refs/heads/master@{#476539}

Plus a couple of minor bug fixing:
- Check is user turned on safe browsing before sending pings
- If verdict is already cached, don't attempt to cache again.

BUG=726794

Review-Url: https://codereview.chromium.org/2905343002
Cr-Commit-Position: refs/heads/master@{#476538}

This converts STGLO to be a pure virtual interface so we can mock it.
It will be used in a coming CL.

Bug: 660942
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ief880307a7ea47d9284fdd26f624de6bf39a6c86
Reviewed-on: https://chromium-review.googlesource.com/520662Reviewed-by: John Bauman <jbauman@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Chris Watkins <watk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476537}

The subpixel accumulation can affect the pixel snapped border box size
of a paint layer. Take this into account when positioning or sizing for
this box's PaintLayer.

Bug: 692486
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I16f78d7105cd9e069d1de563ed81fd09245c1b35
Reviewed-on: https://chromium-review.googlesource.com/509175Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Chris harrelson <chrishtr@chromium.org>
Reviewed-by: Peter Mayo <petermayo@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476536}

JavaScriptBreakpointsSidebarPane, DOMBreakpointsSidebarPane, and
XHRBreakpointsSidebarPane now have their own stylesheets, and all are
encapsulated with shadow DOM.

BUG=none

Review-Url: https://codereview.chromium.org/2900843002
Cr-Commit-Position: refs/heads/master@{#476535}

Without this ODR-using these constants will cause linking errors.
Namespace scoped constants are fine without a definition, since those
have internal linkage and thus every user gets their own copy of the
constant anyway.

Bug: 
Change-Id: I361fc705500d67f010498208622022e81a20b2eb
Reviewed-on: https://chromium-review.googlesource.com/521767Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476534}

Bug: 713222
Change-Id: I39e246f090e86f204d2251323eef457dca2c944b
Reviewed-on: https://chromium-review.googlesource.com/521264
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476533}

This reverts commit a031ee0c.

Reason for revert: Possible cause of Chromium Win x64 PGO Builder compile failures; hypothesis is that filenames are exceeding the maximum path length.  See https://build.chromium.org/p/chromium.fyi/builders/Chromium%20Win%20x64%20PGO%20Builder/builds/19881 .

Original change's description:
> bindings: Add an intermediate target for generated module bindings.
> 
> Follow what's already done in bindings/core/v8 and add a
> "bindings_modules_impl" target to bindings/modules/v8 to aggregate all the
> .cpp/.h files generated by the other targets in the same BUILD.gn (the ones
> processing the modules IDL files).
> 
> By declaring the target in the same GN file, we can use get_target_outputs()
> to obtain some output names, which then allows us to get rid of
> |bindings_modules_generated_interface_files| as well as
> |bindings_modules_generated_partial_interface_files|.
> 
> This cleanup is also being done in preparation for getting rid of the
> hardcoded list of generated dictionary impl files we currently maintain in
> GN, as Source/modules:modules would not be able to retrieve any similar list
> of generated files that it needs.
> 
> Bug: 725996
> Change-Id: Ia53de40ef394af197351f218050af6d8a10f2c3a
> Reviewed-on: https://chromium-review.googlesource.com/517955
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
> Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
> Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com>
> Cr-Commit-Position: refs/heads/master@{#476243}

TBR=peria@chromium.org,yukishiino@chromium.org,raphael.kubo.da.costa@intel.com,bashi@chromium.org,haraken@chromium.org
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 725996

Change-Id: I416da9cb0234ec7a184edae527645805453a9177
Reviewed-on: https://chromium-review.googlesource.com/522226Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476532}

BUG=728300

Review-Url: https://codereview.chromium.org/2913383002
Cr-Commit-Position: refs/heads/master@{#476531}

BUG=728895
TEST=none
TBR=wangxianzhu

Change-Id: I1086a24605c4597962da3247f6d2404a7aef651a
Reviewed-on: https://chromium-review.googlesource.com/522343Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476530}

https://pdfium.googlesource.com/pdfium.git/+log/5171a27eaa74..8cb884102c17

$ git log 5171a27ea..8cb884102 --date=short --no-merges --format='%ad %ae %s'
2017-06-01 tsepez Tag CFXJSE_HostObject sub-classes.

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I62ce734d7943b4520fe15c571a80094b20069f59
Reviewed-on: https://chromium-review.googlesource.com/521712
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476529}

BUG=546208

Review-Url: https://codereview.chromium.org/2820763002
Cr-Commit-Position: refs/heads/master@{#476528}

We currently bucket UMA for all decode tasks in a single histogram.
With checker-imaging enabled, we expect to see a decline in the decode
duration for images decoded with raster. Add UMA to track these
seperately.

BUG=725344
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2904743002
Cr-Commit-Position: refs/heads/master@{#476527}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/817b8684be60..b33525e99124

$ git log 817b8684b..b33525e99 --date=short --no-merges --format='%ad %ae %s'
2017-06-01 benjhayden Check that Diagnostic subclasses are registered in presubmit.
2017-06-01 dtu [pinpoint] Handle Job failure.
2017-06-01 achuith Disable logging redirect on chromeos.
2017-06-01 benjhayden Simplify dashboard autocomplete-box.

Created with:
  roll-dep src/third_party/catapult
BUG=724273


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ife7287880104fcce2c3109c20e215645b0e13210
Reviewed-on: https://chromium-review.googlesource.com/521771
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476526}

The mapping was getting copied every invocation of InspectModule, which
is pretty inefficient.

Review-Url: https://codereview.chromium.org/2916663002
Cr-Commit-Position: refs/heads/master@{#476525}

When overlays are enabled, on Nexus 5 devices, upon exiting and
re-entering fullscreen, nothing is displayed on screen.

This is caused by the fact that AVDACodecImage never resets
|most_recent_bounds_| when a new overlay is received. This means
AndroidOverlay::ScheduleLayout() is never called in
AVDACodecImage::ScheduleOverlayPlane(), and new overlays retains their
initial bounds of [0,0,1,1].

This CL fixes the issue by reseting the bounds when a new shared state
(and therefore potential new Overlay) is set.

BUG=728802
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2916193002
Cr-Commit-Position: refs/heads/master@{#476524}

Revert of cc: Don't use StreamVideoDrawQuad on any platform but Android. (patchset #3 id:40001 of https://codereview.chromium.org/2763223003/ )

Reason for revert:
crbug.com/724812

Original issue's description:
> cc: Don't use StreamVideoDrawQuad on any platform but Android.
>
> VideoLayerImpl is appending StreamVideoDrawQuads on CrOS.
>
> StreamVideoDrawQuads should be used on Android since almost all its
> features are supported by TextureDrawQuad.
> The only difference is that StreamVideoDrawQuad calls
> glUniformMatrix4fvStreamTextureMatrixCHROMIUM before drawing, that
> just sets a uniform matrix on CrOS.
>
> This CL makes sure VideoLayerImpl produces StreamVideoDrawQuads only
> on Android.
>
> BUG=702750
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Review-Url: https://codereview.chromium.org/2763223003
> Cr-Commit-Position: refs/heads/master@{#460547}
> Committed: https://chromium.googlesource.com/chromium/src/+/517d0115d3c435383f79a0b730b6514a6cc97f44

TBR=danakj@chromium.org,reveman@chromium.org,avi@chromium.org,dcastagna@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=702750
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2920893003
Cr-Commit-Position: refs/heads/master@{#476523}

For the majority of tests, SetUpWithHelper() was run twice, which is confusing.
Change the tests to call SetUpWithHelper() once explicitly.

Change-Id: I393182eb6c6ad56a8be4a08e03f308545ae1d223
Reviewed-on: https://chromium-review.googlesource.com/522263Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476522}

Native bindings should replace many of the core modules used in
extension APIs. Don't include some of these when native bindings
are enabled.

Update custom bindings that are exercised in native binding tests to
behavior properly with either JS or native bindings.

BUG=653596

Review-Url: https://codereview.chromium.org/2908883002
Cr-Commit-Position: refs/heads/master@{#476521}

Replace references to constants in ui/views/layout/layout_constants.h with their
equivalents using ChromeLayoutProvider.

BUG=691897

Review-Url: https://codereview.chromium.org/2919903002
Cr-Commit-Position: refs/heads/master@{#476520}

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/ff270ca217a8..d1586d3fcb3a

$ git log ff270ca21..d1586d3fc --date=short --no-merges --format='%ad %ae %s'
2017-05-25 tengs cros_system_api: Add constants for valid parameters of the SetLEConnectionParameters API.

Created with:
  roll-dep src/third_party/cros_system_api

BUG=725367

Review-Url: https://codereview.chromium.org/2920863002
Cr-Commit-Position: refs/heads/master@{#476519}

The above mentioned function simply returns a string member of the class,
and is only used inside the class. Hence, this patch removes the function
to reduce code complexity and any possible confusion.

BUG=721957
TEST=n/a; no behavioral change

Review-Url: https://codereview.chromium.org/2915863005
Cr-Commit-Position: refs/heads/master@{#476518}

1) Added supervised-user and signed-in user badge. We do not have
designs for other badges yet and I need to investigate on all other
badge types to see which one should be switched to the new style.
Before that we hide all other badges to avoid style conflict.

2) Updated caps lock icon to match the new spec.

BUG=718159

Review-Url: https://codereview.chromium.org/2919523005
Cr-Commit-Position: refs/heads/master@{#476517}

This allows the navigator.GetVRDisplays() promise to resolve when the
underlying VR libraries are not installed or out of date.

BUG=727969

Review-Url: https://codereview.chromium.org/2915993004
Cr-Commit-Position: refs/heads/master@{#476516}

This is essentially a clone of UserEventServiceFactory that uses
web::BrowserState to be iOS compatible.

BUG=701032

Review-Url: https://codereview.chromium.org/2916873003
Cr-Commit-Position: refs/heads/master@{#476515}

The "Site Details" page currently only shows content settings that are set to a
non-default setting for the given origin. This patch will show all content
settings in "Site Details", regardless of whether they are still set to the
default setting or not.

BUG=656758,709171
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2912253003
Cr-Commit-Position: refs/heads/master@{#476514}

Support is compliant with RFC 5280 and supports all the policy
extensions specified therein:

 * Inhibit Any Policy
 * Policy Constraints
 * Policies
 * Policy Mappings

Testing is done solely using the PKITS test suite, which has fairly good
coverage of these extensions:

  4.8 (Certificate Policies)
  4.9 (Require Explicit Policy)
  4.10 (Policy Mappings)
  4.11 (Inhibit Policy Mapping)
  4.12 (Inhibit Any Policy)

BUG=634456,634453,634452

Review-Url: https://codereview.chromium.org/2903283002
Cr-Commit-Position: refs/heads/master@{#476513}

This change simplifies the scope and lifetime of the manifest_.

Bug: 728667
Change-Id: Ia234f9cf6e56dac45c5f358f6b3cd8bdc6652ba3
Reviewed-on: https://chromium-review.googlesource.com/522202
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476512}

This patch moves TextIteratorTextState's member initialization to the class
declaration, since they are all trivially initialized.

BUG=721957
TEST=n/a; no behavioral change

Review-Url: https://codereview.chromium.org/2922553002
Cr-Commit-Position: refs/heads/master@{#476511}

Clicking back-to-safety will now navigate backward for the malicious
subresource case, which is consistent with Chrome's behavior.

This removes is_resource_cancellable, since it was only added for the
old WebView behavior (see crrev/458833).

BUG=699196

Change-Id: Idb78f514f3ccbc8d899622c3700d71c93fdc7253
Reviewed-on: https://chromium-review.googlesource.com/516803Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
Reviewed-by: Selim Gurun <sgurun@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476510}

This CL changes CompositionMarker to take and store its thickness param as an
enum instead of a bool. This makes code creating CompositionMarkers easier to
understand (and also enables us to add additional thickness values in the future
if necessary).

BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2906953002
Cr-Commit-Position: refs/heads/master@{#476509}

This patch renames |VisibleSelection::end()| to |End()| to follow Blink coding
style.

BUG=727486
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2920733002
Cr-Commit-Position: refs/heads/master@{#476508}

Bug: 718063
Change-Id: Ia60355916d1e9e440f661255e40e4af83f288365
Reviewed-on: https://chromium-review.googlesource.com/521364
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476507}

Fixes a bug where the resolved term isn't always selected in the text.
The case fixed is due to the selection including a trailing space
when at the end of a line.  It's unclear why the trailing space is
included in the selection.  We simply trim the trailing space.

BUG=726767

Review-Url: https://codereview.chromium.org/2910713002
Cr-Commit-Position: refs/heads/master@{#476506}

Even on a beefy workstation, resizing theme images takes a long time
(>1s). This causes a painful hiccup in the UI. This patch addresses that
by moving the operation to a helper thread. The actual application of
the theme won't be any faster but it won't block interaction.

As a future area of investigation it might be worth changing the "theme
installed" infobar to show earlier with a message like "installing
theme..." until this operation is completed, since otherwise it can feel
like nothing is happening.

BUG=316070

Review-Url: https://codereview.chromium.org/2799003002
Cr-Commit-Position: refs/heads/master@{#476505}

Mapping a custom element constructor to its definition used to look in
a JavaScript map from constructor to custom element name string, and
then hash that name to look up the custom element definition in the
registry.

After this change the JavaScript map values are IDs so the definition
can be retrieved directly from a vector. This avoids marshaling the
name string from V8 to C++, and avoids hashing the string, to look up
a definition. (There's still a map from name to ID on the side so that
CustomElementRegistry.get can look up definitions by name, but it is
not used in common operations like creating a custom element.)

Bug: 710184
Change-Id: I90ee5759bf692b5a2df43a4a59ef4fac94d22f2c
Reviewed-on: https://chromium-review.googlesource.com/520543
Commit-Queue: Dominic Cooney <dominicc@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476504}

Change one more native layer message to cr.sendWithPromise and adjust
tests to use browser proxy for this message instead of triggering an
event.

BUG=717296
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2919693002
Cr-Commit-Position: refs/heads/master@{#476503}

BUG=687863

Review-Url: https://codereview.chromium.org/2914193003
Cr-Commit-Position: refs/heads/master@{#476502}