GitLab

NOTRY=true

Review URL: https://codereview.chromium.org/504503002

Cr-Commit-Position: refs/heads/master@{#291984}

Revert of Suppress an uninitialized read in ThreadHeap<>::sweepNormalPages (patchset #2 of https://codereview.chromium.org/502233002/)

Reason for revert:
The fix (https://src.chromium.org/viewvc/blink?revision=180854) should be included by the Blink roll in http://crrev.com/ecb9875276ccd.

Original issue's description:
> Suppress an uninitialized read in ThreadHeap<>::sweepNormalPages
>
> BUG=407396
> NOTRY=true
> TBR=ager@chromium.org
> NOTREECHECKS=true
>
> Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/8da39ba

TBR=ager@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=407396

Review URL: https://codereview.chromium.org/507833002

Cr-Commit-Position: refs/heads/master@{#291983}

Allow the ContentViewRenderView to request composites if UX components require it.

BUG=387177

Review URL: https://codereview.chromium.org/504553002

Cr-Commit-Position: refs/heads/master@{#291982}

This is a new pure virtual on WebMimeRegistry.

The implementations of WebMimeRegistry appear to bind only to net, so
they could go somewhere and be shared by both content/ and mojo/ instead
of duplicated. But this fixes a pending compile error so should probably
happen first.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/511583002

Cr-Commit-Position: refs/heads/master@{#291981}

This fixes a crash when we skip a test only on ChromeOS; it turns out
that telemetry uses two mechanisms for disabling tests, and only one of
them was provoking this; that mechanism only seems to be used for this
one ChromeOS test (everything else uses the other mechanism).

R=dtu@chromium.org, nduca@chromium.org
BUG=397279

Review URL: https://codereview.chromium.org/484333002

Cr-Commit-Position: refs/heads/master@{#291980}

BUG=339240
TBR=joaodasilva@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/474163004

Cr-Commit-Position: refs/heads/master@{#291979}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/509583002

Cr-Commit-Position: refs/heads/master@{#291978}

The ARB needs updating to use git commit numbers rather than SVN rev.

BUG=None
TBR=gavinp@chromium.org

Review URL: https://codereview.chromium.org/505173002

Cr-Commit-Position: refs/heads/master@{#291977}

Review URL: https://codereview.chromium.org/508643003

Cr-Commit-Position: refs/heads/master@{#291976}

Currently not enought unit test case  is available for Select Action Bar.
This change adding useful UT for Select Action Bar with respect to input
field.

BUG=

Review URL: https://codereview.chromium.org/501383002

Cr-Commit-Position: refs/heads/master@{#291975}

https://chromeperf.appspot.com/report?masters=ChromiumPerf&bots=chromium-rel-win8-dual&tests=startup.warm.dirty.blank_page%2Fwindow_display_time&rev=286928

It is not a real regression, the initial_time and initial_ticks are not properly initialized when switching to HighResolution (i.e. QPC).
This CL initializes the now_function to the HighResNowWrapper instead of setting it to RolloverProtectedNow then to the HighResNowWrapper.

By doing that, we avoid getting an incorrect initial_time and initial_ticks using the RolloverProtectedNow and avoid having to reinitialize.

BUG=158234

Review URL: https://codereview.chromium.org/446203002

Cr-Commit-Position: refs/heads/master@{#291974}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/505283002

Cr-Commit-Position: refs/heads/master@{#291973}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/505233004

Cr-Commit-Position: refs/heads/master@{#291972}

Viewing passwords locally requires reauth and users should not be able to
go to a different location to circumvent this restriction.

BUG=406579

Review URL: https://codereview.chromium.org/497233003

Cr-Commit-Position: refs/heads/master@{#291971}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/474973004

Cr-Commit-Position: refs/heads/master@{#291970}

1. Automate the selection of the proper channel to enable the verifier.
   Now the code is enabled at runtime.

2. Switch to a hash_map to track handles.

3. Intercept CloseHandle to detect the code that is closing handles owned
   by ScopedHandles. The initial implementation only covers chrome.exe/dll,
   but the plan is to extend that in the future to all modules loaded in the
   process.

BUG=362176
R=cpu@chromium.org
R=sky@chromium.org

See https://codereview.chromium.org/490043002/ for the actual review.

TBR=cpu@chromium.org
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/506013004

Cr-Commit-Position: refs/heads/master@{#291969}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/498553004

Cr-Commit-Position: refs/heads/master@{#291968}

BUG=391005

Review URL: https://codereview.chromium.org/507733002

Cr-Commit-Position: refs/heads/master@{#291967}

BUG=372607

Review URL: https://codereview.chromium.org/504773004

Cr-Commit-Position: refs/heads/master@{#291966}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/506903003

Cr-Commit-Position: refs/heads/master@{#291965}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/500383003

Cr-Commit-Position: refs/heads/master@{#291964}

The icon is changed so it's more distinguishable from the 'locked' icon

BUG=405770

Review URL: https://codereview.chromium.org/508703002

Cr-Commit-Position: refs/heads/master@{#291963}

It was only used for GPU rendering on Windows XP, which is now blacklisted.

BUG=407177

Review URL: https://codereview.chromium.org/506633002

Cr-Commit-Position: refs/heads/master@{#291962}

This also makes the opus_demo app in the GYP build compile and link (which I discovered when tracking down why the GN version of this gives warnings).

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/507753002

Cr-Commit-Position: refs/heads/master@{#291961}

BUG=407750
TBR=hashimoto@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/508713002

Cr-Commit-Position: refs/heads/master@{#291960}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/501993003

Cr-Commit-Position: refs/heads/master@{#291959}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/509563002

Cr-Commit-Position: refs/heads/master@{#291958}

BUG = N/A

Review URL: https://codereview.chromium.org/505743002

Cr-Commit-Position: refs/heads/master@{#291957}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/503883005

Cr-Commit-Position: refs/heads/master@{#291956}

Using const scoped_refptr<T>& is more efficient when passing a
scoped_refptr<T> to a function or returning a scoped_refptr<T> from an
accessor. It avoids the creation of a temporary scoped_refptr and
reduces refcount churn.

BUG=none

Review URL: https://codereview.chromium.org/467183003

Cr-Commit-Position: refs/heads/master@{#291955}

The HidConnection knows the appropriate read buffer size and the
platform-specific implementation may already have a buffer that it is
waiting to return to the next caller. Passing a buffer in is therefore
unnecessary, one can be provided in the callback.

By standardizing on a buffer format which always includes the report ID
as the first byte (even when it is zero) most of the buffer copying can
be removed except in the case of OS X's persistent read buffer and
getting feature reports on Windows.

BUG=

Review URL: https://codereview.chromium.org/499713002

Cr-Commit-Position: refs/heads/master@{#291954}

i.e. "chrome-extension://<id>" instead of "Chrome Dev Editor"

BUG=407451

Review URL: https://codereview.chromium.org/505073002

Cr-Commit-Position: refs/heads/master@{#291953}

Fixes the rest of the non-rtc and non-vpx linker errors for the chrome target.

BUG=
R=ajwong@chromium.org

Review URL: https://codereview.chromium.org/505853003

Cr-Commit-Position: refs/heads/master@{#291952}

BUG=

Review URL: https://codereview.chromium.org/506103002

Cr-Commit-Position: refs/heads/master@{#291951}

ImagePainter is in an unnamed namespace, exporting it makes no sense.

Fixes
..\..\ui\views\painter.cc(187,15) :  error(clang): 'views::(anonymous namespace)::ImagePainter::ImagePainter' must have external linkage when declared 'dllexport'
ImagePainter::ImagePainter(const int image_ids[])
              ^
on the clang/win components bot.

BUG=82385
R=msw@chromium.org

Review URL: https://codereview.chromium.org/496123003

Cr-Commit-Position: refs/heads/master@{#291950}

This patch removes tiles from the recycle tree that were deleted from
the active tree as a result of a shifting live tiles rect. It is
important to do this, since if the active tree then would recreate
the deleted tile (ie, live tiles rect shift back), we have to ensure
that this tile will be shared when the next pending tree is created.
If we don't do it, we can run into a situation in which we will
continuously raster the same tile.

The patch does the following:
- Adds a way to get a recycled tree twin tiling.
- During LiveTilesRect tile deletion, deletes tiles from the same
  location from the recycle twin (if one exists).

R=danakj, enne

Review URL: https://codereview.chromium.org/502453003

Cr-Commit-Position: refs/heads/master@{#291949}

The Reset Settings section in Advanced Settings used to be hidden by
default, and then enabled if the profile was OffTheRecord. CL
https://codereview.chromium.org/467363003 changed this setting to be
hidden if guest mode is set, but did not ever remove the hidden flag.
Thus, it was only ever hidden.

In this CL the Reset Settings section is now visible by default. It
still gets hidden by guest mode.

BUG=407493

Review URL: https://codereview.chromium.org/505143002

Cr-Commit-Position: refs/heads/master@{#291948}

BUG=352290

Committed: https://chromium.googlesource.com/chromium/src/+/1218a23163baab9f53d70e9a63030db13ef04d04

Review URL: https://codereview.chromium.org/496873006

Cr-Commit-Position: refs/heads/master@{#291947}

Previous revision is 333. Revision 334 fixes a clang warning about
writing timestamps into strings with "%ld" on systems that use 64-bit
time. The fix is a static cast of the timestamp into long. This will be
fine until 2037.

TBR=estade@chromium.org

Review URL: https://codereview.chromium.org/503383003

Cr-Commit-Position: refs/heads/master@{#291946}

BUG=403813
R=sadrul@chromium.org
TEST=athena_unittests

Review URL: https://codereview.chromium.org/502583002

Cr-Commit-Position: refs/heads/master@{#291945}