GitLab

This class vends GTK colors into views. There are a lot of little places where
cleanup is needed due to hard coded colors in views, but this is a start and
HighContrastInverse doesn't look too terrible.

BUG=130810


Review URL: https://chromiumcodereview.appspot.com/12395034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186244 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/12393045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186243 0039d316-1c4b-4281-b951-d872f2087c98

Navigating to iwoeaslkdfja.com will now show the alternate error/suggestion
page, instead of the net::ERR_NAME_NOT_RESOLVED error page.

BUG=179399


Review URL: https://chromiumcodereview.appspot.com/12391082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186242 0039d316-1c4b-4281-b951-d872f2087c98

The switch to MessagePopupCollection broke this test but 
wasn't caught on the try bots since 
--enable-rich-notifications isn't run there. 

R=stevenjb@chromium.org
TBR=mukai@chromium.org
BUG=NONE 
TEST=ash_unittests --enable-rich-notifications


Review URL: https://chromiumcodereview.appspot.com/12391041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186241 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186240 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=try bots
Review URL: https://codereview.chromium.org/12414006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186239 0039d316-1c4b-4281-b951-d872f2087c98

The first hit from debugging added in r185719 points at NativeViewHostAura
destructing without removing itself as an observer.

BUG=177012
TEST=NativeViewHostAuraTest.StopObservingNativeViewOnDestruct

Review URL: https://chromiumcodereview.appspot.com/12390067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186238 0039d316-1c4b-4281-b951-d872f2087c98

BUG=177812,178311


Review URL: https://chromiumcodereview.appspot.com/12386093

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186237 0039d316-1c4b-4281-b951-d872f2087c98

Cached reads would return -1 when reading at the end of the file (instead of 0).

BUG=none
TBR=sbc@chromium.org
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/12379091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186236 0039d316-1c4b-4281-b951-d872f2087c98

Only ClearFocus on RestoreFocusOnActivate if a view is focused.
Otherwise, views focused before activation are incorrectly unfocused.

Fixes initial OmniboxViewWin cursor blinking on my local debug builds.
(oddly, this doesn't reproduce on my local dev channel installation)
Fixes initial OmniboxViewViews focus from BrowserView::Show.
Fixes BrowserFocusTest.ClickingMovesFocus and more with --enable-views-textfield.
(needed to enable the views omnibox and textfields by default)

Remove the BubbleDelegateTest.InitiallyFocusedView workaround for the hack.

BUG=125976,131660
TEST=automated tests pass with and without --enable-views-textfield; no focus regressions.
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12377071

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186235 0039d316-1c4b-4281-b951-d872f2087c98

> Windows: Automatically disable GPU sandbox when DisplayLink is installed.
> 
> BUG=177611
> 
> Review URL: https://chromiumcodereview.appspot.com/12375003

TBR=apatrick@chromium.org
Review URL: https://codereview.chromium.org/12467002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186234 0039d316-1c4b-4281-b951-d872f2087c98

Broke Win Aura builder.
> Rename DumpAccesibilityTreeHelper to AccessibilityTreeFormatter, pull into content/browser.
> 
> BUG=178756
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/12389028

TBR=aboxhall@chromium.org
Review URL: https://codereview.chromium.org/12459006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186233 0039d316-1c4b-4281-b951-d872f2087c98

Initial patch by mad@chromium: https://codereview.chromium.org/12310109/

BUG=177377
TEST=Make sure that an app shortcut is available in the bookmark bar when instant extended is enabled, and that this button can be hidden/shown from the bookmark bar context menu.

Review URL: https://chromiumcodereview.appspot.com/12386088

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186232 0039d316-1c4b-4281-b951-d872f2087c98

Add a condition when searching for modes for mirroring -
both modes must either be interlaced or progressive scan.

Also, as internal panels don't support interlacing,
do not attempt to panel fit interlaced modes on them.

BUG=179207
TEST=Manually disabled modes, making interlaced one the preferred,
     then verified that this mode is not picked for mirroring,
     but the next one. Steps in the bug should also work,
     but I don't have the necessary hardware.

Review URL: https://chromiumcodereview.appspot.com/12388090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186231 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/12385063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186230 0039d316-1c4b-4281-b951-d872f2087c98

BUG=178756


Review URL: https://chromiumcodereview.appspot.com/12389028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186229 0039d316-1c4b-4281-b951-d872f2087c98

BUG=159265
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12379095

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186222 0039d316-1c4b-4281-b951-d872f2087c98

In the case where Ash is displayed on Windows, we want a single
message center data structure with multiple UI surfaces for
notifications.

g_browser_process now manages the lifetime of the global Message
Center object, since its lifetime is always longer than Ash::Shell.

This allows us to re-enable the browser tests for message center
on Ash+Win, and stops a crash bug.

BUG=178429


Review URL: https://chromiumcodereview.appspot.com/12375004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186220 0039d316-1c4b-4281-b951-d872f2087c98

This matches the existing page_cycler behavior exactly.

Also, only display by_url results when there are at least 2 pages in the
page_set. This prevents duplicate results for single page sets.

BUG=163680
TEST=tools/perf/run_multipage_benchmarks --browser=system page_cycler tools/perf/page_sets/page_cycler/moz.json
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/11576050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186219 0039d316-1c4b-4281-b951-d872f2087c98

We currently perform TLS 1.1 -> 1.0 fallback for ERR_CONNECTION_RESET
to workaround some buggy servers. This change causes ERR_CONNECTION_ABORTED
to be treated like ERR_CONNECTION_RESET because, with non-blocking I/O,
it appears that we get this error rather than ERR_CONNECTION_RESET.
See r165170 and the bug.

See https://code.google.com/p/chromium/issues/detail?id=178672#c17

BUG=178672,179037

Review URL: https://codereview.chromium.org/12390059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186218 0039d316-1c4b-4281-b951-d872f2087c98

- White list ash accelerator actions;
- White list browser accelerators;
- Use a limited render view context menu;

BUG=178469
TEST=Verify Ctrl-N etc is disabled and no accelerator/menu to get a browser
     window in app mode.

R=zelidrag@chromium.org,sky@chromium.org


Review URL: https://chromiumcodereview.appspot.com/12389083

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186214 0039d316-1c4b-4281-b951-d872f2087c98

BUG=161604
TEST=Follow instructions in bug. Chromium should quit, not crash.


Review URL: https://chromiumcodereview.appspot.com/12388035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186212 0039d316-1c4b-4281-b951-d872f2087c98

Eventually, this will enable us to remove the current hack for
starting the devtools server.

NOTRY=True
BUG=177053


Review URL: https://chromiumcodereview.appspot.com/12395022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186211 0039d316-1c4b-4281-b951-d872f2087c98

> Disable threaded HTML parser
> 
> This CL disables the threaded HTML parser so that we don't promote it to the
> Dev channel. Once the Dev channel build is cut, we'll revert this CL to enable
> the threaded parser for Canary again.
> 
> TBR=darin
> 
> Review URL: https://chromiumcodereview.appspot.com/12391067

The Dev channel build has been cut. We're going to send this feature to Canary
again.

TBR=abarth@chromium.org
Review URL: https://codereview.chromium.org/12457006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186210 0039d316-1c4b-4281-b951-d872f2087c98

The code was slated for deletion in early March 2013.

BUG=172189


Review URL: https://chromiumcodereview.appspot.com/12454002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186209 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186208 0039d316-1c4b-4281-b951-d872f2087c98

The buttons currently provide no functionality so disable them for now.

BUG=171370
R=jhawkins@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12389079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186205 0039d316-1c4b-4281-b951-d872f2087c98

I have manually added logs here too many times already and I think it doesn't hurt to have them in the codebase permanently.

R=willchan@chromium.org
NOTRY=True
BUG=None


Review URL: https://chromiumcodereview.appspot.com/12453006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186200 0039d316-1c4b-4281-b951-d872f2087c98

BUG=179717
R=dmazzoni@chromium.org
Review URL: https://codereview.chromium.org/12378095

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186199 0039d316-1c4b-4281-b951-d872f2087c98

BUG=156838
TEST=Manual tests on Linux ChromeOS build.


Review URL: https://chromiumcodereview.appspot.com/12448003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186197 0039d316-1c4b-4281-b951-d872f2087c98

> Fix touch scaling for high dpi windows.
> 
> Touch events in windows are always expressed in screen coordinates, even if
> the target app is not dpi-aware. This patch determines the dpi scale used
> by the OS, and re-scales touch events accordingly. 
> 
> In some cases the touch events are sent to the wrong window. This is detected
> and corrected.
> 
> BUG=175542
> 
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185474
> 
> Review URL: https://chromiumcodereview.appspot.com/12317157

TBR=girard@chromium.org
Review URL: https://codereview.chromium.org/12454004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186196 0039d316-1c4b-4281-b951-d872f2087c98

GetAboutResource is supported by both GData WAPI and Drive API v2, while
GetAccountMetadata is now only supported by GData WAPI.
To prepare Drive API v2 migration, replace GetAccountMetadata by
GetAboutResource.
Note that GetAboutResource doesn't include installed third party application
info, but fortunately it is not used in sync file system so we don't need
to take care about it.

BUG=174237
TEST=Ran unit_tests


Review URL: https://chromiumcodereview.appspot.com/12385081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186194 0039d316-1c4b-4281-b951-d872f2087c98

Root cause of key-type-array (165671) believed fixed. Index tests
not timing out marked as flaky (but maybe just not running?). In
any case - let's give it a whirl.

BUG=153064,165671

Review URL: https://codereview.chromium.org/12387105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186191 0039d316-1c4b-4281-b951-d872f2087c98

Patch originally by Eric Penner <epenner@chromium.org>.

We currently have high latency if need to wait for uploads
in the renderer client. If we can do a shallow client side
wait it will be much better. This is effectively the
same as doing synchronous uploads, but exposes less driver
bug surface area then mixing uploads across threads.

BUG=161828, 178634


Review URL: https://chromiumcodereview.appspot.com/12210129

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186190 0039d316-1c4b-4281-b951-d872f2087c98

BUG=172594
TEST=
1- launch chrome
2- bookmark some folders on bookmarks bar either through bookmarks bar or
bookmark manager.
3- go to wrench (hotdogs) menu -> bookmarks menu.
4- now you should see the bookmark folder icon for folders as well.
R=erg@chromium.org

Review URL: https://codereview.chromium.org/12390052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186189 0039d316-1c4b-4281-b951-d872f2087c98

Extracted from the changelist here:
https://chromiumcodereview.appspot.com/12379014/

BUG=171370
TEST=Manual

Review URL: https://chromiumcodereview.appspot.com/12388073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186188 0039d316-1c4b-4281-b951-d872f2087c98

Touch events in windows are always expressed in screen coordinates, even if
the target app is not dpi-aware. This patch determines the dpi scale used
by the OS, and re-scales touch events accordingly. 

In some cases the touch events are sent to the wrong window. This is detected
and corrected.

BUG=175542


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185474

Review URL: https://chromiumcodereview.appspot.com/12317157

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186187 0039d316-1c4b-4281-b951-d872f2087c98

This also bumps up the Control group to 10%, which is the preferred practice for experiment group sizes (makes it easier to look at the stats later when we have comparable groups that are the same size).

Review URL: https://chromiumcodereview.appspot.com/12398016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186186 0039d316-1c4b-4281-b951-d872f2087c98

Added function DeleteOriginDirectory to RemoteFileSyncService interface that removes the remote copy of data for a particular extension. Implementation is in DriveFileSyncService.cc. Will hook this up to DeleteFileSystem and Uninstall notification mechanism next.

BUG=177387


Review URL: https://chromiumcodereview.appspot.com/12389017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186185 0039d316-1c4b-4281-b951-d872f2087c98

Those comments were invalidated as of http://crrev.com/154145

R=grt@chromium.org
NOTRY=True
BUG=None


Review URL: https://chromiumcodereview.appspot.com/12390082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186184 0039d316-1c4b-4281-b951-d872f2087c98