- 05 Jun, 2018 40 commits
-
-
edchin authored
This CL hooks up the remote tabs in the tab grid. A user can sign in from the remote tabs page in the tab grid. The transition animation that displays the signin interaction controller looks bad (and we are investigating the cause). If the user is signed in but does not have sync enabled, the user can enable sync from here. Currently, tapping on a tab does nothing. This will be enabled in a future CL. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ifba06919e1fb496917254a0da7e5462a4b854d79 Reviewed-on: https://chromium-review.googlesource.com/1084080 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#564684}
-
Kyle Horimoto authored
Previous location: //chromeos/components/tether New location: //chromeos/services/secure_channel Eventually all Instant Tethering code will access these BLE classes via the SecureChannel service; until then, //chromeos/components/tether has a dependency on //chromeos/services/secure_channel. Bug: 824568, 752273 Change-Id: I2152fa1d958b70062ed20b46f3359c6e792d3dca Reviewed-on: https://chromium-review.googlesource.com/1084312 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Cr-Commit-Position: refs/heads/master@{#564683}
-
Jeremy Roman authored
It encapsulates the subtle use of atomics and drops a use of WTF atomics. Change-Id: I3f3fa727f388fe5e68fcd7653a99d94d31db9b0f Reviewed-on: https://chromium-review.googlesource.com/1086046Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#564682}
-
Philip Jägenstedt authored
These tests are blocking wpt-importer and have failed on both Linux and Mac: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/109192 https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/62409 Bug: 849859 Change-Id: Ia17d662af4c5eec2cd581b931cdf58efa87db9ca No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1087464Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#564681}
-
Xianzhu Wang authored
Previously it treated transforms with abs(determinant) less than 1e-8 as non-invertible. This was too strict that transforms like Scale(9.9e-5) were treated as non-invertible. Now just check if determinant is zero, which is consistent with AffineTransform and SkMatrix[44]. The code was added here: https://chromium.googlesource.com/chromium/src/+/041f0d1e8d01d8dc0cd2f4fe2579e1f09a9ae27a in an initial commit of 3D transforms. Bug: 849382 Change-Id: I01e395f373493f61fcf85851b694be9aed7b41c5 Reviewed-on: https://chromium-review.googlesource.com/1087362 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#564680}
-
Marcin Wiacek authored
Error: In file included from gen/chrome/browser/browser_jumbo_20.cc:34: ./../../chrome/browser/offline_pages/offline_page_url_loader.cc:30:6: error: redefinition of 'GetTabId' bool GetTabId(content::WebContents* web_contents, int* tab_id) { ^ ./../../chrome/browser/offline_pages/offline_page_request_job.cc:46:6: note: previous definition is here bool GetTabId(content::WebContents* web_contents, int* tab_id) { ^ Compilation settings: target_os="android" target_cpu="arm" enable_nacl=false symbol_level=0 remove_webcore_debug_symbols=true is_debug=false dcheck_always_on=false is_component_build=false use_jumbo_build=true Presubmit warning: Banned functions were used. chrome/browser/offline_pages/offline_page_request_job.cc:227: Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018) BUG=849792 Change-Id: I74fa48c00dcf31a29cab60848015c6d042d51d1a Reviewed-on: https://chromium-review.googlesource.com/1087228Reviewed-by:Cathy Li <chili@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#564679}
-
Dmitry Gozman authored
Bug: 849142 Change-Id: I1a758908af5e765dd69868a8d045664d208346d3 Reviewed-on: https://chromium-review.googlesource.com/1086229Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#564678}
-
Scott Chen authored
This CL replaces paper-input with cr-input in a few more pages. The management of spacing around cr-input is adjusted to make consistent spacing more easily. cr-input now has no margin or padding on top. If there's an error message, there will also be a 8px margin on the bottom of the error message. Or if the user opts to hide the error-message with --cr-input-error-display: none, it will not have any spacing on the bottom either; One should use --cr-form-field-bottom-spacing to add spacing under cr-input if it is followed by an element. Also, the "suffix" slot is introduced to cr-input in order for elements to easily align with the input field itself regardless of label and error-message. Bug: 832177 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I638cffa576ec9c8767c4a96b464510ef55ad6874 Reviewed-on: https://chromium-review.googlesource.com/1074206 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#564677}
-
Patrick Noland authored
Bug: 849456 Change-Id: I296348c5fd7e4bb99c1c88694d05f80245d7d8fa Reviewed-on: https://chromium-review.googlesource.com/1087685Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#564676}
-
Peter Boström authored
* Removes the incognito badging from the new-tab button. * Uses the same inkdrop base color as Refresh does. * Adds a couple of DCHECKs to document which paths are dead in Refresh for easier cleanup when pre-Refresh modes go away. This change was essentially done by auditing IsTouchOptimizedUiEnabled() calls in the new-tab button and making sure that the existing Refresh code takes precedence. Bug: chromium:834520 Change-Id: I28e244472780f65f11d5f3309c567b21401d20ad Reviewed-on: https://chromium-review.googlesource.com/1082436 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#564675}
-
Ryan Sturm authored
The cached config takes a few thread hops to apply and in the case of opening the browser from an intent, may not be loaded by the time the navigation occurs. There is a quick optimization to check if the config would apply to the navigation URL that will fail if this race is lost. Removing this optimization should not change the result of the preview in the case that lite page should not be applied. This still checks HTTP/HTTPS to make it consistent with other scheme checks. Bug: 849375 Change-Id: I23131b700cd465d496f88c7a4f108198f953c9f2 Reviewed-on: https://chromium-review.googlesource.com/1087357 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#564674}
-
Tien-Ren Chen authored
If layout tests are ran in succession, DelegatedFrameHost::CopyFromCompositingSurface() would use the device scale factor from the previous test to compute capture area, causing the next test to fail (if it uses a different scale factor). This CL makes it to always delay computation until the first surface activation. BUG=667551 Change-Id: I2f50daa80c60f926f43c3edea91af832de224a24 Reviewed-on: https://chromium-review.googlesource.com/1079955 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#564673}
-
Ted Choc authored
Allows the keyboard to resize the content in Webapp fullscreen mode. BUG=519394 Change-Id: I881d1d9c9db9436bc86ac1835bfe1d940d3b0a16 Reviewed-on: https://chromium-review.googlesource.com/1074215 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#564672}
-
Scott Violet authored
Ash has two distinct phases for when accelerators are processed. The post target phase handles accelerators such as control-n (new window). Post target accelerators are handled after the target is given a chance to handle the accelerator. With the WindowService the post phase needs to wait until the client responds with whether it handled the event or not. This patch adds support for post-target processing of accelerators. Specifically, when a KeyEvent is sent to the client, WindowServiceClient waits for the ack. If the client did not process the event, then ws2 forwards the event to its delegate. Ash's delegate implementation then forwards to the acceleratorcontroller for post-target processing. BUG=848883 TEST=covered by tests Change-Id: I4b6a464b1752f3cb884e50ee52d4c0f2a106f3be Reviewed-on: https://chromium-review.googlesource.com/1087545 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#564671}
-
Nico Weber authored
This is part of an effort to reduce the number of test configurations. Originally reviewed as part of https://chromium-review.googlesource.com/1061795, which I'm now landing in smaller pieces. TBR=kbr Bug: 843511 Change-Id: I94fd156bc7b75da9b69b39bf68556413b4390326 Reviewed-on: https://chromium-review.googlesource.com/1087577 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#564670}
-
Kevin Marshall authored
This code adds Fuchsia platform implementation code for broadcasting events on major network interface change events (IP address changes, connectivity change, interface up/down changes, etc.) Modified network_interfaces_fuchsia.cc to support adapters w/multiple IPv6 addresses. Added unit tests. Bug: 843443 Change-Id: Id7edc944ceef439d9c360e5d31966807f306489c Reviewed-on: https://chromium-review.googlesource.com/1066074 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#564669}
-
Quan Nguyen authored
This reverts commit 99a3e243. Reland of https://chromium-review.googlesource.com/c/chromium/src/+/1080077 TBR=dcheng@chromium.org Bug: 836861 Change-Id: Ic58e155d4dec32d81772f241c02fd8ad732ea234 Reviewed-on: https://chromium-review.googlesource.com/1087667 Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Reviewed-by:
-
tzik authored
MicrotasksCheckpoint is moved to EndOfTaskRunner in blink_initializer.cc at some point, and RunMicrotasksObserver in Gin is no longer used. Change-Id: Ie90f0d53d873fc5ca06034db5eccb8ec786a6e0a Reviewed-on: https://chromium-review.googlesource.com/1086889Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#564667}
-
Adrienne Walker authored
isFinite is not sufficient for an oval to be valid. It needs to also check isSorted, based on SkRRect::isValid's implementation. Bug: 849009 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I968b086b6cc5ed2a253a0afc35008ce6c1ba818a Reviewed-on: https://chromium-review.googlesource.com/1087543 Commit-Queue: enne <enne@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#564666}
-
Xi Cheng authored
Change-Id: Id2eb7ae1771168c7e062c5d436d54b400229f365 Reviewed-on: https://chromium-review.googlesource.com/1087395Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#564665}
-
Xi Cheng authored
Change-Id: I32519c87031058bb49b0ab005e4f8128d9502200 Reviewed-on: https://chromium-review.googlesource.com/1087590Reviewed-by:
-
Bernhard Bauer authored
Change-Id: Ie3482a4bce615ea70392f4722132cbcd0ded77bf Reviewed-on: https://chromium-review.googlesource.com/1087058Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#564663}
-
Xiaohan Wang authored
This is useful for logging. Bug: 846793 Change-Id: I8982b3cffae0fa51900a745766e0351492ad2e76 Reviewed-on: https://chromium-review.googlesource.com/1085558Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#564662}
-
lgcheng authored
Show notification about usage & diagnostics during ARC setup if the user does not see the ARC ToS dialog due to all relevant settings being managed, and usage & diagnostics is enabled for the device. Bug: b/73338614 Test: Unit test added Test: Manual Change-Id: Ia27b2d1864a3be47b2dcfeb662aa2d72106f80c8 Reviewed-on: https://chromium-review.googlesource.com/1086354Reviewed-by:
Josh Horwich <jhorwich@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#564661}
-
Aaron Leventhal authored
Bug: None Change-Id: I97010e6898ca9e7dd48f6cdc4a43460db850bc5d Reviewed-on: https://chromium-review.googlesource.com/1078915 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#564660}
-
Findit authored
This reverts commit 7acb4716. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 564609 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzdhY2I0NzE2ODA4ZjMwM2M3YzhiYWZjNzYyZjFmY2RhNzY5YTMzYmQM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.11%20Tests/27041 Sample Failed Step: device_unittests on Mac-10.11 Original change's description: > device/fido/mac: encrypt credential metadata in the macOS keychain > > This adds a CredentialMetadata class to encrypt any account metadata > associated with a WebAuthn credential (user ID, user name, user display > name, and RP ID) before writing it to the macOS keychain. > > The key will be generated and stored in the Chrome profile under which > the credential was created. (It is currently hardcoded but I'm changing > that in a follow-up CL.) Deletion of the profile or key will therefore > render the data unreadable. > > Bug: 678128 > Change-Id: I536d537e9220cc5f89d487c7f94e169d06d62e7a > Reviewed-on: https://chromium-review.googlesource.com/1073708 > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Reviewed-by: Adam Langley <agl@chromium.org> > Commit-Queue: Martin Kreichgauer <martinkr@google.com> > Cr-Commit-Position: refs/heads/master@{#564609} Change-Id: I24c8937ae0855ce542e16f0fa9f21ca159d51abe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 678128 Reviewed-on: https://chromium-review.googlesource.com/1087613 Cr-Commit-Position: refs/heads/master@{#564659}
-
Scott Violet authored
We had accumulated quite a few test AcceleratorTarget implementations. This patch adds one to ui/base:test_support and converts usage. BUG=848883 TEST=test only changes Change-Id: Icb543f1f0c20a9341510362493683f7eeed1b485 Reviewed-on: https://chromium-review.googlesource.com/1087534 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#564658}
-
Bernhard Bauer authored
This allows removing special cases for CH, particularly in the content suggestions code. Bug: 805070, 847420 Change-Id: I69db669f85564e10e4452cec8bb7dcf75773f283 Reviewed-on: https://chromium-review.googlesource.com/1087048 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5352ad7..1659e97 git log 5352ad7..1659e97 --date=short --no-merges --format='%ad %ae %s' 2018-06-05 sakal@webrtc.org Use DecimalFormat instead of String.format. 2018-06-05 peterhanspers@webrtc.org Support cropping and rotation override in Metal renderers. 2018-06-05 magjed@webrtc.org Android: Remove deprecated CapturerObserver methods 2018-06-05 ilnik@webrtc.org Cleanup webrtc:: namespace from leaked TimingFrameFlags Created with: gclient setdep -r src/third_party/webrtc@1659e97 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:b/80240768 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I681963bf4943ffdf1428a80175af3e03ad299d27 Reviewed-on: https://chromium-review.googlesource.com/1087300Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564656}
-
Min Qin authored
Windows seem to have a poor sparse file support. The test took about 180 seconds to pass, and sometimes it times out. BUG=846276 Change-Id: I9899c6025e938f38e5079f4ef6da53fcffa1709d Reviewed-on: https://chromium-review.googlesource.com/1087591 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#564655}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c53433e..8bc3398 git log c53433e..8bc3398 --date=short --no-merges --format='%ad %ae %s' 2018-06-05 vapier@chromium.org lint_unittest: refactor assert helper to make checking easier 2018-06-05 dgarrett@chromium.org Reland "chromeos_config: Move zoombini-release to swarming." 2018-06-05 dgarrett@google.com scheduler_stages: Correctly test for swarming slave. Created with: gclient setdep -r src/third_party/chromite@8bc3398 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:834076,chromium:834076 TBR=chrome-os-gardeners@chromium.org Change-Id: Ic83da17e578ec3206a22b73b08d1a81bcd6ae310 Reviewed-on: https://chromium-review.googlesource.com/1087391Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564654}
-
Nico Weber authored
Also run non_android_and_cast_and_chromeos_chromium_gtests on the mac clang bots, it was missing unintentinoally. Effectively adds battor_agent_unittests to the memory waterfall and to the clang tot bots, and adds snapshot_unittests to the mac clang tot bots. This is part of an effort to reduce the number of test configurations. Originally reviewed as part of https://chromium-review.googlesource.com/1061795, which I'm now landing in smaller pieces. TBR=kbr Bug: 843511,843729 Change-Id: I83fe8723e3634c516a378fb76d8b02ac6a2fab4f Reviewed-on: https://chromium-review.googlesource.com/1087574Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#564653}
-
Eugene But authored
Placeholder URLs are also used for WebErrorPages features, so this CL ignores placeholder URLs in decidePolicy callbacks if WebErrorPages is enabled. Bug: 725241 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I54fb0a5e6dd692d741db4bac298f760165d276f7 Reviewed-on: https://chromium-review.googlesource.com/1087364Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#564652}
-
Nick Harper authored
TBR=estark@chromium.org Change-Id: I9a42c6925763fbb36997aae5929a2ed256e4ccdb Reviewed-on: https://chromium-review.googlesource.com/1087544Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#564651}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4c1bea2..591c140 git log 4c1bea2..591c140 --date=short --no-merges --format='%ad %ae %s' 2018-06-05 dtu@chromium.org [pinpoint] Show results2 in an iframe on the Job page. Created with: gclient setdep -r src/third_party/catapult@591c140 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I49b376afc7eaafff41e9ac4aac4531cf4a056b5e Reviewed-on: https://chromium-review.googlesource.com/1087549Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564650}
-
Jacob Dufault authored
A child class (ie, LoginPinView) may override OnEvent and not OnMouseEvent. The default OnEvent implementation dispatches to OnMouseEvent so existing uses should remain the same, at the cost of an additional function call. Bug: 848018 Change-Id: I20ce712ceadeeda8738eb83d450d9390daedf949 Reviewed-on: https://chromium-review.googlesource.com/1079890Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
-
Nick Harper authored
TBR=estark@chromium.org Change-Id: Iaf24e51b0fc806219d7d0b54719bf32505e2e6f2 Reviewed-on: https://chromium-review.googlesource.com/1087533 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
The layout tests has a big test() function holding a set of independent test cases, each with a single assert() statement. This patch breaks the big test() into one test() for each test case to improve coding style, and also makes the output more informative when the tests fails. Change-Id: I11d1032b8af0335bdedcee456fdaaf5abcacba5c Reviewed-on: https://chromium-review.googlesource.com/1087628 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#564647}
-
Scott Violet authored
There are a couple of issues addressed here: . kFocusable_InitProperty was not wired up correctly. . Ash created top-levels were not picking up the value set by clients To fix these I'm adding kCanFocus. ws2 sets this from calls by clients to WindowTree::SetCanFocus(). Ash uses this property as well if the client supplies kFocusable_InitProperty. I think kFocusable_InitProperty should go away. That'll be easier once we get rid of --mash. I'm also forking the TopLevelWindowFactory tests. I moved the existing ones into TopLevelWindowFactoryMash (these only run with --mash). I also made the tests work in classic mode with ws2. I added a new file for this that is built in ash_unittests. BUG=842301 TEST=covered by tests Change-Id: I016ed612e7ab1d7bc1cdc4840c3aa9271078ab9e Reviewed-on: https://chromium-review.googlesource.com/1086151 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#564646}
-
Ryan Sturm authored
This test suite now handles requests instead of looking at connections and tracks the count of requests based on a specific URL pattern. The first test will pass when no image requests have been loaded, so if for some reason 20 round trips to the renderer do not gaurantee the request is seen on the net/ stack, the test will still pass. The second test creates an image request while the page is paused, and upon unpausing the page, waits for the image request to be seen in the embedded test server. The third test loads the image in the same pattern as the second without ever pausing the page. Bug: 848675 Change-Id: I5a72cf1765b583bdb83ade2046366c12d6d70613 Reviewed-on: https://chromium-review.googlesource.com/1086125 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
-
