- 03 May, 2018 37 commits
-
-
Nasko Oskov authored
Currently this test navigates to a file that is not copied over to the device, which causes it to fail on the bots inconsistently. This CL makes sure the file is present in the location copied to the device and updates the path in the test. Bug: 838161 Change-Id: Icc8f7aa4537ba89575cda19fe1fd00b84e375323 Reviewed-on: https://chromium-review.googlesource.com/1040873Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#555651}
-
https://webrtc.googlesource.com/src.git/+log/219958059034..6f7e6d6ff353 $ git log 219958059..6f7e6d6ff --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic73ab77163de035ecdd8bb59faed90b2db587573 Reviewed-on: https://chromium-review.googlesource.com/1041148Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555650}
-
Joel Hockey authored
Replace the logic in NavigationListModel.prototype.item and NavigationListModel.prototype.length_ to instead calculate the order and preserve it in an array in reorderNavigationItems_. This makes the ordering rules clearer and should also give faster performance for the more frequently accessed item function. Update tests to include recent. This change in done in advance of adding crostini Linux Files. Bug: 834103 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I08c3222b4317b0d38524c52e320545d6717ef9b0 Reviewed-on: https://chromium-review.googlesource.com/1039207 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#555649}
-
Robert Ogden authored
Adds user action reasons and fleshes out all UMA recording around why data savings may have been cleared. Also adds another histogram, DataReductionProxy.DeleteBrowsingHistory.NumBuckets to track how many buckets are deleted when browsing history is cleared. Bug: 812922 Change-Id: I8cf989fa724f23c62bda8232f1215f8ff6b7839a Reviewed-on: https://chromium-review.googlesource.com/1030880 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#555648}
-
Khushal authored
Integrate SkStrikeServer/SkStrikeClient to remote glyph generation for OOP raster. This includes the following changes: 1) Use a SkTextBlobCacheDiffCanvas during serialization to analyze text blobs serialized as a part of raster commands. This is used to track the set of glyphs that will be required to raster these commands. 2) Use the SkStrikeServer::DiscardableHandleManager to let skia allocate and lock discardable handles. Each handle is allocated a unique id that skia can internally serialize and map to an instance of SkGlyphCache on the GPU process. This allows the renderer to pin glyph caches on the GPU until dependent raster commands are executed on the service. 3) In the GPU process, deserialize the font data prior to executing the raster commands. The deserialization populates the requisite glyph caches with the glyphs generated by the renderer. Once the raster commands have been executed, unlock all the discardable handles. R=enne@chromium.org, piman@chromium.org TBR=bsalomon@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ifff356a30bb2ac235eea0bc80e00180a508bce81 Reviewed-on: https://chromium-review.googlesource.com/1006181 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#555647}
-
https://chromium.googlesource.com/angle/angle.git/+log/9aef36705b66..e708f004bce5 $ git log 9aef36705..e708f004b --date=short --no-merges --format='%ad %ae %s' 2018-05-02 tobine Set ANGLE lib apk targetSdkVersion to 28 2018-04-30 jmadill Scope ANGLE_UNUSED_VARIABLE. 2018-05-02 geofflang Pass a context pointer to SurfaceImpl::[bind|release]TexImage. 2018-03-09 cwallez Use packed enums for QueryType. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I13e2713e43f6704aa01a880a581ade23316b3d8e Reviewed-on: https://chromium-review.googlesource.com/1040882Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555646}
-
John Chen authored
Android Chrome 67 has just been promoted to Beta. Copy ToT Java test filters to Beta, and remove obsolete Python test filters. TBR=kereliuk@chromium.org Change-Id: I811bbe653025675a6660652e82d6c169e94ca0d8 Reviewed-on: https://chromium-review.googlesource.com/1041211Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#555645}
-
Chromium WPT Sync authored
Using wpt-import in Chromium dbf8b1b5. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16702 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: alexander.shalamov@intel.com, mikhail.pozdnyakov@intel.com, rijubrata.bhaumik@intel.com, timvolodine@chromium.org: external/wpt/generic-sensor jsbell@chromium.org: external/wpt/resources TBR=kereliuk No-Export: true Change-Id: If0d0b706d7e437f3f4099cd5f4b71be345948a10 Reviewed-on: https://chromium-review.googlesource.com/1040948 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#555644}
-
Victor Costan authored
base::AdaptCallbackForRepeating was introduced to help migrate from base::Callback to base::OnceCallback / base::RepeatingCallback. However, the methods used by ServiceWorkerContextCore have been converted to take base::OnceCallback, so the adapter isn't needed anymore. Bug: 730593 Change-Id: I6eb27da059494075d457d3a3609faf80ca7087a2 Reviewed-on: https://chromium-review.googlesource.com/1040986Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#555643}
-
Zhiling Huang authored
Bug: 837790 Change-Id: Ibecf02ab361f83b3b14d6b69e25682b408482ca2 Reviewed-on: https://chromium-review.googlesource.com/1041213Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Zhiling Huang <hzl@chromium.org> Cr-Commit-Position: refs/heads/master@{#555642}
-
Evan Stade authored
The ash::kWindowPositionManagedTypeKey was inverted in Mash compared to classic Ash (see BrowserFrameAsh::SetWindowAutoManaged()). This fixes BrowserTestParam.TabbedOrAppBrowserWindowAutoManagementTest, largely by updating that test - to deal with the asynchronicity of mash - to use Widget and BrowserWindow interfaces instead of NativeWindow when dealing with bounds (more closely matches production code) - to appropriately test handling of initial widget bounds Change-Id: I68914c360908973a27d432248316ff12243ae932 Reviewed-on: https://chromium-review.googlesource.com/1033489 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#555641}
-
Andrey Lushnikov authored
This patch changes the behavior of Target.disposeBrowserContext method to force-close all the belonging WebContents. R=dgozman BUG=836272 Change-Id: Iec3da859363120a22c2648b31102457aee20e6cb Reviewed-on: https://chromium-review.googlesource.com/1031774 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#555640}
-
Varun Mohan authored
This metric measures the time a call to ComputeNativeWindowOcclusionStatus takes. It will be used when deciding whether or not to pursue native window occlusion tracking on Windows going forward. Change-Id: I497f77682dc88dc48373c9171109f24102eb101c Reviewed-on: https://chromium-review.googlesource.com/1036461Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Varun Mohan <varunmohan@google.com> Cr-Commit-Position: refs/heads/master@{#555639}
-
Ramya Nagarajan authored
Bug: 837798, 837784, 839152 Change-Id: I7ab82dd70af2408cd57bae0e93b3175427af7470 Reviewed-on: https://chromium-review.googlesource.com/1040684Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#555638}
-
Chris Harrelson authored
This means they will show up by default in telemetry trace output. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia67721c41f3347e1f58d1b37ebf69032fd06ddb7 Reviewed-on: https://chromium-review.googlesource.com/1041146Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#555637}
-
Bo Liu authored
Add counts that uses whether a renderer is a subframe process or not. Dependent changes: * Rename RenderProcessHost::GetFrameDepthForTesting. * Add explicit constructor and assignment operator for TerminationInfo. This means no longer using list initialization. Bug: 813232 Change-Id: I80de8004d344cf012bd906eb01c8a4c63c218bda Reviewed-on: https://chromium-review.googlesource.com/1040675Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#555636}
-
Andrey Kosyakov authored
Bug: 832045 Change-Id: I30edba5188f28a67d20de4dbfe75cc2e419c107f Reviewed-on: https://chromium-review.googlesource.com/1040664Reviewed-by:
-
rbpotter authored
Remove the register button which was migrated from the old UI. This feature will be removed from the componentized UI. Bug: 832312 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0d65e275e90aab7452798fe84e8bdc382c301c65 Reviewed-on: https://chromium-review.googlesource.com/1041013Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#555634}
-
Vikas Soni authored
This CL is adding a new class that provides run-time support for working with AImage, AImageReader and ANativeWindow objects on Android O systems without requiring building for the Android O NDK level. Bug : 838725 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I30b3cd69af1f387344301bb6b8472f98b8ff0cf3 Reviewed-on: https://chromium-review.googlesource.com/1031113 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#555633}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5fe1d392..f93c127f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I6d0955bcbf8db06622e8191aa4bb40767ad2f31d Reviewed-on: https://chromium-review.googlesource.com/1041106Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#555632}
-
Nate Chapin authored
Bug: 624061 Change-Id: Ibe1c69d7329590ce86d53463e030e594ff079bf4 Reviewed-on: https://chromium-review.googlesource.com/1040787Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#555631}
-
Han Leon authored
This reverts commit 8aaac438. Reason for revert: crbug.com/838397 and 834200, reland later when we make all things clear Original change's description: > [ServiceWorker] Associate interfaces living on the SW thread together > > This CL switches those interfaces (ServiceWorkerHost, > ServiceWorkerRegistrationObject[Host] etc.) associated with > EmbeddedWorkerInstanceClient interface before to be associated with > ServiceWorkerEventDispatcher interface living on its particular service > worker thread in the renderer process. > This will not only ensure them keeping the FIFO ordering with > ServiceWorkerEventDispatcher, but also make all their Mojo message > dispatches skip the main thread completely to avoid possible congestion. > > The idea is to let browser-side pass ServiceWorkerHost endpoint and > ServiceWorkerRegistrationObjectInfo via a newly defined Mojo call > ServiceWorkerEventDispatcher::InitializeGlobalScope() to the service > worker thread, which holds on evaluating its service worker script until > received that call. > > BUG=745327,834200,834183 > TBR=lazyboy@chromium.org for enabling a test in > chrome/browser/extensions/service_worker_apitest.cc > > Change-Id: Icc9d03d2cc0f099735cfcf34660b835ccf908402 > Reviewed-on: https://chromium-review.googlesource.com/981898 > Commit-Queue: Han Leon <leon.han@intel.com> > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Han Leon <leon.han@intel.com> > Cr-Commit-Position: refs/heads/master@{#555307} TBR=falken@chromium.org,kinuko@chromium.org,lazyboy@chromium.org,shimazu@chromium.org,leon.han@intel.com Change-Id: I935bfdbce9b407c937c2e3a5da424773ec397a1d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 745327, 834200, 834183 Reviewed-on: https://chromium-review.googlesource.com/1041050Reviewed-by:
Han Leon <leon.han@intel.com> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#555630}
-
Mark Pilgrim authored
Bug: 714018 Change-Id: I4c0c9935a6c2864717eb9a0f995591d85e3d2a15 Reviewed-on: https://chromium-review.googlesource.com/1039947 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
-
Victor Vasiliev authored
Merge internal change: 194843554 R=rch@chromium.org Change-Id: Ia7c236db9045f3ea59df088b0f18d3717dbc32cc Reviewed-on: https://chromium-review.googlesource.com/1038023Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#555628}
-
Joel Einbinder authored
This was attempted before, but the ExecutionContextChanged event is actually for when the name of an execution context changes, not for when a new one is selected by the user (or the page is reloaded). Also added a safety clear on DebuggerResumed Change-Id: I4c9360139fe90beee2fa3d8a82317fc3aed1e6ae Reviewed-on: https://chromium-review.googlesource.com/1040906Reviewed-by:
-
Alexey Kozyatinskiy authored
Some source map does not contain entry exactly at the end of the line, so our frontend fails to find a mapping and ignores current line. This CL tunes sourcemap to return last mapping in the line if there is no mapping with offset greater then passed column. R=dgozman@chromium.org Bug: chromium:836440 Change-Id: I0da57992ca2c94101084aef2ed21c5b5ba6edc0a Reviewed-on: https://chromium-review.googlesource.com/1028510 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
-
Alan Cutter authored
This CL adds a null check to BrowserActionsContainer::Layout() and updates browser_non_client_frame_view_ash_browsertest.cc to cover --top-chrome-md=material-refresh. The existing HostedAppNonClientFrameViewAshTest.BrowserActions test catches this crash with the material-refresh flag enabled. Bug: 838581 Change-Id: I263b3cd3551a3171f5acc010c1c99f0daef47998 Reviewed-on: https://chromium-review.googlesource.com/1039209Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#555625}
-
Tarun Bansal authored
This does not affect OFFLINE preview type. Change-Id: Ia7dbec31a7eb1434fc1b46bc6895eab5d32f9086 Bug: 838969 Reviewed-on: https://chromium-review.googlesource.com/1039160 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/90864a21c4ab..0caef298c2ff $ git log 90864a21c..0caef298c --date=short --no-merges --format='%ad %ae %s' 2018-05-02 liyuqian Let each threaded device in the ThreadSink own its SkExecutor 2018-05-02 egdaniel Add internal grsurface flag to track if using gl rectangle or external texture. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I87cb60797b453af519fa18b8d3c2369232bb9432 Reviewed-on: https://chromium-review.googlesource.com/1041066 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555623}
-
Xiangjun Zhang authored
Add MessageDispatcher to handle sending/receiving cast messages. Bug: 734672 Change-Id: I1941ba72107b4629da8c47f0b726484d800b2891 Reviewed-on: https://chromium-review.googlesource.com/1008729 Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#555622}
-
Fredrik Hubinette authored
For unknown reasons, IMFTransform::ProcessOutput sometimes return E_FAIL. It seems that in most of those cases, we can still keep playing the video. A previous CL changed all unknown errors from IMFTransform::Processoutput to be reported back as decode errors, this CL makes an exception for E_FAIL. Bug: 839057 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4b3edb118728347da7cf5364cbcec8b9b7d8b03b Reviewed-on: https://chromium-review.googlesource.com/1038643 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Noel Gordon authored
Add comment about class DriveTestVolume pointer member ownership (none are owned). Initialize these members. Add EXPECT cases when creating the test Drive integration service. Use nullptr in place of NULL. Covered by existing tests: Transfer/FileManagerBrowserTest.Test* Bug: 833834 Change-Id: I04d132e36d8293627f388469138ee7c58e453538 Reviewed-on: https://chromium-review.googlesource.com/1039211 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#555620}
-
Joel Hockey authored
Bug: 834103 Change-Id: Ib4fd72617f0648e99de0f6f84c03b1b65498e978 Reviewed-on: https://chromium-review.googlesource.com/1039109Reviewed-by:
-
Evan Stade authored
Bug: 834092 Change-Id: I0676206a08de89cb6f4a8d0884228357b9576d60 Reviewed-on: https://chromium-review.googlesource.com/1028982Reviewed-by:
-
Scott Chen authored
this CL adds styling to make cr-checkbox looks like the md-refresh mock. Also added a slot to cr-checkbox for allowing labels. Also replaced one checkbox in reset-profile-dialog as a pilot demo. There will be a follow-up CL to replace all paper-checkbox to cr-checkbox. Bug: 836391 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia55925bc91c95407abe5b775758f1b9b4ef97b05 Reviewed-on: https://chromium-review.googlesource.com/1033346 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
https://goo.gl/AgkxzN caused a bug of omnibox not disappearing when a new page is opened from NTP. The change missed setting control bar height in such case. This CL fixes it by removing the check for native page which is not necessary. Bug: 837791 Change-Id: I84a9e5324280d6ca161bb8f99c51fb93baa0ca80 Reviewed-on: https://chromium-review.googlesource.com/1034051Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#555616}
-
John Budorick authored
Bug: 731426,826895 Change-Id: Ia71d026639c2138770ca80461a32c77bee737d0a Reviewed-on: https://chromium-review.googlesource.com/1040285Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#555615}
-
- 02 May, 2018 3 commits
-
-
Bret Sepulveda authored
This updates MdTextButton to draw 32dips high and with 4dip corner radii when refresh is on. Also updates LayoutProvider:: GetControlHeightForFont even though it's not used by MdTextButton, to avoid the two getting out of sync. Also moves empahsis methods to LayoutProvider so that general views code can access them. Bug: 822073 Change-Id: Ia3038ccafdddd79ca42837dc1de4f726894377e2 Reviewed-on: https://chromium-review.googlesource.com/1031551 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
-
Tommy C. Li authored
Previously, the drag threshold calculation had a bug. The last-click event was stored as a root_location, which was tested against the drag event's location relative to the View origin. This CL makes both the stored last-click and the current drag event use the root_location. Using root_location is most robust, since the View itself can move in response to edit-in-progress state. It also updates the API of textfield to make more explicit that the stored last click location is a root_location rather than relative to the position of the View. This CL also adds a test. Bug: 838830, 797354 Change-Id: Iedff486a3c6e842bc5c87c6fd597e1faf7a2930d Reviewed-on: https://chromium-review.googlesource.com/1040347 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#555613}
-
Sergey Volk authored
Earlier CL https://codereview.chromium.org/2518403004 replaced most of __FUNCTION__ usage with __func__. But a few more places used it since then. Let's replace those as well. Bug: none Change-Id: Ieef098e9e4061c9261f9d044b82c5fd71ad81918 Reviewed-on: https://chromium-review.googlesource.com/1040771Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#555612}
-
